René's URL Explorer Experiment


Title: fix(sse): bound workspace SSE connection lifetime by waleedlatif1 · Pull Request #7058 · simstudioai/sim · GitHub

Open Graph Title: fix(sse): bound workspace SSE connection lifetime by waleedlatif1 · Pull Request #7058 · simstudioai/sim

X Title: fix(sse): bound workspace SSE connection lifetime by waleedlatif1 · Pull Request #7058 · simstudioai/sim

Description: Summary createWorkspaceSSE tore down a connection only from the request.signal abort listener and the stream's cancel(). Both fire only when the runtime reports the client disconnect, and nothing else bounded the connection — so a missed report left the pub/sub handler in a process-lifetime Set, the heartbeat interval running, and the stream's undrained queue held until the process restarted. Retention scaled with uptime instead of with concurrent clients. Unread-consumer check — the heartbeat reads controller.desiredSize (the default strategy reports 1 - queued) and closes once nothing has been pulled for several minutes. This is what actually reclaims a vanished consumer, within minutes. A healthy client keeps its stream drained and is never unread, so this never touches a working connection. Lifetime ceiling (4h, jittered) — the backstop for whatever the abort, cancel, and unread paths all miss, so retention is bounded by the ceiling rather than by process uptime. Checked on the existing heartbeat tick, so it adds no second timer. Matches lib/realtime/event-stream-route.ts, which uses the same deadline pattern for the same purpose. Deliberately far longer than the unread window: a short ceiling would only force reconnects on the connections that are working, and every reconnect is a window in which a transient event can be missed. The abort listener is now removed on every path. { once: true } only self-removes if abort fires; the ceiling and unread paths close while the signal is still live, so the listener would have stayed installed retaining close → the controller, the teardown list, and the workspace id — most of the scope this change exists to release. It registers with an owned AbortController as its removal token. A failed heartbeat enqueue now runs full teardown instead of clearing only its own interval and leaving the subscriptions registered. cleanup takes a reason, so the close log says which path ran (aborted, cancelled, expired, unread, errored). Opens minus closes, grouped by reason, is what makes this class of leak visible rather than inferred. Reconnect resync (useMothershipChatEvents) — task_status events are transient and never replayed, and the hook previously reconciled nothing on reconnect. It now re-syncs the workspace chat lists on reconnect, on the first open of a re-subscription, and on a first open that only succeeded after an error, matching the pattern useMcpToolsEvents already uses. Only the lists: they carry the create/rename/delete state a gap can drop and are always safe to refetch. Chat detail reconciliation is deliberately out of scope and unchanged from staging. Refetching a mounted detail can replace an in-flight optimistic transcript with a server copy that lacks the streaming message, and cached state cannot reliably say whether a turn is still running — the optimistic markers outlive it. Doing that properly needs the streaming state that can answer it, and belongs in its own change rather than being half-solved here. createWorkspaceSSE is the only push-driven, indefinite-lifetime SSE surface in the app. The two other long-lived SSE routes are poll loops that already carry their own duration ceilings and never depended on abort. A shared bounded-SSE primitive would be the honest end state for all three, but that is a three-site refactor and doesn't belong in a leak fix. Type of Change Bug fix Testing sse-endpoint.test.ts covers the ceiling, the unread path, a drained connection surviving past the unread threshold, abort, consumer cancel, and teardown idempotency when two paths overlap. use-mothership-chat-events.test.ts covers the resync invalidating the lists and leaving details untouched. Verified the tests are load-bearing rather than assuming it: disabling each backstop reds exactly its own test and leaves the rest green. The abort-listener removal isn't unit-observable (AbortSignal exposes no listener count), so it's covered by review — I dropped an earlier test that looked like it covered it but only re-asserted an idempotency guard another test already owns. bun run lint, bun run check:audits (33 audits), and tsc clean. 163 test files / 1816 tests green across hooks, lib/events, and lib/copilot/chat. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary createWorkspaceSSE tore down a connection only from the request.signal abort listener and the stream's cancel(). Both fire only when the runtime reports the client disconnect, and noth...

X Description: Summary createWorkspaceSSE tore down a connection only from the request.signal abort listener and the stream's cancel(). Both fire only when the runtime reports the client disconnect, and ...

Opengraph URL: https://github.com/simstudioai/sim/pull/7058

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:83641e91-72de-d2e2-8960-8f20dc8f00fb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDCA6:C876F:B4C308:F9650B:6AFB5459
html-safe-nonce7fd90afbad08e1eed62acee54b10318ceb3cc16aa48394de9cfb056d5ab4f2e2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0E2OkM4NzZGOkI0QzMwODpGOTY1MEI6NkFGQjU0NTkiLCJ2aXNpdG9yX2lkIjoiNTIwNTAwNzgzMzg1MTA1NDk3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6d2ae252ace67d9df0a1bf627dfcc3d11663dd0f2a9850051edf681d3a373d16
hovercard-subject-tagpull_request:4354080325
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7058/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary createWorkspaceSSE tore down a connection only from the request.signal abort listener and the stream's cancel(). Both fire only when the runtime reports the client disconnect, and noth...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7058/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7058%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7058%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7058/files
Reloadhttps://github.com/simstudioai/sim/pull/7058/files
Reloadhttps://github.com/simstudioai/sim/pull/7058/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/sse-connection-teardownhttps://github.com/simstudioai/sim/tree/fix/sse-connection-teardown
Conversation 24 https://github.com/simstudioai/sim/pull/7058
Commits 5 https://github.com/simstudioai/sim/pull/7058/commits
Checks 31 https://github.com/simstudioai/sim/pull/7058/checks
Files changed https://github.com/simstudioai/sim/pull/7058/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7058/files
fix(sse): bound workspace SSE connection lifetime https://github.com/simstudioai/sim/pull/7058/files#top
Show all changes 5 commits https://github.com/simstudioai/sim/pull/7058/files
fb1fead fix(sse): bound workspace SSE connection lifetime waleedlatif1 Aug 25, 2026 https://github.com/simstudioai/sim/pull/7058/commits/fb1fead94d6d8a4b0d9e37b622168d6415b6bd99
0c22829 fix(mothership): resync chat caches after an SSE reconnect gap waleedlatif1 Aug 25, 2026 https://github.com/simstudioai/sim/pull/7058/commits/0c22829f66919d65007fd90b8f9735ed00b3353c
70541f4 fix(mothership): keep reconnect resync off locally streaming chats waleedlatif1 Aug 25, 2026 https://github.com/simstudioai/sim/pull/7058/commits/70541f43c009417cd276d9bf33af2105890df689
f76765f fix(mothership): only skip resync for a stream still running waleedlatif1 Aug 25, 2026 https://github.com/simstudioai/sim/pull/7058/commits/f76765fbc15dcdabfd899deea20d866557f79a73
cbe8898 fix(sse): raise the ceiling and narrow reconnect resync to the lists waleedlatif1 Aug 25, 2026 https://github.com/simstudioai/sim/pull/7058/commits/cbe889839daf831833705e3ad60b98bd7c0f82f5
Clear filters https://github.com/simstudioai/sim/pull/7058/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7058/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7058/files
use-mothership-chat-events.test.ts https://github.com/simstudioai/sim/pull/7058/files#diff-6ac715a9e75a39d5f94cbc0f22d6a102e1a51329e36df86a7ec38f9d2c100433
use-mothership-chat-events.ts https://github.com/simstudioai/sim/pull/7058/files#diff-963a944f69743406cd60f43c3c8ae7523922b5efdda370416b64bbd310167eec
sse-endpoint.test.ts https://github.com/simstudioai/sim/pull/7058/files#diff-fe4bc27f0a5836f89b1ee7e1ab0e1180c4c53f170b14768b494c3d83e482e7a0
sse-endpoint.ts https://github.com/simstudioai/sim/pull/7058/files#diff-383257e7bcffe26ad3a94d114fdb49ceed8019920242632adf23ea0b72687978
apps/sim/hooks/use-mothership-chat-events.test.tshttps://github.com/simstudioai/sim/pull/7058/files#diff-6ac715a9e75a39d5f94cbc0f22d6a102e1a51329e36df86a7ec38f9d2c100433
View file https://github.com/simstudioai/sim/blob/cbe889839daf831833705e3ad60b98bd7c0f82f5/apps/sim/hooks/use-mothership-chat-events.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7058/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7058/files#diff-6ac715a9e75a39d5f94cbc0f22d6a102e1a51329e36df86a7ec38f9d2c100433
https://github.com/simstudioai/sim/pull/7058/files#diff-6ac715a9e75a39d5f94cbc0f22d6a102e1a51329e36df86a7ec38f9d2c100433
https://github.com/simstudioai/sim/pull/7058/files#diff-6ac715a9e75a39d5f94cbc0f22d6a102e1a51329e36df86a7ec38f9d2c100433
apps/sim/hooks/use-mothership-chat-events.tshttps://github.com/simstudioai/sim/pull/7058/files#diff-963a944f69743406cd60f43c3c8ae7523922b5efdda370416b64bbd310167eec
View file https://github.com/simstudioai/sim/blob/cbe889839daf831833705e3ad60b98bd7c0f82f5/apps/sim/hooks/use-mothership-chat-events.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7058/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7058/files#diff-963a944f69743406cd60f43c3c8ae7523922b5efdda370416b64bbd310167eec
https://github.com/simstudioai/sim/pull/7058/files#diff-963a944f69743406cd60f43c3c8ae7523922b5efdda370416b64bbd310167eec
https://github.com/simstudioai/sim/pull/7058/files#diff-963a944f69743406cd60f43c3c8ae7523922b5efdda370416b64bbd310167eec
Please reload this pagehttps://github.com/simstudioai/sim/pull/7058/files
https://github.com/simstudioai/sim/pull/7058/files#diff-963a944f69743406cd60f43c3c8ae7523922b5efdda370416b64bbd310167eec
https://github.com/simstudioai/sim/pull/7058/files#diff-963a944f69743406cd60f43c3c8ae7523922b5efdda370416b64bbd310167eec
apps/sim/lib/events/sse-endpoint.test.tshttps://github.com/simstudioai/sim/pull/7058/files#diff-fe4bc27f0a5836f89b1ee7e1ab0e1180c4c53f170b14768b494c3d83e482e7a0
View file https://github.com/simstudioai/sim/blob/cbe889839daf831833705e3ad60b98bd7c0f82f5/apps/sim/lib/events/sse-endpoint.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7058/{{ revealButtonHref }}
apps/sim/lib/events/sse-endpoint.tshttps://github.com/simstudioai/sim/pull/7058/files#diff-383257e7bcffe26ad3a94d114fdb49ceed8019920242632adf23ea0b72687978
View file https://github.com/simstudioai/sim/blob/cbe889839daf831833705e3ad60b98bd7c0f82f5/apps/sim/lib/events/sse-endpoint.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7058/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7058/files#diff-383257e7bcffe26ad3a94d114fdb49ceed8019920242632adf23ea0b72687978
https://github.com/simstudioai/sim/pull/7058/files#diff-383257e7bcffe26ad3a94d114fdb49ceed8019920242632adf23ea0b72687978
https://github.com/simstudioai/sim/pull/7058/files#diff-383257e7bcffe26ad3a94d114fdb49ceed8019920242632adf23ea0b72687978
https://github.com/simstudioai/sim/pull/7058/files#diff-383257e7bcffe26ad3a94d114fdb49ceed8019920242632adf23ea0b72687978
Please reload this pagehttps://github.com/simstudioai/sim/pull/7058/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7058/files
https://github.com/simstudioai/sim/pull/7058/files#diff-383257e7bcffe26ad3a94d114fdb49ceed8019920242632adf23ea0b72687978
Please reload this pagehttps://github.com/simstudioai/sim/pull/7058/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.