René's URL Explorer Experiment


Title: refactor(renderer): drop the isWorkflowRunning prop the views never read by waleedlatif1 · Pull Request #7040 · simstudioai/sim · GitHub

Open Graph Title: refactor(renderer): drop the isWorkflowRunning prop the views never read by waleedlatif1 · Pull Request #7040 · simstudioai/sim

X Title: refactor(renderer): drop the isWorkflowRunning prop the views never read by waleedlatif1 · Pull Request #7040 · simstudioai/sim

Description: Follow-up to #7037, which merged before this landed. In that PR I removed only the unused binding and kept the prop — that was half a fix, and the reasoning behind it was wrong. What I got wrong in #7037 I justified keeping the prop as "implementing it is a UX decision." That conflated two things: Should the toolbar pin open during a run? — a UX decision Should we keep a prop that does nothing? — not a UX decision, just dead code Keeping it on the chance someone wants the behavior later is speculative generality. If the toolbar should pin open during a run, that gets implemented deliberately and the prop comes back with logic behind it. What was actually dead WorkflowBlockView and SubflowNodeView both declared isWorkflowRunning?: boolean, both had it destructured, and neither ever read it. Its TSDoc claimed it "holds every block's action swell open" — a behavior that does not exist in either view. Both are removed, along with the two call sites that fed them. What deliberately stays The store subscription is not removed. workflow-block.tsx:642 and subflow-node.tsx:47 each pass the same value to two places: Consumer Reads it? WorkflowBlockView / SubflowNodeView no — removed here ActionBar yes — 28 reads ActionBar is what the surrounding TSDoc is actually describing when it says the flag "only swaps Run for Stop and disables mutations." workflow-edge-view uses it as well (7 reads) and is untouched. So the subscription earns its keep; only the dead second pass goes. A note on the test workflow-block-view-interaction.test.tsx passed the flag in two cases to stage a workflow run. Since the view ignored it, those two cases were never exercising the run state their names describe — they pass on other logic. The argument is removed; the assertions are unchanged and still pass. Worth flagging for whoever owns that behavior. Verification All 26 workspaces type-check — this is what caught my first attempt, which deleted the prop while two callers and a test still passed it bun run lint:check exits 0 113 renderer tests, 636 across app/workspace/w and stores/workflows Remaining isWorkflowRunning references are exactly the live ones: action-bar.tsx, workflow-edge-view.tsx, note-block.tsx, and the two subscriptions Net −22 lines.

Open Graph Description: Follow-up to #7037, which merged before this landed. In that PR I removed only the unused binding and kept the prop — that was half a fix, and the reasoning behind it was wrong. What I got wrong i...

X Description: Follow-up to #7037, which merged before this landed. In that PR I removed only the unused binding and kept the prop — that was half a fix, and the reasoning behind it was wrong. What I got wrong i...

Opengraph URL: https://github.com/simstudioai/sim/pull/7040

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:616baf4c-b24c-be27-a94c-551aa8849936
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE18A:1AE782:AF036E:F61699:6AFB79B5
html-safe-noncee75f322ca85a793c302792b6d3795d58b330cf286b1bd7ef1470a94a483fc1de
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMThBOjFBRTc4MjpBRjAzNkU6RjYxNjk5OjZBRkI3OUI1IiwidmlzaXRvcl9pZCI6IjgxNzUzNTk1MzQwNjM5MDkzMDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaceeb045877ff1e96b077a9f99222db0e822a3a2c61a3ff7875beed422a3645fb8
hovercard-subject-tagpull_request:4351489143
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7040/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altFollow-up to #7037, which merged before this landed. In that PR I removed only the unused binding and kept the prop — that was half a fix, and the reasoning behind it was wrong. What I got wrong i...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7040/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7040%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7040%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7040/files
Reloadhttps://github.com/simstudioai/sim/pull/7040/files
Reloadhttps://github.com/simstudioai/sim/pull/7040/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests202 (202)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix-dead-isworkflowrunning-prophttps://github.com/simstudioai/sim/tree/fix-dead-isworkflowrunning-prop
Conversation 3 https://github.com/simstudioai/sim/pull/7040
Commits 1 https://github.com/simstudioai/sim/pull/7040/commits
Checks 30 https://github.com/simstudioai/sim/pull/7040/checks
Files changed https://github.com/simstudioai/sim/pull/7040/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7040/files
refactor(renderer): drop the isWorkflowRunning prop the views never read https://github.com/simstudioai/sim/pull/7040/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/7040/files
793e483 refactor(renderer): drop the isWorkflowRunning prop the views never read waleedlatif1 Aug 24, 2026 https://github.com/simstudioai/sim/pull/7040/commits/793e4833108601082d16b35bcdddf803f455344c
Clear filters https://github.com/simstudioai/sim/pull/7040/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7040/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7040/files
subflow-node.tsx https://github.com/simstudioai/sim/pull/7040/files#diff-a65436bf2ecf73f7e53d1cc7512384525177ba398565f945a15c16d74f4382ae
workflow-block.tsx https://github.com/simstudioai/sim/pull/7040/files#diff-eb2223ecc5d1f699578f6498c95b4182bbe7df71b182febbfb6886413b61043b
subflow-node-view.tsx https://github.com/simstudioai/sim/pull/7040/files#diff-e86d718b25140b2ddd51edbb8d3b59dabb4a749a9d3392c8341993944a8e7726
workflow-block-view-interaction.test.tsx https://github.com/simstudioai/sim/pull/7040/files#diff-f2a0bc1e527c23e5d96871c26af75c3a9a8c967240fa7e03dfe3e667a7b1a0a5
workflow-block-view.tsx https://github.com/simstudioai/sim/pull/7040/files#diff-41333094c321a4cbc8ce835330aa50fe21b431fd334173f728dd28a420f2bbff
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/subflows/subflow-node.tsxhttps://github.com/simstudioai/sim/pull/7040/files#diff-a65436bf2ecf73f7e53d1cc7512384525177ba398565f945a15c16d74f4382ae
View file https://github.com/simstudioai/sim/blob/793e4833108601082d16b35bcdddf803f455344c/apps/sim/app/workspace/%5BworkspaceId%5D/w/%5BworkflowId%5D/components/subflows/subflow-node.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7040/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7040/files#diff-a65436bf2ecf73f7e53d1cc7512384525177ba398565f945a15c16d74f4382ae
https://github.com/simstudioai/sim/pull/7040/files#diff-a65436bf2ecf73f7e53d1cc7512384525177ba398565f945a15c16d74f4382ae
...m/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-block/workflow-block.tsxhttps://github.com/simstudioai/sim/pull/7040/files#diff-eb2223ecc5d1f699578f6498c95b4182bbe7df71b182febbfb6886413b61043b
View file https://github.com/simstudioai/sim/blob/793e4833108601082d16b35bcdddf803f455344c/apps/sim/app/workspace/%5BworkspaceId%5D/w/%5BworkflowId%5D/components/workflow-block/workflow-block.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7040/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7040/files#diff-eb2223ecc5d1f699578f6498c95b4182bbe7df71b182febbfb6886413b61043b
https://github.com/simstudioai/sim/pull/7040/files#diff-eb2223ecc5d1f699578f6498c95b4182bbe7df71b182febbfb6886413b61043b
packages/workflow-renderer/src/subflow/subflow-node-view.tsxhttps://github.com/simstudioai/sim/pull/7040/files#diff-e86d718b25140b2ddd51edbb8d3b59dabb4a749a9d3392c8341993944a8e7726
View file https://github.com/simstudioai/sim/blob/793e4833108601082d16b35bcdddf803f455344c/packages/workflow-renderer/src/subflow/subflow-node-view.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7040/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7040/files#diff-e86d718b25140b2ddd51edbb8d3b59dabb4a749a9d3392c8341993944a8e7726
https://github.com/simstudioai/sim/pull/7040/files#diff-e86d718b25140b2ddd51edbb8d3b59dabb4a749a9d3392c8341993944a8e7726
packages/workflow-renderer/src/workflow-block/workflow-block-view-interaction.test.tsxhttps://github.com/simstudioai/sim/pull/7040/files#diff-f2a0bc1e527c23e5d96871c26af75c3a9a8c967240fa7e03dfe3e667a7b1a0a5
View file https://github.com/simstudioai/sim/blob/793e4833108601082d16b35bcdddf803f455344c/packages/workflow-renderer/src/workflow-block/workflow-block-view-interaction.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7040/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7040/files#diff-f2a0bc1e527c23e5d96871c26af75c3a9a8c967240fa7e03dfe3e667a7b1a0a5
https://github.com/simstudioai/sim/pull/7040/files#diff-f2a0bc1e527c23e5d96871c26af75c3a9a8c967240fa7e03dfe3e667a7b1a0a5
https://github.com/simstudioai/sim/pull/7040/files#diff-f2a0bc1e527c23e5d96871c26af75c3a9a8c967240fa7e03dfe3e667a7b1a0a5
https://github.com/simstudioai/sim/pull/7040/files#diff-f2a0bc1e527c23e5d96871c26af75c3a9a8c967240fa7e03dfe3e667a7b1a0a5
https://github.com/simstudioai/sim/pull/7040/files#diff-f2a0bc1e527c23e5d96871c26af75c3a9a8c967240fa7e03dfe3e667a7b1a0a5
https://github.com/simstudioai/sim/pull/7040/files#diff-f2a0bc1e527c23e5d96871c26af75c3a9a8c967240fa7e03dfe3e667a7b1a0a5
packages/workflow-renderer/src/workflow-block/workflow-block-view.tsxhttps://github.com/simstudioai/sim/pull/7040/files#diff-41333094c321a4cbc8ce835330aa50fe21b431fd334173f728dd28a420f2bbff
View file https://github.com/simstudioai/sim/blob/793e4833108601082d16b35bcdddf803f455344c/packages/workflow-renderer/src/workflow-block/workflow-block-view.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7040/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7040/files#diff-41333094c321a4cbc8ce835330aa50fe21b431fd334173f728dd28a420f2bbff
https://github.com/simstudioai/sim/pull/7040/files#diff-41333094c321a4cbc8ce835330aa50fe21b431fd334173f728dd28a420f2bbff
Please reload this pagehttps://github.com/simstudioai/sim/pull/7040/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.