René's URL Explorer Experiment


Title: fix(webhooks): requeue deliveries dropped by retryable setup infrastructure failures by icecrasher321 · Pull Request #7038 · simstudioai/sim · GitHub

Open Graph Title: fix(webhooks): requeue deliveries dropped by retryable setup infrastructure failures by icecrasher321 · Pull Request #7038 · simstudioai/sim

X Title: fix(webhooks): requeue deliveries dropped by retryable setup infrastructure failures by icecrasher321 · Pull Request #7038 · simstudioai/sim

Description: Summary Webhook deliveries were permanently dropped when setup hit a transient infrastructure failure (e.g. a database connection timeout in the worker): the task runs with maxAttempts: 1, ingress has already ACKed the provider, and the idempotency key was memoized as failed for the 7-day dedupe window — so even provider redeliveries of the same event were rejected Requeue the same delivery (same execution id, bounded jittered backoff) when setup fails on retryable infrastructure before any block has run — mirrors the schedule executor's retryable_setup_failure handling, including the workflowCoreStarted boundary so errors after the executor starts are never reclassified as retryable (no double-run risk); retries are capped by WEBHOOK_INFRA_RETRY_MAX_ATTEMPTS (default 5, 0 disables) and an exhausted budget still faults the run loudly New RetryableSetupError contract in lib/core/errors/retryable-infrastructure: it certifies the operation performed no effect, so executeWithIdempotency releases the claim instead of memoizing the failure — the requeued run (or a later provider redelivery) can claim and execute Classify postgres.js client connection codes (CONNECT_TIMEOUT, CONNECTION_CLOSED, CONNECTION_ENDED, CONNECTION_DESTROYED) as retryable infrastructure — they previously fell outside the Node syscall / undici / Postgres server-code sets, which also weakened the schedule path's existing infra retry Preprocessing gains suppressRetryableFailureLogs so an attempt that will be retried does not leave a terminal failed execution-log row (the retry reuses the execution id, which is unique per log row); the final attempt still records it Trigger.dev applies the requeue delay server-side; the database backend executes jobs only through an in-process runner, so the runner sleeps out the backoff itself Type of Change Bug fix Testing New coverage across the touched suites: requeue on retryable preprocessing failures and setup reads, retry-budget exhaustion, non-retryable passthrough, post-core errors never reclassified, enqueue-failure fallback to loud failure, idempotency claim release vs memoization, classifier codes, log-row suppression against the real preprocessing module tsc --noEmit, bun run lint, bun run check:audits (33 audits), and bun run check:api-validation pass Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Webhook deliveries were permanently dropped when setup hit a transient infrastructure failure (e.g. a database connection timeout in the worker): the task runs with maxAttempts: 1, ingress...

X Description: Summary Webhook deliveries were permanently dropped when setup hit a transient infrastructure failure (e.g. a database connection timeout in the worker): the task runs with maxAttempts: 1, ingress...

Opengraph URL: https://github.com/simstudioai/sim/pull/7038

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7fa504e3-c665-91af-fad7-8d9cec57efd6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDCD2:1EFDE9:FF1467:15D9500:6AFB6481
html-safe-nonce1c62006742d3c92478a108300545ec04416adc24c2429f3915ed713c020b46c2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0QyOjFFRkRFOTpGRjE0Njc6MTVEOTUwMDo2QUZCNjQ4MSIsInZpc2l0b3JfaWQiOiI3NjM3MTU4OTczMjAzNTA2MzA1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7e973a1c407a09c3659dc290ecf478a822502f0d7026c4daeeaaf5dcad4814f9
hovercard-subject-tagpull_request:4351156635
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7038/files
twitter:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
og:image:altSummary Webhook deliveries were permanently dropped when setup hit a transient infrastructure failure (e.g. a database connection timeout in the worker): the task runs with maxAttempts: 1, ingress...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7038/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7038%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7038%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7038/files
Reloadhttps://github.com/simstudioai/sim/pull/7038/files
Reloadhttps://github.com/simstudioai/sim/pull/7038/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
icecrasher321https://github.com/icecrasher321
staginghttps://github.com/simstudioai/sim/tree/staging
fix/webhook-setup-infra-retryhttps://github.com/simstudioai/sim/tree/fix/webhook-setup-infra-retry
Conversation 14 https://github.com/simstudioai/sim/pull/7038
Commits 2 https://github.com/simstudioai/sim/pull/7038/commits
Checks 30 https://github.com/simstudioai/sim/pull/7038/checks
Files changed https://github.com/simstudioai/sim/pull/7038/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7038/files
fix(webhooks): requeue deliveries dropped by retryable setup infrastructure failures https://github.com/simstudioai/sim/pull/7038/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/7038/files
4c35a7b fix(webhooks): requeue deliveries dropped by retryable setup infrastr… Aug 24, 2026 https://github.com/simstudioai/sim/pull/7038/commits/4c35a7b097e8f27f931d4594dd27c4339bc55b1f
95e763e fix(webhooks): restore terminal log on failed requeue and make retry … Aug 24, 2026 https://github.com/simstudioai/sim/pull/7038/commits/95e763ecb6ccac7c52db11ca93674629a062569d
Clear filters https://github.com/simstudioai/sim/pull/7038/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7038/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7038/files
webhook-execution.test.ts https://github.com/simstudioai/sim/pull/7038/files#diff-f433f35408ec79af440433628ad09b0d3585344dcdd28099fbb68a4884b6ecb3
webhook-execution.ts https://github.com/simstudioai/sim/pull/7038/files#diff-d3c199a17069fce702da388ec4cd1b4efc793e0a5968072a181280db5aafdbb1
env.ts https://github.com/simstudioai/sim/pull/7038/files#diff-7db3fc610ff89cf819c4eb69b43ec37ae18530e1861f6c322faeb62f8f48f298
retryable-infrastructure.test.ts https://github.com/simstudioai/sim/pull/7038/files#diff-ae248c83b1a7c80bdae6ebc2009609268e248e7810a217cb8a3172d54c5743e0
retryable-infrastructure.ts https://github.com/simstudioai/sim/pull/7038/files#diff-d3bf1ec5010c8cfc395cb391fb296ba33ac4ba034748a9c0a65b3e2f138a4b5b
service.test.ts https://github.com/simstudioai/sim/pull/7038/files#diff-bee0727cc1cd837ad7cdff4dc81a85bf4c40d0b6888169e7610f69587560e348
service.ts https://github.com/simstudioai/sim/pull/7038/files#diff-6622bed9a9e8ea71519df9b69f50201260f8b7aa4742fe7973f87212b37dc024
hosted-key-rate-limiter.ts https://github.com/simstudioai/sim/pull/7038/files#diff-50012c98ac0631c1a2f4437ea8fcc3795ec93da3d6cffba26bea478e5e381056
preprocessing.test.ts https://github.com/simstudioai/sim/pull/7038/files#diff-bf810ff832cf89c1bf98cfe2ecb746f021b88001dc8a0bd0732de89cb289089a
preprocessing.ts https://github.com/simstudioai/sim/pull/7038/files#diff-302a95657ffed9f4b7bf818f94d31f82065f79bda02a09a46da02a6a3411aa21
helpers.test.ts https://github.com/simstudioai/sim/pull/7038/files#diff-ac1697546154ed78e4c883d3d5f89015e13a2bc2ee3124d5c35227557654a646
helpers.ts https://github.com/simstudioai/sim/pull/7038/files#diff-216592f7d0a585eba5dee5c3a09a7d673509c75b25aa6f38a18d5743ab25b61d
apps/sim/background/webhook-execution.test.tshttps://github.com/simstudioai/sim/pull/7038/files#diff-f433f35408ec79af440433628ad09b0d3585344dcdd28099fbb68a4884b6ecb3
View file https://github.com/simstudioai/sim/blob/95e763ecb6ccac7c52db11ca93674629a062569d/apps/sim/background/webhook-execution.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7038/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7038/files#diff-f433f35408ec79af440433628ad09b0d3585344dcdd28099fbb68a4884b6ecb3
https://github.com/simstudioai/sim/pull/7038/files#diff-f433f35408ec79af440433628ad09b0d3585344dcdd28099fbb68a4884b6ecb3
https://github.com/simstudioai/sim/pull/7038/files#diff-f433f35408ec79af440433628ad09b0d3585344dcdd28099fbb68a4884b6ecb3
https://github.com/simstudioai/sim/pull/7038/files#diff-f433f35408ec79af440433628ad09b0d3585344dcdd28099fbb68a4884b6ecb3
https://github.com/simstudioai/sim/pull/7038/files#diff-f433f35408ec79af440433628ad09b0d3585344dcdd28099fbb68a4884b6ecb3
https://github.com/simstudioai/sim/pull/7038/files#diff-f433f35408ec79af440433628ad09b0d3585344dcdd28099fbb68a4884b6ecb3
https://github.com/simstudioai/sim/pull/7038/files#diff-f433f35408ec79af440433628ad09b0d3585344dcdd28099fbb68a4884b6ecb3
https://github.com/simstudioai/sim/pull/7038/files#diff-f433f35408ec79af440433628ad09b0d3585344dcdd28099fbb68a4884b6ecb3
https://github.com/simstudioai/sim/pull/7038/files#diff-f433f35408ec79af440433628ad09b0d3585344dcdd28099fbb68a4884b6ecb3
Please reload this pagehttps://github.com/simstudioai/sim/pull/7038/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7038/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.