Title: fix(webhooks): requeue deliveries dropped by retryable setup infrastructure failures by icecrasher321 · Pull Request #7038 · simstudioai/sim · GitHub
Open Graph Title: fix(webhooks): requeue deliveries dropped by retryable setup infrastructure failures by icecrasher321 · Pull Request #7038 · simstudioai/sim
X Title: fix(webhooks): requeue deliveries dropped by retryable setup infrastructure failures by icecrasher321 · Pull Request #7038 · simstudioai/sim
Description: Summary Webhook deliveries were permanently dropped when setup hit a transient infrastructure failure (e.g. a database connection timeout in the worker): the task runs with maxAttempts: 1, ingress has already ACKed the provider, and the idempotency key was memoized as failed for the 7-day dedupe window — so even provider redeliveries of the same event were rejected Requeue the same delivery (same execution id, bounded jittered backoff) when setup fails on retryable infrastructure before any block has run — mirrors the schedule executor's retryable_setup_failure handling, including the workflowCoreStarted boundary so errors after the executor starts are never reclassified as retryable (no double-run risk); retries are capped by WEBHOOK_INFRA_RETRY_MAX_ATTEMPTS (default 5, 0 disables) and an exhausted budget still faults the run loudly New RetryableSetupError contract in lib/core/errors/retryable-infrastructure: it certifies the operation performed no effect, so executeWithIdempotency releases the claim instead of memoizing the failure — the requeued run (or a later provider redelivery) can claim and execute Classify postgres.js client connection codes (CONNECT_TIMEOUT, CONNECTION_CLOSED, CONNECTION_ENDED, CONNECTION_DESTROYED) as retryable infrastructure — they previously fell outside the Node syscall / undici / Postgres server-code sets, which also weakened the schedule path's existing infra retry Preprocessing gains suppressRetryableFailureLogs so an attempt that will be retried does not leave a terminal failed execution-log row (the retry reuses the execution id, which is unique per log row); the final attempt still records it Trigger.dev applies the requeue delay server-side; the database backend executes jobs only through an in-process runner, so the runner sleeps out the backoff itself Type of Change Bug fix Testing New coverage across the touched suites: requeue on retryable preprocessing failures and setup reads, retry-budget exhaustion, non-retryable passthrough, post-core errors never reclassified, enqueue-failure fallback to loud failure, idempotency claim release vs memoization, classifier codes, log-row suppression against the real preprocessing module tsc --noEmit, bun run lint, bun run check:audits (33 audits), and bun run check:api-validation pass Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Webhook deliveries were permanently dropped when setup hit a transient infrastructure failure (e.g. a database connection timeout in the worker): the task runs with maxAttempts: 1, ingress...
X Description: Summary Webhook deliveries were permanently dropped when setup hit a transient infrastructure failure (e.g. a database connection timeout in the worker): the task runs with maxAttempts: 1, ingress...
Opengraph URL: https://github.com/simstudioai/sim/pull/7038
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:7fa504e3-c665-91af-fad7-8d9cec57efd6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DCD2:1EFDE9:FF1467:15D9500:6AFB6481 |
| html-safe-nonce | 1c62006742d3c92478a108300545ec04416adc24c2429f3915ed713c020b46c2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0QyOjFFRkRFOTpGRjE0Njc6MTVEOTUwMDo2QUZCNjQ4MSIsInZpc2l0b3JfaWQiOiI3NjM3MTU4OTczMjAzNTA2MzA1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7e973a1c407a09c3659dc290ecf478a822502f0d7026c4daeeaaf5dcad4814f9 |
| hovercard-subject-tag | pull_request:4351156635 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7038/files |
| twitter:image | https://avatars.githubusercontent.com/u/17950982?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/17950982?s=400&v=4 |
| og:image:alt | Summary Webhook deliveries were permanently dropped when setup hit a transient infrastructure failure (e.g. a database connection timeout in the worker): the task runs with maxAttempts: 1, ingress... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | ea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ef97164c52cf59bd10558ddec9c4f482763988 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width