René's URL Explorer Experiment


Title: chore(lint): turn on the rules that would have caught the dead code by waleedlatif1 · Pull Request #7037 · simstudioai/sim · GitHub

Open Graph Title: chore(lint): turn on the rules that would have caught the dead code by waleedlatif1 · Pull Request #7037 · simstudioai/sim

X Title: chore(lint): turn on the rules that would have caught the dead code by waleedlatif1 · Pull Request #7037 · simstudioai/sim

Description: Three lint rules were "off", so nothing enforced them. I measured each, fixed the sites, and enabled them where the cost is bounded. What changed Rule Violations Action performance/noAccumulatingSpread 2 fixed both → enabled repo-wide correctness/noUnusedVariables + noUnusedFunctionParameters 633 repo-wide, 6 under packages/ fixed the 6 → enabled at error for packages/** suspicious/noDocumentCookie 3 not enabled — see below The accumulating spreads were real Both are O(n²) reducers, now Object.fromEntries: stores/workflows/workflow/store.ts — rebuilds a block's subBlocks on every block duplication secrets-manager.tsx — rebuilds a Record from every workspace env var Why packages/** and not everywhere apps/sim carries 627 of the 633. That is a sweep of its own, and a rule switched on with 627 outstanding warnings teaches people to scroll past it. Scoped to packages/**, the cost was 6 fixes and the coverage is 979 files, permanently. This is the rule class whose absence let #7019 happen — eleven unread loggers, a whole unimported file, write-only locals. No gate could see any of it. One fix is narrower than it looks Two of the six were isWorkflowRunning in workflow-renderer: destructured, never read, in both the block and subflow views. My first instinct was to delete the prop — that was wrong twice over, and type-check caught it: A test passes it (this package type-checks its tests; apps/sim doesn't) The app passes it, from workflow-block.tsx:1243 and subflow-node.tsx:78 Its TSDoc claimed it "holds every block's action swell open." Nothing reads it, so that behavior does not exist today. Implementing it is a UX call — there is adjacent logic deliberately not pinning the toolbar during a handoff — and deleting the prop breaks two callers. So only the unused binding goes, the prop stays in the interface, and the TSDoc now states the truth instead of describing behavior that isn't there. Wiring it up or dropping it from the callers is a follow-up for someone who knows the intended UX. Not enabled noDocumentCookie (3 sites, all in the sidebar store) — its fix is the CookieStore API, which is a browser-support decision, not a lint cleanup. useExhaustiveDependencies — 384 errors. Noted, not attempted. Verification All 26 workspaces type-check bun run lint:check exits 0 Both enabled rule sets report zero across their scopes 113 + 14 + 332 tests pass across workflow-renderer, workflow-persistence, stores/workflows, and settings Confirmed the rule can fail: reintroducing the spread turns lint:check red, restoring it goes green One pre-existing suppressions/unused warning in shell-layout.test.ts is untouched — it is on staging too and unrelated.

Open Graph Description: Three lint rules were "off", so nothing enforced them. I measured each, fixed the sites, and enabled them where the cost is bounded. What changed Rule Violations Action performance...

X Description: Three lint rules were "off", so nothing enforced them. I measured each, fixed the sites, and enabled them where the cost is bounded. What changed Rule Violations Action per...

Opengraph URL: https://github.com/simstudioai/sim/pull/7037

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:80e44543-8788-89ac-5247-557d91d41e09
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8566:D16D6:1210841:18D713B:6AFB7182
html-safe-nonce705ed694c1bd8b7bce56489150219cf7a472a46279a9bee7a95de8fd11c44f50
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTY2OkQxNkQ2OjEyMTA4NDE6MThENzEzQjo2QUZCNzE4MiIsInZpc2l0b3JfaWQiOiI1NzExMzU5MTE3MjkzNzQ0NTE0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4b5dc4c9646fc734af9ac13dd0d973b42b93bffa3a479af5bda08a6dd1901527
hovercard-subject-tagpull_request:4351099564
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7037/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altThree lint rules were "off", so nothing enforced them. I measured each, fixed the sites, and enabled them where the cost is bounded. What changed Rule Violations Action performance...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7037/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7037%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7037%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7037/files
Reloadhttps://github.com/simstudioai/sim/pull/7037/files
Reloadhttps://github.com/simstudioai/sim/pull/7037/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
deslop-nexthttps://github.com/simstudioai/sim/tree/deslop-next
Conversation 3 https://github.com/simstudioai/sim/pull/7037
Commits 1 https://github.com/simstudioai/sim/pull/7037/commits
Checks 30 https://github.com/simstudioai/sim/pull/7037/checks
Files changed https://github.com/simstudioai/sim/pull/7037/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7037/files
chore(lint): turn on the rules that would have caught the dead code https://github.com/simstudioai/sim/pull/7037/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/7037/files
67ad7eb chore(lint): turn on the rules that would have caught the dead code waleedlatif1 Aug 24, 2026 https://github.com/simstudioai/sim/pull/7037/commits/67ad7eb2939513c67fbc93ed09cf47feb4d19fee
Clear filters https://github.com/simstudioai/sim/pull/7037/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7037/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7037/files
secrets-manager.tsx https://github.com/simstudioai/sim/pull/7037/files#diff-2b2005db8b8d047cb3aba7c97de2978fe046a48ced2e80dd066bd341bc0d4c04
store.ts https://github.com/simstudioai/sim/pull/7037/files#diff-e77f6367a437f03a60f0109e5343df013b4bce81e7487e582377350b117ef813
biome.json https://github.com/simstudioai/sim/pull/7037/files#diff-2bc8a1f5e9380d5a187a4e90f11b4dd36c3abad6aea44c84be354a4f44cdec55
socket.mock.ts https://github.com/simstudioai/sim/pull/7037/files#diff-17e648752ed39281dff0307c30e2dc9778a8cf4eeab3128ec5c0a48c29ffddae
index.ts https://github.com/simstudioai/sim/pull/7037/files#diff-6f0d66e14d5a03f7e0c32b3a45b550e1ecb947e21d79bd19ef64de8d24ae0cec
subflow-helpers.ts https://github.com/simstudioai/sim/pull/7037/files#diff-7d8aca7fab89f4653c89138a5b35118e04dbe9a354edf50d8ef336853a82b61d
subflow-node-view.tsx https://github.com/simstudioai/sim/pull/7037/files#diff-e86d718b25140b2ddd51edbb8d3b59dabb4a749a9d3392c8341993944a8e7726
workflow-block-view.tsx https://github.com/simstudioai/sim/pull/7037/files#diff-41333094c321a4cbc8ce835330aa50fe21b431fd334173f728dd28a420f2bbff
.../[workspaceId]/settings/components/secrets/components/secrets-manager/secrets-manager.tsxhttps://github.com/simstudioai/sim/pull/7037/files#diff-2b2005db8b8d047cb3aba7c97de2978fe046a48ced2e80dd066bd341bc0d4c04
View file https://github.com/simstudioai/sim/blob/67ad7eb2939513c67fbc93ed09cf47feb4d19fee/apps/sim/app/workspace/%5BworkspaceId%5D/settings/components/secrets/components/secrets-manager/secrets-manager.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7037/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7037/files#diff-2b2005db8b8d047cb3aba7c97de2978fe046a48ced2e80dd066bd341bc0d4c04
https://github.com/simstudioai/sim/pull/7037/files#diff-2b2005db8b8d047cb3aba7c97de2978fe046a48ced2e80dd066bd341bc0d4c04
apps/sim/stores/workflows/workflow/store.tshttps://github.com/simstudioai/sim/pull/7037/files#diff-e77f6367a437f03a60f0109e5343df013b4bce81e7487e582377350b117ef813
View file https://github.com/simstudioai/sim/blob/67ad7eb2939513c67fbc93ed09cf47feb4d19fee/apps/sim/stores/workflows/workflow/store.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7037/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7037/files#diff-e77f6367a437f03a60f0109e5343df013b4bce81e7487e582377350b117ef813
https://github.com/simstudioai/sim/pull/7037/files#diff-e77f6367a437f03a60f0109e5343df013b4bce81e7487e582377350b117ef813
biome.jsonhttps://github.com/simstudioai/sim/pull/7037/files#diff-2bc8a1f5e9380d5a187a4e90f11b4dd36c3abad6aea44c84be354a4f44cdec55
View file https://github.com/simstudioai/sim/blob/67ad7eb2939513c67fbc93ed09cf47feb4d19fee/biome.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7037/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7037/files#diff-2bc8a1f5e9380d5a187a4e90f11b4dd36c3abad6aea44c84be354a4f44cdec55
https://github.com/simstudioai/sim/pull/7037/files#diff-2bc8a1f5e9380d5a187a4e90f11b4dd36c3abad6aea44c84be354a4f44cdec55
packages/testing/src/mocks/socket.mock.tshttps://github.com/simstudioai/sim/pull/7037/files#diff-17e648752ed39281dff0307c30e2dc9778a8cf4eeab3128ec5c0a48c29ffddae
View file https://github.com/simstudioai/sim/blob/67ad7eb2939513c67fbc93ed09cf47feb4d19fee/packages/testing/src/mocks/socket.mock.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7037/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7037/files#diff-17e648752ed39281dff0307c30e2dc9778a8cf4eeab3128ec5c0a48c29ffddae
https://github.com/simstudioai/sim/pull/7037/files#diff-17e648752ed39281dff0307c30e2dc9778a8cf4eeab3128ec5c0a48c29ffddae
packages/ts-sdk/src/index.tshttps://github.com/simstudioai/sim/pull/7037/files#diff-6f0d66e14d5a03f7e0c32b3a45b550e1ecb947e21d79bd19ef64de8d24ae0cec
View file https://github.com/simstudioai/sim/blob/67ad7eb2939513c67fbc93ed09cf47feb4d19fee/packages/ts-sdk/src/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7037/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7037/files#diff-6f0d66e14d5a03f7e0c32b3a45b550e1ecb947e21d79bd19ef64de8d24ae0cec
https://github.com/simstudioai/sim/pull/7037/files#diff-6f0d66e14d5a03f7e0c32b3a45b550e1ecb947e21d79bd19ef64de8d24ae0cec
packages/workflow-persistence/src/subflow-helpers.tshttps://github.com/simstudioai/sim/pull/7037/files#diff-7d8aca7fab89f4653c89138a5b35118e04dbe9a354edf50d8ef336853a82b61d
View file https://github.com/simstudioai/sim/blob/67ad7eb2939513c67fbc93ed09cf47feb4d19fee/packages/workflow-persistence/src/subflow-helpers.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7037/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7037/files#diff-7d8aca7fab89f4653c89138a5b35118e04dbe9a354edf50d8ef336853a82b61d
https://github.com/simstudioai/sim/pull/7037/files#diff-7d8aca7fab89f4653c89138a5b35118e04dbe9a354edf50d8ef336853a82b61d
https://github.com/simstudioai/sim/pull/7037/files#diff-7d8aca7fab89f4653c89138a5b35118e04dbe9a354edf50d8ef336853a82b61d
packages/workflow-renderer/src/subflow/subflow-node-view.tsxhttps://github.com/simstudioai/sim/pull/7037/files#diff-e86d718b25140b2ddd51edbb8d3b59dabb4a749a9d3392c8341993944a8e7726
View file https://github.com/simstudioai/sim/blob/67ad7eb2939513c67fbc93ed09cf47feb4d19fee/packages/workflow-renderer/src/subflow/subflow-node-view.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7037/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7037/files#diff-e86d718b25140b2ddd51edbb8d3b59dabb4a749a9d3392c8341993944a8e7726
https://github.com/simstudioai/sim/pull/7037/files#diff-e86d718b25140b2ddd51edbb8d3b59dabb4a749a9d3392c8341993944a8e7726
https://github.com/simstudioai/sim/pull/7037/files#diff-e86d718b25140b2ddd51edbb8d3b59dabb4a749a9d3392c8341993944a8e7726
https://github.com/simstudioai/sim/pull/7037/files#diff-e86d718b25140b2ddd51edbb8d3b59dabb4a749a9d3392c8341993944a8e7726
packages/workflow-renderer/src/workflow-block/workflow-block-view.tsxhttps://github.com/simstudioai/sim/pull/7037/files#diff-41333094c321a4cbc8ce835330aa50fe21b431fd334173f728dd28a420f2bbff
View file https://github.com/simstudioai/sim/blob/67ad7eb2939513c67fbc93ed09cf47feb4d19fee/packages/workflow-renderer/src/workflow-block/workflow-block-view.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7037/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7037/files#diff-41333094c321a4cbc8ce835330aa50fe21b431fd334173f728dd28a420f2bbff
https://github.com/simstudioai/sim/pull/7037/files#diff-41333094c321a4cbc8ce835330aa50fe21b431fd334173f728dd28a420f2bbff
https://github.com/simstudioai/sim/pull/7037/files#diff-41333094c321a4cbc8ce835330aa50fe21b431fd334173f728dd28a420f2bbff
https://github.com/simstudioai/sim/pull/7037/files#diff-41333094c321a4cbc8ce835330aa50fe21b431fd334173f728dd28a420f2bbff
Please reload this pagehttps://github.com/simstudioai/sim/pull/7037/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.