Title: fix(ci): skip the diff-based audits on branch creation instead of guessing a base by waleedlatif1 · Pull Request #7034 · simstudioai/sim · GitHub
Open Graph Title: fix(ci): skip the diff-based audits on branch creation instead of guessing a base by waleedlatif1 · Pull Request #7034 · simstudioai/sim
X Title: fix(ci): skip the diff-based audits on branch creation instead of guessing a base by waleedlatif1 · Pull Request #7034 · simstudioai/sim
Description: Follow-up to #7033, which merged with a Greptile P1 thread still open. This closes it. The finding Branch creation audits only tip — when the first push creates main, staging, or dev with multiple commits, the all-zero github.event.before selects HEAD~1, so both audits inspect only the final commit. Correct. It is the same failure #7033 set out to remove — a partial audit reported as a complete one — one case further along. Why there is no base to substitute Nothing precedes a branch-creating push. The alternatives are both wrong: HEAD~1 audits one arbitrary commit and reports on the whole push. The whole history would lint every migration ever written; --all mode already exits 1 on this repo for exactly that reason. So the audits now skip, and say so: ::notice::Branch created — no preceding commit to diff against; skipping the diff-based audits. A stated skip is honest. A partial audit wearing a green check is what this whole line of work exists to stop. Reachability Only by deleting and recreating main, staging or dev — the three branches the push trigger covers, all of which exist. This closes a gap, not an incident, and I'd rather say that plainly than dress it up. It makes #7033 smaller fetch-depth: 2 existed solely to give the HEAD~1 fallback something to resolve to. With the fallback gone its only consumer goes too, and since before is fetched by SHA the checkout returns to its default depth — untouched, as it was before #7033. Net −9 lines against #7033. Verification HEAD~1 no longer appears anywhere in the workflow Both audits still pass against a raw SHA base (exit=0) YAML parses; both audit steps carry the same if: steps.audit_base.outputs.ref != '' guard, so they cannot diverge on when they run
Open Graph Description: Follow-up to #7033, which merged with a Greptile P1 thread still open. This closes it. The finding Branch creation audits only tip — when the first push creates main, staging, or dev with multipl...
X Description: Follow-up to #7033, which merged with a Greptile P1 thread still open. This closes it. The finding Branch creation audits only tip — when the first push creates main, staging, or dev with multipl...
Opengraph URL: https://github.com/simstudioai/sim/pull/7034
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:52d4d5a5-551d-d7d5-172e-d186ce7c116b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E988:32523A:290783:39350E:6AFB714A |
| html-safe-nonce | 0198cadcae15c6bf3259d9ba93390a3dcd119a81f9e87ebf46e69b58034b7fad |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTg4OjMyNTIzQToyOTA3ODM6MzkzNTBFOjZBRkI3MTRBIiwidmlzaXRvcl9pZCI6Ijg0MTMyNzk0NjY0NjkxNTkyNDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 0ebb011a0b29c0268973387e8aec7bbe2d16a2ad4dc84c68053fea1c0cbd4148 |
| hovercard-subject-tag | pull_request:4346608469 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7034/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Follow-up to #7033, which merged with a Greptile P1 thread still open. This closes it. The finding Branch creation audits only tip — when the first push creates main, staging, or dev with multipl... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2e8872b770cc4d5d0cc1f2026afab747a268e2ce |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width