Title: fix(ci): require a default export before treating a file as a route entry by waleedlatif1 · Pull Request #7028 · simstudioai/sim · GitHub
Open Graph Title: fix(ci): require a default export before treating a file as a route entry by waleedlatif1 · Pull Request #7028 · simstudioai/sim
X Title: fix(ci): require a default export before treating a file as a route entry by waleedlatif1 · Pull Request #7028 · simstudioai/sim
Description: Follow-up to #7026. Both points were raised in review there and I merged before reading them, so they land here. The filename was never the right test #7026 added error.tsx to the entry filenames, and with it picked up [workspaceId]/components/error/error.tsx — named like a boundary, and not one: export interface ErrorBoundaryProps { … } export function ErrorShell(…) { … } export function ErrorState(…) { … } Named exports only. It is the shared helper the thirteen real boundaries render, and Next would reject it as a boundary for having no default export. Counting it inflated the coverage number and — the part that would have bitten — recorded a shared component in the graph-weight baseline as though it were a route. Every convention-composed entry must default-export the thing Next renders, so that is the discriminator now. Entry count 60 → 59. All thirteen real error.tsx boundaries still walk; only the helper drops out. Completing the enumeration Also adds template.tsx and default.tsx. Neither exists under app/workspace today, so this changes nothing right now — but the list claims to cover what Next composes, and leaving two out makes that claim false the day someone adds one. That is the same failure the surrounding TSDoc already warns about: "A hardcoded list goes stale silently." Verification ✓ tool registry stays out of 59 workspace page/layout graphs error.tsx entries walked: 13 components/error/error.tsx: not present Credit The non-route entry was Cursor's; the missing template.tsx/default.tsx was Greptile's. Both were correct.
Open Graph Description: Follow-up to #7026. Both points were raised in review there and I merged before reading them, so they land here. The filename was never the right test #7026 added error.tsx to the entry filenames, ...
X Description: Follow-up to #7026. Both points were raised in review there and I merged before reading them, so they land here. The filename was never the right test #7026 added error.tsx to the entry filenames, ...
Opengraph URL: https://github.com/simstudioai/sim/pull/7028
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:258b1658-b21b-ef3c-f6fc-8d03b05f26c0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E654:1BB36A:16787D0:1EA53CA:6AFB79DD |
| html-safe-nonce | 2d88ce9c201db7cea7d50be666b8d9659c534c2a14de73c122087525d763bea0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjU0OjFCQjM2QToxNjc4N0QwOjFFQTUzQ0E6NkFGQjc5REQiLCJ2aXNpdG9yX2lkIjoiNDA2NjI5NzQzMjE2MDA0MTQzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 78b38d4e64a92f025bedcd8de53cde20b8ecc55107b2b47cc1a8ffbee63841ed |
| hovercard-subject-tag | pull_request:4344840385 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7028/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Follow-up to #7026. Both points were raised in review there and I merged before reading them, so they land here. The filename was never the right test #7026 added error.tsx to the entry filenames, ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2e8872b770cc4d5d0cc1f2026afab747a268e2ce |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width