Title: fix(ci): stop failing the API audit for adding a compliant route by waleedlatif1 · Pull Request #7027 · simstudioai/sim · GitHub
Open Graph Title: fix(ci): stop failing the API audit for adding a compliant route by waleedlatif1 · Pull Request #7027 · simstudioai/sim
X Title: fix(ci): stop failing the API audit for adding a compliant route by waleedlatif1 · Pull Request #7027 · simstudioai/sim
Description: The next route fails CI regardless of quality BASELINE.totalRoutes is 1162 and the repo has exactly 1162 routes. The gate is: if (totalRoutes > BASELINE.totalRoutes) { failures.push(`route count increased from ${BASELINE.totalRoutes} to ${totalRoutes}`) } Route 1163 turns CI red whether or not it is contract-backed. Reproduced by dropping the baseline by one: API validation audit failed: - route count increased from 1161 to 1162 It gates nothing the other counters miss Live output: total routes: 1162 / Zod-backed: 1162 / non-Zod: 0. The invariant worth holding is every route has a contract, and nonZodRoutes states exactly that — it is 0 and rises the moment a route ships without one. With zodRoutes === totalRoutes, the total carries no information the other two counters don't. What it adds instead is a bad habit The only way past this failure is editing the number. This file holds seven other baselines — routeZodImports, routeLocalSchemaConstructors, clientHookZodImports and the rest — and every one of them works only while nobody bumps a baseline casually. A gate you must bump to add a compliant route trains exactly the reflex that erodes the gates that matter. Change The total is still printed as a metric. It is no longer a failure condition. Nothing else moves. Verified both directions Scenario Before After Compliant new route (total over baseline, nonZod still 0) ❌ red ✅ passes Route with no contract (nonZod rises) ❌ red ❌ red The second was checked by lowering nonZodRoutes to -1, which correctly produced non-Zod routes increased from -1 to 0 (1162 Zod-backed routes) and exit 1. check:api-validation and check:api-validation:strict both exit 0 on the restored file.
Open Graph Description: The next route fails CI regardless of quality BASELINE.totalRoutes is 1162 and the repo has exactly 1162 routes. The gate is: if (totalRoutes > BASELINE.totalRoutes) { failures.push(`route cou...
X Description: The next route fails CI regardless of quality BASELINE.totalRoutes is 1162 and the repo has exactly 1162 routes. The gate is: if (totalRoutes > BASELINE.totalRoutes) { failures.push(`route...
Opengraph URL: https://github.com/simstudioai/sim/pull/7027
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5b161826-828e-9be6-fd7f-1de6b8cb08d0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E072:9464C:138D0D0:1AB0A7B:6AFB7156 |
| html-safe-nonce | 817712b2acb0e38058c0d1cb7d899b30851a8b7641f4a2778849fbeb440edac3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDcyOjk0NjRDOjEzOEQwRDA6MUFCMEE3Qjo2QUZCNzE1NiIsInZpc2l0b3JfaWQiOiI2ODU0NzMyNzM3ODAyODkxNjA2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | dbac7823c51d12aed01dee49a6af50ce9c30a8b0873db577232c067518062f04 |
| hovercard-subject-tag | pull_request:4344803924 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7027/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | The next route fails CI regardless of quality BASELINE.totalRoutes is 1162 and the repo has exactly 1162 routes. The gate is: if (totalRoutes > BASELINE.totalRoutes) { failures.push(`route cou... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2e8872b770cc4d5d0cc1f2026afab747a268e2ce |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width