Title: fix(ci): walk every route entry the workspace app composes by waleedlatif1 · Pull Request #7026 · simstudioai/sim · GitHub
Open Graph Title: fix(ci): walk every route entry the workspace app composes by waleedlatif1 · Pull Request #7026 · simstudioai/sim
X Title: fix(ci): walk every route entry the workspace app composes by waleedlatif1 · Pull Request #7026 · simstudioai/sim
Description: The gap check-tool-registry-boundary.ts collected two entry filenames: const ENTRY_FILENAMES = new Set(['page.tsx', 'layout.tsx']) Next composes three more by convention — error.tsx, loading.tsx, not-found.tsx. 26 exist under app/workspace and none was walked. The guard's own TSDoc already makes the argument for including them: layouts are enumerated separately "because Next.js composes them by convention — a page does not import its layout". That reasoning covers error boundaries and loading states identically. error.tsx matters most: Next requires it to be a Client Component, so a registry edge there lands in the browser bundle exactly as one from a page does. Result Coverage goes from 34 entry graphs to 60. Nothing new is reported — the hole was unexploited. This closes it before it costs something, at no price. The root stays at app/workspace Widening ENTRY_ROOT to app looks tempting and is wrong. It reports: ❌ app/(interfaces)/resume/[workflowId]/[executionId]/page.tsx can reach @/tools/registry via: lib/workflows/executor/human-in-the-loop-manager.ts → ... → tools/registry.ts That page is a Server Component (runtime = 'nodejs', dynamic = 'force-dynamic', async with await params). Its PauseResumeManager import resolves server-side and never reaches a client bundle, so the registry costs nothing there. The guard cannot distinguish a server entry from a client one — its premise is "everything a route entry imports ships to the browser", which holds across app/workspace and not across app. Recorded in the TSDoc so the next person to consider widening it does not have to rediscover this. Testing bun run scripts/check-tool-registry-boundary.ts → ✓ tool registry stays out of 60 workspace page/layout graphs (was 34). Provenance From an audit of the repo's custom gates for blind spots. Two sibling claims in the same report were false positives and are not fixed here: the walker was said to follow no re-exports (it applies REEXPORT_RE alongside three other patterns at line 151, covering export * from, export * as ns from, and export { … } from), and the root was said to need widening (above).
Open Graph Description: The gap check-tool-registry-boundary.ts collected two entry filenames: const ENTRY_FILENAMES = new Set(['page.tsx', 'layout.tsx']) Next composes three more by convention — error.tsx...
X Description: The gap check-tool-registry-boundary.ts collected two entry filenames: const ENTRY_FILENAMES = new Set(['page.tsx', 'layout.tsx']) Next composes three more by conven...
Opengraph URL: https://github.com/simstudioai/sim/pull/7026
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:1a84a13b-b608-089b-ee07-718fb07d94cd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BA88:1C135C:3022E:417B6:6AFB64B5 |
| html-safe-nonce | 20ff5371035b4fe4211acb44af05874e7de948e5301b345e3381066874fa5692 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTg4OjFDMTM1QzozMDIyRTo0MTdCNjo2QUZCNjRCNSIsInZpc2l0b3JfaWQiOiIxMzc3ODg0MTUzODM1MTE5Nzk3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 74f7fbbc7740b65b7153520728563bd7cc76b173f9c11282777080227a453a07 |
| hovercard-subject-tag | pull_request:4344792019 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7026/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | The gap check-tool-registry-boundary.ts collected two entry filenames: const ENTRY_FILENAMES = new Set(['page.tsx', 'layout.tsx']) Next composes three more by convention — error.tsx... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | ea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ef97164c52cf59bd10558ddec9c4f482763988 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width