René's URL Explorer Experiment


Title: fix: surface an unbilled run, and clamp the google-docs page cap by waleedlatif1 · Pull Request #7025 · simstudioai/sim · GitHub

Open Graph Title: fix: surface an unbilled run, and clamp the google-docs page cap by waleedlatif1 · Pull Request #7025 · simstudioai/sim

X Title: fix: surface an unbilled run, and clamp the google-docs page cap by waleedlatif1 · Pull Request #7025 · simstudioai/sim

Description: Two places where a failure is reported as something smaller than it is. A run that is never billed logs as a notification problem lib/logs/execution/logger.ts:1389 } catch (e) { // Safety net: if a step above threw BEFORE the single record call, ensure // the run is still billed. Reconciliation is idempotent... try { await this.recordExecutionUsage(...) } catch {} execLog.warn('Usage threshold notification check failed (non-fatal)', { error: e }) } The comment documents the safety net, not the bare catch {} inside it. The outer try covers a user lookup, recordExecutionUsage, and the threshold-email calls. With a degraded database the lookup throws before the record call, the safety-net re-record hits the same degraded database and is swallowed, and the run is never billed. The only line emitted says the notification check failed and was non-fatal — true of the outer failure, badly wrong about the inner one. That is the shape that keeps a revenue-losing incident out of alerting: the log asserts the opposite of what happened. Now logs at error with the execution and workflow ids, saying the run may be unbilled. The outer warn still covers the email path it was written for. google-docs can ask Drive for a negative page // google-slides.ts:301 /** Last-page precision: never ask Drive for more files than the cap still allows. */ const remaining = maxDocs > 0 ? Math.max(0, maxDocs - previouslyFetched) : 0 // google-docs.ts:307 — no clamp const remaining = maxDocs > 0 ? maxDocs - previouslyFetched : 0 Both then run: if (maxDocs > 0 && documents.length > remaining) documents = documents.slice(0, remaining) A negative remaining makes that guard true for any non-empty page, and slice counts a negative end from the end — so it keeps the leading documents and drops the trailing ones, where the cap says to keep none. The wrong subset, silently, with slicedSome set. Reachable when maxDocs is lowered while a sync cursor persists. google-drive guards the same case a different way (an early return when previouslyFetched >= maxFiles); google-docs had neither, and its google-slides twin carries the fix under a comment marking it deliberate — it just never propagated. Scope The logging change is observability only. The clamp changes behavior exactly in the case that is currently wrong. Testing 1653 tests passing across lib/logs and connectors; bun run type-check clean.

Open Graph Description: Two places where a failure is reported as something smaller than it is. A run that is never billed logs as a notification problem lib/logs/execution/logger.ts:1389 } catch (e) { // Safety net: if...

X Description: Two places where a failure is reported as something smaller than it is. A run that is never billed logs as a notification problem lib/logs/execution/logger.ts:1389 } catch (e) { // Safety net: if...

Opengraph URL: https://github.com/simstudioai/sim/pull/7025

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:79cefd9d-13d6-8559-7964-2496883be670
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC174:2BF3D1:66B180:909ABC:6AFB64D3
html-safe-nonce5a47d4b103045404315e7ea20a4eec8cd625148e41794b78a3b19e74f4b329c9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTc0OjJCRjNEMTo2NkIxODA6OTA5QUJDOjZBRkI2NEQzIiwidmlzaXRvcl9pZCI6IjMwMTM4OTMwNTI5MzEyMDQzMDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac30221ff9a67b7c8fdcba7c39a3b10ec1265f9a3f54bc4c4af6174df0ca77f27a
hovercard-subject-tagpull_request:4344750200
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7025/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altTwo places where a failure is reported as something smaller than it is. A run that is never billed logs as a notification problem lib/logs/execution/logger.ts:1389 } catch (e) { // Safety net: if...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7025/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7025%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7025%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7025/files
Reloadhttps://github.com/simstudioai/sim/pull/7025/files
Reloadhttps://github.com/simstudioai/sim/pull/7025/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix-billing-observabilityhttps://github.com/simstudioai/sim/tree/fix-billing-observability
Conversation 5 https://github.com/simstudioai/sim/pull/7025
Commits 1 https://github.com/simstudioai/sim/pull/7025/commits
Checks 30 https://github.com/simstudioai/sim/pull/7025/checks
Files changed https://github.com/simstudioai/sim/pull/7025/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7025/files
fix: surface an unbilled run, and clamp the google-docs page cap https://github.com/simstudioai/sim/pull/7025/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/7025/files
9c2a46a fix: surface an unbilled run, and clamp the google-docs page cap waleedlatif1 Aug 24, 2026 https://github.com/simstudioai/sim/pull/7025/commits/9c2a46a63f86e33d173d77af33edd72855f1c465
Clear filters https://github.com/simstudioai/sim/pull/7025/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7025/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7025/files
google-docs.ts https://github.com/simstudioai/sim/pull/7025/files#diff-45eb95783c2a2fa432b4ef345fbef006a8235a5e78c9c4f664cdf234b2bbb915
logger.ts https://github.com/simstudioai/sim/pull/7025/files#diff-c93eef5145bbe011ec0c231c435952a4a5d8f1826332935030595b98b5980ee6
apps/sim/connectors/google-docs/google-docs.tshttps://github.com/simstudioai/sim/pull/7025/files#diff-45eb95783c2a2fa432b4ef345fbef006a8235a5e78c9c4f664cdf234b2bbb915
View file https://github.com/simstudioai/sim/blob/9c2a46a63f86e33d173d77af33edd72855f1c465/apps/sim/connectors/google-docs/google-docs.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7025/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7025/files#diff-45eb95783c2a2fa432b4ef345fbef006a8235a5e78c9c4f664cdf234b2bbb915
https://github.com/simstudioai/sim/pull/7025/files#diff-45eb95783c2a2fa432b4ef345fbef006a8235a5e78c9c4f664cdf234b2bbb915
apps/sim/lib/logs/execution/logger.tshttps://github.com/simstudioai/sim/pull/7025/files#diff-c93eef5145bbe011ec0c231c435952a4a5d8f1826332935030595b98b5980ee6
View file https://github.com/simstudioai/sim/blob/9c2a46a63f86e33d173d77af33edd72855f1c465/apps/sim/lib/logs/execution/logger.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7025/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7025/files#diff-c93eef5145bbe011ec0c231c435952a4a5d8f1826332935030595b98b5980ee6
cursorhttps://github.com/apps/cursor
Aug 24, 2026https://github.com/simstudioai/sim/pull/7025/files#r3840272742
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
apps/sim/lib/logs/execution/logger.ts#L1788-L1802https://github.com/simstudioai/sim/blob/9c2a46a63f86e33d173d77af33edd72855f1c465/apps/sim/lib/logs/execution/logger.ts#L1788-L1802
https://cursor.com/open?link=eyJ2ZXJzaW9uIjoxLCJ0eXBlIjoiQlVHQk9UX0ZJWF9JTl9DVVJTT1IiLCJkYXRhIjp7InJlZGlzS2V5IjoiYnVnYm90Ojg2Y2ZjZDJjLTBjMTAtNDc0NS04MmViLWNmOWZhOTY5ZWVlOSIsImVuY3J5cHRpb25LZXkiOiJtcmpBQy00ZHhZVVgzSnJHZUo5ZXZaMEZtVmIxa0NPMklqMGhLS04tV0o4IiwiYnJhbmNoIjoiZml4LWJpbGxpbmctb2JzZXJ2YWJpbGl0eSIsInJlcG9Pd25lciI6InNpbXN0dWRpb2FpIiwicmVwb05hbWUiOiJzaW0iLCJwcm92aWRlciI6ImdpdGh1YiJ9fQ
https://cursor.com/agents?link=eyJ2ZXJzaW9uIjoxLCJ0eXBlIjoiQlVHQk9UX0ZJWF9JTl9XRUIiLCJkYXRhIjp7InJlZGlzS2V5IjoiYnVnYm90Ojg2Y2ZjZDJjLTBjMTAtNDc0NS04MmViLWNmOWZhOTY5ZWVlOSIsImVuY3J5cHRpb25LZXkiOiJtcmpBQy00ZHhZVVgzSnJHZUo5ZXZaMEZtVmIxa0NPMklqMGhLS04tV0o4IiwiYnJhbmNoIjoiZml4LWJpbGxpbmctb2JzZXJ2YWJpbGl0eSIsInJlcG9Pd25lciI6InNpbXN0dWRpb2FpIiwicmVwb05hbWUiOiJzaW0iLCJwck51bWJlciI6NzAyNSwiY29tbWl0U2hhIjoiOWMyYTQ2YTYzZjg2ZTMzZDE3M2Q3N2FmMzNlZGQ3Mjg1NWYxYzQ2NSIsInByb3ZpZGVyIjoiZ2l0aHViIn19
Cursor Bugbothttps://cursor.com/bugbot
9c2a46ahttps://github.com/simstudioai/sim/commit/9c2a46a63f86e33d173d77af33edd72855f1c465
herehttps://www.cursor.com/dashboard/bugbot
Please reload this pagehttps://github.com/simstudioai/sim/pull/7025/files
https://github.com/simstudioai/sim/pull/7025/files#diff-c93eef5145bbe011ec0c231c435952a4a5d8f1826332935030595b98b5980ee6
Please reload this pagehttps://github.com/simstudioai/sim/pull/7025/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.