Title: fix: surface an unbilled run, and clamp the google-docs page cap by waleedlatif1 · Pull Request #7025 · simstudioai/sim · GitHub
Open Graph Title: fix: surface an unbilled run, and clamp the google-docs page cap by waleedlatif1 · Pull Request #7025 · simstudioai/sim
X Title: fix: surface an unbilled run, and clamp the google-docs page cap by waleedlatif1 · Pull Request #7025 · simstudioai/sim
Description: Two places where a failure is reported as something smaller than it is. A run that is never billed logs as a notification problem lib/logs/execution/logger.ts:1389 } catch (e) { // Safety net: if a step above threw BEFORE the single record call, ensure // the run is still billed. Reconciliation is idempotent... try { await this.recordExecutionUsage(...) } catch {} execLog.warn('Usage threshold notification check failed (non-fatal)', { error: e }) } The comment documents the safety net, not the bare catch {} inside it. The outer try covers a user lookup, recordExecutionUsage, and the threshold-email calls. With a degraded database the lookup throws before the record call, the safety-net re-record hits the same degraded database and is swallowed, and the run is never billed. The only line emitted says the notification check failed and was non-fatal — true of the outer failure, badly wrong about the inner one. That is the shape that keeps a revenue-losing incident out of alerting: the log asserts the opposite of what happened. Now logs at error with the execution and workflow ids, saying the run may be unbilled. The outer warn still covers the email path it was written for. google-docs can ask Drive for a negative page // google-slides.ts:301 /** Last-page precision: never ask Drive for more files than the cap still allows. */ const remaining = maxDocs > 0 ? Math.max(0, maxDocs - previouslyFetched) : 0 // google-docs.ts:307 — no clamp const remaining = maxDocs > 0 ? maxDocs - previouslyFetched : 0 Both then run: if (maxDocs > 0 && documents.length > remaining) documents = documents.slice(0, remaining) A negative remaining makes that guard true for any non-empty page, and slice counts a negative end from the end — so it keeps the leading documents and drops the trailing ones, where the cap says to keep none. The wrong subset, silently, with slicedSome set. Reachable when maxDocs is lowered while a sync cursor persists. google-drive guards the same case a different way (an early return when previouslyFetched >= maxFiles); google-docs had neither, and its google-slides twin carries the fix under a comment marking it deliberate — it just never propagated. Scope The logging change is observability only. The clamp changes behavior exactly in the case that is currently wrong. Testing 1653 tests passing across lib/logs and connectors; bun run type-check clean.
Open Graph Description: Two places where a failure is reported as something smaller than it is. A run that is never billed logs as a notification problem lib/logs/execution/logger.ts:1389 } catch (e) { // Safety net: if...
X Description: Two places where a failure is reported as something smaller than it is. A run that is never billed logs as a notification problem lib/logs/execution/logger.ts:1389 } catch (e) { // Safety net: if...
Opengraph URL: https://github.com/simstudioai/sim/pull/7025
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:79cefd9d-13d6-8559-7964-2496883be670 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C174:2BF3D1:66B180:909ABC:6AFB64D3 |
| html-safe-nonce | 5a47d4b103045404315e7ea20a4eec8cd625148e41794b78a3b19e74f4b329c9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTc0OjJCRjNEMTo2NkIxODA6OTA5QUJDOjZBRkI2NEQzIiwidmlzaXRvcl9pZCI6IjMwMTM4OTMwNTI5MzEyMDQzMDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 30221ff9a67b7c8fdcba7c39a3b10ec1265f9a3f54bc4c4af6174df0ca77f27a |
| hovercard-subject-tag | pull_request:4344750200 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7025/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Two places where a failure is reported as something smaller than it is. A run that is never billed logs as a notification problem lib/logs/execution/logger.ts:1389 } catch (e) { // Safety net: if... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | ea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ef97164c52cf59bd10558ddec9c4f482763988 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width