René's URL Explorer Experiment


Title: fix(ci): stop the migration safety audit from passing on a branch it never read by waleedlatif1 · Pull Request #7022 · simstudioai/sim · GitHub

Open Graph Title: fix(ci): stop the migration safety audit from passing on a branch it never read by waleedlatif1 · Pull Request #7022 · simstudioai/sim

X Title: fix(ci): stop the migration safety audit from passing on a branch it never read by waleedlatif1 · Pull Request #7022 · simstudioai/sim

Description: The check reports success when it cannot run check-migrations-safety.ts returns the same empty file list for "this branch adds no migrations" and "I could not diff against the base". The second prints as a pass: $ bun run scripts/check-migrations-safety.ts origin/does-not-exist-branch ✓ No new migrations to check. exit=0 changedMigrationFiles returned [] whenever git diff failed, with a comment deferring the call to the caller — but resolveFiles only ever recognised a missing git binary (git rev-parse HEAD === null), never an unusable ref. CI supplies exactly that input test-build.yml: git fetch --depth=1 origin "${{ github.base_ref }}" 2>/dev/null || true The || true swallows a failed fetch, which leaves origin/ absent — the precise condition above. A PR adding a destructive DROP COLUMN then clears the only guard on production DDL with a green check. This is the one audit in the repo whose failure mode is silent and whose subject is irreversible. The fix, both halves The audit distinguishes the two cases. Absent git remains the one legitimate skip and is now checked before the diff; a diff that fails with git present raises BaseRefUnusableError and exits 1 with a message naming the ref. The fetch is its own step with no || true, so a failed fetch fails the job instead of quietly degrading the next one. Depth stays at 1 deliberately. Without a merge-base the audit falls back to diffing the two tips, and under --diff-filter=AM that is exactly the set of migrations new on the branch — so a shallow fetch is correct here and a full-history fetch would slow every PR for nothing. Testing The defect lived in the exit code, not in any function's return value, so the test runs the script end to end and asserts on the code and stderr. Verified it can fail: reverting the throw to return [] turns the first case red with expected +0 to be 1, and restoring it goes green. ✓ fails loudly when the base ref cannot be diffed ✓ passes against a real base ref with no new migrations Also confirmed the real-base path still exits 0, so this does not turn every PR red. Provenance Found while auditing the repo's custom gates for blind spots — the same sweep that produced #7020 (where \buseQuery\s*\( never matched useQuery(, leaving 10 strict-zone queries unscanned). A passing gate that cannot see part of its own domain is the most expensive kind of green.

Open Graph Description: The check reports success when it cannot run check-migrations-safety.ts returns the same empty file list for "this branch adds no migrations" and "I could not diff against the base&q...

X Description: The check reports success when it cannot run check-migrations-safety.ts returns the same empty file list for "this branch adds no migrations" and "I could not diff agains...

Opengraph URL: https://github.com/simstudioai/sim/pull/7022

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b90fa55f-a6e4-d551-b4cd-70b558005c44
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE2F8:F138D:E511E0:139971C:6AFB5DFB
html-safe-nonced9c2878fb8cc189f93c1028edfed521663e07f8b07f624fdae5395d3006ce6d1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMkY4OkYxMzhEOkU1MTFFMDoxMzk5NzFDOjZBRkI1REZCIiwidmlzaXRvcl9pZCI6IjQ1OTY5MTI2NjMxMzc3MjUzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac829b723e7bda1d13c3b2c515dc075c609f7b23e1bc5a4711805773825a322e0a
hovercard-subject-tagpull_request:4344712306
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7022/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altThe check reports success when it cannot run check-migrations-safety.ts returns the same empty file list for "this branch adds no migrations" and "I could not diff against the base&q...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7022/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7022%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7022%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7022/files
Reloadhttps://github.com/simstudioai/sim/pull/7022/files
Reloadhttps://github.com/simstudioai/sim/pull/7022/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix-migration-gatehttps://github.com/simstudioai/sim/tree/fix-migration-gate
Conversation 3 https://github.com/simstudioai/sim/pull/7022
Commits 2 https://github.com/simstudioai/sim/pull/7022/commits
Checks 28 https://github.com/simstudioai/sim/pull/7022/checks
Files changed https://github.com/simstudioai/sim/pull/7022/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7022/files
fix(ci): stop the migration safety audit from passing on a branch it never read https://github.com/simstudioai/sim/pull/7022/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/7022/files
cb74e15 fix(ci): stop the migration safety audit from passing on a branch it … waleedlatif1 Aug 24, 2026 https://github.com/simstudioai/sim/pull/7022/commits/cb74e153e11007aa6295a64dc304c52c120ba71a
44115b0 fix(ci): fetch the base ref once, and stop swallowing the failure waleedlatif1 Aug 24, 2026 https://github.com/simstudioai/sim/pull/7022/commits/44115b0c4c7e367df833d1ad30ef86494afc4b6c
Clear filters https://github.com/simstudioai/sim/pull/7022/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7022/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7022/files
test-build.yml https://github.com/simstudioai/sim/pull/7022/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
check-migrations-safety.test.ts https://github.com/simstudioai/sim/pull/7022/files#diff-46d6287301fbad5fdb174d71c845a33c73cf30de52c7ae27a0169df384497dbe
check-migrations-safety.ts https://github.com/simstudioai/sim/pull/7022/files#diff-865af4a4f714acde64e1c454597c6426e4779e4927b66c876b03d546447e82ab
.github/workflows/test-build.ymlhttps://github.com/simstudioai/sim/pull/7022/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
View file https://github.com/simstudioai/sim/blob/44115b0c4c7e367df833d1ad30ef86494afc4b6c/.github/workflows/test-build.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7022/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7022/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
https://github.com/simstudioai/sim/pull/7022/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
https://github.com/simstudioai/sim/pull/7022/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
scripts/check-migrations-safety.test.tshttps://github.com/simstudioai/sim/pull/7022/files#diff-46d6287301fbad5fdb174d71c845a33c73cf30de52c7ae27a0169df384497dbe
View file https://github.com/simstudioai/sim/blob/44115b0c4c7e367df833d1ad30ef86494afc4b6c/scripts/check-migrations-safety.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7022/{{ revealButtonHref }}
scripts/check-migrations-safety.tshttps://github.com/simstudioai/sim/pull/7022/files#diff-865af4a4f714acde64e1c454597c6426e4779e4927b66c876b03d546447e82ab
View file https://github.com/simstudioai/sim/blob/44115b0c4c7e367df833d1ad30ef86494afc4b6c/scripts/check-migrations-safety.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7022/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7022/files#diff-865af4a4f714acde64e1c454597c6426e4779e4927b66c876b03d546447e82ab
https://github.com/simstudioai/sim/pull/7022/files#diff-865af4a4f714acde64e1c454597c6426e4779e4927b66c876b03d546447e82ab
https://github.com/simstudioai/sim/pull/7022/files#diff-865af4a4f714acde64e1c454597c6426e4779e4927b66c876b03d546447e82ab
https://github.com/simstudioai/sim/pull/7022/files#diff-865af4a4f714acde64e1c454597c6426e4779e4927b66c876b03d546447e82ab
https://github.com/simstudioai/sim/pull/7022/files#diff-865af4a4f714acde64e1c454597c6426e4779e4927b66c876b03d546447e82ab
Please reload this pagehttps://github.com/simstudioai/sim/pull/7022/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.