René's URL Explorer Experiment


Title: fix(react-query): close the lint's blind spots, and the drift they hid by waleedlatif1 · Pull Request #7020 · simstudioai/sim · GitHub

Open Graph Title: fix(react-query): close the lint's blind spots, and the drift they hid by waleedlatif1 · Pull Request #7020 · simstudioai/sim

X Title: fix(react-query): close the lint's blind spots, and the drift they hid by waleedlatif1 · Pull Request #7020 · simstudioai/sim

Description: Stacked on #7019 → #7018 → #7016 → #7015. The gate was partly reporting on what it could see scripts/check-react-query-patterns.ts has a zero-tolerance strict zone (apps/sim/hooks/queries/**) and an empty baseline, and it passes clean. Two gaps in one regex explain part of that. 1. Type arguments. \buseQuery\s*\( does not match useQuery({ ... }) — the type argument sits between the name and the paren. 20 query calls carry one, 10 inside the strict zone. That zone's "0 violations" was, for those ten, a statement about the scan rather than the code. 2. useQueries. Absent from both the call pattern and the file pre-filter, where \buse(Query|...)\b rejects it on the trailing s. All 16 call sites were unscanned. It also nests its options one level deeper, inside a queries array — so a naive fix that reads the wrapper would take a single staleTime anywhere inside as covering every entry. It gets its own per-entry pass. Closing both surfaced exactly three violations. The drift they hid knowledge-base-selector.tsx served knowledgeKeys.detail(id) with an inline 60 * 1000, while useKnowledgeBaseQuery serves the same cache key from KNOWLEDGE_BASE_DETAIL_STALE_TIME. They agree today by coincidence. TanStack resolves staleTime per observer, so tuning the constant would have left this component on the old freshness window for the same cache entry — the precise failure the CLAUDE.md rule exists to prevent. The same call also dropped the AbortSignal that fetchKnowledgeBase accepts, and use-permission-config.ts gave staleTime as a bare literal. New category: stale-time-literal The rule reads "assigned from a named exported constant, never an inline numeric literal" — but only the presence of staleTime was ever checked. That is the half that let all three through, so it is now enforced. 0 is exempt. It is the sentinel for "always refetch", not a window anyone keeps in step with a prefetch, and the two documented staleTime: 0 sites in the strict zone are correct as written. Verified the rules can fail Reverted each of the three fixes, confirmed the audit reported it, then restored: ratchet zone violations: 3 {"stale-time-literal":2,"queryfn-no-signal":1} knowledge-base-selector.tsx:75 [stale-time-literal] useQueries entry staleTime is the literal 60 * 1000 knowledge-base-selector.tsx:75 [queryfn-no-signal] useQueries entry queryFn takes no args use-permission-config.ts:56 [stale-time-literal] useQuery staleTime is the literal 5 * 60 * 1000 With the fixes in place both zones are 0, so no baseline entries were needed. Testing 3809 tests passing across hooks and app/workspace bun run type-check clean; the audit passes under --check Follow-up not included use-permission-config.ts also breaks "all React Query hooks live in hooks/queries/" — its private key factory and hook sit outside the strict zone, which is why the zone never saw them. Moving the file would put it under strict enforcement but touches imports across the permission surface, so it wants its own PR.

Open Graph Description: Stacked on #7019 → #7018 → #7016 → #7015. The gate was partly reporting on what it could see scripts/check-react-query-patterns.ts has a zero-tolerance strict zone (apps/sim/hooks/queries/**) and ...

X Description: Stacked on #7019 → #7018 → #7016 → #7015. The gate was partly reporting on what it could see scripts/check-react-query-patterns.ts has a zero-tolerance strict zone (apps/sim/hooks/queries/**) and ...

Opengraph URL: https://github.com/simstudioai/sim/pull/7020

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:26399bbd-8610-e941-a8e4-d16c7f71a274
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD38C:2C60B8:CF0AFC:12642EA:6AFB6485
html-safe-noncec0225ad50541831e2d21e8319a9ab5bd4a04ac7836f3f9cd26e58e7dd2ab0d6f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzhDOjJDNjBCODpDRjBBRkM6MTI2NDJFQTo2QUZCNjQ4NSIsInZpc2l0b3JfaWQiOiIxMzI2OTA0MTI4OTgyMTgwOTk3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3cf99a9bbe04be3817a99757ed8970b51eb9f2a395b2f51ce9be9e74cb5218c8
hovercard-subject-tagpull_request:4344223172
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7020/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altStacked on #7019 → #7018 → #7016 → #7015. The gate was partly reporting on what it could see scripts/check-react-query-patterns.ts has a zero-tolerance strict zone (apps/sim/hooks/queries/**) and ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7020/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7020%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7020%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7020/files
Reloadhttps://github.com/simstudioai/sim/pull/7020/files
Reloadhttps://github.com/simstudioai/sim/pull/7020/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
deslop-queryhttps://github.com/simstudioai/sim/tree/deslop-query
Conversation 7 https://github.com/simstudioai/sim/pull/7020
Commits 1 https://github.com/simstudioai/sim/pull/7020/commits
Checks 28 https://github.com/simstudioai/sim/pull/7020/checks
Files changed https://github.com/simstudioai/sim/pull/7020/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7020/files
fix(react-query): close the lint's blind spots, and the drift they hid https://github.com/simstudioai/sim/pull/7020/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/7020/files
43c5104 fix(react-query): close the lint's blind spots, and the drift they hid waleedlatif1 Aug 23, 2026 https://github.com/simstudioai/sim/pull/7020/commits/43c510435f1bbb4a26a92b16f83d6776d4a1417a
Clear filters https://github.com/simstudioai/sim/pull/7020/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7020/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7020/files
knowledge-base-selector.tsx https://github.com/simstudioai/sim/pull/7020/files#diff-d0d0e368c0e7b41031b4893948dee1434c9eef3a236c86782da11bd8a45a9306
use-permission-config.ts https://github.com/simstudioai/sim/pull/7020/files#diff-9dfe45e7b42b8b77d8f35464c466c8dee54bedebb87cd7779c47776cbd5ba50f
check-react-query-patterns.ts https://github.com/simstudioai/sim/pull/7020/files#diff-5e97d692c9965bcafaa5baa80da56fc23197f905bcfac42d3632b92bd9dfd6d0
...ditor/components/sub-block/components/knowledge-base-selector/knowledge-base-selector.tsxhttps://github.com/simstudioai/sim/pull/7020/files#diff-d0d0e368c0e7b41031b4893948dee1434c9eef3a236c86782da11bd8a45a9306
View file https://github.com/simstudioai/sim/blob/43c510435f1bbb4a26a92b16f83d6776d4a1417a/apps/sim/app/workspace/%5BworkspaceId%5D/w/%5BworkflowId%5D/components/panel/components/editor/components/sub-block/components/knowledge-base-selector/knowledge-base-selector.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7020/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7020/files#diff-d0d0e368c0e7b41031b4893948dee1434c9eef3a236c86782da11bd8a45a9306
https://github.com/simstudioai/sim/pull/7020/files#diff-d0d0e368c0e7b41031b4893948dee1434c9eef3a236c86782da11bd8a45a9306
https://github.com/simstudioai/sim/pull/7020/files#diff-d0d0e368c0e7b41031b4893948dee1434c9eef3a236c86782da11bd8a45a9306
https://github.com/simstudioai/sim/pull/7020/files#diff-d0d0e368c0e7b41031b4893948dee1434c9eef3a236c86782da11bd8a45a9306
apps/sim/hooks/use-permission-config.tshttps://github.com/simstudioai/sim/pull/7020/files#diff-9dfe45e7b42b8b77d8f35464c466c8dee54bedebb87cd7779c47776cbd5ba50f
View file https://github.com/simstudioai/sim/blob/43c510435f1bbb4a26a92b16f83d6776d4a1417a/apps/sim/hooks/use-permission-config.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7020/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7020/files#diff-9dfe45e7b42b8b77d8f35464c466c8dee54bedebb87cd7779c47776cbd5ba50f
https://github.com/simstudioai/sim/pull/7020/files#diff-9dfe45e7b42b8b77d8f35464c466c8dee54bedebb87cd7779c47776cbd5ba50f
scripts/check-react-query-patterns.tshttps://github.com/simstudioai/sim/pull/7020/files#diff-5e97d692c9965bcafaa5baa80da56fc23197f905bcfac42d3632b92bd9dfd6d0
View file https://github.com/simstudioai/sim/blob/43c510435f1bbb4a26a92b16f83d6776d4a1417a/scripts/check-react-query-patterns.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7020/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7020/files#diff-5e97d692c9965bcafaa5baa80da56fc23197f905bcfac42d3632b92bd9dfd6d0
https://github.com/simstudioai/sim/pull/7020/files#diff-5e97d692c9965bcafaa5baa80da56fc23197f905bcfac42d3632b92bd9dfd6d0
https://github.com/simstudioai/sim/pull/7020/files#diff-5e97d692c9965bcafaa5baa80da56fc23197f905bcfac42d3632b92bd9dfd6d0
https://github.com/simstudioai/sim/pull/7020/files#diff-5e97d692c9965bcafaa5baa80da56fc23197f905bcfac42d3632b92bd9dfd6d0
https://github.com/simstudioai/sim/pull/7020/files#diff-5e97d692c9965bcafaa5baa80da56fc23197f905bcfac42d3632b92bd9dfd6d0
https://github.com/simstudioai/sim/pull/7020/files#diff-5e97d692c9965bcafaa5baa80da56fc23197f905bcfac42d3632b92bd9dfd6d0
greptile-appshttps://github.com/apps/greptile-apps
Aug 23, 2026https://github.com/simstudioai/sim/pull/7020/files#r3839919859
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/simstudioai/sim/pull/7020/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7020/files
greptile-appshttps://github.com/apps/greptile-apps
Aug 23, 2026https://github.com/simstudioai/sim/pull/7020/files#r3839919863
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/simstudioai/sim/pull/7020/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7020/files
https://github.com/simstudioai/sim/pull/7020/files#diff-5e97d692c9965bcafaa5baa80da56fc23197f905bcfac42d3632b92bd9dfd6d0
https://github.com/simstudioai/sim/pull/7020/files#diff-5e97d692c9965bcafaa5baa80da56fc23197f905bcfac42d3632b92bd9dfd6d0
https://github.com/simstudioai/sim/pull/7020/files#diff-5e97d692c9965bcafaa5baa80da56fc23197f905bcfac42d3632b92bd9dfd6d0
cursorhttps://github.com/apps/cursor
Aug 23, 2026https://github.com/simstudioai/sim/pull/7020/files#r3839907374
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://cursor.com/open?link=eyJ2ZXJzaW9uIjoxLCJ0eXBlIjoiQlVHQk9UX0ZJWF9JTl9DVVJTT1IiLCJkYXRhIjp7InJlZGlzS2V5IjoiYnVnYm90OmZlZDY1NjVlLWYyOWItNDA5Mi05ZmI4LWI0MDFjNWFmMDMxZiIsImVuY3J5cHRpb25LZXkiOiJaWEhQcjhERE9YVnN1N0ptMF9EY3JpZjBidk1TMG0tSVhMVHM3d0p0NTI0IiwiYnJhbmNoIjoiZGVzbG9wLXF1ZXJ5IiwicmVwb093bmVyIjoic2ltc3R1ZGlvYWkiLCJyZXBvTmFtZSI6InNpbSIsInByb3ZpZGVyIjoiZ2l0aHViIn19
https://cursor.com/agents?link=eyJ2ZXJzaW9uIjoxLCJ0eXBlIjoiQlVHQk9UX0ZJWF9JTl9XRUIiLCJkYXRhIjp7InJlZGlzS2V5IjoiYnVnYm90OmZlZDY1NjVlLWYyOWItNDA5Mi05ZmI4LWI0MDFjNWFmMDMxZiIsImVuY3J5cHRpb25LZXkiOiJaWEhQcjhERE9YVnN1N0ptMF9EY3JpZjBidk1TMG0tSVhMVHM3d0p0NTI0IiwiYnJhbmNoIjoiZGVzbG9wLXF1ZXJ5IiwicmVwb093bmVyIjoic2ltc3R1ZGlvYWkiLCJyZXBvTmFtZSI6InNpbSIsInByTnVtYmVyIjo3MDIwLCJjb21taXRTaGEiOiIxMzJiMTc4YTIyNGFmZjQwNWQyNmQ1MWQ5MDdiMTZlOGYxNTAyZDljIiwicHJvdmlkZXIiOiJnaXRodWIifX0
Cursor Bugbothttps://cursor.com/bugbot
132b178https://github.com/simstudioai/sim/commit/132b178a224aff405d26d51d907b16e8f1502d9c
herehttps://www.cursor.com/dashboard/bugbot
Please reload this pagehttps://github.com/simstudioai/sim/pull/7020/files
https://github.com/simstudioai/sim/pull/7020/files#diff-5e97d692c9965bcafaa5baa80da56fc23197f905bcfac42d3632b92bd9dfd6d0
https://github.com/simstudioai/sim/pull/7020/files#diff-5e97d692c9965bcafaa5baa80da56fc23197f905bcfac42d3632b92bd9dfd6d0
https://github.com/simstudioai/sim/pull/7020/files#diff-5e97d692c9965bcafaa5baa80da56fc23197f905bcfac42d3632b92bd9dfd6d0
Please reload this pagehttps://github.com/simstudioai/sim/pull/7020/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.