René's URL Explorer Experiment


Title: fix(files): allowlist the schemes a markdown link may target by waleedlatif1 · Pull Request #7012 · simstudioai/sim · GitHub

Open Graph Title: fix(files): allowlist the schemes a markdown link may target by waleedlatif1 · Pull Request #7012 · simstudioai/sim

X Title: fix(files): allowlist the schemes a markdown link may target by waleedlatif1 · Pull Request #7012 · simstudioai/sim

Description: Summary normalizeLinkHref rejected only file for a scheme:// target and returned every other scheme unchanged. scheme:// is well-formed for any scheme, so a blocklist can't be complete here — switched it to an allowlist of http(s), ftp(s), mailto, tel. The rendered anchor for a linked image is built from a node attribute rather than a link mark, so the editor's own URI validation never inspects it. That made this function the step deciding whether such a target reaches the DOM. Committing an edit whose target normalizes away no longer unsets the link. The edit field is seeded with the current href, so committing an untouched one used to delete a link the user had only opened; refusing a target isn't the same instruction as removing one. Clearing the field still removes the link. Collapsed the scheme check to a single regex and dropped the now-unused one, matching how the other rules in the file are written. Type of Change Bug fix Testing Added coverage for the slash-bearing and unknown-scheme cases, a property test over the paddings and interior whitespace a browser strips before resolving a scheme, a test that a linked image's target is refused before it can become an anchor, and tests for all three applyLink outcomes. Each was verified to fail against the previous behavior. Confirmed no effect on stored documents: normalization runs on the render and edit paths only, never on parse or serialize, so a refused target still round-trips byte-identical. Verified across 21 schemes. Relative, anchor, protocol-relative, bare-domain, and host:port handling are unchanged, as are sim: mention links, which take a different branch. bun run type-check, bun run lint and the full bun run check:audits (33 audits) pass; 770 tests in the affected area pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary normalizeLinkHref rejected only file for a scheme:// target and returned every other scheme unchanged. scheme:// is well-formed for any scheme, so a blocklist can't be complete here — ...

X Description: Summary normalizeLinkHref rejected only file for a scheme:// target and returned every other scheme unchanged. scheme:// is well-formed for any scheme, so a blocklist can't be complete her...

Opengraph URL: https://github.com/simstudioai/sim/pull/7012

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c3b51173-6a20-b370-296d-60700f0a288e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC406:3FAE84:DA14ED:12B2661:6AFB5C92
html-safe-nonce0283303fa1d9f830cd9b10610cc0054835402121585df968cd3b44e1d79620ad
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDA2OjNGQUU4NDpEQTE0RUQ6MTJCMjY2MTo2QUZCNUM5MiIsInZpc2l0b3JfaWQiOiI2Mzg4NjI1NTYwOTQyODk0MjI2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac19f846e45103d030c378c4132127910f5a67bda9e3e6f4eb2f8065ff546854a4
hovercard-subject-tagpull_request:4341967408
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7012/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary normalizeLinkHref rejected only file for a scheme:// target and returned every other scheme unchanged. scheme:// is well-formed for any scheme, so a blocklist can't be complete here — ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7012/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7012%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7012%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7012/files
Reloadhttps://github.com/simstudioai/sim/pull/7012/files
Reloadhttps://github.com/simstudioai/sim/pull/7012/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/markdown-link-scheme-allowlisthttps://github.com/simstudioai/sim/tree/fix/markdown-link-scheme-allowlist
Conversation 3 https://github.com/simstudioai/sim/pull/7012
Commits 1 https://github.com/simstudioai/sim/pull/7012/commits
Checks 30 https://github.com/simstudioai/sim/pull/7012/checks
Files changed https://github.com/simstudioai/sim/pull/7012/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7012/files
fix(files): allowlist the schemes a markdown link may target https://github.com/simstudioai/sim/pull/7012/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/7012/files
383c010 fix(files): allowlist the schemes a markdown link may target waleedlatif1 Aug 23, 2026 https://github.com/simstudioai/sim/pull/7012/commits/383c010173019f30bf352db91ca50b12e8c9febc
Clear filters https://github.com/simstudioai/sim/pull/7012/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7012/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7012/files
markdown-fidelity.ts https://github.com/simstudioai/sim/pull/7012/files#diff-72ac244deaf0ab3b6e2e96aaafd9ca68e768a57c80f9f00c6937830a896557ce
link-editing.test.ts https://github.com/simstudioai/sim/pull/7012/files#diff-a0705c4d19872cbc2cad2f80afa28d57243994dc6a172e9823fa3b98f4def75d
link-editing.tsx https://github.com/simstudioai/sim/pull/7012/files#diff-6dea5e4273a40af969ae837512d46e77f3957e6d80f3f8a7d37a0ceff3570854
round-trip.test.ts https://github.com/simstudioai/sim/pull/7012/files#diff-478932c17a194e130d11561221b7c6393e357d243b9fda308d46b688ea61e766
...pace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/markdown-fidelity.tshttps://github.com/simstudioai/sim/pull/7012/files#diff-72ac244deaf0ab3b6e2e96aaafd9ca68e768a57c80f9f00c6937830a896557ce
View file https://github.com/simstudioai/sim/blob/383c010173019f30bf352db91ca50b12e8c9febc/apps/sim/app/workspace/%5BworkspaceId%5D/files/components/file-viewer/rich-markdown-editor/markdown-fidelity.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7012/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7012/files#diff-72ac244deaf0ab3b6e2e96aaafd9ca68e768a57c80f9f00c6937830a896557ce
https://github.com/simstudioai/sim/pull/7012/files#diff-72ac244deaf0ab3b6e2e96aaafd9ca68e768a57c80f9f00c6937830a896557ce
https://github.com/simstudioai/sim/pull/7012/files#diff-72ac244deaf0ab3b6e2e96aaafd9ca68e768a57c80f9f00c6937830a896557ce
...workspaceId]/files/components/file-viewer/rich-markdown-editor/menus/link-editing.test.tshttps://github.com/simstudioai/sim/pull/7012/files#diff-a0705c4d19872cbc2cad2f80afa28d57243994dc6a172e9823fa3b98f4def75d
View file https://github.com/simstudioai/sim/blob/383c010173019f30bf352db91ca50b12e8c9febc/apps/sim/app/workspace/%5BworkspaceId%5D/files/components/file-viewer/rich-markdown-editor/menus/link-editing.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7012/{{ revealButtonHref }}
...ce/[workspaceId]/files/components/file-viewer/rich-markdown-editor/menus/link-editing.tsxhttps://github.com/simstudioai/sim/pull/7012/files#diff-6dea5e4273a40af969ae837512d46e77f3957e6d80f3f8a7d37a0ceff3570854
View file https://github.com/simstudioai/sim/blob/383c010173019f30bf352db91ca50b12e8c9febc/apps/sim/app/workspace/%5BworkspaceId%5D/files/components/file-viewer/rich-markdown-editor/menus/link-editing.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7012/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7012/files#diff-6dea5e4273a40af969ae837512d46e77f3957e6d80f3f8a7d37a0ceff3570854
https://github.com/simstudioai/sim/pull/7012/files#diff-6dea5e4273a40af969ae837512d46e77f3957e6d80f3f8a7d37a0ceff3570854
...kspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/round-trip.test.tshttps://github.com/simstudioai/sim/pull/7012/files#diff-478932c17a194e130d11561221b7c6393e357d243b9fda308d46b688ea61e766
View file https://github.com/simstudioai/sim/blob/383c010173019f30bf352db91ca50b12e8c9febc/apps/sim/app/workspace/%5BworkspaceId%5D/files/components/file-viewer/rich-markdown-editor/round-trip.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7012/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7012/files#diff-478932c17a194e130d11561221b7c6393e357d243b9fda308d46b688ea61e766
https://github.com/simstudioai/sim/pull/7012/files#diff-478932c17a194e130d11561221b7c6393e357d243b9fda308d46b688ea61e766
https://github.com/simstudioai/sim/pull/7012/files#diff-478932c17a194e130d11561221b7c6393e357d243b9fda308d46b688ea61e766
https://github.com/simstudioai/sim/pull/7012/files#diff-478932c17a194e130d11561221b7c6393e357d243b9fda308d46b688ea61e766
https://github.com/simstudioai/sim/pull/7012/files#diff-478932c17a194e130d11561221b7c6393e357d243b9fda308d46b688ea61e766
Please reload this pagehttps://github.com/simstudioai/sim/pull/7012/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.