Title: fix(inbox): stop an unattributed sender inheriting owner write authority by icecrasher321 · Pull Request #7006 · simstudioai/sim · GitHub
Open Graph Title: fix(inbox): stop an unattributed sender inheriting owner write authority by icecrasher321 · Pull Request #7006 · simstudioai/sim
X Title: fix(inbox): stop an unattributed sender inheriting owner write authority by icecrasher321 · Pull Request #7006 · simstudioai/sim
Description: What An inbox message from a sender that matches no workspace member runs as ws.ownerId. That identity also supplies userPermission, which is what tool authorization gates on — so the owner's admin satisfied every check. This caps such a run at read. Follow-up to #7004, which established that Copilot's function_execute gate was routable around via the workflow tools. Same shape, larger blast radius. The path resolveInboxExecutionActor deliberately refuses to name a raw-secret actor for an unmatched sender: return { executionUserId: ws.ownerId, secretActorUserId: null } The null guards function_execute's direct mount. Nothing guarded the rest: executor.ts:218 → userPermission = workspaceAccess.permission, resolved for ws.ownerId → admin. Headless has no browser, so client-routed tools fall back to their server handlers — the comment at tool-executor/executor.ts:57-59 says exactly this, and register-handlers.ts:142,148 wires create_workflow and run_workflow. All three of create_workflow, edit_workflow, run_workflow carry requiredPermission: 'write', checked at executor.ts:41-53 against that userPermission. runWorkflowFromCopilot (lib/workflows/application/run-workflow-from-copilot.ts:223) calls executeWorkflow(..., actorUserId, { enforceCredentialAccess: true }). enforceCredentialAccess makes identifiedCallerUserId = metadata.userId (execution-core.ts:452), so both personalEnvUserId and workspaceEnvUserId become the owner. Net: an allowlisted external correspondent could reach the owner's workspace and personal secrets by having the agent build and run a workflow — precisely what secretActorUserId: null refuses for a direct mount. Bounded by mothership_inbox_allowed_sender (webhooks/agentmail/route.ts:304), so an admin deliberately added the address. Not the open internet, but a far larger implicit grant than adding a vendor's address suggests. Change One predicate, inboxToolPermission: an attributed message keeps the sender's own permission; an unattributed one is capped at read. Attributed runs are unchanged — executionUserId and secretActorUserId are already the same member there, so an emailed request is equivalent to that person acting in the app, and a read-only member still cannot run or edit anything. Read rather than none because answering an external correspondent from workspace context is the point of the inbox; only mutation and execution are withheld. null stays null — no promotion. The owner identity itself stays. Billing attribution and workspace reads need a real user; that need is why the fallback exists, and it's now separated from the authority that rode along with it. Test plan lib/mothership/inbox/executor.test.ts — 4 passed. caps an external sender at read even when the owner is an admin — verified this fails without the fix (reverted the one line, watched it go red, restored). does not lend a read-only member write authority — attributed path unchanged. leaves an external sender with no permission at none rather than promoting to read. Existing member-attribution test extended to assert userPermission. bun run type-check clean, biome clean. Not addressed This caps authority; it does not change the fact that an unattributed run still reads workspace context as the owner, which is the inbox's intended behaviour. If that should narrow too, it's a product decision about what an external correspondent may be told, not an authorization bug. 🤖 Generated with Claude Code
Open Graph Description: What An inbox message from a sender that matches no workspace member runs as ws.ownerId. That identity also supplies userPermission, which is what tool authorization gates on — so the owner's a...
X Description: What An inbox message from a sender that matches no workspace member runs as ws.ownerId. That identity also supplies userPermission, which is what tool authorization gates on — so the owner'...
Opengraph URL: https://github.com/simstudioai/sim/pull/7006
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:29e46123-5653-4aea-df25-a7a4a4d1a8b8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E3FA:1D7E5A:AC5283:ECE0AB:6AFB50AE |
| html-safe-nonce | 9691c7f152b6b63f852ae31776de6e94c5043687bdff23d00e010910cd170459 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0ZBOjFEN0U1QTpBQzUyODM6RUNFMEFCOjZBRkI1MEFFIiwidmlzaXRvcl9pZCI6IjQyNzg1NTU4MDI1NTUwNzY3ODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 2f738d1fc9ba1f73b242f509edb4c34599226968d62d52991f9e5949976dc107 |
| hovercard-subject-tag | pull_request:4340493718 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7006/files |
| twitter:image | https://avatars.githubusercontent.com/u/17950982?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/17950982?s=400&v=4 |
| og:image:alt | What An inbox message from a sender that matches no workspace member runs as ws.ownerId. That identity also supplies userPermission, which is what tool authorization gates on — so the owner's a... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width