René's URL Explorer Experiment


Title: fix(inbox): stop an unattributed sender inheriting owner write authority by icecrasher321 · Pull Request #7006 · simstudioai/sim · GitHub

Open Graph Title: fix(inbox): stop an unattributed sender inheriting owner write authority by icecrasher321 · Pull Request #7006 · simstudioai/sim

X Title: fix(inbox): stop an unattributed sender inheriting owner write authority by icecrasher321 · Pull Request #7006 · simstudioai/sim

Description: What An inbox message from a sender that matches no workspace member runs as ws.ownerId. That identity also supplies userPermission, which is what tool authorization gates on — so the owner's admin satisfied every check. This caps such a run at read. Follow-up to #7004, which established that Copilot's function_execute gate was routable around via the workflow tools. Same shape, larger blast radius. The path resolveInboxExecutionActor deliberately refuses to name a raw-secret actor for an unmatched sender: return { executionUserId: ws.ownerId, secretActorUserId: null } The null guards function_execute's direct mount. Nothing guarded the rest: executor.ts:218 → userPermission = workspaceAccess.permission, resolved for ws.ownerId → admin. Headless has no browser, so client-routed tools fall back to their server handlers — the comment at tool-executor/executor.ts:57-59 says exactly this, and register-handlers.ts:142,148 wires create_workflow and run_workflow. All three of create_workflow, edit_workflow, run_workflow carry requiredPermission: 'write', checked at executor.ts:41-53 against that userPermission. runWorkflowFromCopilot (lib/workflows/application/run-workflow-from-copilot.ts:223) calls executeWorkflow(..., actorUserId, { enforceCredentialAccess: true }). enforceCredentialAccess makes identifiedCallerUserId = metadata.userId (execution-core.ts:452), so both personalEnvUserId and workspaceEnvUserId become the owner. Net: an allowlisted external correspondent could reach the owner's workspace and personal secrets by having the agent build and run a workflow — precisely what secretActorUserId: null refuses for a direct mount. Bounded by mothership_inbox_allowed_sender (webhooks/agentmail/route.ts:304), so an admin deliberately added the address. Not the open internet, but a far larger implicit grant than adding a vendor's address suggests. Change One predicate, inboxToolPermission: an attributed message keeps the sender's own permission; an unattributed one is capped at read. Attributed runs are unchanged — executionUserId and secretActorUserId are already the same member there, so an emailed request is equivalent to that person acting in the app, and a read-only member still cannot run or edit anything. Read rather than none because answering an external correspondent from workspace context is the point of the inbox; only mutation and execution are withheld. null stays null — no promotion. The owner identity itself stays. Billing attribution and workspace reads need a real user; that need is why the fallback exists, and it's now separated from the authority that rode along with it. Test plan lib/mothership/inbox/executor.test.ts — 4 passed. caps an external sender at read even when the owner is an admin — verified this fails without the fix (reverted the one line, watched it go red, restored). does not lend a read-only member write authority — attributed path unchanged. leaves an external sender with no permission at none rather than promoting to read. Existing member-attribution test extended to assert userPermission. bun run type-check clean, biome clean. Not addressed This caps authority; it does not change the fact that an unattributed run still reads workspace context as the owner, which is the inbox's intended behaviour. If that should narrow too, it's a product decision about what an external correspondent may be told, not an authorization bug. 🤖 Generated with Claude Code

Open Graph Description: What An inbox message from a sender that matches no workspace member runs as ws.ownerId. That identity also supplies userPermission, which is what tool authorization gates on — so the owner's a...

X Description: What An inbox message from a sender that matches no workspace member runs as ws.ownerId. That identity also supplies userPermission, which is what tool authorization gates on — so the owner&#39...

Opengraph URL: https://github.com/simstudioai/sim/pull/7006

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:29e46123-5653-4aea-df25-a7a4a4d1a8b8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE3FA:1D7E5A:AC5283:ECE0AB:6AFB50AE
html-safe-nonce9691c7f152b6b63f852ae31776de6e94c5043687bdff23d00e010910cd170459
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0ZBOjFEN0U1QTpBQzUyODM6RUNFMEFCOjZBRkI1MEFFIiwidmlzaXRvcl9pZCI6IjQyNzg1NTU4MDI1NTUwNzY3ODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2f738d1fc9ba1f73b242f509edb4c34599226968d62d52991f9e5949976dc107
hovercard-subject-tagpull_request:4340493718
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7006/files
twitter:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
og:image:altWhat An inbox message from a sender that matches no workspace member runs as ws.ownerId. That identity also supplies userPermission, which is what tool authorization gates on — so the owner's a...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7006/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7006%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7006%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7006/files
Reloadhttps://github.com/simstudioai/sim/pull/7006/files
Reloadhttps://github.com/simstudioai/sim/pull/7006/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
icecrasher321https://github.com/icecrasher321
staginghttps://github.com/simstudioai/sim/tree/staging
fix/inbox-unattributed-sender-permissionhttps://github.com/simstudioai/sim/tree/fix/inbox-unattributed-sender-permission
Conversation 8 https://github.com/simstudioai/sim/pull/7006
Commits 2 https://github.com/simstudioai/sim/pull/7006/commits
Checks 30 https://github.com/simstudioai/sim/pull/7006/checks
Files changed https://github.com/simstudioai/sim/pull/7006/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7006/files
fix(inbox): stop an unattributed sender inheriting owner write authority https://github.com/simstudioai/sim/pull/7006/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/7006/files
17c049a fix(inbox): stop an unattributed sender inheriting owner write authority Aug 23, 2026 https://github.com/simstudioai/sim/pull/7006/commits/17c049ab8d3522956383c6aab710d4132723ff62
6a0ce48 fix(copilot): bar the headless client-tool fallback below write Aug 23, 2026 https://github.com/simstudioai/sim/pull/7006/commits/6a0ce48f987d51e2dacf208baa912e16e0d766fc
Clear filters https://github.com/simstudioai/sim/pull/7006/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7006/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7006/files
executor.test.ts https://github.com/simstudioai/sim/pull/7006/files#diff-cce67d724b7b145761161e2942d75cbfacfc491751ce7246b879c173680c9ffe
executor.ts https://github.com/simstudioai/sim/pull/7006/files#diff-ca3f0dbdc8a86f4c37bf1c1ddc1d33aa988f7e2eba498247e6c4d8fd34522f18
executor.test.ts https://github.com/simstudioai/sim/pull/7006/files#diff-ca635d219f2ef2635aca720ecb4f22d6fc67c54abac092c8fb213f080e687d31
executor.ts https://github.com/simstudioai/sim/pull/7006/files#diff-c33f60778aa0c14a73019c4f39d873ee087fec05114374d21a5914e5376ac91b
apps/sim/lib/copilot/tool-executor/executor.test.tshttps://github.com/simstudioai/sim/pull/7006/files#diff-cce67d724b7b145761161e2942d75cbfacfc491751ce7246b879c173680c9ffe
View file https://github.com/simstudioai/sim/blob/6a0ce48f987d51e2dacf208baa912e16e0d766fc/apps/sim/lib/copilot/tool-executor/executor.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7006/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7006/files#diff-cce67d724b7b145761161e2942d75cbfacfc491751ce7246b879c173680c9ffe
https://github.com/simstudioai/sim/pull/7006/files#diff-cce67d724b7b145761161e2942d75cbfacfc491751ce7246b879c173680c9ffe
apps/sim/lib/copilot/tool-executor/executor.tshttps://github.com/simstudioai/sim/pull/7006/files#diff-ca3f0dbdc8a86f4c37bf1c1ddc1d33aa988f7e2eba498247e6c4d8fd34522f18
View file https://github.com/simstudioai/sim/blob/6a0ce48f987d51e2dacf208baa912e16e0d766fc/apps/sim/lib/copilot/tool-executor/executor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7006/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7006/files#diff-ca3f0dbdc8a86f4c37bf1c1ddc1d33aa988f7e2eba498247e6c4d8fd34522f18
https://github.com/simstudioai/sim/pull/7006/files#diff-ca3f0dbdc8a86f4c37bf1c1ddc1d33aa988f7e2eba498247e6c4d8fd34522f18
https://github.com/simstudioai/sim/pull/7006/files#diff-ca3f0dbdc8a86f4c37bf1c1ddc1d33aa988f7e2eba498247e6c4d8fd34522f18
apps/sim/lib/mothership/inbox/executor.test.tshttps://github.com/simstudioai/sim/pull/7006/files#diff-ca635d219f2ef2635aca720ecb4f22d6fc67c54abac092c8fb213f080e687d31
View file https://github.com/simstudioai/sim/blob/6a0ce48f987d51e2dacf208baa912e16e0d766fc/apps/sim/lib/mothership/inbox/executor.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7006/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7006/files#diff-ca635d219f2ef2635aca720ecb4f22d6fc67c54abac092c8fb213f080e687d31
https://github.com/simstudioai/sim/pull/7006/files#diff-ca635d219f2ef2635aca720ecb4f22d6fc67c54abac092c8fb213f080e687d31
https://github.com/simstudioai/sim/pull/7006/files#diff-ca635d219f2ef2635aca720ecb4f22d6fc67c54abac092c8fb213f080e687d31
https://github.com/simstudioai/sim/pull/7006/files#diff-ca635d219f2ef2635aca720ecb4f22d6fc67c54abac092c8fb213f080e687d31
https://github.com/simstudioai/sim/pull/7006/files#diff-ca635d219f2ef2635aca720ecb4f22d6fc67c54abac092c8fb213f080e687d31
https://github.com/simstudioai/sim/pull/7006/files#diff-ca635d219f2ef2635aca720ecb4f22d6fc67c54abac092c8fb213f080e687d31
apps/sim/lib/mothership/inbox/executor.tshttps://github.com/simstudioai/sim/pull/7006/files#diff-c33f60778aa0c14a73019c4f39d873ee087fec05114374d21a5914e5376ac91b
View file https://github.com/simstudioai/sim/blob/6a0ce48f987d51e2dacf208baa912e16e0d766fc/apps/sim/lib/mothership/inbox/executor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7006/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7006/files#diff-c33f60778aa0c14a73019c4f39d873ee087fec05114374d21a5914e5376ac91b
https://github.com/simstudioai/sim/pull/7006/files#diff-c33f60778aa0c14a73019c4f39d873ee087fec05114374d21a5914e5376ac91b
https://github.com/simstudioai/sim/pull/7006/files#diff-c33f60778aa0c14a73019c4f39d873ee087fec05114374d21a5914e5376ac91b
https://github.com/simstudioai/sim/pull/7006/files#diff-c33f60778aa0c14a73019c4f39d873ee087fec05114374d21a5914e5376ac91b
https://github.com/simstudioai/sim/pull/7006/files#diff-c33f60778aa0c14a73019c4f39d873ee087fec05114374d21a5914e5376ac91b
Please reload this pagehttps://github.com/simstudioai/sim/pull/7006/files
https://github.com/simstudioai/sim/pull/7006/files#diff-c33f60778aa0c14a73019c4f39d873ee087fec05114374d21a5914e5376ac91b
Please reload this pagehttps://github.com/simstudioai/sim/pull/7006/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.