René's URL Explorer Experiment


Title: fix(media): stop the ffmpeg output format from choosing its own path by icecrasher321 · Pull Request #7001 · simstudioai/sim · GitHub

Open Graph Title: fix(media): stop the ffmpeg output format from choosing its own path by icecrasher321 · Pull Request #7001 · simstudioai/sim

X Title: fix(media): stop the ffmpeg output format from choosing its own path by icecrasher321 · Pull Request #7001 · simstudioai/sim

Description: Summary convert and extract_audio built their output path as path.join(dir, `out.${format}`), and format arrives from the tool as an unconstrained {"type": "string"} — no pattern, no enum — which the handler passes through untouched. A traversal in that string relocates the file FFmpeg writes. Verified against a real FFmpeg binary rather than reasoned about: format = "../../../../../../../../tmp/ffx-escaped.mp4" path.join(dir, "out." + format) -> /tmp/ffx-escaped.mp4 result: 44,078-byte MP4 written outside the temp directory The temp directory is removed with fs.rm(dir, { recursive: true, force: true }) afterwards, which never sees that file — it was never inside the directory being removed. So the write also outlives the cleanup that is supposed to bound this tool's filesystem footprint. The bytes are a transcode of a caller-supplied input, so the attacker influences the content as well as the destination, bounded only by what the app process can write. Reaching it needs nothing but workspace write permission, the same gate as the rest of the tool. Fix Output extensions are letters and digits only, up to 12 characters. Because the pattern admits no . and no separator, out.${ext} is always a single path segment — containment follows from the validation itself rather than from a second check that could drift away from it. Every ordinary target still works: mp4, mp3, webm, m4a, flac, opus, gif, mkv, and MP4 still lowercases before validating. What is deliberately not changed trim and fade also build paths from an extension, but theirs comes from extFromMime, which returns mime.split('/')[1] — that can never contain a separator, so those paths are already contained. Routing them through this stricter pattern would wrongly reject legitimate values like x-msvideo that the fallback produces for an unrecognized MIME type. Provenance Found while tracing a report that targeted escapeDrawtext and addText. That vulnerability is already fixed — #6734 replaced the inline caption with textfile= plus expansion=none, and escapeDrawtext no longer exists — but the report's observation that the tool's string parameters are unconstrained still held for format, which is a path rather than a filtergraph. Verification Six traversal cases pinned by tests — parent-relative, deep-relative, embedded .., absolute, and an embedded NUL — each confirmed to fail against the unfixed source before the fix was applied. Full suite: 1,789 tests across lib/copilot and lib/media, plus tsc --noEmit, lint:check, and the api-validation / boundaries / client-boundary / utils gates. Follow-ups, not in scope A -protocol_whitelist on FFmpeg inputs would stop a crafted input container from referencing external resources. No injection vector remains through the tool's own parameters, so this is defence in depth rather than a fix, and it needs care not to break the concat demuxer. concat is separately broken for any clip without an audio stream: it synthesizes silence with -f lavfi, but lavfi is a libavdevice device and fluent-ffmpeg validates -f against ffmpeg -formats, which does not list devices. Reproduced standalone; fix verified; wants its own PR. 🤖 Generated with Claude Code

Open Graph Description: Summary convert and extract_audio built their output path as path.join(dir, `out.${format}`), and format arrives from the tool as an unconstrained {"type": "string"} — no patter...

X Description: Summary convert and extract_audio built their output path as path.join(dir, `out.${format}`), and format arrives from the tool as an unconstrained {"type": "string&qu...

Opengraph URL: https://github.com/simstudioai/sim/pull/7001

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a30ddd91-b614-a4da-2c92-3f32bd2eeb33
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA28A:305156:1139D:187AE:6AFB47D4
html-safe-nonce62da0f4813a0958f471dcfda3fe753bc69bcc2a1cacbd70a1f32e39e66327601
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjhBOjMwNTE1NjoxMTM5RDoxODdBRTo2QUZCNDdENCIsInZpc2l0b3JfaWQiOiI4NjE2MDU3MzQ1MDk4MzM2MjEyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacaa6ff8fba6f75101cca1c0c024c87b28c8fe6b3d8a24a456c2f874bd18c6cf0b
hovercard-subject-tagpull_request:4340285720
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7001/files
twitter:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
og:image:altSummary convert and extract_audio built their output path as path.join(dir, `out.${format}`), and format arrives from the tool as an unconstrained {"type": "string"} — no patter...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7001/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7001%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7001%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7001/files
Reloadhttps://github.com/simstudioai/sim/pull/7001/files
Reloadhttps://github.com/simstudioai/sim/pull/7001/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
icecrasher321https://github.com/icecrasher321
staginghttps://github.com/simstudioai/sim/tree/staging
fix/ffmpeg-output-format-traversalhttps://github.com/simstudioai/sim/tree/fix/ffmpeg-output-format-traversal
Conversation 3 https://github.com/simstudioai/sim/pull/7001
Commits 1 https://github.com/simstudioai/sim/pull/7001/commits
Checks 30 https://github.com/simstudioai/sim/pull/7001/checks
Files changed https://github.com/simstudioai/sim/pull/7001/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7001/files
fix(media): stop the ffmpeg output format from choosing its own path https://github.com/simstudioai/sim/pull/7001/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/7001/files
88e3235 fix(media): stop the ffmpeg output format from choosing its own path Aug 23, 2026 https://github.com/simstudioai/sim/pull/7001/commits/88e3235479f7ffb2dcdef4a3d97fcd67f78fe3c1
Clear filters https://github.com/simstudioai/sim/pull/7001/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7001/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7001/files
ffmpeg.test.ts https://github.com/simstudioai/sim/pull/7001/files#diff-84d6454b1747ffe231fb651f9c2f250ca9c9ffca1b44c177c5c5930d7f68bc1e
ffmpeg.ts https://github.com/simstudioai/sim/pull/7001/files#diff-4cb239d09c65948f5097877c0984c0a2063556969163ff7c4316dd2de35ca7a9
apps/sim/lib/media/ffmpeg.test.tshttps://github.com/simstudioai/sim/pull/7001/files#diff-84d6454b1747ffe231fb651f9c2f250ca9c9ffca1b44c177c5c5930d7f68bc1e
View file https://github.com/simstudioai/sim/blob/88e3235479f7ffb2dcdef4a3d97fcd67f78fe3c1/apps/sim/lib/media/ffmpeg.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7001/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7001/files#diff-84d6454b1747ffe231fb651f9c2f250ca9c9ffca1b44c177c5c5930d7f68bc1e
https://github.com/simstudioai/sim/pull/7001/files#diff-84d6454b1747ffe231fb651f9c2f250ca9c9ffca1b44c177c5c5930d7f68bc1e
apps/sim/lib/media/ffmpeg.tshttps://github.com/simstudioai/sim/pull/7001/files#diff-4cb239d09c65948f5097877c0984c0a2063556969163ff7c4316dd2de35ca7a9
View file https://github.com/simstudioai/sim/blob/88e3235479f7ffb2dcdef4a3d97fcd67f78fe3c1/apps/sim/lib/media/ffmpeg.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7001/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7001/files#diff-4cb239d09c65948f5097877c0984c0a2063556969163ff7c4316dd2de35ca7a9
https://github.com/simstudioai/sim/pull/7001/files#diff-4cb239d09c65948f5097877c0984c0a2063556969163ff7c4316dd2de35ca7a9
https://github.com/simstudioai/sim/pull/7001/files#diff-4cb239d09c65948f5097877c0984c0a2063556969163ff7c4316dd2de35ca7a9
https://github.com/simstudioai/sim/pull/7001/files#diff-4cb239d09c65948f5097877c0984c0a2063556969163ff7c4316dd2de35ca7a9
https://github.com/simstudioai/sim/pull/7001/files#diff-4cb239d09c65948f5097877c0984c0a2063556969163ff7c4316dd2de35ca7a9
Please reload this pagehttps://github.com/simstudioai/sim/pull/7001/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.