René's URL Explorer Experiment


Title: fix(charts): confine untrusted chart options to canvas render paths by icecrasher321 · Pull Request #6998 · simstudioai/sim · GitHub

Open Graph Title: fix(charts): confine untrusted chart options to canvas render paths by icecrasher321 · Pull Request #6998 · simstudioai/sim

X Title: fix(charts): confine untrusted chart options to canvas render paths by icecrasher321 · Pull Request #6998 · simstudioai/sim

Description: Summary parseChartSpec forwarded a .chart document's option to setOption unchanged. A .chart file is untrusted input — any workspace member authors one, and a public share link renders it to anonymous visitors on the app origin — so a string tooltip.formatter reached ECharts' innerHTML sink as stored XSS. ECharts draws through canvas with two exceptions: a tooltip left in its default renderMode: 'html' assigns its content to innerHTML, and a string formatter is that content's template verbatim (only substituted values are escaped); toolbox assigns dataView.lang to innerHTML and fills a saveAsImage popup with document.write. Both are now closed at the parse boundary, so the document has no DOM sink at all — rather than filtering the values that flow through one. The walk is deep because a top-level fix is provably incomplete: baseOption, media[].option and timeline options[] each carry their own tooltip, a tooltip declared only under media still instantiates the component in HTML mode, and a media entry can override a top-level renderMode. Escaped the series name in the pptx chart renderer's bubble tooltip — same sink, different door. It comes from the uploaded document and is interpolated into a hand-built innerHTML string; every other tooltip there leaves the markup to ECharts, which escapes it. Used encodeHTML rather than the render mode because Sim owns that formatter and only the values are untrusted. Deliberately did not restrict contentType on file creation: resolvePreviewType falls back to the .chart extension, so it closes nothing and would reject legitimate types. renderMode: 'richText' is ECharts' own documented injection-safe mode. One behavior note: HTML inside an author's formatter string (
, ) now renders as literal text. Templates ({b}: {c}), default tooltips and markers are unaffected — ECharts builds those per-mode. Side effect: a document nested deeply enough to exhaust the stack already crashed the render (structuredClone in buildChartRenderOption throws on it). It's now rejected at parse, so it shows the document's error card instead of failing inside the render. Type of Change Bug fix Testing 20 new tests in lib/charts/spec.test.ts, including two that render through real ECharts in SSR mode and assert the resolved model — a version bump that breaks the renderMode assumption fails loudly instead of silently reopening the hole bun run test lib/charts lib/pptx-renderer app/workspace/[workspaceId]/files — 801 passing type-check, lint, check:block-registry and check:audits (33 audits, incl. check:api-validation:strict) all clean Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary parseChartSpec forwarded a .chart document's option to setOption unchanged. A .chart file is untrusted input — any workspace member authors one, and a public share link renders it to a...

X Description: Summary parseChartSpec forwarded a .chart document's option to setOption unchanged. A .chart file is untrusted input — any workspace member authors one, and a public share link renders it ...

Opengraph URL: https://github.com/simstudioai/sim/pull/6998

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4856979c-6aea-791f-6aa0-1b29e683e738
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC2CA:2F2AB3:D20CEC:120FF1B:6AFB59C4
html-safe-noncef088e077daec1b3fd471f44aefac9a6804fdf0326824b832b25951f79f76cba5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkNBOjJGMkFCMzpEMjBDRUM6MTIwRkYxQjo2QUZCNTlDNCIsInZpc2l0b3JfaWQiOiIyNzI3NTUxODQ4MjA5NDA2NDA0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7f3656f185300b55926610558021f6ccfed4089b2891963c910c5252f2e2d615
hovercard-subject-tagpull_request:4340226423
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6998/files
twitter:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
og:image:altSummary parseChartSpec forwarded a .chart document's option to setOption unchanged. A .chart file is untrusted input — any workspace member authors one, and a public share link renders it to a...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6998/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6998%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6998%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6998/files
Reloadhttps://github.com/simstudioai/sim/pull/6998/files
Reloadhttps://github.com/simstudioai/sim/pull/6998/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
icecrasher321https://github.com/icecrasher321
staginghttps://github.com/simstudioai/sim/tree/staging
fix/chart-preview-xsshttps://github.com/simstudioai/sim/tree/fix/chart-preview-xss
Conversation 3 https://github.com/simstudioai/sim/pull/6998
Commits 1 https://github.com/simstudioai/sim/pull/6998/commits
Checks 30 https://github.com/simstudioai/sim/pull/6998/checks
Files changed https://github.com/simstudioai/sim/pull/6998/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6998/files
fix(charts): confine untrusted chart options to canvas render paths https://github.com/simstudioai/sim/pull/6998/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6998/files
b878a46 fix(charts): confine untrusted chart options to canvas render paths Aug 22, 2026 https://github.com/simstudioai/sim/pull/6998/commits/b878a46c4c2f6c8371e3ec47966464866ddd3e3b
Clear filters https://github.com/simstudioai/sim/pull/6998/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6998/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6998/files
spec.test.ts https://github.com/simstudioai/sim/pull/6998/files#diff-6d458e046aad6866554b57da44aa80a17b38e2aa214a7ace9f7d30c74678bdde
spec.ts https://github.com/simstudioai/sim/pull/6998/files#diff-971fc45f1f3b79a59ef01fb9e52eb6d171c4c87cd332d336e8df318c9b8cce7d
chart-renderer.ts https://github.com/simstudioai/sim/pull/6998/files#diff-5aacbf7d9ca381e6102d1f11ad31a9bec1a6c3013cccab5169832d04510e3891
apps/sim/lib/charts/spec.test.tshttps://github.com/simstudioai/sim/pull/6998/files#diff-6d458e046aad6866554b57da44aa80a17b38e2aa214a7ace9f7d30c74678bdde
View file https://github.com/simstudioai/sim/blob/b878a46c4c2f6c8371e3ec47966464866ddd3e3b/apps/sim/lib/charts/spec.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6998/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6998/files#diff-6d458e046aad6866554b57da44aa80a17b38e2aa214a7ace9f7d30c74678bdde
https://github.com/simstudioai/sim/pull/6998/files#diff-6d458e046aad6866554b57da44aa80a17b38e2aa214a7ace9f7d30c74678bdde
https://github.com/simstudioai/sim/pull/6998/files#diff-6d458e046aad6866554b57da44aa80a17b38e2aa214a7ace9f7d30c74678bdde
apps/sim/lib/charts/spec.tshttps://github.com/simstudioai/sim/pull/6998/files#diff-971fc45f1f3b79a59ef01fb9e52eb6d171c4c87cd332d336e8df318c9b8cce7d
View file https://github.com/simstudioai/sim/blob/b878a46c4c2f6c8371e3ec47966464866ddd3e3b/apps/sim/lib/charts/spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6998/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6998/files#diff-971fc45f1f3b79a59ef01fb9e52eb6d171c4c87cd332d336e8df318c9b8cce7d
https://github.com/simstudioai/sim/pull/6998/files#diff-971fc45f1f3b79a59ef01fb9e52eb6d171c4c87cd332d336e8df318c9b8cce7d
https://github.com/simstudioai/sim/pull/6998/files#diff-971fc45f1f3b79a59ef01fb9e52eb6d171c4c87cd332d336e8df318c9b8cce7d
https://github.com/simstudioai/sim/pull/6998/files#diff-971fc45f1f3b79a59ef01fb9e52eb6d171c4c87cd332d336e8df318c9b8cce7d
https://github.com/simstudioai/sim/pull/6998/files#diff-971fc45f1f3b79a59ef01fb9e52eb6d171c4c87cd332d336e8df318c9b8cce7d
apps/sim/lib/pptx-renderer/renderer/chart-renderer.tshttps://github.com/simstudioai/sim/pull/6998/files#diff-5aacbf7d9ca381e6102d1f11ad31a9bec1a6c3013cccab5169832d04510e3891
View file https://github.com/simstudioai/sim/blob/b878a46c4c2f6c8371e3ec47966464866ddd3e3b/apps/sim/lib/pptx-renderer/renderer/chart-renderer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6998/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6998/files#diff-5aacbf7d9ca381e6102d1f11ad31a9bec1a6c3013cccab5169832d04510e3891
https://github.com/simstudioai/sim/pull/6998/files#diff-5aacbf7d9ca381e6102d1f11ad31a9bec1a6c3013cccab5169832d04510e3891
Please reload this pagehttps://github.com/simstudioai/sim/pull/6998/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.