René's URL Explorer Experiment


Title: fix(kb): show spinner for pending connector sync by BillLeoutsakosvl346 · Pull Request #6959 · simstudioai/sim · GitHub

Open Graph Title: fix(kb): show spinner for pending connector sync by BillLeoutsakosvl346 · Pull Request #6959 · simstudioai/sim

X Title: fix(kb): show spinner for pending connector sync by BillLeoutsakosvl346 · Pull Request #6959 · simstudioai/sim

Description: Summary Updates the top knowledge-base connector chip to use the existing isConnectorSyncingOrPending predicate. Newly created connectors are persisted as active before their asynchronous initial sync acquires the syncing lock, so the previous literal status check kept showing the provider logo during that pending window. The chip now shows its loader during both the initial pending-sync period and persisted syncing state without changing connector state transitions or other connector UI. GitHub issue: N/A — reported in the Slack thread. Type of Change Bug fix New feature Breaking change Documentation Other: ___________ Testing bun run --cwd apps/sim test hooks/queries/kb/connectors.test.ts bunx biome check 'apps/sim/app/workspace/[workspaceId]/knowledge/[id]/base.tsx' apps/sim/hooks/queries/kb/connectors.test.ts bun run --cwd apps/sim type-check Reviewers should focus on the top connector-chip condition and the focused coverage for recent unsynced, persisted syncing, completed, expired-pending, and non-active connector states. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) Screenshots/Videos The Slack thread contains the before screenshot. The focused regression test verifies the connector-state behavior that controls the logo-to-spinner swap.

Open Graph Description: Summary Updates the top knowledge-base connector chip to use the existing isConnectorSyncingOrPending predicate. Newly created connectors are persisted as active before their asynchronous initial s...

X Description: Summary Updates the top knowledge-base connector chip to use the existing isConnectorSyncingOrPending predicate. Newly created connectors are persisted as active before their asynchronous initial s...

Opengraph URL: https://github.com/simstudioai/sim/pull/6959

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:64ee0708-1f8e-3f14-623e-b463dc25cbec
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA1B0:870C9:C32529:113CCC9:6AFB5DEC
html-safe-nonce96f36443ede6ad284b86ceccb22b72a62f925603232f283866b81aa83bcf302b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMUIwOjg3MEM5OkMzMjUyOToxMTNDQ0M5OjZBRkI1REVDIiwidmlzaXRvcl9pZCI6IjM4MjM1NzkxMjc5MzE5NTI2MjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4faf4c09cd7afddb4a2d4b2fb5515dbb64427194e5e65125dfb3ea1639018b63
hovercard-subject-tagpull_request:4336307337
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6959/files
twitter:imagehttps://avatars.githubusercontent.com/u/157128530?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/157128530?s=400&v=4
og:image:altSummary Updates the top knowledge-base connector chip to use the existing isConnectorSyncingOrPending predicate. Newly created connectors are persisted as active before their asynchronous initial s...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6959/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6959%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6959%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6959/files
Reloadhttps://github.com/simstudioai/sim/pull/6959/files
Reloadhttps://github.com/simstudioai/sim/pull/6959/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
BillLeoutsakosvl346https://github.com/BillLeoutsakosvl346
staginghttps://github.com/simstudioai/sim/tree/staging
fix/kb-connector-pending-spinnerhttps://github.com/simstudioai/sim/tree/fix/kb-connector-pending-spinner
Conversation 6 https://github.com/simstudioai/sim/pull/6959
Commits 2 https://github.com/simstudioai/sim/pull/6959/commits
Checks 29 https://github.com/simstudioai/sim/pull/6959/checks
Files changed https://github.com/simstudioai/sim/pull/6959/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6959/files
fix(kb): show spinner for pending connector sync https://github.com/simstudioai/sim/pull/6959/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/6959/files
78804c9 fix(kb): show spinner for pending connector sync Aug 22, 2026 https://github.com/simstudioai/sim/pull/6959/commits/78804c93aa2904305efe9e9fd632e7e6b67b2933
7a32737 fix(kb): expire pending connector state Aug 22, 2026 https://github.com/simstudioai/sim/pull/6959/commits/7a327378ecbd8f42efaa301f0b354dbe23c7d71f
Clear filters https://github.com/simstudioai/sim/pull/6959/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6959/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6959/files
base.tsx https://github.com/simstudioai/sim/pull/6959/files#diff-9b1c8365e920c2c33ce67896c76e98caf6c8535794de2ce1d01ea707bb2b2161
connectors.test.ts https://github.com/simstudioai/sim/pull/6959/files#diff-eeaa40030cc3b66809605b671690ea1513332970b3285d6fd545a6f5dd6c478f
connectors.ts https://github.com/simstudioai/sim/pull/6959/files#diff-13f97cd6f6b052ac1fb420979601d978b4aee1a9e84b5dba8e12845057e8ddf2
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/base.tsxhttps://github.com/simstudioai/sim/pull/6959/files#diff-9b1c8365e920c2c33ce67896c76e98caf6c8535794de2ce1d01ea707bb2b2161
View file https://github.com/simstudioai/sim/blob/7a327378ecbd8f42efaa301f0b354dbe23c7d71f/apps/sim/app/workspace/%5BworkspaceId%5D/knowledge/%5Bid%5D/base.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6959/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6959/files#diff-9b1c8365e920c2c33ce67896c76e98caf6c8535794de2ce1d01ea707bb2b2161
Please reload this pagehttps://github.com/simstudioai/sim/pull/6959/files
https://github.com/simstudioai/sim/pull/6959/files#diff-9b1c8365e920c2c33ce67896c76e98caf6c8535794de2ce1d01ea707bb2b2161
apps/sim/hooks/queries/kb/connectors.test.tshttps://github.com/simstudioai/sim/pull/6959/files#diff-eeaa40030cc3b66809605b671690ea1513332970b3285d6fd545a6f5dd6c478f
View file https://github.com/simstudioai/sim/blob/7a327378ecbd8f42efaa301f0b354dbe23c7d71f/apps/sim/hooks/queries/kb/connectors.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6959/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6959/files#diff-eeaa40030cc3b66809605b671690ea1513332970b3285d6fd545a6f5dd6c478f
https://github.com/simstudioai/sim/pull/6959/files#diff-eeaa40030cc3b66809605b671690ea1513332970b3285d6fd545a6f5dd6c478f
https://github.com/simstudioai/sim/pull/6959/files#diff-eeaa40030cc3b66809605b671690ea1513332970b3285d6fd545a6f5dd6c478f
apps/sim/hooks/queries/kb/connectors.tshttps://github.com/simstudioai/sim/pull/6959/files#diff-13f97cd6f6b052ac1fb420979601d978b4aee1a9e84b5dba8e12845057e8ddf2
View file https://github.com/simstudioai/sim/blob/7a327378ecbd8f42efaa301f0b354dbe23c7d71f/apps/sim/hooks/queries/kb/connectors.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6959/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6959/files#diff-13f97cd6f6b052ac1fb420979601d978b4aee1a9e84b5dba8e12845057e8ddf2
https://github.com/simstudioai/sim/pull/6959/files#diff-13f97cd6f6b052ac1fb420979601d978b4aee1a9e84b5dba8e12845057e8ddf2
Please reload this pagehttps://github.com/simstudioai/sim/pull/6959/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.