René's URL Explorer Experiment


Title: fix(combobox): report every open, not just the dismissals Radix initiates by icecrasher321 · Pull Request #6931 · simstudioai/sim · GitHub

Open Graph Title: fix(combobox): report every open, not just the dismissals Radix initiates by icecrasher321 · Pull Request #6931 · simstudioai/sim

X Title: fix(combobox): report every open, not just the dismissals Radix initiates by icecrasher321 · Pull Request #6931 · simstudioai/sim

Description: The agent block's tool picker opens onto "No tools found" over the entire block registry. What broke Combobox owns its open state but renders a controlled Radix Popover (PopoverAnchor + open={open}, no PopoverTrigger), and the consumer's onOpenChange hung off that Popover alone. A controlled popover reports only the transitions it initiates itself, so outside-click and Escape arrived and nothing else did — the trigger, the chevron, focus, Enter/Space/ArrowDown, and select-to-close were all the component's own setOpen, invisible from outside. Every consumer used the signal to refresh on open or reset on close, so the damage stayed quiet: the credential selectors, the MCP tool selector, the workspace-file picker, the connector modal, and the sub-block dropdown's remote option list simply never refreshed when opened. Lists still populated from their initial query, so the symptom was staleness. Then #6881 gated the agent block's toolGroups on the same signal, to keep the group build off the canvas's hot path: const toolGroups = useMemo((): ComboboxOptionGroup[] => { if (!open) return EMPTY_COMBOBOX_GROUPS A picker that cannot learn it is open builds nothing. The gate is sound; the signal it reads was not. The fix Every transition now goes through one changeOpen, which Radix's own onOpenChange also feeds, so setOpen has exactly one caller and the callback cannot be missed. It dedupes through a ref — several paths both close and let the popover dismiss, a redundancy the raw setState absorbed silently but a consumer callback would not — and reading that ref lets the toggles resolve their next value without re-creating their handlers on every open. This also revives refresh-on-open for the nine consumers that had been asking for it all along. Verification combobox.dom.test.tsx covers the transitions Radix never reported (trigger click both ways, keyboard open, Escape) plus the consumer shape that made this visible: options supplied only once the dropdown says it opened must render, not the empty state. Four of the five fail on staging; the last one renders 'Select...No tools', which is exactly what the picker shows on screen. emcn 80/80, apps/sim 29,715 passed / 0 failed type-check clean on both workspaces, biome clean 🤖 Generated with Claude Code

Open Graph Description: The agent block's tool picker opens onto "No tools found" over the entire block registry. What broke Combobox owns its open state but renders a controlled Radix Popover (PopoverAnchor...

X Description: The agent block's tool picker opens onto "No tools found" over the entire block registry. What broke Combobox owns its open state but renders a controlled Radix Popover (P...

Opengraph URL: https://github.com/simstudioai/sim/pull/6931

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:95245e36-fbc8-e199-ed99-2f673ee1a706
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9CF6:3FAE84:F94BB1:155F236:6AFB6433
html-safe-noncef27fcbd60ee19345aeba912b5d2ca8b26b52f686d44b4114b466d269a1a6e33b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0Y2OjNGQUU4NDpGOTRCQjE6MTU1RjIzNjo2QUZCNjQzMyIsInZpc2l0b3JfaWQiOiI3ODE4NDUzNDUxMTg3OTA1NTg3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac748132c412e494a4e813606d0c0dc082165c151c694cc70f94881bccace61350
hovercard-subject-tagpull_request:4333142844
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6931/files
twitter:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
og:image:altThe agent block's tool picker opens onto "No tools found" over the entire block registry. What broke Combobox owns its open state but renders a controlled Radix Popover (PopoverAnchor...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6931/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6931%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6931%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6931/files
Reloadhttps://github.com/simstudioai/sim/pull/6931/files
Reloadhttps://github.com/simstudioai/sim/pull/6931/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
icecrasher321https://github.com/icecrasher321
staginghttps://github.com/simstudioai/sim/tree/staging
fix/combobox-open-signalhttps://github.com/simstudioai/sim/tree/fix/combobox-open-signal
Conversation 3 https://github.com/simstudioai/sim/pull/6931
Commits 1 https://github.com/simstudioai/sim/pull/6931/commits
Checks 31 https://github.com/simstudioai/sim/pull/6931/checks
Files changed https://github.com/simstudioai/sim/pull/6931/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6931/files
fix(combobox): report every open, not just the dismissals Radix initiates https://github.com/simstudioai/sim/pull/6931/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6931/files
f6cffd1 fix(combobox): report every open, not just the dismissals Radix initi… Aug 21, 2026 https://github.com/simstudioai/sim/pull/6931/commits/f6cffd1b711c96bf61571355867afa35562f0411
Clear filters https://github.com/simstudioai/sim/pull/6931/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6931/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6931/files
combobox.dom.test.tsx https://github.com/simstudioai/sim/pull/6931/files#diff-e011e21dba56eea74fd3218ad71f2a365aeadb95d9342aecf64e6635a79e6f0c
combobox.tsx https://github.com/simstudioai/sim/pull/6931/files#diff-af507bf3319191fdd3419bd107befb822e415435568924aea3413eba2ac39b66
packages/emcn/src/components/combobox/combobox.dom.test.tsxhttps://github.com/simstudioai/sim/pull/6931/files#diff-e011e21dba56eea74fd3218ad71f2a365aeadb95d9342aecf64e6635a79e6f0c
View file https://github.com/simstudioai/sim/blob/f6cffd1b711c96bf61571355867afa35562f0411/packages/emcn/src/components/combobox/combobox.dom.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6931/{{ revealButtonHref }}
packages/emcn/src/components/combobox/combobox.tsxhttps://github.com/simstudioai/sim/pull/6931/files#diff-af507bf3319191fdd3419bd107befb822e415435568924aea3413eba2ac39b66
View file https://github.com/simstudioai/sim/blob/f6cffd1b711c96bf61571355867afa35562f0411/packages/emcn/src/components/combobox/combobox.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6931/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6931/files#diff-af507bf3319191fdd3419bd107befb822e415435568924aea3413eba2ac39b66
https://github.com/simstudioai/sim/pull/6931/files#diff-af507bf3319191fdd3419bd107befb822e415435568924aea3413eba2ac39b66
https://github.com/simstudioai/sim/pull/6931/files#diff-af507bf3319191fdd3419bd107befb822e415435568924aea3413eba2ac39b66
https://github.com/simstudioai/sim/pull/6931/files#diff-af507bf3319191fdd3419bd107befb822e415435568924aea3413eba2ac39b66
https://github.com/simstudioai/sim/pull/6931/files#diff-af507bf3319191fdd3419bd107befb822e415435568924aea3413eba2ac39b66
https://github.com/simstudioai/sim/pull/6931/files#diff-af507bf3319191fdd3419bd107befb822e415435568924aea3413eba2ac39b66
https://github.com/simstudioai/sim/pull/6931/files#diff-af507bf3319191fdd3419bd107befb822e415435568924aea3413eba2ac39b66
https://github.com/simstudioai/sim/pull/6931/files#diff-af507bf3319191fdd3419bd107befb822e415435568924aea3413eba2ac39b66
https://github.com/simstudioai/sim/pull/6931/files#diff-af507bf3319191fdd3419bd107befb822e415435568924aea3413eba2ac39b66
https://github.com/simstudioai/sim/pull/6931/files#diff-af507bf3319191fdd3419bd107befb822e415435568924aea3413eba2ac39b66
https://github.com/simstudioai/sim/pull/6931/files#diff-af507bf3319191fdd3419bd107befb822e415435568924aea3413eba2ac39b66
https://github.com/simstudioai/sim/pull/6931/files#diff-af507bf3319191fdd3419bd107befb822e415435568924aea3413eba2ac39b66
https://github.com/simstudioai/sim/pull/6931/files#diff-af507bf3319191fdd3419bd107befb822e415435568924aea3413eba2ac39b66
https://github.com/simstudioai/sim/pull/6931/files#diff-af507bf3319191fdd3419bd107befb822e415435568924aea3413eba2ac39b66
https://github.com/simstudioai/sim/pull/6931/files#diff-af507bf3319191fdd3419bd107befb822e415435568924aea3413eba2ac39b66
https://github.com/simstudioai/sim/pull/6931/files#diff-af507bf3319191fdd3419bd107befb822e415435568924aea3413eba2ac39b66
https://github.com/simstudioai/sim/pull/6931/files#diff-af507bf3319191fdd3419bd107befb822e415435568924aea3413eba2ac39b66
https://github.com/simstudioai/sim/pull/6931/files#diff-af507bf3319191fdd3419bd107befb822e415435568924aea3413eba2ac39b66
Please reload this pagehttps://github.com/simstudioai/sim/pull/6931/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.