René's URL Explorer Experiment


Title: fix(auth): bound the three unbounded session-policy caches by icecrasher321 · Pull Request #6919 · simstudioai/sim · GitHub

Open Graph Title: fix(auth): bound the three unbounded session-policy caches by icecrasher321 · Pull Request #6919 · simstudioai/sim

X Title: fix(auth): bound the three unbounded session-policy caches by icecrasher321 · Pull Request #6919 · simstudioai/sim

Description: security-policy.ts and session-policy.ts are read from Better Auth's session create and update hooks, so they run on every session validation. All three caches were plain Maps with a hand-rolled Date.now() - fetchedAt < TTL read and no ceiling — entries were released only by an explicit invalidate*, so they grew for the life of the process. membershipCache is the sharpest of the three: it is keyed by user, not organization, so it held one entry per user who ever authenticated on that instance. Change All three move to LRUCache — already a direct dependency of apps/sim, and the pattern lib/copilot/entitlements.ts and providers/client-cache.ts already use. The library owns the TTL and the ceiling, and the hand-rolled TTL arithmetic goes away. Every existing invalidate* keeps working unchanged (LRUCache has .delete). Cache Key Was Now session-policy.policyCache org unbounded max: 1000, 60s security-policy.versionCache org unbounded max: 1000, 60s security-policy.membershipCache user unbounded max: 10_000, 60s / 15s Two behaviors preserved deliberately The asymmetric membership TTL. A non-member result still expires far sooner than a member one — a user can join through paths this codebase never sees (Better Auth SSO JIT provisioning), and a longer-lived cached null would let them dodge the new org's policy. Now expressed as membershipCacheTtlMs() rather than an inline ternary, because it is a security property rather than a tuning knob, and applied via LRUCache's per-entry ttl. Reads test !== undefined. A version is a number and a membership is nullable, so a truthiness check would read both as a miss and re-query on every call. Coalescing was deliberately not added. These are single cheap reads, unlike the multi-query billing gate that motivated coalesceLocally elsewhere, and changing concurrency semantics on the auth path is not worth bundling here. Tests security-policy.ts had no test file; this adds one covering caching, explicit invalidation, failure fallbacks, and the TTL asymmetry. session-policy.test.ts (pure clamp math) is untouched and still passes. Full suite: 29,508 passing. Two failures in the full run are Test timed out under a saturated machine (sso-trust, diff-engine); both pass in isolation and both fail identically on branches that never touch lib/auth/. 🤖 Generated with Claude Code

Open Graph Description: security-policy.ts and session-policy.ts are read from Better Auth's session create and update hooks, so they run on every session validation. All three caches were plain Maps with a hand-rolle...

X Description: security-policy.ts and session-policy.ts are read from Better Auth&#39;s session create and update hooks, so they run on every session validation. All three caches were plain Maps with a hand-r...

Opengraph URL: https://github.com/simstudioai/sim/pull/6919

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2753421c-0ce2-a640-8bf3-7b5a53069f06
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD30:71943:E0F52D:13C70D4:6AFB63FA
html-safe-nonce3f51a30b604876c7b3dc97b3857c4e0667e9da3e50757cdc0ec28ab792c43088
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDMwOjcxOTQzOkUwRjUyRDoxM0M3MEQ0OjZBRkI2M0ZBIiwidmlzaXRvcl9pZCI6IjQ1MTQ5NjYyMzQzNDQ0MTYyNTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4332a75de018b5469fd33d8bea7e467695042349f23313406026e170284f88b7
hovercard-subject-tagpull_request:4327679758
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6919/files
twitter:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
og:image:altsecurity-policy.ts and session-policy.ts are read from Better Auth's session create and update hooks, so they run on every session validation. All three caches were plain Maps with a hand-rolle...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6919/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6919%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6919%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6919/files
Reloadhttps://github.com/simstudioai/sim/pull/6919/files
Reloadhttps://github.com/simstudioai/sim/pull/6919/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
icecrasher321https://github.com/icecrasher321
staginghttps://github.com/simstudioai/sim/tree/staging
chore/bound-auth-policy-cacheshttps://github.com/simstudioai/sim/tree/chore/bound-auth-policy-caches
Conversation 3 https://github.com/simstudioai/sim/pull/6919
Commits 3 https://github.com/simstudioai/sim/pull/6919/commits
Checks 28 https://github.com/simstudioai/sim/pull/6919/checks
Files changed https://github.com/simstudioai/sim/pull/6919/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6919/files
fix(auth): bound the three unbounded session-policy caches https://github.com/simstudioai/sim/pull/6919/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/6919/files
5b86cf3 fix(auth): bound the three unbounded session-policy caches Aug 21, 2026 https://github.com/simstudioai/sim/pull/6919/commits/5b86cf32263ca8c9817d4b20d0777527db9c90d4
b6b607e fix(auth): raise the cache ceilings to a memory backstop Aug 21, 2026 https://github.com/simstudioai/sim/pull/6919/commits/b6b607e75712df31012b77f2ea50da8e99d3b7ef
96b91e0 docs(rules): write down the caching decision tree Aug 21, 2026 https://github.com/simstudioai/sim/pull/6919/commits/96b91e0e3eac72e25e7fe0e5b290a938319c09e7
Clear filters https://github.com/simstudioai/sim/pull/6919/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6919/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6919/files
sim-caching.md https://github.com/simstudioai/sim/pull/6919/files#diff-77f30dcfbff32219b1e0fa7166b927b013ef60b47fb79474c5af5fb3c43af983
CLAUDE.md https://github.com/simstudioai/sim/pull/6919/files#diff-6ebdb617a8104a7756d0cf36578ab01103dc9f07e4dc6feb751296b9c402faf7
security-policy.test.ts https://github.com/simstudioai/sim/pull/6919/files#diff-c753bc27fc9208b37307ec1d1dfaae9bdbfc4d662980459aeb08e87b6351fefb
security-policy.ts https://github.com/simstudioai/sim/pull/6919/files#diff-fee93899e8f9dc7646e77b4077b358b3167461f9ce25222023709a1e2c334eed
session-policy.ts https://github.com/simstudioai/sim/pull/6919/files#diff-cf03895d7da936c345c9606e8bfc48e849d2f943124d77871fb1035db961a828
.claude/rules/sim-caching.mdhttps://github.com/simstudioai/sim/pull/6919/files#diff-77f30dcfbff32219b1e0fa7166b927b013ef60b47fb79474c5af5fb3c43af983
View file https://github.com/simstudioai/sim/blob/96b91e0e3eac72e25e7fe0e5b290a938319c09e7/.claude/rules/sim-caching.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6919/{{ revealButtonHref }}
CLAUDE.mdhttps://github.com/simstudioai/sim/pull/6919/files#diff-6ebdb617a8104a7756d0cf36578ab01103dc9f07e4dc6feb751296b9c402faf7
View file https://github.com/simstudioai/sim/blob/96b91e0e3eac72e25e7fe0e5b290a938319c09e7/CLAUDE.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6919/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6919/files#diff-6ebdb617a8104a7756d0cf36578ab01103dc9f07e4dc6feb751296b9c402faf7
https://github.com/simstudioai/sim/pull/6919/files#diff-6ebdb617a8104a7756d0cf36578ab01103dc9f07e4dc6feb751296b9c402faf7
apps/sim/lib/auth/security-policy.test.tshttps://github.com/simstudioai/sim/pull/6919/files#diff-c753bc27fc9208b37307ec1d1dfaae9bdbfc4d662980459aeb08e87b6351fefb
View file https://github.com/simstudioai/sim/blob/96b91e0e3eac72e25e7fe0e5b290a938319c09e7/apps/sim/lib/auth/security-policy.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6919/{{ revealButtonHref }}
apps/sim/lib/auth/security-policy.tshttps://github.com/simstudioai/sim/pull/6919/files#diff-fee93899e8f9dc7646e77b4077b358b3167461f9ce25222023709a1e2c334eed
View file https://github.com/simstudioai/sim/blob/96b91e0e3eac72e25e7fe0e5b290a938319c09e7/apps/sim/lib/auth/security-policy.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6919/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6919/files#diff-fee93899e8f9dc7646e77b4077b358b3167461f9ce25222023709a1e2c334eed
https://github.com/simstudioai/sim/pull/6919/files#diff-fee93899e8f9dc7646e77b4077b358b3167461f9ce25222023709a1e2c334eed
https://github.com/simstudioai/sim/pull/6919/files#diff-fee93899e8f9dc7646e77b4077b358b3167461f9ce25222023709a1e2c334eed
https://github.com/simstudioai/sim/pull/6919/files#diff-fee93899e8f9dc7646e77b4077b358b3167461f9ce25222023709a1e2c334eed
https://github.com/simstudioai/sim/pull/6919/files#diff-fee93899e8f9dc7646e77b4077b358b3167461f9ce25222023709a1e2c334eed
https://github.com/simstudioai/sim/pull/6919/files#diff-fee93899e8f9dc7646e77b4077b358b3167461f9ce25222023709a1e2c334eed
https://github.com/simstudioai/sim/pull/6919/files#diff-fee93899e8f9dc7646e77b4077b358b3167461f9ce25222023709a1e2c334eed
https://github.com/simstudioai/sim/pull/6919/files#diff-fee93899e8f9dc7646e77b4077b358b3167461f9ce25222023709a1e2c334eed
https://github.com/simstudioai/sim/pull/6919/files#diff-fee93899e8f9dc7646e77b4077b358b3167461f9ce25222023709a1e2c334eed
Please reload this pagehttps://github.com/simstudioai/sim/pull/6919/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6919/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.