René's URL Explorer Experiment


Title: fix(knowledge): stop billing a document once per processing attempt by waleedlatif1 · Pull Request #6911 · simstudioai/sim · GitHub

Open Graph Title: fix(knowledge): stop billing a document once per processing attempt by waleedlatif1 · Pull Request #6911 · simstudioai/sim

X Title: fix(knowledge): stop billing a document once per processing attempt by waleedlatif1 · Pull Request #6911 · simstudioai/sim

Description: recordUsage built its sourceReference as knowledge-document:{documentId}:{startTime}, where startTime is captured per attempt. That string is what usage_log hashes into its dedup eventKey, so the timestamp defeated the deduplication by construction. knowledge-process-document runs up to 3 attempts, and the connector sync's stuck-document sweep can re-dispatch on top of that — so one document could be billed four times for a single indexing pass. The key knowledge-document:{documentId}:{indexingPassId}, where indexingPassId is the dispatch requestId. That is already the codebase's own name for one indexing pass: dispatchViaBatchTrigger uses it in doc-process-{documentId}-{requestId} with a comment saying it blocks intra-dispatch retries while later syncs mint a fresh one. It is fixed across all attempts of a run and fresh on every new dispatch — exactly "same work retried" versus "new work". Two alternatives were rejected: documentId alone dedupes retries but would suppress billing for a legitimate re-index — a content change, a rehydrate, a user reprocess. usage_log has no retention (verified: no delete path anywhere; rows only disappear via the user FK cascade), so that under-bill would be permanent, not windowed. Including the token count looks like a sharper discriminator, but OCR- and LLM-backed parsing is not bit-stable across attempts, so a differing count on attempt 2 would defeat the very dedup being added. Falls back to the resolved embedding pricing id where no pass id is threaded — still collapses attempts, and still re-bills a KB whose embedding model changed. The half that would have been missed background/knowledge-processing.ts destructured requestId for logging and dropped it before calling processDocumentAsync. On the Trigger path — the only path that actually retries — the new parameter would have arrived undefined and only the weaker fallback would apply. Now threaded. The existing worker tests pin the exact argument list and caught the signature change, which is what they are for; they now assert the threaded value. Verification type-check clean · check:audits 32/32 · 659 tests across lib/knowledge and background. Mutation-checked: restoring the timestamp turns all 5 new tests red. Collapsing to documentId-only granularity turns 4 red and correctly leaves the stability test green — confirming the stability and discrimination assertions fail independently rather than keying off one condition. Dropping the threaded requestId turns both worker tests red. Swept, not changed Every other sourceReference producer in apps/sim was checked. The knowledge-search ones key on a per-HTTP-request id, which is correct — each search genuinely incurs a fresh embedding cost and searches are not retried under a shared identity. The enrichment producer is content-scoped. None carries a per-attempt value.

Open Graph Description: recordUsage built its sourceReference as knowledge-document:{documentId}:{startTime}, where startTime is captured per attempt. That string is what usage_log hashes into its dedup eventKey, so the t...

X Description: recordUsage built its sourceReference as knowledge-document:{documentId}:{startTime}, where startTime is captured per attempt. That string is what usage_log hashes into its dedup eventKey, so the t...

Opengraph URL: https://github.com/simstudioai/sim/pull/6911

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1121de51-1dc2-53e4-0721-270a91882a7a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBEE8:A82D7:2059:2ABD:6AFB63EE
html-safe-nonced55a97594fa571f65e091cadf59d3afbaf080a1e686384c2be0ddf672062417d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRUU4OkE4MkQ3OjIwNTk6MkFCRDo2QUZCNjNFRSIsInZpc2l0b3JfaWQiOiI0Mzk1ODI0OTc1NDI0NzQyMzgzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7f249b2cc759e180576481d90e94c3c47d869e3d54649ccac072f33e80dcea94
hovercard-subject-tagpull_request:4327501308
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6911/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altrecordUsage built its sourceReference as knowledge-document:{documentId}:{startTime}, where startTime is captured per attempt. That string is what usage_log hashes into its dedup eventKey, so the t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6911/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6911%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6911%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6911/files
Reloadhttps://github.com/simstudioai/sim/pull/6911/files
Reloadhttps://github.com/simstudioai/sim/pull/6911/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/sync-billinghttps://github.com/simstudioai/sim/tree/fix/sync-billing
Conversation 3 https://github.com/simstudioai/sim/pull/6911
Commits 1 https://github.com/simstudioai/sim/pull/6911/commits
Checks 30 https://github.com/simstudioai/sim/pull/6911/checks
Files changed https://github.com/simstudioai/sim/pull/6911/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6911/files
fix(knowledge): stop billing a document once per processing attempt https://github.com/simstudioai/sim/pull/6911/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6911/files
d23dd1b fix(knowledge): stop billing a document once per processing attempt waleedlatif1 Aug 20, 2026 https://github.com/simstudioai/sim/pull/6911/commits/d23dd1b7ea4ce76a6029827c2c192b37e7969314
Clear filters https://github.com/simstudioai/sim/pull/6911/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6911/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6911/files
knowledge-processing.test.ts https://github.com/simstudioai/sim/pull/6911/files#diff-aaf9905be5fe36e82320cdc33a518d0acb21ee35d54ebfc80fddcefb4ece2150
knowledge-processing.ts https://github.com/simstudioai/sim/pull/6911/files#diff-3f4102c851bc01170c71054100d270ba20a2d444e99d32cbf6450a1f0152138e
document-indexing-usage.test.ts https://github.com/simstudioai/sim/pull/6911/files#diff-ff4ae625d37edbdfb8ea953b69b76e91faa6761157ff50400a5242c5ef120577
service.ts https://github.com/simstudioai/sim/pull/6911/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
apps/sim/background/knowledge-processing.test.tshttps://github.com/simstudioai/sim/pull/6911/files#diff-aaf9905be5fe36e82320cdc33a518d0acb21ee35d54ebfc80fddcefb4ece2150
View file https://github.com/simstudioai/sim/blob/d23dd1b7ea4ce76a6029827c2c192b37e7969314/apps/sim/background/knowledge-processing.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6911/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6911/files#diff-aaf9905be5fe36e82320cdc33a518d0acb21ee35d54ebfc80fddcefb4ece2150
https://github.com/simstudioai/sim/pull/6911/files#diff-aaf9905be5fe36e82320cdc33a518d0acb21ee35d54ebfc80fddcefb4ece2150
https://github.com/simstudioai/sim/pull/6911/files#diff-aaf9905be5fe36e82320cdc33a518d0acb21ee35d54ebfc80fddcefb4ece2150
apps/sim/background/knowledge-processing.tshttps://github.com/simstudioai/sim/pull/6911/files#diff-3f4102c851bc01170c71054100d270ba20a2d444e99d32cbf6450a1f0152138e
View file https://github.com/simstudioai/sim/blob/d23dd1b7ea4ce76a6029827c2c192b37e7969314/apps/sim/background/knowledge-processing.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6911/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6911/files#diff-3f4102c851bc01170c71054100d270ba20a2d444e99d32cbf6450a1f0152138e
https://github.com/simstudioai/sim/pull/6911/files#diff-3f4102c851bc01170c71054100d270ba20a2d444e99d32cbf6450a1f0152138e
apps/sim/lib/knowledge/documents/document-indexing-usage.test.tshttps://github.com/simstudioai/sim/pull/6911/files#diff-ff4ae625d37edbdfb8ea953b69b76e91faa6761157ff50400a5242c5ef120577
View file https://github.com/simstudioai/sim/blob/d23dd1b7ea4ce76a6029827c2c192b37e7969314/apps/sim/lib/knowledge/documents/document-indexing-usage.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6911/{{ revealButtonHref }}
apps/sim/lib/knowledge/documents/service.tshttps://github.com/simstudioai/sim/pull/6911/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
View file https://github.com/simstudioai/sim/blob/d23dd1b7ea4ce76a6029827c2c192b37e7969314/apps/sim/lib/knowledge/documents/service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6911/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6911/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/6911/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/6911/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/6911/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/6911/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/6911/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/6911/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
Please reload this pagehttps://github.com/simstudioai/sim/pull/6911/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.