René's URL Explorer Experiment


Title: fix(connectors): stop rendering running and crashed syncs as successes by waleedlatif1 · Pull Request #6910 · simstudioai/sim · GitHub

Open Graph Title: fix(connectors): stop rendering running and crashed syncs as successes by waleedlatif1 · Pull Request #6910 · simstudioai/sim

X Title: fix(connectors): stop rendering running and crashed syncs as successes by waleedlatif1 · Pull Request #6910 · simstudioai/sim

Description: The sync-history row derived its state from status literals the engine never writes. 'running', 'syncing', and 'error' are connector statuses. The sync log only ever carries 'started', 'completed', or 'failed'. So the in-progress branch was false for every row that will ever exist — a live sync rendered as a green success tick for its entire duration, and a run killed mid-flight left a permanent fake success reading "No changes". The "In progress…" branch was unreachable. syncLogDataSchema.status was typed z.string(), so nothing caught the mismatch at compile time. Changes Derive the row state from the three statuses the engine actually writes. Narrow the contract to an enum, verified against the only writer first — sync-engine.ts inserts 'started' and completeSyncLog is already typed 'completed' | 'failed', so the enum cannot over-narrow and fail response validation. Make the render switch exhaustive with a never assertion. Producer drift now fails response validation; consumer drift now fails the build. Add an interrupted state for a 'started' row older than the stale-lock TTL. On the interrupted state Fixing only the predicate would have traded one false signal for another. The reaper flips the connector to error but nothing closes the sync-log row, so a killed run stays 'started' — and a permanent spinner claiming a three-week-old sync is still in flight is no more honest than a green tick. Amber "Interrupted" is the accurate third reading, derived client-side from the existing shared TTL constant with no engine change. Once #6909 lands, its reaper sweep closes those rows to 'failed', so this state becomes transient — covering the window between the crash and the next reaper pass. The two changes compose; neither depends on the other. Verification type-check clean · check:audits 32/32 including check:api-validation:strict over the contract change · 723 tests across knowledge, v2 knowledge, and the connector hooks pass unchanged · 6 new tests. All 6 mutation-checked: restoring the original bug turns 3 red; dropping the TTL branch turns 1 red; each status swap turns its own test red. None inert. Found, not touched contracts/v2/knowledge.ts has the identical z.string() drift hazard on the same field, but it is a published OpenAPI surface that gets .parse()d by the v2 route — an over-narrow enum there would 500 the endpoint. It deserves its own change and its own verification. tools/knowledge/types.ts carries a third copy of the vocabulary as a passthrough string; nothing branches on it, so no bug today.

Open Graph Description: The sync-history row derived its state from status literals the engine never writes. 'running', 'syncing', and 'error' are connector statuses. The sync log only ever carries...

X Description: The sync-history row derived its state from status literals the engine never writes. 'running', 'syncing', and 'error' are connector statuses. The sy...

Opengraph URL: https://github.com/simstudioai/sim/pull/6910

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:76a22c6d-cc69-8ad8-b006-dfc93c5beaa0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD4C:21AF89:D3A98D:12C37C2:6AFB63FE
html-safe-nonce4e61bcfad71bdf183be89e540bc76abfabd4faa8a7d85cfe93d5bd1b915f5ead
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDRDOjIxQUY4OTpEM0E5OEQ6MTJDMzdDMjo2QUZCNjNGRSIsInZpc2l0b3JfaWQiOiI3MjU5NzA3NTc5MjU5NjQyODc4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca0da43bb404e329f2d700e44bb28dfe7c15db40ef8d81ef9ac4e6bdbc3c953ee
hovercard-subject-tagpull_request:4327501168
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6910/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altThe sync-history row derived its state from status literals the engine never writes. 'running', 'syncing', and 'error' are connector statuses. The sync log only ever carries...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6910/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6910%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6910%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6910/files
Reloadhttps://github.com/simstudioai/sim/pull/6910/files
Reloadhttps://github.com/simstudioai/sim/pull/6910/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/sync-uihttps://github.com/simstudioai/sim/tree/fix/sync-ui
Conversation 8 https://github.com/simstudioai/sim/pull/6910
Commits 2 https://github.com/simstudioai/sim/pull/6910/commits
Checks 30 https://github.com/simstudioai/sim/pull/6910/checks
Files changed https://github.com/simstudioai/sim/pull/6910/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6910/files
fix(connectors): stop rendering running and crashed syncs as successes https://github.com/simstudioai/sim/pull/6910/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/6910/files
a57deef fix(connectors): stop rendering running and crashed syncs as successes waleedlatif1 Aug 20, 2026 https://github.com/simstudioai/sim/pull/6910/commits/a57deefe6ff48112bfae576b0f0262a5ee74c2c7
649d83d docs(connectors): record why the stale TTL is a hard ceiling for the … waleedlatif1 Aug 21, 2026 https://github.com/simstudioai/sim/pull/6910/commits/649d83dfd0a505ea8a80a3d8e8bbcee07419b674
Clear filters https://github.com/simstudioai/sim/pull/6910/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6910/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6910/files
connectors-section.test.tsx https://github.com/simstudioai/sim/pull/6910/files#diff-589fe7bae9fe856b0265388a8b424a759ffbad5d14b93b059441b9567a253c5b
connectors-section.tsx https://github.com/simstudioai/sim/pull/6910/files#diff-9fbc901cf4031233c1e0bfcb5393b66023e459cadee02f330dcac6bd8d1889cb
connectors.ts https://github.com/simstudioai/sim/pull/6910/files#diff-e93268a083eddbc5d4228aedad29b6f265c8b07354fe5bc04f514727b1308eb1
...ce/[workspaceId]/knowledge/[id]/components/connectors-section/connectors-section.test.tsxhttps://github.com/simstudioai/sim/pull/6910/files#diff-589fe7bae9fe856b0265388a8b424a759ffbad5d14b93b059441b9567a253c5b
View file https://github.com/simstudioai/sim/blob/649d83dfd0a505ea8a80a3d8e8bbcee07419b674/apps/sim/app/workspace/%5BworkspaceId%5D/knowledge/%5Bid%5D/components/connectors-section/connectors-section.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6910/{{ revealButtonHref }}
...rkspace/[workspaceId]/knowledge/[id]/components/connectors-section/connectors-section.tsxhttps://github.com/simstudioai/sim/pull/6910/files#diff-9fbc901cf4031233c1e0bfcb5393b66023e459cadee02f330dcac6bd8d1889cb
View file https://github.com/simstudioai/sim/blob/649d83dfd0a505ea8a80a3d8e8bbcee07419b674/apps/sim/app/workspace/%5BworkspaceId%5D/knowledge/%5Bid%5D/components/connectors-section/connectors-section.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6910/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6910/files#diff-9fbc901cf4031233c1e0bfcb5393b66023e459cadee02f330dcac6bd8d1889cb
https://github.com/simstudioai/sim/pull/6910/files#diff-9fbc901cf4031233c1e0bfcb5393b66023e459cadee02f330dcac6bd8d1889cb
https://github.com/simstudioai/sim/pull/6910/files#diff-9fbc901cf4031233c1e0bfcb5393b66023e459cadee02f330dcac6bd8d1889cb
Please reload this pagehttps://github.com/simstudioai/sim/pull/6910/files
https://github.com/simstudioai/sim/pull/6910/files#diff-9fbc901cf4031233c1e0bfcb5393b66023e459cadee02f330dcac6bd8d1889cb
https://github.com/simstudioai/sim/pull/6910/files#diff-9fbc901cf4031233c1e0bfcb5393b66023e459cadee02f330dcac6bd8d1889cb
https://github.com/simstudioai/sim/pull/6910/files#diff-9fbc901cf4031233c1e0bfcb5393b66023e459cadee02f330dcac6bd8d1889cb
https://github.com/simstudioai/sim/pull/6910/files#diff-9fbc901cf4031233c1e0bfcb5393b66023e459cadee02f330dcac6bd8d1889cb
https://github.com/simstudioai/sim/pull/6910/files#diff-9fbc901cf4031233c1e0bfcb5393b66023e459cadee02f330dcac6bd8d1889cb
apps/sim/lib/api/contracts/knowledge/connectors.tshttps://github.com/simstudioai/sim/pull/6910/files#diff-e93268a083eddbc5d4228aedad29b6f265c8b07354fe5bc04f514727b1308eb1
View file https://github.com/simstudioai/sim/blob/649d83dfd0a505ea8a80a3d8e8bbcee07419b674/apps/sim/lib/api/contracts/knowledge/connectors.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6910/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6910/files#diff-e93268a083eddbc5d4228aedad29b6f265c8b07354fe5bc04f514727b1308eb1
https://github.com/simstudioai/sim/pull/6910/files#diff-e93268a083eddbc5d4228aedad29b6f265c8b07354fe5bc04f514727b1308eb1
Please reload this pagehttps://github.com/simstudioai/sim/pull/6910/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.