Title: fix(connectors): stop rendering running and crashed syncs as successes by waleedlatif1 · Pull Request #6910 · simstudioai/sim · GitHub
Open Graph Title: fix(connectors): stop rendering running and crashed syncs as successes by waleedlatif1 · Pull Request #6910 · simstudioai/sim
X Title: fix(connectors): stop rendering running and crashed syncs as successes by waleedlatif1 · Pull Request #6910 · simstudioai/sim
Description: The sync-history row derived its state from status literals the engine never writes. 'running', 'syncing', and 'error' are connector statuses. The sync log only ever carries 'started', 'completed', or 'failed'. So the in-progress branch was false for every row that will ever exist — a live sync rendered as a green success tick for its entire duration, and a run killed mid-flight left a permanent fake success reading "No changes". The "In progress…" branch was unreachable. syncLogDataSchema.status was typed z.string(), so nothing caught the mismatch at compile time. Changes Derive the row state from the three statuses the engine actually writes. Narrow the contract to an enum, verified against the only writer first — sync-engine.ts inserts 'started' and completeSyncLog is already typed 'completed' | 'failed', so the enum cannot over-narrow and fail response validation. Make the render switch exhaustive with a never assertion. Producer drift now fails response validation; consumer drift now fails the build. Add an interrupted state for a 'started' row older than the stale-lock TTL. On the interrupted state Fixing only the predicate would have traded one false signal for another. The reaper flips the connector to error but nothing closes the sync-log row, so a killed run stays 'started' — and a permanent spinner claiming a three-week-old sync is still in flight is no more honest than a green tick. Amber "Interrupted" is the accurate third reading, derived client-side from the existing shared TTL constant with no engine change. Once #6909 lands, its reaper sweep closes those rows to 'failed', so this state becomes transient — covering the window between the crash and the next reaper pass. The two changes compose; neither depends on the other. Verification type-check clean · check:audits 32/32 including check:api-validation:strict over the contract change · 723 tests across knowledge, v2 knowledge, and the connector hooks pass unchanged · 6 new tests. All 6 mutation-checked: restoring the original bug turns 3 red; dropping the TTL branch turns 1 red; each status swap turns its own test red. None inert. Found, not touched contracts/v2/knowledge.ts has the identical z.string() drift hazard on the same field, but it is a published OpenAPI surface that gets .parse()d by the v2 route — an over-narrow enum there would 500 the endpoint. It deserves its own change and its own verification. tools/knowledge/types.ts carries a third copy of the vocabulary as a passthrough string; nothing branches on it, so no bug today.
Open Graph Description: The sync-history row derived its state from status literals the engine never writes. 'running', 'syncing', and 'error' are connector statuses. The sync log only ever carries...
X Description: The sync-history row derived its state from status literals the engine never writes. 'running', 'syncing', and 'error' are connector statuses. The sy...
Opengraph URL: https://github.com/simstudioai/sim/pull/6910
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:76a22c6d-cc69-8ad8-b006-dfc93c5beaa0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CD4C:21AF89:D3A98D:12C37C2:6AFB63FE |
| html-safe-nonce | 4e61bcfad71bdf183be89e540bc76abfabd4faa8a7d85cfe93d5bd1b915f5ead |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDRDOjIxQUY4OTpEM0E5OEQ6MTJDMzdDMjo2QUZCNjNGRSIsInZpc2l0b3JfaWQiOiI3MjU5NzA3NTc5MjU5NjQyODc4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a0da43bb404e329f2d700e44bb28dfe7c15db40ef8d81ef9ac4e6bdbc3c953ee |
| hovercard-subject-tag | pull_request:4327501168 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6910/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | The sync-history row derived its state from status literals the engine never writes. 'running', 'syncing', and 'error' are connector statuses. The sync log only ever carries... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | ea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ef97164c52cf59bd10558ddec9c4f482763988 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width