René's URL Explorer Experiment


Title: refactor(search): one definition of what a search occurrence is by icecrasher321 · Pull Request #6905 · simstudioai/sim · GitHub

Open Graph Title: refactor(search): one definition of what a search occurrence is by icecrasher321 · Pull Request #6905 · simstudioai/sim

X Title: refactor(search): one definition of what a search occurrence is by icecrasher321 · Pull Request #6905 · simstudioai/sim

Description: Follow-up to #6901. Two places where the workflow search index and the Note card that mirrors it could drift apart. Neither is a live bug — both are the shape that produced one during that PR's review, where the card silently disagreed with the panel about which hit was which. 1. The scan was duplicated #6901 shared foldSearchWhitespace but left the loop around it written out twice — normalize, then non-overlapping indexOf stepping by max(len, 1) — once in findTextRanges and once in the renderer package. They agree today. They stop agreeing the moment either grows whole-word matching, diacritic folding, or a regex mode, and the failure mode is silent: the panel counts a hit the card marks somewhere else. That is exactly the bug Bugbot caught in #6901, in its whitespace-folding form; sharing only the fold fixed the instance and left the mechanism. Both now call one forEachSearchOccurrence in @sim/utils/string. That is the only place they can share it: the card renders from @sim/workflow-renderer, and packages cannot import from apps/*. 2. The markdown declaration was unpinned The indexer projects markdown escapes only when a field declares searchTextFormat: 'markdown'. The card projects unconditionally — it has no access to the block registry. Removing that one line from the Note config would leave the two disagreeing about what an occurrence is, with nothing to catch it. A test now pins the declaration and explains the coupling. Verified it fails when the line is removed. Notes for review Net −2 lines. This deletes a duplicated loop; it does not add a layer. forEachNoteSearchOccurrence is gone from the renderer package — it was a wrapper around the duplicate. Callers use the shared primitive directly. Case sensitivity stays where it was: the shared scanner takes the flag, the indexer passes it, the card does not (the search panel is the only caller and never enables it). Now that the algorithm is in one place, anyone plumbing it through will see both callers at once rather than having to know a second copy exists. Testing @sim/utils 160, @sim/workflow-renderer 104, apps/sim search-replace + panel 132 — all pass. Both type-checks, check:api-validation, monorepo boundaries and biome clean. The new parity test was checked for vacuousness: deleting searchTextFormat from blocks/blocks/note.ts makes it fail. 🤖 Generated with Claude Code

Open Graph Description: Follow-up to #6901. Two places where the workflow search index and the Note card that mirrors it could drift apart. Neither is a live bug — both are the shape that produced one during that PR's...

X Description: Follow-up to #6901. Two places where the workflow search index and the Note card that mirrors it could drift apart. Neither is a live bug — both are the shape that produced one during that PR&#...

Opengraph URL: https://github.com/simstudioai/sim/pull/6905

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:20de9ede-6f23-3e75-1b6b-a2c4e892bc81
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id95B4:71C2F:F927DF:155F0A6:6AFB6400
html-safe-nonce0bd3645587ad4a7bd1510cfd9e13b0b92af080fea47a48bf8bbe97e5f00c439c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NUI0OjcxQzJGOkY5MjdERjoxNTVGMEE2OjZBRkI2NDAwIiwidmlzaXRvcl9pZCI6IjY2NjE0MDM0MjY0NDc2NDc3NDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5397da28485213caf27076be567240f12c9064a66ac23130004500b3a0912b6f
hovercard-subject-tagpull_request:4327109267
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6905/files
twitter:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
og:image:altFollow-up to #6901. Two places where the workflow search index and the Note card that mirrors it could drift apart. Neither is a live bug — both are the shape that produced one during that PR's...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6905/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6905%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6905%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6905/files
Reloadhttps://github.com/simstudioai/sim/pull/6905/files
Reloadhttps://github.com/simstudioai/sim/pull/6905/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
icecrasher321https://github.com/icecrasher321
staginghttps://github.com/simstudioai/sim/tree/staging
fix/search-occurrence-parityhttps://github.com/simstudioai/sim/tree/fix/search-occurrence-parity
Conversation 3 https://github.com/simstudioai/sim/pull/6905
Commits 1 https://github.com/simstudioai/sim/pull/6905/commits
Checks 30 https://github.com/simstudioai/sim/pull/6905/checks
Files changed https://github.com/simstudioai/sim/pull/6905/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6905/files
refactor(search): one definition of what a search occurrence is https://github.com/simstudioai/sim/pull/6905/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6905/files
44fe5f4 refactor(search): one definition of what a search occurrence is Aug 20, 2026 https://github.com/simstudioai/sim/pull/6905/commits/44fe5f45b8728feb6019ba10818b6a9f333369db
Clear filters https://github.com/simstudioai/sim/pull/6905/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6905/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6905/files
indexer.test.ts https://github.com/simstudioai/sim/pull/6905/files#diff-5ffc04e0dbdd5ef8efa2d91372c71ecf297365c14b31b2c22b9253bc395b6615
indexer.ts https://github.com/simstudioai/sim/pull/6905/files#diff-8d4f1d87c5bf2fd16d5cfcd0fc5f42322e04a9e5fca83f9fbb9938bda006769e
string.ts https://github.com/simstudioai/sim/pull/6905/files#diff-9b50bdcf9d922aa7d14b9be1a170a437df47378c6ee3576efaaedcdf7389f503
note-search-highlight.test.tsx https://github.com/simstudioai/sim/pull/6905/files#diff-83a508ffac3f5f939d01417f40f11821c387030530383040480e5b8a758f4c88
note-search-highlight.ts https://github.com/simstudioai/sim/pull/6905/files#diff-7b3739ed355e58277041bae3440739ea6e388677bb853042a6cb8971ae62913c
apps/sim/lib/workflows/search-replace/indexer.test.tshttps://github.com/simstudioai/sim/pull/6905/files#diff-5ffc04e0dbdd5ef8efa2d91372c71ecf297365c14b31b2c22b9253bc395b6615
View file https://github.com/simstudioai/sim/blob/44fe5f45b8728feb6019ba10818b6a9f333369db/apps/sim/lib/workflows/search-replace/indexer.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6905/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6905/files#diff-5ffc04e0dbdd5ef8efa2d91372c71ecf297365c14b31b2c22b9253bc395b6615
https://github.com/simstudioai/sim/pull/6905/files#diff-5ffc04e0dbdd5ef8efa2d91372c71ecf297365c14b31b2c22b9253bc395b6615
https://github.com/simstudioai/sim/pull/6905/files#diff-5ffc04e0dbdd5ef8efa2d91372c71ecf297365c14b31b2c22b9253bc395b6615
https://github.com/simstudioai/sim/pull/6905/files#diff-5ffc04e0dbdd5ef8efa2d91372c71ecf297365c14b31b2c22b9253bc395b6615
apps/sim/lib/workflows/search-replace/indexer.tshttps://github.com/simstudioai/sim/pull/6905/files#diff-8d4f1d87c5bf2fd16d5cfcd0fc5f42322e04a9e5fca83f9fbb9938bda006769e
View file https://github.com/simstudioai/sim/blob/44fe5f45b8728feb6019ba10818b6a9f333369db/apps/sim/lib/workflows/search-replace/indexer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6905/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6905/files#diff-8d4f1d87c5bf2fd16d5cfcd0fc5f42322e04a9e5fca83f9fbb9938bda006769e
https://github.com/simstudioai/sim/pull/6905/files#diff-8d4f1d87c5bf2fd16d5cfcd0fc5f42322e04a9e5fca83f9fbb9938bda006769e
https://github.com/simstudioai/sim/pull/6905/files#diff-8d4f1d87c5bf2fd16d5cfcd0fc5f42322e04a9e5fca83f9fbb9938bda006769e
https://github.com/simstudioai/sim/pull/6905/files#diff-8d4f1d87c5bf2fd16d5cfcd0fc5f42322e04a9e5fca83f9fbb9938bda006769e
packages/utils/src/string.tshttps://github.com/simstudioai/sim/pull/6905/files#diff-9b50bdcf9d922aa7d14b9be1a170a437df47378c6ee3576efaaedcdf7389f503
View file https://github.com/simstudioai/sim/blob/44fe5f45b8728feb6019ba10818b6a9f333369db/packages/utils/src/string.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6905/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6905/files#diff-9b50bdcf9d922aa7d14b9be1a170a437df47378c6ee3576efaaedcdf7389f503
https://github.com/simstudioai/sim/pull/6905/files#diff-9b50bdcf9d922aa7d14b9be1a170a437df47378c6ee3576efaaedcdf7389f503
packages/workflow-renderer/src/note/note-search-highlight.test.tsxhttps://github.com/simstudioai/sim/pull/6905/files#diff-83a508ffac3f5f939d01417f40f11821c387030530383040480e5b8a758f4c88
View file https://github.com/simstudioai/sim/blob/44fe5f45b8728feb6019ba10818b6a9f333369db/packages/workflow-renderer/src/note/note-search-highlight.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6905/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6905/files#diff-83a508ffac3f5f939d01417f40f11821c387030530383040480e5b8a758f4c88
https://github.com/simstudioai/sim/pull/6905/files#diff-83a508ffac3f5f939d01417f40f11821c387030530383040480e5b8a758f4c88
https://github.com/simstudioai/sim/pull/6905/files#diff-83a508ffac3f5f939d01417f40f11821c387030530383040480e5b8a758f4c88
https://github.com/simstudioai/sim/pull/6905/files#diff-83a508ffac3f5f939d01417f40f11821c387030530383040480e5b8a758f4c88
https://github.com/simstudioai/sim/pull/6905/files#diff-83a508ffac3f5f939d01417f40f11821c387030530383040480e5b8a758f4c88
packages/workflow-renderer/src/note/note-search-highlight.tshttps://github.com/simstudioai/sim/pull/6905/files#diff-7b3739ed355e58277041bae3440739ea6e388677bb853042a6cb8971ae62913c
View file https://github.com/simstudioai/sim/blob/44fe5f45b8728feb6019ba10818b6a9f333369db/packages/workflow-renderer/src/note/note-search-highlight.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6905/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6905/files#diff-7b3739ed355e58277041bae3440739ea6e388677bb853042a6cb8971ae62913c
https://github.com/simstudioai/sim/pull/6905/files#diff-7b3739ed355e58277041bae3440739ea6e388677bb853042a6cb8971ae62913c
https://github.com/simstudioai/sim/pull/6905/files#diff-7b3739ed355e58277041bae3440739ea6e388677bb853042a6cb8971ae62913c
https://github.com/simstudioai/sim/pull/6905/files#diff-7b3739ed355e58277041bae3440739ea6e388677bb853042a6cb8971ae62913c
https://github.com/simstudioai/sim/pull/6905/files#diff-7b3739ed355e58277041bae3440739ea6e388677bb853042a6cb8971ae62913c
https://github.com/simstudioai/sim/pull/6905/files#diff-7b3739ed355e58277041bae3440739ea6e388677bb853042a6cb8971ae62913c
Please reload this pagehttps://github.com/simstudioai/sim/pull/6905/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.