René's URL Explorer Experiment


Title: fix(webhooks): accept the methods and expose the request metadata the generic webhook advertises by waleedlatif1 · Pull Request #6893 · simstudioai/sim · GitHub

Open Graph Title: fix(webhooks): accept the methods and expose the request metadata the generic webhook advertises by waleedlatif1 · Pull Request #6893 · simstudioai/sim

X Title: fix(webhooks): accept the methods and expose the request metadata the generic webhook advertises by waleedlatif1 · Pull Request #6893 · simstudioai/sim

Description: Supersedes #6889, whose four commits this branch contains unchanged and unsquashed — the feature is @minijeong-log's work and their authorship is preserved in git history. Please credit that PR when merging. Fixes #6888. The bug Open a Webhook Trigger today and the Setup Instructions make three claims. All three are false: The panel says What happens "will receive any HTTP method (GET, POST, PUT, DELETE, etc.)" Only POST. Everything else gets 405. "All request data (headers, body, query parameters) will be available" Only the body. formatInput is return { input: body } — headers and query parameters are read off the request and discarded. "include the token using either the custom header or Authorization: Bearer" Not either. Set a Secret Header Name and verifyTokenAuth returns early; Bearer never works. So a service calling .../trigger/abc?orderId=123 with X-Event-Name: created reaches a workflow that can see neither value, and no way exists to get them. You reference query.orderId because the panel said the data was there, get nothing, and have no indication why. What this does Makes the panel true, as an opt-in. query is exposed unconditionally — it is dropped today, it only appears when the caller's own URL carries parameters, and a body field of the same name still wins. That is the reported bug and it needs no toggle. Everything else is a per-webhook flag, off by default: Switch providerConfig flag Effect Accept Other HTTP Methods acceptOtherMethods Accept GET, PUT, PATCH, DELETE; expose method Expose Request Headers exposeRequestHeaders Expose headers, minus credential-bearing ones extraDeliveryMethods declares the methods and the flag that unlocks them, so acceptsWebhookDeliveryMethod requires both. A provider-level capability alone would have changed behavior for every generic webhook already deployed — accepting GET on URLs that answered 405 yesterday, and writing every inbound header into execution logs on POST deliveries that never asked for it. method rides the methods flag rather than getting its own: until a webhook accepts more than POST it is the constant "POST", so emitting it would change every existing payload to say nothing. Trigger outputs are condition-gated on their switches, so the reference dropdown cannot offer a field the running webhook will not send. Two cross-provider bugs fixed along the way Challenge handlers run before the webhook lookup and match on payload shape alone, so one that answers on a method its provider never uses will intercept a delivery addressed to whoever owns the path. Today a GET ?validationToken=abc to any webhook path echoes abc back with a 200. handleProviderChallenges now gates every handler to POST by default via challengeMethods. WhatsApp widens it to GET — Meta sends the verification handshake that way — so the one real exception is stated in the type rather than implied by the absence of a guard. Separately, WhatsApp answered 403 for hub.* parameters on a path with no WhatsApp webhook expecting a token. Those parameters belong to whoever owns the path; it now falls through. Security The credential-header denylist covers 24 names (authorization, apikey, x-functions-key, x-access-token, x-amz-security-token, x-goog-api-key, …). Because a denylist is leaky by construction it is not the only defense: the webhook's own token is withheld by value as well as by name, catching a sender that repeats it under a header nobody anticipated. Value matching applies only above 8 characters so a short token cannot strip unrelated headers. And the whole feature is off unless the owner turns it on. Note that authentication is header-based, so it cannot be used with a plain link — the "trigger from a URL in an email" case requires disabling auth. The instructions now say so outright instead of leaving users to discover it after publishing an open trigger URL. Compatibility No migration. The gate is the absence of a database key: every generic webhook written before this exists has neither flag, undefined reads as off, and the old behavior is what the new code produces when it finds nothing. POST responses: unchanged (acceptsWebhookDeliveryMethod returns true for POST before reading anything). POST workflow input: body + query. method and headers are absent without flags. PUT/PATCH/DELETE: previously unrouted, so Next returned 405; without the flag they return 405. GET: verified branch by branch against staging — unknown path, un-flagged generic webhook, POST-only provider, non-path trigger and pending setup verification all answer exactly as they do today. Queued jobs: payload.query/method are optional and defaulted on read, and the payload has no runtime schema, so a new payload on an old worker during a rolling deploy is inert. Three things do change, all intentional, two of them the bug fixes: query appears when the caller's URL has parameters. GET ?validationToken=abc stops echoing (Graph sends validation as POST; unaffected). WhatsApp hub.* on a path with no WhatsApp webhook returns 405 instead of 403. Also PUT/PATCH/DELETE get their own contracts instead of reusing webhookTriggerPostContract, whose method: 'POST' had become untrue. A GET delivery generated two different request IDs and parsed and challenged twice; one entry point now does each once. Every non-POST rejection answers the same 405 with Allow: POST, whether the path is unknown, holds only non-path triggers, or holds a trigger that has not opted in — so a probe cannot tell them apart. Object.hasOwn replaces key in body, so an inherited property name no longer reads as a collision and swallows the metadata. Flags read through isProviderConfigFlagEnabled, which treats only true/'true' as on: the editor writes booleans, but a YAML- or Copilot-authored workflow can write the string 'false', which is truthy and would ship the inverse of the setting the user sees. The metadata-drop logs are debug, not warn — each fires once per delivery for a webhook whose shape simply is that way. Testing vitest run lib/webhooks triggers app/api/webhooks → 823 passed / 66 files. Full apps/sim suite → 28,616 passed, one unrelated pre-existing flake (lib/auth/sso-trust.test.ts, a 10s import timeout that fails at a similar rate on staging — 1 in 4 there, 1 in 3 here). bun run type-check clean, bun run check:audits 32/32, real next build completes. Every guard was mutation-tested — reverted individually, confirmed red, restored: Guard broken Tests that fail Per-webhook opt-in flag ignored 2 Header exposure gate removed 4 Method exposure gate removed 30 Challenge method gate removed 5 Token value-withholding removed 2 Boolean(value) flag coercion 1 404/405 uniformity removed 1 Pre-lookup handshake order inverted 2 That last row exists because an earlier revision of this branch did invert it, and it passed all 820 tests at the time — nothing asserted where the challenge offer sat relative to the load-shed gate or the verification probe. Cursor Bugbot caught the half I had missed: behind tryAdmit, a busy instance answers 429 to Meta's WhatsApp handshake and the webhook silently fails to verify at setup time. Not verified: nobody has sent a real HTTP request at a running instance on this branch. Worth a manual pass before this reaches production.

Open Graph Description: Supersedes #6889, whose four commits this branch contains unchanged and unsquashed — the feature is @minijeong-log's work and their authorship is preserved in git history. Please credit that PR...

X Description: Supersedes #6889, whose four commits this branch contains unchanged and unsquashed — the feature is @minijeong-log's work and their authorship is preserved in git history. Please credit tha...

Opengraph URL: https://github.com/simstudioai/sim/pull/6893

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7ba98340-221e-c752-8276-4f318055da5b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9CCC:24084C:2842:3531:6AFB63E8
html-safe-noncebc4045e23ccefa8a7953fe65d95d681af76a2b52e514336cbdbaa1ba496b99c8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0NDOjI0MDg0QzoyODQyOjM1MzE6NkFGQjYzRTgiLCJ2aXNpdG9yX2lkIjoiODY2MTcxNzQwODcxMDA5MTc1MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8940c7a196b793bd408cc84d258da47452d8180d60c10e841b605fe6d3bf56ea
hovercard-subject-tagpull_request:4325442271
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6893/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSupersedes #6889, whose four commits this branch contains unchanged and unsquashed — the feature is @minijeong-log's work and their authorship is preserved in git history. Please credit that PR...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6893/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6893%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6893%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6893/files
Reloadhttps://github.com/simstudioai/sim/pull/6893/files
Reloadhttps://github.com/simstudioai/sim/pull/6893/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/generic-webhook-metadata-opt-inhttps://github.com/simstudioai/sim/tree/fix/generic-webhook-metadata-opt-in
Conversation 7 https://github.com/simstudioai/sim/pull/6893
Commits 6 https://github.com/simstudioai/sim/pull/6893/commits
Checks 28 https://github.com/simstudioai/sim/pull/6893/checks
Files changed https://github.com/simstudioai/sim/pull/6893/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6893/files
fix(webhooks): accept the methods and expose the request metadata the generic webhook advertises https://github.com/simstudioai/sim/pull/6893/files#top
Show all changes 6 commits https://github.com/simstudioai/sim/pull/6893/files
517b590 feat(webhooks): support query parameters and GET deliveries on generi… minijeong-log Aug 19, 2026 https://github.com/simstudioai/sim/pull/6893/commits/517b5904db280a3fd9cf072047fb14e65990b6ba
00eb922 feat(webhooks): expose generic webhook request headers minijeong-log Aug 20, 2026 https://github.com/simstudioai/sim/pull/6893/commits/00eb9228e3fa87842b6d2d36a0e435cd320bb6e9
e3d1c74 feat(webhooks): accept PUT, PATCH and DELETE deliveries and expose th… minijeong-log Aug 20, 2026 https://github.com/simstudioai/sim/pull/6893/commits/e3d1c7446b8218e9cc5ae8c8845c2bddc115cc89
6914b8e feat(webhooks): declare the generic webhook trigger outputs minijeong-log Aug 20, 2026 https://github.com/simstudioai/sim/pull/6893/commits/6914b8ee64a977c684a9f51b45e385927afd1d24
ab13e20 fix(webhooks): stop provider challenges from intercepting other provi… minijeong-log Aug 20, 2026 https://github.com/simstudioai/sim/pull/6893/commits/ab13e20fce02e87a9cb988b5e0a4d8660e9435d0
6d00f10 fix(webhooks): make the request metadata opt-in per webhook waleedlatif1 Aug 20, 2026 https://github.com/simstudioai/sim/pull/6893/commits/6d00f10503267d58b5f803e26a632536a36d8169
Clear filters https://github.com/simstudioai/sim/pull/6893/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6893/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6893/files
route.test.ts https://github.com/simstudioai/sim/pull/6893/files#diff-e64f716a2d8bbb31fbf091f72c7d92fd1465ce94316d45f763d193257b4a45f2
route.ts https://github.com/simstudioai/sim/pull/6893/files#diff-3bd4eef0ad51030b1d68ee20db814255683ff6b47007a80d8592ff70cdb2a5da
webhook-execution.ts https://github.com/simstudioai/sim/pull/6893/files#diff-d3c199a17069fce702da388ec4cd1b4efc793e0a5968072a181280db5aafdbb1
webhooks.ts https://github.com/simstudioai/sim/pull/6893/files#diff-85a769472781e1337ee35f1d71242aee81da3073fb5dced3f1813ef425ddb29d
processor.test.ts https://github.com/simstudioai/sim/pull/6893/files#diff-ba6e1a44cdb94ccfcc4f6c6c96e2f28ad8e08f49903062d74f913a57f657ab94
processor.ts https://github.com/simstudioai/sim/pull/6893/files#diff-d1f09ac3bd1aabe69708139bcf5137c047ada2dc058c916925187e924c12de4c
generic.test.ts https://github.com/simstudioai/sim/pull/6893/files#diff-be4901deef08095a22abff3e55fec9e8366e5ad4932ab44fe8542aefad822810
generic.ts https://github.com/simstudioai/sim/pull/6893/files#diff-e017c16b8399d29e3c4cace0fd5ab819d277c5d320afc1bd20f5c81f5d64efc1
index.ts https://github.com/simstudioai/sim/pull/6893/files#diff-9bfb606f5b174dc4141ec70b767ebf2bbb8eb39695841c86eb66db237f8a5aec
microsoft-teams.test.ts https://github.com/simstudioai/sim/pull/6893/files#diff-34119a3fcf36697d112c96a6a71b81d3eaf27c46f58c0a08f901300032330ae4
types.ts https://github.com/simstudioai/sim/pull/6893/files#diff-e76b638e3f0830dde71e2304e01806f7472280e67a9d38f2a7746320b1837b77
utils.ts https://github.com/simstudioai/sim/pull/6893/files#diff-9cefa4cb90fb0c00a1a429b04d14ebcf4410483c11f12c6935c1b97e56cdeb9a
whatsapp.test.ts https://github.com/simstudioai/sim/pull/6893/files#diff-a3cbf515d0f0835d691fb662e0de446f48fb2389734f4d2fa6251a5e022c23b6
whatsapp.ts https://github.com/simstudioai/sim/pull/6893/files#diff-82908a339dbf933a7dff84e9361c715ab22e1bd81f880fd383f041b00818f991
webhook.test.ts https://github.com/simstudioai/sim/pull/6893/files#diff-f26e39791a0aab20048204fde95d0884e689be722d1cf20cd3d0d5b932343f18
webhook.ts https://github.com/simstudioai/sim/pull/6893/files#diff-8a5d4e2e2ca71de263e3df44261dabd2d39a077dd40623178f451e82db3d471b
apps/sim/app/api/webhooks/trigger/[path]/route.test.tshttps://github.com/simstudioai/sim/pull/6893/files#diff-e64f716a2d8bbb31fbf091f72c7d92fd1465ce94316d45f763d193257b4a45f2
View file https://github.com/simstudioai/sim/blob/6d00f10503267d58b5f803e26a632536a36d8169/apps/sim/app/api/webhooks/trigger/%5Bpath%5D/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6893/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6893/files#diff-e64f716a2d8bbb31fbf091f72c7d92fd1465ce94316d45f763d193257b4a45f2
https://github.com/simstudioai/sim/pull/6893/files#diff-e64f716a2d8bbb31fbf091f72c7d92fd1465ce94316d45f763d193257b4a45f2
https://github.com/simstudioai/sim/pull/6893/files#diff-e64f716a2d8bbb31fbf091f72c7d92fd1465ce94316d45f763d193257b4a45f2
https://github.com/simstudioai/sim/pull/6893/files#diff-e64f716a2d8bbb31fbf091f72c7d92fd1465ce94316d45f763d193257b4a45f2
Please reload this pagehttps://github.com/simstudioai/sim/pull/6893/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6893/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.