Title: fix(workspace-forking): keep a repointed custom block's inputs configurable after the mapping is saved by icecrasher321 · Pull Request #6877 · simstudioai/sim · GitHub
Open Graph Title: fix(workspace-forking): keep a repointed custom block's inputs configurable after the mapping is saved by icecrasher321 · Pull Request #6877 · simstudioai/sim
X Title: fix(workspace-forking): keep a repointed custom block's inputs configurable after the mapping is saved by icecrasher321 · Pull Request #6877 · simstudioai/sim
Description: Summary Mapping a custom block to a different block and syncing showed "no changes required" with no fields to fill — so the target-input configuration added in #6871 was unreachable on every sync after the one where the mapping was picked. parentChanged comes from shouldReconfigureEntry, which asks whether the target was edited in this session. Saving the mapping makes it false, and isDependentConfigurationActionable then keeps only fields that are both required and empty — so an optional input vanished entirely, and a filled required one never came back. That test is correct for every other kind: an unchanged credential or table mapping leaves its stored dependent picks valid, and a Gmail label picked under the same credential still resolves. A custom block has no such continuity. Its sub-blocks are keyed by the SOURCE block's Start field ids, so under a different target they describe fields that do not exist and nothing carries over. The mapping standing is the reason to configure it, regardless of when it was made. So: a custom block mapped to a different block is always actionable. Mapped to itself — "keep the same block across environments" — it is not, since its own field ids still describe it. An in-session re-pick still wins over the saved target. Type of Change Bug fix Testing turbo run type-check (24/24), check:api-validation, biome clean. 644 fork tests green, 5 new. shouldReconfigureEntry is now exported and directly covered — it is the one predicate the inline render, the Sync gate, and the payload build all share (its own docstring says so), so it is the right place to pin this rather than asserting through the rendered tree. Cases: settled non-custom-block mapping, saved custom-block mapping to a different block, identity mapping, in-session re-pick overriding the saved target, and unmapped. Reviewers should focus on whether "always actionable while pointed elsewhere" is the right rule, versus something narrower like "actionable until every required field has a stored value". I went with the broader rule because a custom block's optional inputs are just as unreachable under the old behavior, and there is no stored state that makes them safe to hide. 🤖 Generated with Claude Code
Open Graph Description: Summary Mapping a custom block to a different block and syncing showed "no changes required" with no fields to fill — so the target-input configuration added in #6871 was unreachable on e...
X Description: Summary Mapping a custom block to a different block and syncing showed "no changes required" with no fields to fill — so the target-input configuration added in #6871 was unreacha...
Opengraph URL: https://github.com/simstudioai/sim/pull/6877
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:6bbaa336-a5c3-b5f2-200a-c83c063a62f1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 87AC:14B945:D7248F:1284960:6AFB5D84 |
| html-safe-nonce | b5a236ecd1a5bb03c6c1945ff8c4e815ecc5bdc55ea17cc4ff09cfdea11790fc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4N0FDOjE0Qjk0NTpENzI0OEY6MTI4NDk2MDo2QUZCNUQ4NCIsInZpc2l0b3JfaWQiOiI4NDgzNzQyNzYwMDU2ODcyMzI0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ca2ae4e4f691f5d24140bbadc12fd285c6e9cc7a55456b27d8baf87f41780826 |
| hovercard-subject-tag | pull_request:4318636651 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6877/files |
| twitter:image | https://avatars.githubusercontent.com/u/17950982?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/17950982?s=400&v=4 |
| og:image:alt | Summary Mapping a custom block to a different block and syncing showed "no changes required" with no fields to fill — so the target-input configuration added in #6871 was unreachable on e... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | ea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ef97164c52cf59bd10558ddec9c4f482763988 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width