René's URL Explorer Experiment


Title: fix(knowledge): stop retrying an embedding key with no credit left by waleedlatif1 · Pull Request #6868 · simstudioai/sim · GitHub

Open Graph Title: fix(knowledge): stop retrying an embedding key with no credit left by waleedlatif1 · Pull Request #6868 · simstudioai/sim

X Title: fix(knowledge): stop retrying an embedding key with no credit left by waleedlatif1 · Pull Request #6868 · simstudioai/sim

Description: Problem A connector sync ran the full hour and hit MAX_DURATION_EXCEEDED. The cause is not rate limiting. OpenAI answers an exhausted balance with 429, the same status as a rate limit: { "error": { "message": "You have no credits remaining. Add credits to continue using the API at ...", "type": "insufficient_quota", "code": "credit_balance_exhausted" } } isTransientEmbeddingError classified every 429 as transient, so these were retried like a rate limit. But a rate limit reopens and a spent account does not — no amount of waiting can make the next attempt succeed. That alone would be wasted work. What makes it persistent is the interaction with the stuck-document sweep: a failed document is re-queued on every sync, so each one burns its full retry budget again, forever. An account with no credit stops being a one-off failure and becomes permanent load, which is what consumed the hour. Measured in production before this change: Documents failed on insufficient_quota 2,286 across 2 knowledge bases Continuously retrying since 2026-07-27 (three weeks) Embedding failures from a genuine rate limit 0 Every terminal embedding 429 in production is an exhausted balance. Not one is a rate limit. Change The rejection body is what distinguishes them, so it is read when the error is constructed and recorded on the error. Retries against a spent key stop immediately. Retrying and failing over are decided separately, and that distinction is the point: Retry asks whether another attempt against the same provider could work. An exhausted balance rules that out. Failover asks whether a different provider could work. An exhausted balance says nothing about the next key in the chain. So the error stops the retries while remaining eligible for failover, rather than being reclassified as fatal. Why this matters for what just shipped The retry budget was widened in the previous PR (5 retries, 30s ceiling). That is correct for a real rate limit, but against a spent account it would have made this worse — 6 attempts per document instead of 4. The regression test reproduces exactly that: it fails at 6 attempts without this change and passes at 1. Verification 632 tests pass; 29/29 audits; type-check clean Three tests, each verified to fail without the change: the quota case stops at one attempt; a rate_limit_exceeded body with the same status still retries and recovers; an exhausted-balance error stays eligible for failover Note The underlying account still has no credit — this stops us from burning an hour per sync discovering that, and surfaces the provider's own actionable message ("add credits at ...") instead of retrying past it. The sweep re-queueing failed documents with no cooldown remains open and is the next thing worth fixing.

Open Graph Description: Problem A connector sync ran the full hour and hit MAX_DURATION_EXCEEDED. The cause is not rate limiting. OpenAI answers an exhausted balance with 429, the same status as a rate limit: { "erro...

X Description: Problem A connector sync ran the full hour and hit MAX_DURATION_EXCEEDED. The cause is not rate limiting. OpenAI answers an exhausted balance with 429, the same status as a rate limit: { "...

Opengraph URL: https://github.com/simstudioai/sim/pull/6868

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8ae83592-67bd-d1cd-d35c-07a56883c3e0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD38C:277BD5:1549DC1:1D174D8:6AFB783D
html-safe-noncead16a87342747dc35f3d25ccec79cb2ec0ad45762825206180fafa792dbc1573
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzhDOjI3N0JENToxNTQ5REMxOjFEMTc0RDg6NkFGQjc4M0QiLCJ2aXNpdG9yX2lkIjoiMzIyMDI2OTIxNjUwNjI3OTk5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac77ba86971453dc1f0b51248a3b792b38cce095c1917860351cc75c9470f0e507
hovercard-subject-tagpull_request:4317996991
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6868/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altProblem A connector sync ran the full hour and hit MAX_DURATION_EXCEEDED. The cause is not rate limiting. OpenAI answers an exhausted balance with 429, the same status as a rate limit: { "erro...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6868/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6868%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6868%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6868/files
Reloadhttps://github.com/simstudioai/sim/pull/6868/files
Reloadhttps://github.com/simstudioai/sim/pull/6868/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests201 (201)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/kb-embedding-quota-429https://github.com/simstudioai/sim/tree/fix/kb-embedding-quota-429
Conversation 3 https://github.com/simstudioai/sim/pull/6868
Commits 1 https://github.com/simstudioai/sim/pull/6868/commits
Checks 30 https://github.com/simstudioai/sim/pull/6868/checks
Files changed https://github.com/simstudioai/sim/pull/6868/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6868/files
fix(knowledge): stop retrying an embedding key with no credit left https://github.com/simstudioai/sim/pull/6868/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6868/files
d6d63c5 fix(knowledge): stop retrying an embedding key with no credit left waleedlatif1 Aug 19, 2026 https://github.com/simstudioai/sim/pull/6868/commits/d6d63c5bd44fdf173f67a0d510f224db617eeaca
Clear filters https://github.com/simstudioai/sim/pull/6868/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6868/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6868/files
client.test.ts https://github.com/simstudioai/sim/pull/6868/files#diff-776dd477f81ddfab85944a291f03f7cd5365106f51de7615adc673aac72a589a
client.ts https://github.com/simstudioai/sim/pull/6868/files#diff-bff32d70819c246fcf759a2ace839aa7e4569d2c62cf0658c5d2613a89d1170c
apps/sim/lib/embeddings/client.test.tshttps://github.com/simstudioai/sim/pull/6868/files#diff-776dd477f81ddfab85944a291f03f7cd5365106f51de7615adc673aac72a589a
View file https://github.com/simstudioai/sim/blob/d6d63c5bd44fdf173f67a0d510f224db617eeaca/apps/sim/lib/embeddings/client.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6868/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6868/files#diff-776dd477f81ddfab85944a291f03f7cd5365106f51de7615adc673aac72a589a
https://github.com/simstudioai/sim/pull/6868/files#diff-776dd477f81ddfab85944a291f03f7cd5365106f51de7615adc673aac72a589a
apps/sim/lib/embeddings/client.tshttps://github.com/simstudioai/sim/pull/6868/files#diff-bff32d70819c246fcf759a2ace839aa7e4569d2c62cf0658c5d2613a89d1170c
View file https://github.com/simstudioai/sim/blob/d6d63c5bd44fdf173f67a0d510f224db617eeaca/apps/sim/lib/embeddings/client.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6868/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6868/files#diff-bff32d70819c246fcf759a2ace839aa7e4569d2c62cf0658c5d2613a89d1170c
https://github.com/simstudioai/sim/pull/6868/files#diff-bff32d70819c246fcf759a2ace839aa7e4569d2c62cf0658c5d2613a89d1170c
https://github.com/simstudioai/sim/pull/6868/files#diff-bff32d70819c246fcf759a2ace839aa7e4569d2c62cf0658c5d2613a89d1170c
https://github.com/simstudioai/sim/pull/6868/files#diff-bff32d70819c246fcf759a2ace839aa7e4569d2c62cf0658c5d2613a89d1170c
https://github.com/simstudioai/sim/pull/6868/files#diff-bff32d70819c246fcf759a2ace839aa7e4569d2c62cf0658c5d2613a89d1170c
https://github.com/simstudioai/sim/pull/6868/files#diff-bff32d70819c246fcf759a2ace839aa7e4569d2c62cf0658c5d2613a89d1170c
https://github.com/simstudioai/sim/pull/6868/files#diff-bff32d70819c246fcf759a2ace839aa7e4569d2c62cf0658c5d2613a89d1170c
https://github.com/simstudioai/sim/pull/6868/files#diff-bff32d70819c246fcf759a2ace839aa7e4569d2c62cf0658c5d2613a89d1170c
Please reload this pagehttps://github.com/simstudioai/sim/pull/6868/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.