René's URL Explorer Experiment


Title: fix(provenance): stop size limits silently dropping secret provenance by icecrasher321 · Pull Request #6867 · simstudioai/sim · GitHub

Open Graph Title: fix(provenance): stop size limits silently dropping secret provenance by icecrasher321 · Pull Request #6867 · simstudioai/sim

X Title: fix(provenance): stop size limits silently dropping secret provenance by icecrasher321 · Pull Request #6867 · simstudioai/sim

Description: Summary A bundle-selection cap counted cells rather than rows, so a 25-column table insert lost secret provenance for every row past 400 — the whole batch was stamped unknown, with nothing logged. The same number lived in three layers (sender, runtime type guard, route contract); all three are gone, and a cross-layer test pins the sender's output against the contract so they can't drift apart again. Consolidated the scattered provenance limits into one definition. The same two numbers — an 8MB serialized envelope and 10,000 distinct secrets — had been copied into seven modules under fourteen names, and several copies had drifted into bounding inputs (rows, cells, files, chunks) rather than the envelope. Removed every limit that could refuse a legal payload: a 20-file cap that threw outright when a Function block exported 21 files (now paged, so every file still gets marked), a 100-row knowledge response cap, a memory record cap, and the table row/column caps. What remains is two envelope bounds plus page sizes that bound a statement and can never refuse. Reads that proceed on unrecorded provenance now write a workspace-visible audit entry (secret_provenance.unrecorded) alongside the log line, aggregated per read rather than per record. Added write-side cause logging: every path that can stamp a row unknown now names why, through a single chokepoint. Fixed a classifier disagreement where a demoted row was read as legacy by the read path and the fork classifier but as unknown by the derived-transformation SQL, which turned ordinary column operations into bulk producers of unknowns. Script migration returns existing unknown rows to the untracked state — the state the read path already tolerates, and which passes even once a surface is closed. Type of Change Bug fix Testing Tested manually. bun run lint, check:audits, and check-block-registry pass; type-check clean across apps/sim, packages/audit, packages/testing, packages/db. 4,837 tests pass across the provenance, table, knowledge, memory, uploads, contracts, and audit suites. One unrelated failure (unreadable-document.test.ts, OCR error-message assertion) reproduces on staging without these changes. Notes for review: The enforcement feature flag is deliberately untouched — the intent is to merge and watch the new cause logging trend before changing posture. The derived-transformation classification SQL has no test coverage; that change is verified by reading, not by test. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary A bundle-selection cap counted cells rather than rows, so a 25-column table insert lost secret provenance for every row past 400 — the whole batch was stamped unknown, with nothing logged....

X Description: Summary A bundle-selection cap counted cells rather than rows, so a 25-column table insert lost secret provenance for every row past 400 — the whole batch was stamped unknown, with nothing logged....

Opengraph URL: https://github.com/simstudioai/sim/pull/6867

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:048eb87d-9466-52ed-33f6-acb62e4bd3b8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD30:16FEFE:4F2487:6F154C:6AFB5E58
html-safe-nonce568286e2216cbbcdac315891421b9d1c13766e99489961704b62d18bf0f55cc2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDMwOjE2RkVGRTo0RjI0ODc6NkYxNTRDOjZBRkI1RTU4IiwidmlzaXRvcl9pZCI6IjU1NTYzNDM0MDEwMDQ4ODM1NDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2ef43284d7fd5b5c0d4f563df103c17c161bcb7137a1e31e13cdac60bd701b3c
hovercard-subject-tagpull_request:4317844531
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6867/files
twitter:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
og:image:altSummary A bundle-selection cap counted cells rather than rows, so a 25-column table insert lost secret provenance for every row past 400 — the whole batch was stamped unknown, with nothing logged....
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6867/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6867%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6867%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6867/files
Reloadhttps://github.com/simstudioai/sim/pull/6867/files
Reloadhttps://github.com/simstudioai/sim/pull/6867/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
icecrasher321https://github.com/icecrasher321
staginghttps://github.com/simstudioai/sim/tree/staging
provenance/remove-arbitrary-limitshttps://github.com/simstudioai/sim/tree/provenance/remove-arbitrary-limits
Conversation 16 https://github.com/simstudioai/sim/pull/6867
Commits 3 https://github.com/simstudioai/sim/pull/6867/commits
Checks 30 https://github.com/simstudioai/sim/pull/6867/checks
Files changed https://github.com/simstudioai/sim/pull/6867/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6867/files
fix(provenance): stop size limits silently dropping secret provenance https://github.com/simstudioai/sim/pull/6867/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/6867/files
0ee8e08 fix(provenance): stop size limits silently dropping secret provenance Aug 19, 2026 https://github.com/simstudioai/sim/pull/6867/commits/0ee8e08e20ef8a279bfed171b4423865a20cb0eb
06f5e76 fix(provenance): close a repair race and stop memory double-reporting Aug 19, 2026 https://github.com/simstudioai/sim/pull/6867/commits/06f5e763a0366c58ef8e7179527d9e309ae6b115
a8e6233 fix(provenance): take the repair's locks in the writer's order Aug 19, 2026 https://github.com/simstudioai/sim/pull/6867/commits/a8e6233c3908d49d0e9097a9e1ec243f5d0bc8d0
Clear filters https://github.com/simstudioai/sim/pull/6867/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6867/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6867/files
secret-provenance.test.ts https://github.com/simstudioai/sim/pull/6867/files#diff-9331b37b0f5e5ff93210df6e787f252f53331ff487e799e93a4df21acc1a3c6f
secret-provenance.ts https://github.com/simstudioai/sim/pull/6867/files#diff-dca9b8f557340d78da243ba64a4424f367d1998674adf1a8bf2300bf189ecaba
index.mdx https://github.com/simstudioai/sim/pull/6867/files#diff-b94164b4dbf17865454616c83929a24a38dcf7d51d291551a65659dbd12c1952
resolved-secret-trace-registry.test.ts https://github.com/simstudioai/sim/pull/6867/files#diff-6a951339566d1c8718b8d7e4776e3b8babd34c01fbbf1e095c2d7e1062abd39d
resolved-secret-trace-registry.ts https://github.com/simstudioai/sim/pull/6867/files#diff-2174fa12ceaf7c6220eeeb43e2c3a89f7716e471bbe9504b3a69996bbb96952a
primitives.ts https://github.com/simstudioai/sim/pull/6867/files#diff-74acbd246ecd57f97189320f8dbdafcd78d0d5150fd1d25da51057ebd06f43f1
durable-secret-provenance-enforcement.test.ts https://github.com/simstudioai/sim/pull/6867/files#diff-861a061ae440092bc3117885916f1c1ffe4bab101690fffd0658c3ddb69a4fdb
durable-secret-provenance-enforcement.ts https://github.com/simstudioai/sim/pull/6867/files#diff-a9cbbb33d846c424c713d03a975eff6b131648cc60052d78fcc3b2b16e8d0000
durable-secret-provenance.ts https://github.com/simstudioai/sim/pull/6867/files#diff-3de9d3c40a70292ffcee710d93cfb33e05030e20daea6798c52692d623e0594d
model-input-provenance.test.ts https://github.com/simstudioai/sim/pull/6867/files#diff-a4b5561dc0c6cea2f128eca1aaa655fafb930062e91c4db9388c87706025c28f
model-input-provenance.ts https://github.com/simstudioai/sim/pull/6867/files#diff-cf5bd2806db54850b2eb6ce9b52197c30d957f8cf4f109b20bc85a44a289dd7b
provenance-limits.ts https://github.com/simstudioai/sim/pull/6867/files#diff-b8e0d576462b5d9092b8d73f7dfef59aa00f09f338d76f0f76d5555523f4b44c
secret-provenance.ts https://github.com/simstudioai/sim/pull/6867/files#diff-79668df40a7e0c39ee6c4f5ac7eb3945da1a3752940303c36ebb6d76e70e13d7
secret-provenance.test.ts https://github.com/simstudioai/sim/pull/6867/files#diff-4e2facc05c9672f2c4ebeb7da66a3c223dadd6edeeb804a188eec7db6473197e
secret-provenance.ts https://github.com/simstudioai/sim/pull/6867/files#diff-c596e887466f07fe84d02c25ab4be5746779df0d5c35286bf9ad0c7a87ab65af
workspace-file-secret-provenance.ts https://github.com/simstudioai/sim/pull/6867/files#diff-dc9f5d8bcbc26f92094970ec14aa86da31ab479567fc6c6997b5ba3bd839c998
types.ts https://github.com/simstudioai/sim/pull/6867/files#diff-0c4c4527875ffe443d3b9bc35837c1dfb53d8918c2751deafbc08896fd8d5731
script-migrations-paused-billing-attribution.test.ts https://github.com/simstudioai/sim/pull/6867/files#diff-509458c3951fa9cd2e97a7942fd977a83ef520c679d29dc242a5b2cacfb02743
0005_repair_unknown_table_row_provenance.test.ts https://github.com/simstudioai/sim/pull/6867/files#diff-c4f41d639b3dc8702f44e050e4fcf8eb9c84cd2bf5f0695e6ebb3fde41bc75c4
0005_repair_unknown_table_row_provenance.ts https://github.com/simstudioai/sim/pull/6867/files#diff-96ebed12ae65912065e11851e64d75dfa550c2b17bb206a586baa671705c597b
index.ts https://github.com/simstudioai/sim/pull/6867/files#diff-4c8058a0b924ce061c5ce010c1308148ea03720952dda10d03cee092b61adbd6
audit.mock.ts https://github.com/simstudioai/sim/pull/6867/files#diff-ddbf3f281bccb1e55eb3765c29403087addedc24fb5f99c437c69a9a412c1e91
apps/sim/app/api/memory/secret-provenance.test.tshttps://github.com/simstudioai/sim/pull/6867/files#diff-9331b37b0f5e5ff93210df6e787f252f53331ff487e799e93a4df21acc1a3c6f
View file https://github.com/simstudioai/sim/blob/a8e6233c3908d49d0e9097a9e1ec243f5d0bc8d0/apps/sim/app/api/memory/secret-provenance.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6867/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6867/files#diff-9331b37b0f5e5ff93210df6e787f252f53331ff487e799e93a4df21acc1a3c6f
https://github.com/simstudioai/sim/pull/6867/files#diff-9331b37b0f5e5ff93210df6e787f252f53331ff487e799e93a4df21acc1a3c6f
https://github.com/simstudioai/sim/pull/6867/files#diff-9331b37b0f5e5ff93210df6e787f252f53331ff487e799e93a4df21acc1a3c6f
https://github.com/simstudioai/sim/pull/6867/files#diff-9331b37b0f5e5ff93210df6e787f252f53331ff487e799e93a4df21acc1a3c6f
https://github.com/simstudioai/sim/pull/6867/files#diff-9331b37b0f5e5ff93210df6e787f252f53331ff487e799e93a4df21acc1a3c6f
https://github.com/simstudioai/sim/pull/6867/files#diff-9331b37b0f5e5ff93210df6e787f252f53331ff487e799e93a4df21acc1a3c6f
https://github.com/simstudioai/sim/pull/6867/files#diff-9331b37b0f5e5ff93210df6e787f252f53331ff487e799e93a4df21acc1a3c6f
https://github.com/simstudioai/sim/pull/6867/files#diff-9331b37b0f5e5ff93210df6e787f252f53331ff487e799e93a4df21acc1a3c6f
apps/sim/app/api/memory/secret-provenance.tshttps://github.com/simstudioai/sim/pull/6867/files#diff-dca9b8f557340d78da243ba64a4424f367d1998674adf1a8bf2300bf189ecaba
View file https://github.com/simstudioai/sim/blob/a8e6233c3908d49d0e9097a9e1ec243f5d0bc8d0/apps/sim/app/api/memory/secret-provenance.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6867/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6867/files#diff-dca9b8f557340d78da243ba64a4424f367d1998674adf1a8bf2300bf189ecaba
https://github.com/simstudioai/sim/pull/6867/files#diff-dca9b8f557340d78da243ba64a4424f367d1998674adf1a8bf2300bf189ecaba
https://github.com/simstudioai/sim/pull/6867/files#diff-dca9b8f557340d78da243ba64a4424f367d1998674adf1a8bf2300bf189ecaba
https://github.com/simstudioai/sim/pull/6867/files#diff-dca9b8f557340d78da243ba64a4424f367d1998674adf1a8bf2300bf189ecaba
Please reload this pagehttps://github.com/simstudioai/sim/pull/6867/files
https://github.com/simstudioai/sim/pull/6867/files#diff-dca9b8f557340d78da243ba64a4424f367d1998674adf1a8bf2300bf189ecaba
apps/sim/content/blog/secret-provenance/index.mdxhttps://github.com/simstudioai/sim/pull/6867/files#diff-b94164b4dbf17865454616c83929a24a38dcf7d51d291551a65659dbd12c1952
View file https://github.com/simstudioai/sim/blob/a8e6233c3908d49d0e9097a9e1ec243f5d0bc8d0/apps/sim/content/blog/secret-provenance/index.mdx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6867/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6867/files#diff-b94164b4dbf17865454616c83929a24a38dcf7d51d291551a65659dbd12c1952
https://github.com/simstudioai/sim/pull/6867/files#diff-b94164b4dbf17865454616c83929a24a38dcf7d51d291551a65659dbd12c1952
apps/sim/executor/utils/resolved-secret-trace-registry.test.tshttps://github.com/simstudioai/sim/pull/6867/files#diff-6a951339566d1c8718b8d7e4776e3b8babd34c01fbbf1e095c2d7e1062abd39d
View file https://github.com/simstudioai/sim/blob/a8e6233c3908d49d0e9097a9e1ec243f5d0bc8d0/apps/sim/executor/utils/resolved-secret-trace-registry.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6867/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6867/files#diff-6a951339566d1c8718b8d7e4776e3b8babd34c01fbbf1e095c2d7e1062abd39d
https://github.com/simstudioai/sim/pull/6867/files#diff-6a951339566d1c8718b8d7e4776e3b8babd34c01fbbf1e095c2d7e1062abd39d
https://github.com/simstudioai/sim/pull/6867/files#diff-6a951339566d1c8718b8d7e4776e3b8babd34c01fbbf1e095c2d7e1062abd39d
https://github.com/simstudioai/sim/pull/6867/files#diff-6a951339566d1c8718b8d7e4776e3b8babd34c01fbbf1e095c2d7e1062abd39d
Please reload this pagehttps://github.com/simstudioai/sim/pull/6867/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6867/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.