René's URL Explorer Experiment


Title: fix(knowledge): say what went wrong when a document's chunks fail to load by waleedlatif1 · Pull Request #6858 · simstudioai/sim · GitHub

Open Graph Title: fix(knowledge): say what went wrong when a document's chunks fail to load by waleedlatif1 · Pull Request #6858 · simstudioai/sim

X Title: fix(knowledge): say what went wrong when a document's chunks fail to load by waleedlatif1 · Pull Request #6858 · simstudioai/sim

Description: Found while surveying empty states for #6855. const combinedError = documentError || searchError || initialError collapsed three different failures into one. On any of them the page blanked the rows, stripped search, sort and filter — and said nothing. A failed read rendered as an empty table, which is exactly what the page shows when a document genuinely has no chunks. Stripping the search box was the worse half. When it was the search that failed, the one control the user needed to clear it was the control that disappeared. The error was a dead end. Telling the three apart The document itself failed. There is no page left to draw, so it gets a full screen — the same treatment the base page already gives a missing knowledge base one level up. This has to run before the editor branches. selectedChunkId renders the chunk editor without checking for a document, and its inner guard falls through to "Loading chunk…" — so a deep link to a chunk of a deleted document sat on a spinner forever. A chunk read failed. The document is fine, so the page keeps its chrome and all its controls, and the message goes in the table body through the emptyState slot. The search box surviving is the point: that is the recovery path. It is tinted with --text-error. At the muted weight the empty states use, a failure is indistinguishable from "nothing here yet" — a softer version of the bug being fixed. A search failed. The loaded chunks are still intact, so claiming the chunks could not be loaded would be untrue. It says the search failed. A hole in the same class const searchError = searchQueryError instanceof Error ? searchQueryError.message : null A rejection that is not an Error instance produced no message, so chunkError stayed falsy and the table went silently blank — the exact bug this PR removes. It uses getErrorMessage now, which is what the chunk read beside it always did, and what global.md requires. Also Pagination is dropped on a failed read; it was counting pages nothing fetched. The action bar reads the same value, so it no longer lifts itself 72px clear of a bar that is not rendered. The breadcrumb's 'Error' label is gone. It is unreachable by construction now — a missing document early-returns, and in every other case the document name is known and correct. Replacing a correct name with "Error" was the bug, not a feature. The not-found screen was about to exist in two files, so it moves to ResourceNotFound and the base page adopts it. More detail routes are coming. Verification Type-check, biome, 29/29 audits, 2220 tests. The error state was rendered in both themes rather than eyeballed from the markup.

Open Graph Description: Found while surveying empty states for #6855. const combinedError = documentError || searchError || initialError collapsed three different failures into one. On any of them the page blanked the row...

X Description: Found while surveying empty states for #6855. const combinedError = documentError || searchError || initialError collapsed three different failures into one. On any of them the page blanked the row...

Opengraph URL: https://github.com/simstudioai/sim/pull/6858

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:553a9215-640e-fec6-c218-a9538723307a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD062:1BD5CA:E5AC9D:13ACFBF:6AFB5DEA
html-safe-noncec584bc026837e6aaa44c1833a81e18d93a54f0653cb9d04befc90b7ed018fa25
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDYyOjFCRDVDQTpFNUFDOUQ6MTNBQ0ZCRjo2QUZCNURFQSIsInZpc2l0b3JfaWQiOiIyMTQ0MTM1NjExMTE4NDc2Nzc4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac207d2a9e936ad0cdbdefbac8b6be2af68f2fce382c56af3868d174fda1cbb99e
hovercard-subject-tagpull_request:4317114583
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6858/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altFound while surveying empty states for #6855. const combinedError = documentError || searchError || initialError collapsed three different failures into one. On any of them the page blanked the row...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6858/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6858%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6858%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6858/files
Reloadhttps://github.com/simstudioai/sim/pull/6858/files
Reloadhttps://github.com/simstudioai/sim/pull/6858/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/chunk-load-error-visibilityhttps://github.com/simstudioai/sim/tree/fix/chunk-load-error-visibility
Conversation 7 https://github.com/simstudioai/sim/pull/6858
Commits 2 https://github.com/simstudioai/sim/pull/6858/commits
Checks 29 https://github.com/simstudioai/sim/pull/6858/checks
Files changed https://github.com/simstudioai/sim/pull/6858/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6858/files
fix(knowledge): say what went wrong when a document's chunks fail to load https://github.com/simstudioai/sim/pull/6858/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/6858/files
c74d27c fix(knowledge): say what went wrong when a document's chunks fail to … waleedlatif1 Aug 19, 2026 https://github.com/simstudioai/sim/pull/6858/commits/c74d27c444824f8f3edc331c7ce4440bdd7f69dd
8a4fc0c fix(knowledge): let a processing document say so, not that it failed waleedlatif1 Aug 19, 2026 https://github.com/simstudioai/sim/pull/6858/commits/8a4fc0c10d9e88668336cc48fb1253be1e9f3ebb
Clear filters https://github.com/simstudioai/sim/pull/6858/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6858/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6858/files
index.ts https://github.com/simstudioai/sim/pull/6858/files#diff-cf629c9c117e79c29a199a88c1f887a4cc2448be93dda99bb99b13bea3561210
resource-not-found.tsx https://github.com/simstudioai/sim/pull/6858/files#diff-3866e146b507c8b7a13f8c5383a03c6d59742f437dce8021dbe1448f3eb951c1
document.tsx https://github.com/simstudioai/sim/pull/6858/files#diff-a99aa06bddd087d73ff5aade48aee6821f62f95c800662505252fbf29976f71f
base.tsx https://github.com/simstudioai/sim/pull/6858/files#diff-9b1c8365e920c2c33ce67896c76e98caf6c8535794de2ce1d01ea707bb2b2161
apps/sim/app/workspace/[workspaceId]/components/index.tshttps://github.com/simstudioai/sim/pull/6858/files#diff-cf629c9c117e79c29a199a88c1f887a4cc2448be93dda99bb99b13bea3561210
View file https://github.com/simstudioai/sim/blob/8a4fc0c10d9e88668336cc48fb1253be1e9f3ebb/apps/sim/app/workspace/%5BworkspaceId%5D/components/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6858/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6858/files#diff-cf629c9c117e79c29a199a88c1f887a4cc2448be93dda99bb99b13bea3561210
apps/sim/app/workspace/[workspaceId]/components/resource/resource-not-found.tsxhttps://github.com/simstudioai/sim/pull/6858/files#diff-3866e146b507c8b7a13f8c5383a03c6d59742f437dce8021dbe1448f3eb951c1
View file https://github.com/simstudioai/sim/blob/8a4fc0c10d9e88668336cc48fb1253be1e9f3ebb/apps/sim/app/workspace/%5BworkspaceId%5D/components/resource/resource-not-found.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6858/{{ revealButtonHref }}
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsxhttps://github.com/simstudioai/sim/pull/6858/files#diff-a99aa06bddd087d73ff5aade48aee6821f62f95c800662505252fbf29976f71f
View file https://github.com/simstudioai/sim/blob/8a4fc0c10d9e88668336cc48fb1253be1e9f3ebb/apps/sim/app/workspace/%5BworkspaceId%5D/knowledge/%5Bid%5D/%5BdocumentId%5D/document.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6858/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6858/files#diff-a99aa06bddd087d73ff5aade48aee6821f62f95c800662505252fbf29976f71f
https://github.com/simstudioai/sim/pull/6858/files#diff-a99aa06bddd087d73ff5aade48aee6821f62f95c800662505252fbf29976f71f
https://github.com/simstudioai/sim/pull/6858/files#diff-a99aa06bddd087d73ff5aade48aee6821f62f95c800662505252fbf29976f71f
https://github.com/simstudioai/sim/pull/6858/files#diff-a99aa06bddd087d73ff5aade48aee6821f62f95c800662505252fbf29976f71f
https://github.com/simstudioai/sim/pull/6858/files#diff-a99aa06bddd087d73ff5aade48aee6821f62f95c800662505252fbf29976f71f
https://github.com/simstudioai/sim/pull/6858/files#diff-a99aa06bddd087d73ff5aade48aee6821f62f95c800662505252fbf29976f71f
https://github.com/simstudioai/sim/pull/6858/files#diff-a99aa06bddd087d73ff5aade48aee6821f62f95c800662505252fbf29976f71f
https://github.com/simstudioai/sim/pull/6858/files#diff-a99aa06bddd087d73ff5aade48aee6821f62f95c800662505252fbf29976f71f
https://github.com/simstudioai/sim/pull/6858/files#diff-a99aa06bddd087d73ff5aade48aee6821f62f95c800662505252fbf29976f71f
https://github.com/simstudioai/sim/pull/6858/files#diff-a99aa06bddd087d73ff5aade48aee6821f62f95c800662505252fbf29976f71f
https://github.com/simstudioai/sim/pull/6858/files#diff-a99aa06bddd087d73ff5aade48aee6821f62f95c800662505252fbf29976f71f
https://github.com/simstudioai/sim/pull/6858/files#diff-a99aa06bddd087d73ff5aade48aee6821f62f95c800662505252fbf29976f71f
https://github.com/simstudioai/sim/pull/6858/files#diff-a99aa06bddd087d73ff5aade48aee6821f62f95c800662505252fbf29976f71f
https://github.com/simstudioai/sim/pull/6858/files#diff-a99aa06bddd087d73ff5aade48aee6821f62f95c800662505252fbf29976f71f
https://github.com/simstudioai/sim/pull/6858/files#diff-a99aa06bddd087d73ff5aade48aee6821f62f95c800662505252fbf29976f71f
https://github.com/simstudioai/sim/pull/6858/files#diff-a99aa06bddd087d73ff5aade48aee6821f62f95c800662505252fbf29976f71f
https://github.com/simstudioai/sim/pull/6858/files#diff-a99aa06bddd087d73ff5aade48aee6821f62f95c800662505252fbf29976f71f
https://github.com/simstudioai/sim/pull/6858/files#diff-a99aa06bddd087d73ff5aade48aee6821f62f95c800662505252fbf29976f71f
https://github.com/simstudioai/sim/pull/6858/files#diff-a99aa06bddd087d73ff5aade48aee6821f62f95c800662505252fbf29976f71f
https://github.com/simstudioai/sim/pull/6858/files#diff-a99aa06bddd087d73ff5aade48aee6821f62f95c800662505252fbf29976f71f
https://github.com/simstudioai/sim/pull/6858/files#diff-a99aa06bddd087d73ff5aade48aee6821f62f95c800662505252fbf29976f71f
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/base.tsxhttps://github.com/simstudioai/sim/pull/6858/files#diff-9b1c8365e920c2c33ce67896c76e98caf6c8535794de2ce1d01ea707bb2b2161
View file https://github.com/simstudioai/sim/blob/8a4fc0c10d9e88668336cc48fb1253be1e9f3ebb/apps/sim/app/workspace/%5BworkspaceId%5D/knowledge/%5Bid%5D/base.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6858/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6858/files#diff-9b1c8365e920c2c33ce67896c76e98caf6c8535794de2ce1d01ea707bb2b2161
https://github.com/simstudioai/sim/pull/6858/files#diff-9b1c8365e920c2c33ce67896c76e98caf6c8535794de2ce1d01ea707bb2b2161
https://github.com/simstudioai/sim/pull/6858/files#diff-9b1c8365e920c2c33ce67896c76e98caf6c8535794de2ce1d01ea707bb2b2161
https://github.com/simstudioai/sim/pull/6858/files#diff-9b1c8365e920c2c33ce67896c76e98caf6c8535794de2ce1d01ea707bb2b2161
Please reload this pagehttps://github.com/simstudioai/sim/pull/6858/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.