René's URL Explorer Experiment


Title: fix(connectors): treat a zero-byte source file as nothing to index by waleedlatif1 · Pull Request #6848 · simstudioai/sim · GitHub

Open Graph Title: fix(connectors): treat a zero-byte source file as nothing to index by waleedlatif1 · Pull Request #6848 · simstudioai/sim

X Title: fix(connectors): treat a zero-byte source file as nothing to index by waleedlatif1 · Pull Request #6848 · simstudioai/sim

Description: Summary A zero-byte source file is no longer treated as something to index The emptiness rule now lives in one place, hasIndexablePayload, shared by the sync engine's classify and hydrate gates and both connectors' getDocument Why Found by auditing production after connectors began delivering source files. A zero-byte PDF was stored and sent to OCR, which answered 400 Bad Request: OCR failed: 400 Bad Request - {"success":false,"error":"Mistral API error: Bad Request"} file_size: 0 Two problems in one. It bills an external API call to discover the file was empty, and it reports the result as a provider fault rather than as an empty file, so the row gives no one a reason they can act on. This was a regression. Before source files existed, an empty file produced empty extracted text and was dropped at the empty-content check. The rule also existed in two places that disagreed: the connectors asked whether a source file was present, the sync engine asked the same question a second way, and a source file with no bytes satisfied both. One definition now, so the two gates cannot drift. Scope This is the only unexplained failure class in the fleet since the source-file change deployed. Everything else post-deploy is legitimate and correctly reported: image-only decks, password-protected workbooks, files over the 100MB cap, and archives caught by the decompression guard. Testing vitest run connectors/ lib/knowledge/ lib/uploads/ lib/file-parsers/ app/api/knowledge/ — 2,007 passed (129 files) New cases cover a source file with bytes, extracted text, blank text, and the zero-byte file; verified the zero-byte case fails when the guard is weakened bun run check:audits — 29/29 tsgo --noEmit — no errors in changed files (pre-existing mssql and @c15t/nextjs resolution errors unrelated) Checklist Self-reviewed No secrets or customer data introduced

Open Graph Description: Summary A zero-byte source file is no longer treated as something to index The emptiness rule now lives in one place, hasIndexablePayload, shared by the sync engine's classify and hydrate gate...

X Description: Summary A zero-byte source file is no longer treated as something to index The emptiness rule now lives in one place, hasIndexablePayload, shared by the sync engine's classify and hydrate ...

Opengraph URL: https://github.com/simstudioai/sim/pull/6848

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:788f22c4-6f97-9591-1045-7e7cf5373c4e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBBE6:18E6DD:DEE608:13207DB:6AFB5DDD
html-safe-nonce7446239521550042976a292f7544ffcaebff3a57a0355121334c7e82539a22af
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQkU2OjE4RTZERDpERUU2MDg6MTMyMDdEQjo2QUZCNURERCIsInZpc2l0b3JfaWQiOiI3MDczODQyODk5NTkwMDEyMzgxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac37ab625b32f1975245f53d26e0bb4d6ad6fdab7020f0c11cc41c7a389fd7ef66
hovercard-subject-tagpull_request:4316004437
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6848/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary A zero-byte source file is no longer treated as something to index The emptiness rule now lives in one place, hasIndexablePayload, shared by the sync engine's classify and hydrate gate...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6848/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6848%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6848%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6848/files
Reloadhttps://github.com/simstudioai/sim/pull/6848/files
Reloadhttps://github.com/simstudioai/sim/pull/6848/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/connector-empty-source-filehttps://github.com/simstudioai/sim/tree/fix/connector-empty-source-file
Conversation 3 https://github.com/simstudioai/sim/pull/6848
Commits 1 https://github.com/simstudioai/sim/pull/6848/commits
Checks 30 https://github.com/simstudioai/sim/pull/6848/checks
Files changed https://github.com/simstudioai/sim/pull/6848/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6848/files
fix(connectors): treat a zero-byte source file as nothing to index https://github.com/simstudioai/sim/pull/6848/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6848/files
eabfba7 fix(connectors): treat a zero-byte source file as nothing to index waleedlatif1 Aug 19, 2026 https://github.com/simstudioai/sim/pull/6848/commits/eabfba72c1222ba54849fcccd18d7b7191f0f1d5
Clear filters https://github.com/simstudioai/sim/pull/6848/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6848/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6848/files
onedrive.ts https://github.com/simstudioai/sim/pull/6848/files#diff-60e130e26008d9eb6e671ee3195a984336ebd186565dced245cd820268143da1
sharepoint.ts https://github.com/simstudioai/sim/pull/6848/files#diff-a39a21bb15e6c27b68de3dc7899e31ba8e4ee2fa37e7c34ce1c93a23ab25c625
utils.test.ts https://github.com/simstudioai/sim/pull/6848/files#diff-2405bfb9d79e30136f8e29677391cd1f1164759188077003e27518634e26bbe9
utils.ts https://github.com/simstudioai/sim/pull/6848/files#diff-c27db14947d25b8915e236c873ccf485a2e0497266dde4f61bd295f93e7f3920
sync-engine.ts https://github.com/simstudioai/sim/pull/6848/files#diff-277f76464f02682e44e6de58ebd215c927f0f6a3a7165af669a0717b593790e9
apps/sim/connectors/onedrive/onedrive.tshttps://github.com/simstudioai/sim/pull/6848/files#diff-60e130e26008d9eb6e671ee3195a984336ebd186565dced245cd820268143da1
View file https://github.com/simstudioai/sim/blob/eabfba72c1222ba54849fcccd18d7b7191f0f1d5/apps/sim/connectors/onedrive/onedrive.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6848/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6848/files#diff-60e130e26008d9eb6e671ee3195a984336ebd186565dced245cd820268143da1
https://github.com/simstudioai/sim/pull/6848/files#diff-60e130e26008d9eb6e671ee3195a984336ebd186565dced245cd820268143da1
https://github.com/simstudioai/sim/pull/6848/files#diff-60e130e26008d9eb6e671ee3195a984336ebd186565dced245cd820268143da1
https://github.com/simstudioai/sim/pull/6848/files#diff-60e130e26008d9eb6e671ee3195a984336ebd186565dced245cd820268143da1
apps/sim/connectors/sharepoint/sharepoint.tshttps://github.com/simstudioai/sim/pull/6848/files#diff-a39a21bb15e6c27b68de3dc7899e31ba8e4ee2fa37e7c34ce1c93a23ab25c625
View file https://github.com/simstudioai/sim/blob/eabfba72c1222ba54849fcccd18d7b7191f0f1d5/apps/sim/connectors/sharepoint/sharepoint.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6848/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6848/files#diff-a39a21bb15e6c27b68de3dc7899e31ba8e4ee2fa37e7c34ce1c93a23ab25c625
https://github.com/simstudioai/sim/pull/6848/files#diff-a39a21bb15e6c27b68de3dc7899e31ba8e4ee2fa37e7c34ce1c93a23ab25c625
https://github.com/simstudioai/sim/pull/6848/files#diff-a39a21bb15e6c27b68de3dc7899e31ba8e4ee2fa37e7c34ce1c93a23ab25c625
https://github.com/simstudioai/sim/pull/6848/files#diff-a39a21bb15e6c27b68de3dc7899e31ba8e4ee2fa37e7c34ce1c93a23ab25c625
apps/sim/connectors/utils.test.tshttps://github.com/simstudioai/sim/pull/6848/files#diff-2405bfb9d79e30136f8e29677391cd1f1164759188077003e27518634e26bbe9
View file https://github.com/simstudioai/sim/blob/eabfba72c1222ba54849fcccd18d7b7191f0f1d5/apps/sim/connectors/utils.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6848/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6848/files#diff-2405bfb9d79e30136f8e29677391cd1f1164759188077003e27518634e26bbe9
https://github.com/simstudioai/sim/pull/6848/files#diff-2405bfb9d79e30136f8e29677391cd1f1164759188077003e27518634e26bbe9
https://github.com/simstudioai/sim/pull/6848/files#diff-2405bfb9d79e30136f8e29677391cd1f1164759188077003e27518634e26bbe9
apps/sim/connectors/utils.tshttps://github.com/simstudioai/sim/pull/6848/files#diff-c27db14947d25b8915e236c873ccf485a2e0497266dde4f61bd295f93e7f3920
View file https://github.com/simstudioai/sim/blob/eabfba72c1222ba54849fcccd18d7b7191f0f1d5/apps/sim/connectors/utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6848/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6848/files#diff-c27db14947d25b8915e236c873ccf485a2e0497266dde4f61bd295f93e7f3920
https://github.com/simstudioai/sim/pull/6848/files#diff-c27db14947d25b8915e236c873ccf485a2e0497266dde4f61bd295f93e7f3920
apps/sim/lib/knowledge/connectors/sync-engine.tshttps://github.com/simstudioai/sim/pull/6848/files#diff-277f76464f02682e44e6de58ebd215c927f0f6a3a7165af669a0717b593790e9
View file https://github.com/simstudioai/sim/blob/eabfba72c1222ba54849fcccd18d7b7191f0f1d5/apps/sim/lib/knowledge/connectors/sync-engine.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6848/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6848/files#diff-277f76464f02682e44e6de58ebd215c927f0f6a3a7165af669a0717b593790e9
https://github.com/simstudioai/sim/pull/6848/files#diff-277f76464f02682e44e6de58ebd215c927f0f6a3a7165af669a0717b593790e9
https://github.com/simstudioai/sim/pull/6848/files#diff-277f76464f02682e44e6de58ebd215c927f0f6a3a7165af669a0717b593790e9
https://github.com/simstudioai/sim/pull/6848/files#diff-277f76464f02682e44e6de58ebd215c927f0f6a3a7165af669a0717b593790e9
https://github.com/simstudioai/sim/pull/6848/files#diff-277f76464f02682e44e6de58ebd215c927f0f6a3a7165af669a0717b593790e9
https://github.com/simstudioai/sim/pull/6848/files#diff-277f76464f02682e44e6de58ebd215c927f0f6a3a7165af669a0717b593790e9
https://github.com/simstudioai/sim/pull/6848/files#diff-277f76464f02682e44e6de58ebd215c927f0f6a3a7165af669a0717b593790e9
https://github.com/simstudioai/sim/pull/6848/files#diff-277f76464f02682e44e6de58ebd215c927f0f6a3a7165af669a0717b593790e9
Please reload this pagehttps://github.com/simstudioai/sim/pull/6848/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.