Title: improvement(settings): drop the Delete account row's description by waleedlatif1 · Pull Request #6845 · simstudioai/sim · GitHub
Open Graph Title: improvement(settings): drop the Delete account row's description by waleedlatif1 · Pull Request #6845 · simstudioai/sim
X Title: improvement(settings): drop the Delete account row's description by waleedlatif1 · Pull Request #6845 · simstudioai/sim
Description: Summary Removes the description under the Delete account row in General settings, matching #6844 which did the same for the Privacy row. I checked that the warning isn't lost: the confirmation modal already carries it, and carries it better than the row did. It names the account being deleted, enumerates the workspaces that go with it, notes which ones transfer billing to another admin instead, marks This cannot be undone in the error color, and requires typing the account email before the destructive action is enabled. So the consequence is stated at the point of action rather than one click early, which is where it does the work. Also drops the flex flex-col gap-3 wrapper the paragraph shared with the row — with the paragraph gone, the row is the section's only child. Type of Change Other: copy/layout cleanup Testing type-check, lint:check, all 29 check:audits, and 199 tests pass. No behavior change — only the row's static copy is removed; the modal, its guards, and the delete flow are untouched. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Removes the description under the Delete account row in General settings, matching #6844 which did the same for the Privacy row. I checked that the warning isn't lost: the confirmation ...
X Description: Summary Removes the description under the Delete account row in General settings, matching #6844 which did the same for the Privacy row. I checked that the warning isn't lost: the confirmat...
Opengraph URL: https://github.com/simstudioai/sim/pull/6845
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:aa64f2d7-06dd-f9b8-821e-77a13f10ea33 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E5A0:2FE5F3:A23E24:E40C43:6AFB7578 |
| html-safe-nonce | 8670f51de0b9d2c950d22826645c988ea5a399e04c9067cde7be870ae9d74d33 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNUEwOjJGRTVGMzpBMjNFMjQ6RTQwQzQzOjZBRkI3NTc4IiwidmlzaXRvcl9pZCI6IjkxODEzNTIxNDg3OTk4MTI5ODQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b28ff1025763c95fea3bb226d73e96e401f55b8fb936de735cfc2ba20adb55e2 |
| hovercard-subject-tag | pull_request:4310803933 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6845/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Removes the description under the Delete account row in General settings, matching #6844 which did the same for the Privacy row. I checked that the warning isn't lost: the confirmation ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2e8872b770cc4d5d0cc1f2026afab747a268e2ce |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width