René's URL Explorer Experiment


Title: refactor(consent): fold cookie preferences into General > Privacy by waleedlatif1 · Pull Request #6837 · simstudioai/sim · GitHub

Open Graph Title: refactor(consent): fold cookie preferences into General > Privacy by waleedlatif1 · Pull Request #6837 · simstudioai/sim

X Title: refactor(consent): fold cookie preferences into General > Privacy by waleedlatif1 · Pull Request #6837 · simstudioai/sim

Description: Summary Follow-up to #6835. Cookie preferences were a top-level settings tab of their own, which is the wrong weight for something a user opens once and rarely returns to. They are now a sub-view of General → Privacy, reached from the section that already held the telemetry toggle — and that toggle moves with them, so one page owns everything Sim collects about you. This is the shape the guidance recommends for authenticated surfaces: manage consent from account settings rather than a banner or a dedicated tab inside the product. What changed Removed the top-level privacy settings section (nav entry, section switch, page component). Added General → Privacy as a detail sub-view, following the same SettingsPanel back={{…}} pattern as Browser → Passwords. Moved the telemetry toggle out of General's inline Privacy section into the sub-view; General now shows a one-line Privacy row with a Manage chip. Cookies render only when isHosted — the only deployment that sets them. Telemetry renders everywhere, so the sub-view is useful on a self-hosted deployment too. The open sub-view lives in the URL (?view=privacy) via nuqs, so it is linkable and Back closes it. One deliberate behavior choice Each cookie switch commits on change rather than staging behind a Save, matching the telemetry switch directly above it. One interaction model per page, and no "unsaved consent" state to reason about. That is safe: saveConsents('custom') reads selectedConsents from the store at call time, and the switch's setSelectedConsent write is synchronous, so the value a toggle stages is the value it commits. Verified against the vendored source, and covered by a test. The banner still stages, because its footer owns the commit. Type of Change Refactor New feature Testing type-check, lint:check, all 29 check:audits, and 193 tests pass. The settings surface needs auth, so the behavior I invented — commit-on-toggle — is covered by a unit test rather than a click-through. Reviewers should focus on the telemetry toggle move: the handler (mutation plus the enable_from_settings telemetry event) moved verbatim into the sub-view, and that is the piece most worth a second read. Known gap (unchanged) Prior blocking is still not implemented — GTM, GA, and PostHog load before consent. Tracked separately.

Open Graph Description: Summary Follow-up to #6835. Cookie preferences were a top-level settings tab of their own, which is the wrong weight for something a user opens once and rarely returns to. They are now a sub-view o...

X Description: Summary Follow-up to #6835. Cookie preferences were a top-level settings tab of their own, which is the wrong weight for something a user opens once and rarely returns to. They are now a sub-view o...

Opengraph URL: https://github.com/simstudioai/sim/pull/6837

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:332af6d7-4e01-0db1-c3ee-639066724103
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD6C:327CBE:C0199C:10ED20E:6AFB5D9B
html-safe-nonce29c20c036eb8d5ea7eab75c843f94990e8f3c544c6d6adca5c75140a75079c3b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDZDOjMyN0NCRTpDMDE5OUM6MTBFRDIwRTo2QUZCNUQ5QiIsInZpc2l0b3JfaWQiOiIzMDIzNzA2MDA5NTI1NTA5NTMxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf293d93ec8b17360e308f7b8387ba79b479c533b7010124f9692db1114d1121b
hovercard-subject-tagpull_request:4310079097
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6837/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up to #6835. Cookie preferences were a top-level settings tab of their own, which is the wrong weight for something a user opens once and rarely returns to. They are now a sub-view o...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6837/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6837%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6837%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6837/files
Reloadhttps://github.com/simstudioai/sim/pull/6837/files
Reloadhttps://github.com/simstudioai/sim/pull/6837/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
feat/consent-in-general-settingshttps://github.com/simstudioai/sim/tree/feat/consent-in-general-settings
Conversation 17 https://github.com/simstudioai/sim/pull/6837
Commits 3 https://github.com/simstudioai/sim/pull/6837/commits
Checks 30 https://github.com/simstudioai/sim/pull/6837/checks
Files changed https://github.com/simstudioai/sim/pull/6837/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6837/files
refactor(consent): fold cookie preferences into General > Privacy https://github.com/simstudioai/sim/pull/6837/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/6837/files
f9b3e3e refactor(consent): fold cookie preferences into General > Privacy waleedlatif1 Aug 19, 2026 https://github.com/simstudioai/sim/pull/6837/commits/f9b3e3e21106df92a3b5b63a9ce80306c9957b6e
0b5157d fix(consent): keep the old /settings/privacy link working waleedlatif1 Aug 19, 2026 https://github.com/simstudioai/sim/pull/6837/commits/0b5157d7c72ed49840dd78c6c408c8c1efb33188
88cffc3 fix(consent): stop two cookie toggles from racing, and revert a faile… waleedlatif1 Aug 19, 2026 https://github.com/simstudioai/sim/pull/6837/commits/88cffc31a08ae3ee23a33cff2e4bb8e98ab9adfd
Clear filters https://github.com/simstudioai/sim/pull/6837/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6837/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6837/files
consent-preferences.tsx https://github.com/simstudioai/sim/pull/6837/files#diff-2ea8561e49bde236453a073745811671eff69c88620ebc73e562bca1036ccc0e
page.tsx https://github.com/simstudioai/sim/pull/6837/files#diff-9237dd5eb61b0ca8ac0bdbf17fba44956afe465cddafcc49e6744dc7c6bde7e1
settings.tsx https://github.com/simstudioai/sim/pull/6837/files#diff-a82a043ca7a7736b97bf6a5385a54339c186c7a782a1bd4d3e61c87c6ac2975d
cookie-preferences.test.tsx https://github.com/simstudioai/sim/pull/6837/files#diff-f2a7d83558392775b9f5983bf410a26187349835e0df1a13213f9cd450861568
cookie-preferences.tsx https://github.com/simstudioai/sim/pull/6837/files#diff-c04a0e43ada1dc8ad1bebf243f0762d3680b41a93b5596ac534ee51d3a79382a
privacy-view.tsx https://github.com/simstudioai/sim/pull/6837/files#diff-b922a86111681f13a12583e45ddfeda64d7afd34821ad5dd8cbb5325a50142f7
general.tsx https://github.com/simstudioai/sim/pull/6837/files#diff-1399306bf79ad53ce246baccbfae7d3037e74a2b52fc447a212261f6d1940867
search-params.ts https://github.com/simstudioai/sim/pull/6837/files#diff-1c920ba13e123b600fc33662081a4f67b7bfaf7152edcc34d7226e89cee1c129
privacy.test.tsx https://github.com/simstudioai/sim/pull/6837/files#diff-18c5a3f2e12cf8a4828f5718961aa73c97bd809deec171170ce039a87f1ba1d9
privacy.tsx https://github.com/simstudioai/sim/pull/6837/files#diff-7d60e8b9cb77b8f6d7ac99e33d1e0cf6b19f210967bca54750050bd07d4a4350
navigation.test.ts https://github.com/simstudioai/sim/pull/6837/files#diff-4e76e2b7b0672536b8ca63b35adbfa378d8dc181b46da8b982bf6a117af68258
navigation.test.ts https://github.com/simstudioai/sim/pull/6837/files#diff-62686a474bf0fd1ca1f7d5ad4b2652b3a9dcdedc6e9a128f8fad75b1315f4ae3
navigation.ts https://github.com/simstudioai/sim/pull/6837/files#diff-a7b9aa7de628a7c413599eb668d16b706165d104e5913308c2ef6f9253e3f272
apps/sim/app/_shell/consent/consent-preferences.tsxhttps://github.com/simstudioai/sim/pull/6837/files#diff-2ea8561e49bde236453a073745811671eff69c88620ebc73e562bca1036ccc0e
View file https://github.com/simstudioai/sim/blob/88cffc31a08ae3ee23a33cff2e4bb8e98ab9adfd/apps/sim/app/_shell/consent/consent-preferences.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6837/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6837/files#diff-2ea8561e49bde236453a073745811671eff69c88620ebc73e562bca1036ccc0e
https://github.com/simstudioai/sim/pull/6837/files#diff-2ea8561e49bde236453a073745811671eff69c88620ebc73e562bca1036ccc0e
https://github.com/simstudioai/sim/pull/6837/files#diff-2ea8561e49bde236453a073745811671eff69c88620ebc73e562bca1036ccc0e
apps/sim/app/workspace/[workspaceId]/settings/[section]/page.tsxhttps://github.com/simstudioai/sim/pull/6837/files#diff-9237dd5eb61b0ca8ac0bdbf17fba44956afe465cddafcc49e6744dc7c6bde7e1
View file https://github.com/simstudioai/sim/blob/88cffc31a08ae3ee23a33cff2e4bb8e98ab9adfd/apps/sim/app/workspace/%5BworkspaceId%5D/settings/%5Bsection%5D/page.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6837/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6837/files#diff-9237dd5eb61b0ca8ac0bdbf17fba44956afe465cddafcc49e6744dc7c6bde7e1
https://github.com/simstudioai/sim/pull/6837/files#diff-9237dd5eb61b0ca8ac0bdbf17fba44956afe465cddafcc49e6744dc7c6bde7e1
apps/sim/app/workspace/[workspaceId]/settings/[section]/settings.tsxhttps://github.com/simstudioai/sim/pull/6837/files#diff-a82a043ca7a7736b97bf6a5385a54339c186c7a782a1bd4d3e61c87c6ac2975d
View file https://github.com/simstudioai/sim/blob/88cffc31a08ae3ee23a33cff2e4bb8e98ab9adfd/apps/sim/app/workspace/%5BworkspaceId%5D/settings/%5Bsection%5D/settings.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6837/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6837/files#diff-a82a043ca7a7736b97bf6a5385a54339c186c7a782a1bd4d3e61c87c6ac2975d
https://github.com/simstudioai/sim/pull/6837/files#diff-a82a043ca7a7736b97bf6a5385a54339c186c7a782a1bd4d3e61c87c6ac2975d
https://github.com/simstudioai/sim/pull/6837/files#diff-a82a043ca7a7736b97bf6a5385a54339c186c7a782a1bd4d3e61c87c6ac2975d
https://github.com/simstudioai/sim/pull/6837/files#diff-a82a043ca7a7736b97bf6a5385a54339c186c7a782a1bd4d3e61c87c6ac2975d
https://github.com/simstudioai/sim/pull/6837/files#diff-a82a043ca7a7736b97bf6a5385a54339c186c7a782a1bd4d3e61c87c6ac2975d
Please reload this pagehttps://github.com/simstudioai/sim/pull/6837/files
https://github.com/simstudioai/sim/pull/6837/files#diff-a82a043ca7a7736b97bf6a5385a54339c186c7a782a1bd4d3e61c87c6ac2975d
https://github.com/simstudioai/sim/pull/6837/files#diff-a82a043ca7a7736b97bf6a5385a54339c186c7a782a1bd4d3e61c87c6ac2975d
...orkspace/[workspaceId]/settings/components/general/components/cookie-preferences.test.tsxhttps://github.com/simstudioai/sim/pull/6837/files#diff-f2a7d83558392775b9f5983bf410a26187349835e0df1a13213f9cd450861568
View file https://github.com/simstudioai/sim/blob/88cffc31a08ae3ee23a33cff2e4bb8e98ab9adfd/apps/sim/app/workspace/%5BworkspaceId%5D/settings/components/general/components/cookie-preferences.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6837/{{ revealButtonHref }}
...app/workspace/[workspaceId]/settings/components/general/components/cookie-preferences.tsxhttps://github.com/simstudioai/sim/pull/6837/files#diff-c04a0e43ada1dc8ad1bebf243f0762d3680b41a93b5596ac534ee51d3a79382a
View file https://github.com/simstudioai/sim/blob/88cffc31a08ae3ee23a33cff2e4bb8e98ab9adfd/apps/sim/app/workspace/%5BworkspaceId%5D/settings/components/general/components/cookie-preferences.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6837/{{ revealButtonHref }}
apps/sim/app/workspace/[workspaceId]/settings/components/general/components/privacy-view.tsxhttps://github.com/simstudioai/sim/pull/6837/files#diff-b922a86111681f13a12583e45ddfeda64d7afd34821ad5dd8cbb5325a50142f7
View file https://github.com/simstudioai/sim/blob/88cffc31a08ae3ee23a33cff2e4bb8e98ab9adfd/apps/sim/app/workspace/%5BworkspaceId%5D/settings/components/general/components/privacy-view.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6837/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/6837/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6837/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6837/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.