René's URL Explorer Experiment


Title: feat(consent): manage cookies from Settings, not from a card in the workspace by waleedlatif1 · Pull Request #6835 · simstudioai/sim · GitHub

Open Graph Title: feat(consent): manage cookies from Settings, not from a card in the workspace by waleedlatif1 · Pull Request #6835 · simstudioai/sim

X Title: feat(consent): manage cookies from Settings, not from a card in the workspace by waleedlatif1 · Pull Request #6835 · simstudioai/sim

Description: Summary Follow-up to #6832. The consent banner mounted in the root layout, so it appeared on every page — including inside the product. This moves in-app consent to Settings and fixes the theme mismatch the banner was working around rather than papering over it. The banner never appears in the workspace ConsentProvider returns before the dynamic() boundary on any /workspace path, so the product pays neither the consent chunk nor its init request — the surface with the most hard page loads. Gating inside the lazily-loaded module would still have downloaded it. Consent inside the product is managed from Settings → Privacy instead, which is the documented pattern for authenticated surfaces: a floating card is the wrong shape once someone is signed in. One store, structurally The banner sits behind an ssr: false boundary that cannot wrap the app, so nothing reaches its store through React context. Both surfaces therefore mount their own provider — but getOrCreateConsentRuntime caches manager and store by the option values, so they share one of each. CONSENT_OPTIONS now lives inside ConsentStoreProvider and is not exported, which makes that invariant unbreakable rather than conventional. Verified directly rather than trusting the docs: same store instance: true same manager instance: true different backendURL -> different store: true The theme fix, at the cause The banner previously pinned the light token layer with a comment explaining why. The actual problem is that LandingShell pins light on a wrapper inside the page while keeps the visitor's theme, so any landing route missing from ThemeProvider's hand-written list rendered a light page under dark root chrome — scrollbars, color-scheme, and anything portalled to . LANDING_ROUTES becomes one source of truth in lib/landing/routes.ts, read by both next.config.ts (COEP exemptions) and ThemeProvider (forced light). That is the same drift that let /cookie-policy ship without its COEP exemption in the last PR. The banner now simply inherits the theme. Two pre-existing gaps closed along the way: /cli/auth and /credential-groups/complete both render AuthShell (which pins light) and were in neither list. Type of Change New feature Bug fix Testing type-check, lint:check, all 29 check:audits, and 155 tests pass. Diffed forced-light behavior old vs new across every real route: 16 landing routes gain the correct theme, nothing regresses in the other direction. Browser-verified the theme inheritance: /pricing under a dark system theme renders with a light card; /playground renders with a #1b1b1b card. The banner no longer decides for itself. /workspace needs auth, so the gate is covered by tests asserting the dynamic loader is never invoked on /workspace, /workspace/abc, /workspace/abc/logs — verified those fail when the gate is removed. Reviewers should focus on the ThemeProvider change: it moves from startsWith prefix matching to first-segment set membership, and that route-classification diff is the riskiest part of this PR. Known gap (unchanged from #6832) Prior blocking is still not implemented — GTM, GA, and PostHog load before consent. This PR makes that more load-bearing, not less: a visitor who reaches the workspace with no consent record is now never prompted. It closes properly when the analytics scripts move behind consent, since nothing non-essential loads without a record at all. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-up to #6832. The consent banner mounted in the root layout, so it appeared on every page — including inside the product. This moves in-app consent to Settings and fixes the theme mis...

X Description: Summary Follow-up to #6832. The consent banner mounted in the root layout, so it appeared on every page — including inside the product. This moves in-app consent to Settings and fixes the theme mis...

Opengraph URL: https://github.com/simstudioai/sim/pull/6835

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fac6c618-798e-7ea9-88c5-6671089a4c31
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8518:F138D:E25616:135D1AC:6AFB5D55
html-safe-noncec4ebb9769c3ee3a4e8800e8f6cf5de6ad6606509f2b7b72279b969ca432ecf4b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTE4OkYxMzhEOkUyNTYxNjoxMzVEMUFDOjZBRkI1RDU1IiwidmlzaXRvcl9pZCI6IjY2NDcxMTEyOTE0MTAwMTM1MjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac28b7dc0100f0d276e9d9483cb785958c2be6b079d0f831f553a7f0bd102c5564
hovercard-subject-tagpull_request:4309694015
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6835/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up to #6832. The consent banner mounted in the root layout, so it appeared on every page — including inside the product. This moves in-app consent to Settings and fixes the theme mis...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6835/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6835%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6835%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6835/files
Reloadhttps://github.com/simstudioai/sim/pull/6835/files
Reloadhttps://github.com/simstudioai/sim/pull/6835/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
feat/consent-in-app-settingshttps://github.com/simstudioai/sim/tree/feat/consent-in-app-settings
Conversation 10 https://github.com/simstudioai/sim/pull/6835
Commits 2 https://github.com/simstudioai/sim/pull/6835/commits
Checks 30 https://github.com/simstudioai/sim/pull/6835/checks
Files changed https://github.com/simstudioai/sim/pull/6835/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6835/files
feat(consent): manage cookies from Settings, not from a card in the workspace https://github.com/simstudioai/sim/pull/6835/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/6835/files
3445206 feat(consent): manage cookies from Settings, never from a card in the… waleedlatif1 Aug 19, 2026 https://github.com/simstudioai/sim/pull/6835/commits/34452060f60962ea0372ee294201131d4ff25a99
15dd69a fix(consent): keep Privacy on one settings surface waleedlatif1 Aug 19, 2026 https://github.com/simstudioai/sim/pull/6835/commits/15dd69a8d57dadd7f1a3f13b5ef93e6359e693cb
Clear filters https://github.com/simstudioai/sim/pull/6835/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6835/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6835/files
consent-banner.tsx https://github.com/simstudioai/sim/pull/6835/files#diff-2bf236bc1bf6e9b9f559732c18a782041fe6c155c680172c096c673a4ca56c43
consent-preferences.tsx https://github.com/simstudioai/sim/pull/6835/files#diff-2ea8561e49bde236453a073745811671eff69c88620ebc73e562bca1036ccc0e
consent-provider.test.tsx https://github.com/simstudioai/sim/pull/6835/files#diff-a116e97be3fc9f00860b3d20245c883f6e34fef130e49f8c42fa866d8a004a0c
consent-provider.tsx https://github.com/simstudioai/sim/pull/6835/files#diff-cf59dd67f35b66a08c0b395aedd026b64e47887a98e3b1c440769d3413f5e017
consent-runtime.tsx https://github.com/simstudioai/sim/pull/6835/files#diff-10d3002970786f8042b04164f679b7a4ae8e554cef4304664cafac473d9d85f2
consent-store-provider.test.tsx https://github.com/simstudioai/sim/pull/6835/files#diff-84aafeda6a03c316cd5bf9784c606a96f4aad12a236965cab9fadb5e96a01493
consent-store-provider.tsx https://github.com/simstudioai/sim/pull/6835/files#diff-fe8c973bc2fc7b3460cd4918a7aac533807a7e4e2d6972453c6b5ca2bb182c29
theme-provider.tsx https://github.com/simstudioai/sim/pull/6835/files#diff-852cf6a429eb73b154b1f2c62562f66c755f2d27b75433eb3bb6165b31039dc7
settings.tsx https://github.com/simstudioai/sim/pull/6835/files#diff-a82a043ca7a7736b97bf6a5385a54339c186c7a782a1bd4d3e61c87c6ac2975d
privacy.test.tsx https://github.com/simstudioai/sim/pull/6835/files#diff-18c5a3f2e12cf8a4828f5718961aa73c97bd809deec171170ce039a87f1ba1d9
privacy.tsx https://github.com/simstudioai/sim/pull/6835/files#diff-7d60e8b9cb77b8f6d7ac99e33d1e0cf6b19f210967bca54750050bd07d4a4350
navigation.test.ts https://github.com/simstudioai/sim/pull/6835/files#diff-4e76e2b7b0672536b8ca63b35adbfa378d8dc181b46da8b982bf6a117af68258
navigation.test.ts https://github.com/simstudioai/sim/pull/6835/files#diff-62686a474bf0fd1ca1f7d5ad4b2652b3a9dcdedc6e9a128f8fad75b1315f4ae3
navigation.ts https://github.com/simstudioai/sim/pull/6835/files#diff-a7b9aa7de628a7c413599eb668d16b706165d104e5913308c2ef6f9253e3f272
routes.ts https://github.com/simstudioai/sim/pull/6835/files#diff-4af1dd539527ea7c9c59866afe90f2000cce0bd6885a3728212e5cae64a859ec
next.config.ts https://github.com/simstudioai/sim/pull/6835/files#diff-a2e0d564b8bf660a492f7abe431643db390b0f5696809465afc46475f552f15f
apps/sim/app/_shell/consent/consent-banner.tsxhttps://github.com/simstudioai/sim/pull/6835/files#diff-2bf236bc1bf6e9b9f559732c18a782041fe6c155c680172c096c673a4ca56c43
View file https://github.com/simstudioai/sim/blob/15dd69a8d57dadd7f1a3f13b5ef93e6359e693cb/apps/sim/app/_shell/consent/consent-banner.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6835/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6835/files#diff-2bf236bc1bf6e9b9f559732c18a782041fe6c155c680172c096c673a4ca56c43
https://github.com/simstudioai/sim/pull/6835/files#diff-2bf236bc1bf6e9b9f559732c18a782041fe6c155c680172c096c673a4ca56c43
https://github.com/simstudioai/sim/pull/6835/files#diff-2bf236bc1bf6e9b9f559732c18a782041fe6c155c680172c096c673a4ca56c43
https://github.com/simstudioai/sim/pull/6835/files#diff-2bf236bc1bf6e9b9f559732c18a782041fe6c155c680172c096c673a4ca56c43
apps/sim/app/_shell/consent/consent-preferences.tsxhttps://github.com/simstudioai/sim/pull/6835/files#diff-2ea8561e49bde236453a073745811671eff69c88620ebc73e562bca1036ccc0e
View file https://github.com/simstudioai/sim/blob/15dd69a8d57dadd7f1a3f13b5ef93e6359e693cb/apps/sim/app/_shell/consent/consent-preferences.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6835/{{ revealButtonHref }}
apps/sim/app/_shell/consent/consent-provider.test.tsxhttps://github.com/simstudioai/sim/pull/6835/files#diff-a116e97be3fc9f00860b3d20245c883f6e34fef130e49f8c42fa866d8a004a0c
View file https://github.com/simstudioai/sim/blob/15dd69a8d57dadd7f1a3f13b5ef93e6359e693cb/apps/sim/app/_shell/consent/consent-provider.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6835/{{ revealButtonHref }}
apps/sim/app/_shell/consent/consent-provider.tsxhttps://github.com/simstudioai/sim/pull/6835/files#diff-cf59dd67f35b66a08c0b395aedd026b64e47887a98e3b1c440769d3413f5e017
View file https://github.com/simstudioai/sim/blob/15dd69a8d57dadd7f1a3f13b5ef93e6359e693cb/apps/sim/app/_shell/consent/consent-provider.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6835/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/6835/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6835/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.