René's URL Explorer Experiment


Title: improvement(ui): give the two full-screen takeovers named design-system layers by waleedlatif1 · Pull Request #6829 · simstudioai/sim · GitHub

Open Graph Title: improvement(ui): give the two full-screen takeovers named design-system layers by waleedlatif1 · Pull Request #6829 · simstudioai/sim

X Title: improvement(ui): give the two full-screen takeovers named design-system layers by waleedlatif1 · Pull Request #6829 · simstudioai/sim

Description: Summary The app has exactly two full-screen takeovers — the session-expired screen and the desktop minimum-version gate — and they disagreed on every piece of chrome: an ad-hoc z-[9999] against a z-50 that sat below --z-dropdown, --bg against --surface-1, a legacy Button against a Chip, and muted grey on their failure copy. The z-index was a real bug, not just an inconsistency. At z-50 the session-expired takeover rendered underneath the desktop browser panel's replacement snapshot, which paints at calc(var(--z-modal) - 1). Adds two named layers above the poppers rather than one shared layer: --z-takeover: 500 for in-app takeovers, --z-shell-gate: 600 for the desktop shell gate. The gate mounts earlier in the tree than the session screen, so a single shared layer would have let document order decide which wins — silently reversing the precedence the old z-[9999]/z-50 pair had. An incompatible shell invalidates everything the web app renders inside it, so it outranks. Both takeovers hid their pre-paint state with opacity: 0, which still hit-tests, so a full-viewport surface could swallow clicks before it painted. They now use the visibility toggle ModalContent already uses for the same handshake. Aligns their background, primary action, body-copy and error tokens, and corrects the z-scale in the design-review skill, which listed --z-toast at 500 when it has long been 150. Type of Change Bug fix Testing 85 tests across both takeovers, the workspace layout and the desktop lib pass; bun run type-check, bun run lint, bun run check:audits (29/29) and the block-registry check all pass Verified both tokens are defined once in the unconditional :root, so they resolve in both themes, and that --text-error / --text-secondary exist in both Swept for anything rendering above 400: the five hits are pre-existing ad-hoc z-index values on transient in-workspace surfaces, all already above the old z-[9999] and z-50, so this is not a regression — worth a separate cleanup Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The app has exactly two full-screen takeovers — the session-expired screen and the desktop minimum-version gate — and they disagreed on every piece of chrome: an ad-hoc z-[9999] against a ...

X Description: Summary The app has exactly two full-screen takeovers — the session-expired screen and the desktop minimum-version gate — and they disagreed on every piece of chrome: an ad-hoc z-[9999] against a ...

Opengraph URL: https://github.com/simstudioai/sim/pull/6829

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:69571c75-34d6-3834-19bd-30b5c6a7d4a3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA456:267719:E084AC:1339954:6AFB5D86
html-safe-noncef0f92ea827cb8a0f133cd64a94bb5cc270d3ee9c69ca2c623093043e68500f00
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDU2OjI2NzcxOTpFMDg0QUM6MTMzOTk1NDo2QUZCNUQ4NiIsInZpc2l0b3JfaWQiOiIzODg0NDUyODAzMjI0NzU1NTkwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacee4102199920c92eb41c341c4bdca426a7ab108d021977b3d6e4861fc6d5c789
hovercard-subject-tagpull_request:4309140880
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6829/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The app has exactly two full-screen takeovers — the session-expired screen and the desktop minimum-version gate — and they disagreed on every piece of chrome: an ad-hoc z-[9999] against a ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6829/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6829%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6829%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6829/files
Reloadhttps://github.com/simstudioai/sim/pull/6829/files
Reloadhttps://github.com/simstudioai/sim/pull/6829/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/takeover-emcn-alignmenthttps://github.com/simstudioai/sim/tree/fix/takeover-emcn-alignment
Conversation 8 https://github.com/simstudioai/sim/pull/6829
Commits 2 https://github.com/simstudioai/sim/pull/6829/commits
Checks 31 https://github.com/simstudioai/sim/pull/6829/checks
Files changed https://github.com/simstudioai/sim/pull/6829/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6829/files
improvement(ui): give the two full-screen takeovers named design-system layers https://github.com/simstudioai/sim/pull/6829/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/6829/files
77ec26b improvement(ui): align the two full-screen takeovers on one design-sy… waleedlatif1 Aug 18, 2026 https://github.com/simstudioai/sim/pull/6829/commits/77ec26b7fbc2601edbe4ceae5228ac9b6603aaed
c809b1d fix(ui): keep the shell gate above in-app takeovers and stop pre-pain… waleedlatif1 Aug 18, 2026 https://github.com/simstudioai/sim/pull/6829/commits/c809b1dcefe38c6a15af3431dc27c1574f34bd43
Clear filters https://github.com/simstudioai/sim/pull/6829/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6829/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6829/files
SKILL.md https://github.com/simstudioai/sim/pull/6829/files#diff-a4f57e3d69c02e699f31279795e33b3b11ee0cd4e546580f263ffe1c0a9c4b0b
desktop-update-gate.tsx https://github.com/simstudioai/sim/pull/6829/files#diff-2e18525ddcc2ecf60b5ab0e15a9150378b9fb3a0d267b6575296d2c296ea55a2
globals.css https://github.com/simstudioai/sim/pull/6829/files#diff-a39154a049a8386121aeb235168db7af1a32dc7720f223bce3b809f4aebca0a9
session-expired.tsx https://github.com/simstudioai/sim/pull/6829/files#diff-1991be19dc58415c73d71065e3eef6f0c640c8776e89bce110d75a6523db51ae
.agents/skills/emcn-design-review/SKILL.mdhttps://github.com/simstudioai/sim/pull/6829/files#diff-a4f57e3d69c02e699f31279795e33b3b11ee0cd4e546580f263ffe1c0a9c4b0b
View file https://github.com/simstudioai/sim/blob/c809b1dcefe38c6a15af3431dc27c1574f34bd43/.agents/skills/emcn-design-review/SKILL.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6829/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6829/files#diff-a4f57e3d69c02e699f31279795e33b3b11ee0cd4e546580f263ffe1c0a9c4b0b
https://github.com/simstudioai/sim/pull/6829/files#diff-a4f57e3d69c02e699f31279795e33b3b11ee0cd4e546580f263ffe1c0a9c4b0b
apps/sim/app/_shell/desktop-update-gate.tsxhttps://github.com/simstudioai/sim/pull/6829/files#diff-2e18525ddcc2ecf60b5ab0e15a9150378b9fb3a0d267b6575296d2c296ea55a2
View file https://github.com/simstudioai/sim/blob/c809b1dcefe38c6a15af3431dc27c1574f34bd43/apps/sim/app/_shell/desktop-update-gate.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6829/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6829/files#diff-2e18525ddcc2ecf60b5ab0e15a9150378b9fb3a0d267b6575296d2c296ea55a2
https://github.com/simstudioai/sim/pull/6829/files#diff-2e18525ddcc2ecf60b5ab0e15a9150378b9fb3a0d267b6575296d2c296ea55a2
https://github.com/simstudioai/sim/pull/6829/files#diff-2e18525ddcc2ecf60b5ab0e15a9150378b9fb3a0d267b6575296d2c296ea55a2
https://github.com/simstudioai/sim/pull/6829/files#diff-2e18525ddcc2ecf60b5ab0e15a9150378b9fb3a0d267b6575296d2c296ea55a2
https://github.com/simstudioai/sim/pull/6829/files#diff-2e18525ddcc2ecf60b5ab0e15a9150378b9fb3a0d267b6575296d2c296ea55a2
https://github.com/simstudioai/sim/pull/6829/files#diff-2e18525ddcc2ecf60b5ab0e15a9150378b9fb3a0d267b6575296d2c296ea55a2
https://github.com/simstudioai/sim/pull/6829/files#diff-2e18525ddcc2ecf60b5ab0e15a9150378b9fb3a0d267b6575296d2c296ea55a2
apps/sim/app/_styles/globals.csshttps://github.com/simstudioai/sim/pull/6829/files#diff-a39154a049a8386121aeb235168db7af1a32dc7720f223bce3b809f4aebca0a9
View file https://github.com/simstudioai/sim/blob/c809b1dcefe38c6a15af3431dc27c1574f34bd43/apps/sim/app/_styles/globals.css
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6829/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6829/files#diff-a39154a049a8386121aeb235168db7af1a32dc7720f223bce3b809f4aebca0a9
https://github.com/simstudioai/sim/pull/6829/files#diff-a39154a049a8386121aeb235168db7af1a32dc7720f223bce3b809f4aebca0a9
apps/sim/app/workspace/[workspaceId]/components/session-expired/session-expired.tsxhttps://github.com/simstudioai/sim/pull/6829/files#diff-1991be19dc58415c73d71065e3eef6f0c640c8776e89bce110d75a6523db51ae
View file https://github.com/simstudioai/sim/blob/c809b1dcefe38c6a15af3431dc27c1574f34bd43/apps/sim/app/workspace/%5BworkspaceId%5D/components/session-expired/session-expired.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6829/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6829/files#diff-1991be19dc58415c73d71065e3eef6f0c640c8776e89bce110d75a6523db51ae
https://github.com/simstudioai/sim/pull/6829/files#diff-1991be19dc58415c73d71065e3eef6f0c640c8776e89bce110d75a6523db51ae
Please reload this pagehttps://github.com/simstudioai/sim/pull/6829/files
https://github.com/simstudioai/sim/pull/6829/files#diff-1991be19dc58415c73d71065e3eef6f0c640c8776e89bce110d75a6523db51ae
Please reload this pagehttps://github.com/simstudioai/sim/pull/6829/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.