René's URL Explorer Experiment


Title: fix(credential-groups): pin the clock in the enrollment tests by waleedlatif1 · Pull Request #6812 · simstudioai/sim · GitHub

Open Graph Title: fix(credential-groups): pin the clock in the enrollment tests by waleedlatif1 · Pull Request #6812 · simstudioai/sim

X Title: fix(credential-groups): pin the clock in the enrollment tests by waleedlatif1 · Pull Request #6812 · simstudioai/sim

Description: Summary apps/sim/lib/credential-groups/enrollments.test.ts had a time bomb that has now gone off. It blocks CI on every branch, not just this one. ENROLLMENT.invitationExpiresAt was hardcoded to 2026-08-18T12:00:00.000Z, and completeCredentialGroupEnrollment compares it against the wall clock. Before that instant the invitation was valid and the suite passed; after it, the invitation is expired, the function returns null, and two tests fail. The evidence is a single unchanged commit running twice: Run Time enrollments.test.ts First 2026-08-18T07:21Z 11 passed Re-run 2026-08-18T14:55Z 11 tests, 2 failed Same SHA, same base, no code change between them — only the clock moved past 12:00Z. Confirmed locally: on clean origin/staging the two tests fail deterministically; re-dating the fixture to 2027 makes all 11 pass. Fix Pin the clock to a point inside the invitation window rather than re-dating the fixture: const NOW = new Date('2026-08-11T12:10:00.000Z') beforeEach(() => { vi.useFakeTimers({ shouldAdvanceTime: true }) vi.setSystemTime(NOW) }) afterEach(() => { vi.useRealTimers() }) Every existing date literal keeps its meaning, and the suite stops depending on when it runs. Bumping the date to a later instant would only re-arm the same failure. Type of Change Bug fix (broken CI) Testing lib/credential-groups — 63 tests across 13 files pass. type-check clean, lint clean. Verified the cause by moving the fixture date forward and back. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary apps/sim/lib/credential-groups/enrollments.test.ts had a time bomb that has now gone off. It blocks CI on every branch, not just this one. ENROLLMENT.invitationExpiresAt was hardcoded to 20...

X Description: Summary apps/sim/lib/credential-groups/enrollments.test.ts had a time bomb that has now gone off. It blocks CI on every branch, not just this one. ENROLLMENT.invitationExpiresAt was hardcoded to 20...

Opengraph URL: https://github.com/simstudioai/sim/pull/6812

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:202f8503-4bc0-8cb5-47cf-04a1e3cfa4df
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA954:1A169A:26289A:35A64E:6AFB5288
html-safe-noncebcb6c0e4c03cd1d5ff7bde390e8e72675830abded80efd3ffae9b5e8ace0e2aa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTU0OjFBMTY5QToyNjI4OUE6MzVBNjRFOjZBRkI1Mjg4IiwidmlzaXRvcl9pZCI6IjEwMzMxMDAwMjM0NDY1OTAwODgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace638fa8670d5ee2d22cd05609c34952fe4d74d7482a714fc924881e93608aca5
hovercard-subject-tagpull_request:4305802733
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6812/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary apps/sim/lib/credential-groups/enrollments.test.ts had a time bomb that has now gone off. It blocks CI on every branch, not just this one. ENROLLMENT.invitationExpiresAt was hardcoded to 20...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6812/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6812%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6812%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6812/files
Reloadhttps://github.com/simstudioai/sim/pull/6812/files
Reloadhttps://github.com/simstudioai/sim/pull/6812/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/enrollment-test-time-bombhttps://github.com/simstudioai/sim/tree/fix/enrollment-test-time-bomb
Conversation 3 https://github.com/simstudioai/sim/pull/6812
Commits 1 https://github.com/simstudioai/sim/pull/6812/commits
Checks 30 https://github.com/simstudioai/sim/pull/6812/checks
Files changed https://github.com/simstudioai/sim/pull/6812/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6812/files
fix(credential-groups): pin the clock in the enrollment tests https://github.com/simstudioai/sim/pull/6812/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6812/files
1aa8014 fix(credential-groups): pin the clock in the enrollment tests waleedlatif1 Aug 18, 2026 https://github.com/simstudioai/sim/pull/6812/commits/1aa8014f2faa7d5fd837b5125289401a50e82c5e
Clear filters https://github.com/simstudioai/sim/pull/6812/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6812/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6812/files
apps/sim/lib/credential-groups/enrollments.test.tshttps://github.com/simstudioai/sim/pull/6812/files#diff-4b50546fa581ea494012fd5e80663cb3c87a6cc86ef45462b28b144bb84125cc
View file https://github.com/simstudioai/sim/blob/1aa8014f2faa7d5fd837b5125289401a50e82c5e/apps/sim/lib/credential-groups/enrollments.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6812/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6812/files#diff-4b50546fa581ea494012fd5e80663cb3c87a6cc86ef45462b28b144bb84125cc
https://github.com/simstudioai/sim/pull/6812/files#diff-4b50546fa581ea494012fd5e80663cb3c87a6cc86ef45462b28b144bb84125cc
https://github.com/simstudioai/sim/pull/6812/files#diff-4b50546fa581ea494012fd5e80663cb3c87a6cc86ef45462b28b144bb84125cc
https://github.com/simstudioai/sim/pull/6812/files#diff-4b50546fa581ea494012fd5e80663cb3c87a6cc86ef45462b28b144bb84125cc
Please reload this pagehttps://github.com/simstudioai/sim/pull/6812/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.