René's URL Explorer Experiment


Title: test(table): pin the row-write behavior the suite could not fail on by waleedlatif1 · Pull Request #6811 · simstudioai/sim · GitHub

Open Graph Title: test(table): pin the row-write behavior the suite could not fail on by waleedlatif1 · Pull Request #6811 · simstudioai/sim

X Title: test(table): pin the row-write behavior the suite could not fail on by waleedlatif1 · Pull Request #6811 · simstudioai/sim

Description: Summary Follow-up to #6808/#6809. A mutation-testing pass over that work found four changes that could be reverted with the whole suite green, plus two comments asserting something untrue. This pins them. Copilot row writes now assert the translated storage keys rather than the keying flag. The shared table fixture uses legacy columns with no id, where name-to-id mapping is the identity, so the wrong keying was unobservable; columns whose id differs from name make it fail. Copilot is the one row-write surface whose column keys come from a model, and under id keying the lax write path stores those keys verbatim and reports success — a silent row corruption. The three provenance transport helpers get direct cover. The route tests only reach mapInput and present, so each helper could be replaced by a constant, and a constant envelope reader silently downgrades every executor write from a stamped bundle to untracked. The domain provenance fixtures run against the real envelope guard instead of a stub that always accepted them. None of the old fixtures was a shape the guard admits, so the happy path had never been exercised. The attribution allowlist keys on the client-id reader rather than the field name, so it no longer misses a surface that names the acting tab positionally — one of the two real suppliers was already invisible to it. Restores the selectedValues narrowing on the migrated row routes, so a stale sidecar entry for a dropped column no longer rides along in the provenance envelope. Matches what the unmigrated rows/query routes have always done. Adds a compile-time tie between the shared table fixture and TableDefinition. tsconfig excludes test files, so an assertion placed in one is never checked — a new required field was a production type error and a silent no-op across every route test. The probe is type-only so the @sim/testing devDependency never becomes a runtime import. Corrects the getRowSummaryById TSDoc, which claimed the Copilot row tool never put executions on the wire. It did; that narrowing is a deliberate wire change rather than a pure saving. Type of Change Test coverage Bug fix (provenance envelope narrowing) Testing 1,975 tests pass across lib/table, app/api/table, lib/copilot/tools/server/table, app/api/v2/tables and lib/api/server/routes. type-check clean, all 29 audits pass. Every new test is mutation-verified — the behavior was reverted and the covering test confirmed to go red. The keying mutation reproduces the corruption exactly: { name: 'Grace' } stored where { col_name: 'Grace' } was meant. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-up to #6808/#6809. A mutation-testing pass over that work found four changes that could be reverted with the whole suite green, plus two comments asserting something untrue. This pin...

X Description: Summary Follow-up to #6808/#6809. A mutation-testing pass over that work found four changes that could be reverted with the whole suite green, plus two comments asserting something untrue. This pin...

Opengraph URL: https://github.com/simstudioai/sim/pull/6811

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:40a73730-49b6-dfe1-b7ee-d537142a847d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB4AE:D16D6:A46E8E:E278A9:6AFB51C8
html-safe-nonce7fbef093cb0806d24e8113d045e18ba22c46d5fe557bf7e94ce929940b01e8ae
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEFFOkQxNkQ2OkE0NkU4RTpFMjc4QTk6NkFGQjUxQzgiLCJ2aXNpdG9yX2lkIjoiMzYyMjA3MDI0NDYzNTAwNTM4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4ac899e407a7c8aff7da62ee0ea459cd17bfb854ea76ea021f939edce86f7623
hovercard-subject-tagpull_request:4302370924
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6811/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up to #6808/#6809. A mutation-testing pass over that work found four changes that could be reverted with the whole suite green, plus two comments asserting something untrue. This pin...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6811/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6811%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6811%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6811/files
Reloadhttps://github.com/simstudioai/sim/pull/6811/files
Reloadhttps://github.com/simstudioai/sim/pull/6811/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/table-row-write-test-coveragehttps://github.com/simstudioai/sim/tree/fix/table-row-write-test-coverage
Conversation 7 https://github.com/simstudioai/sim/pull/6811
Commits 2 https://github.com/simstudioai/sim/pull/6811/commits
Checks 30 https://github.com/simstudioai/sim/pull/6811/checks
Files changed https://github.com/simstudioai/sim/pull/6811/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6811/files
test(table): pin the row-write behavior the suite could not fail on https://github.com/simstudioai/sim/pull/6811/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/6811/files
0555030 test(table): pin the row-write behavior the suite could not fail on waleedlatif1 Aug 18, 2026 https://github.com/simstudioai/sim/pull/6811/commits/0555030748b3a5d30597c41ea30f62c01ae8582a
a03e471 test(table): key the attribution audit on the write, not on the id re… waleedlatif1 Aug 18, 2026 https://github.com/simstudioai/sim/pull/6811/commits/a03e47112a048e4abd65a1de1bf61741d9d925cd
Clear filters https://github.com/simstudioai/sim/pull/6811/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6811/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6811/files
row-secret-provenance.test.ts https://github.com/simstudioai/sim/pull/6811/files#diff-07d8a5e5cd63e55499e0873212acf72627b2009d1426db13c659f627b64b3cf6
user-table.test.ts https://github.com/simstudioai/sim/pull/6811/files#diff-4344063d53b20a646a464951b8a78663e1ad34d63fb278d6e864db485bdc4920
row-secret-provenance.test.ts https://github.com/simstudioai/sim/pull/6811/files#diff-144b0c1f0114ff0623e66c7f133e21f278cb0c7c002bc16a7dfe07bb16307ebd
rows.test.ts https://github.com/simstudioai/sim/pull/6811/files#diff-4f91ef4046401cb100975937adc02bbe1b1eb74a0b78676413331558b6a5c70f
rows.ts https://github.com/simstudioai/sim/pull/6811/files#diff-54e60750fc863d4d4f70a80d2ae0f09bc223d6a42faf574f94f93fa8c935063b
events.attribution.test.ts https://github.com/simstudioai/sim/pull/6811/files#diff-e52fb0b21a18dd4954496acffcbd9323004d053b5516ae73fd6491f120b74078
fixture-contract.ts https://github.com/simstudioai/sim/pull/6811/files#diff-a16aba2512b8753e4213ccc3c0b39f3ff8713b93ae8666319cf0103de2ff230c
service.ts https://github.com/simstudioai/sim/pull/6811/files#diff-bb7e45c4b7c8d660db1d230975eb35231ae2616360572a342fd56d37296bb23f
apps/sim/app/api/table/row-secret-provenance.test.tshttps://github.com/simstudioai/sim/pull/6811/files#diff-07d8a5e5cd63e55499e0873212acf72627b2009d1426db13c659f627b64b3cf6
View file https://github.com/simstudioai/sim/blob/a03e47112a048e4abd65a1de1bf61741d9d925cd/apps/sim/app/api/table/row-secret-provenance.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6811/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6811/files#diff-07d8a5e5cd63e55499e0873212acf72627b2009d1426db13c659f627b64b3cf6
https://github.com/simstudioai/sim/pull/6811/files#diff-07d8a5e5cd63e55499e0873212acf72627b2009d1426db13c659f627b64b3cf6
https://github.com/simstudioai/sim/pull/6811/files#diff-07d8a5e5cd63e55499e0873212acf72627b2009d1426db13c659f627b64b3cf6
apps/sim/lib/copilot/tools/server/table/user-table.test.tshttps://github.com/simstudioai/sim/pull/6811/files#diff-4344063d53b20a646a464951b8a78663e1ad34d63fb278d6e864db485bdc4920
View file https://github.com/simstudioai/sim/blob/a03e47112a048e4abd65a1de1bf61741d9d925cd/apps/sim/lib/copilot/tools/server/table/user-table.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6811/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6811/files#diff-4344063d53b20a646a464951b8a78663e1ad34d63fb278d6e864db485bdc4920
https://github.com/simstudioai/sim/pull/6811/files#diff-4344063d53b20a646a464951b8a78663e1ad34d63fb278d6e864db485bdc4920
https://github.com/simstudioai/sim/pull/6811/files#diff-4344063d53b20a646a464951b8a78663e1ad34d63fb278d6e864db485bdc4920
https://github.com/simstudioai/sim/pull/6811/files#diff-4344063d53b20a646a464951b8a78663e1ad34d63fb278d6e864db485bdc4920
https://github.com/simstudioai/sim/pull/6811/files#diff-4344063d53b20a646a464951b8a78663e1ad34d63fb278d6e864db485bdc4920
https://github.com/simstudioai/sim/pull/6811/files#diff-4344063d53b20a646a464951b8a78663e1ad34d63fb278d6e864db485bdc4920
https://github.com/simstudioai/sim/pull/6811/files#diff-4344063d53b20a646a464951b8a78663e1ad34d63fb278d6e864db485bdc4920
Please reload this pagehttps://github.com/simstudioai/sim/pull/6811/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6811/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.