Title: test(table): pin the row-write behavior the suite could not fail on by waleedlatif1 · Pull Request #6811 · simstudioai/sim · GitHub
Open Graph Title: test(table): pin the row-write behavior the suite could not fail on by waleedlatif1 · Pull Request #6811 · simstudioai/sim
X Title: test(table): pin the row-write behavior the suite could not fail on by waleedlatif1 · Pull Request #6811 · simstudioai/sim
Description: Summary Follow-up to #6808/#6809. A mutation-testing pass over that work found four changes that could be reverted with the whole suite green, plus two comments asserting something untrue. This pins them. Copilot row writes now assert the translated storage keys rather than the keying flag. The shared table fixture uses legacy columns with no id, where name-to-id mapping is the identity, so the wrong keying was unobservable; columns whose id differs from name make it fail. Copilot is the one row-write surface whose column keys come from a model, and under id keying the lax write path stores those keys verbatim and reports success — a silent row corruption. The three provenance transport helpers get direct cover. The route tests only reach mapInput and present, so each helper could be replaced by a constant, and a constant envelope reader silently downgrades every executor write from a stamped bundle to untracked. The domain provenance fixtures run against the real envelope guard instead of a stub that always accepted them. None of the old fixtures was a shape the guard admits, so the happy path had never been exercised. The attribution allowlist keys on the client-id reader rather than the field name, so it no longer misses a surface that names the acting tab positionally — one of the two real suppliers was already invisible to it. Restores the selectedValues narrowing on the migrated row routes, so a stale sidecar entry for a dropped column no longer rides along in the provenance envelope. Matches what the unmigrated rows/query routes have always done. Adds a compile-time tie between the shared table fixture and TableDefinition. tsconfig excludes test files, so an assertion placed in one is never checked — a new required field was a production type error and a silent no-op across every route test. The probe is type-only so the @sim/testing devDependency never becomes a runtime import. Corrects the getRowSummaryById TSDoc, which claimed the Copilot row tool never put executions on the wire. It did; that narrowing is a deliberate wire change rather than a pure saving. Type of Change Test coverage Bug fix (provenance envelope narrowing) Testing 1,975 tests pass across lib/table, app/api/table, lib/copilot/tools/server/table, app/api/v2/tables and lib/api/server/routes. type-check clean, all 29 audits pass. Every new test is mutation-verified — the behavior was reverted and the covering test confirmed to go red. The keying mutation reproduces the corruption exactly: { name: 'Grace' } stored where { col_name: 'Grace' } was meant. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Follow-up to #6808/#6809. A mutation-testing pass over that work found four changes that could be reverted with the whole suite green, plus two comments asserting something untrue. This pin...
X Description: Summary Follow-up to #6808/#6809. A mutation-testing pass over that work found four changes that could be reverted with the whole suite green, plus two comments asserting something untrue. This pin...
Opengraph URL: https://github.com/simstudioai/sim/pull/6811
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:40a73730-49b6-dfe1-b7ee-d537142a847d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B4AE:D16D6:A46E8E:E278A9:6AFB51C8 |
| html-safe-nonce | 7fbef093cb0806d24e8113d045e18ba22c46d5fe557bf7e94ce929940b01e8ae |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEFFOkQxNkQ2OkE0NkU4RTpFMjc4QTk6NkFGQjUxQzgiLCJ2aXNpdG9yX2lkIjoiMzYyMjA3MDI0NDYzNTAwNTM4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4ac899e407a7c8aff7da62ee0ea459cd17bfb854ea76ea021f939edce86f7623 |
| hovercard-subject-tag | pull_request:4302370924 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6811/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Follow-up to #6808/#6809. A mutation-testing pass over that work found four changes that could be reverted with the whole suite green, plus two comments asserting something untrue. This pin... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width