René's URL Explorer Experiment


Title: fix(email): greet SMTP relays with a qualified hostname instead of [127.0.0.1] by waleedlatif1 · Pull Request #6799 · simstudioai/sim · GitHub

Open Graph Title: fix(email): greet SMTP relays with a qualified hostname instead of [127.0.0.1] by waleedlatif1 · Pull Request #6799 · simstudioai/sim

X Title: fix(email): greet SMTP relays with a qualified hostname instead of [127.0.0.1] by waleedlatif1 · Pull Request #6799 · simstudioai/sim

Description: Summary Nodemailer derives the EHLO greeting from os.hostname() and substitutes the address literal [127.0.0.1] whenever that name contains no dot. Kubernetes pod hostnames never contain one, so every k8s deployment introduced itself to the relay as loopback. Strict relays refuse that greeting before any mail moves — Google Workspace's smtp-relay.gmail.com answers 421-4.7.0 Try again later, closing connection. (EHLO), which surfaces as "All email providers failed" on invitations and verification mail. Our own self-hosting docs recommend that relay, so this broke the documented path. Sim now greets with the domain it is served from, as RFC 5321 §4.1.4 asks, with SMTP_EHLO_NAME to override it for relays that expect a different identity. Names that are not a dotted FQDN or an address literal are rejected and logged rather than passed into the command. Applied to both nodemailer SMTP transports: the platform mail provider and the SMTP block's send route. SES/Resend/Azure/Gmail go over HTTP APIs and are unaffected. Plumbed through the env schema, capability definition, .env.example, Helm values + schema, and the self-hosting docs. Fixes #6778 Type of Change Bug fix Testing New unit tests for the resolver, including the k8s fallback, the override, a dotless name, and a CRLF-carrying name. Verified they fail when the fix is reverted. bun run type-check, bun run lint, bun run check:audits (29/29), helm lint and helm template with the new key all pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Nodemailer derives the EHLO greeting from os.hostname() and substitutes the address literal [127.0.0.1] whenever that name contains no dot. Kubernetes pod hostnames never contain one, so e...

X Description: Summary Nodemailer derives the EHLO greeting from os.hostname() and substitutes the address literal [127.0.0.1] whenever that name contains no dot. Kubernetes pod hostnames never contain one, so e...

Opengraph URL: https://github.com/simstudioai/sim/pull/6799

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0e8d1b2b-afaa-822a-c1b4-26286833b193
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDE90:26BE6B:AC6EBD:ECF708:6AFB516E
html-safe-nonce6375f230da2d4be737f9ee3c62ed046129e0fe0709f75bf20fc010154fe4b22a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTkwOjI2QkU2QjpBQzZFQkQ6RUNGNzA4OjZBRkI1MTZFIiwidmlzaXRvcl9pZCI6IjMwNjg1NjM5MTQ5ODAyODI3MzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1a8ab540c356334e06f348e660657c369e2f0a4d89e25e946db6161ed184d4cc
hovercard-subject-tagpull_request:4300308524
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6799/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Nodemailer derives the EHLO greeting from os.hostname() and substitutes the address literal [127.0.0.1] whenever that name contains no dot. Kubernetes pod hostnames never contain one, so e...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6799/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6799%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6799%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6799/files
Reloadhttps://github.com/simstudioai/sim/pull/6799/files
Reloadhttps://github.com/simstudioai/sim/pull/6799/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/smtp-ehlo-namehttps://github.com/simstudioai/sim/tree/fix/smtp-ehlo-name
Conversation 14 https://github.com/simstudioai/sim/pull/6799
Commits 3 https://github.com/simstudioai/sim/pull/6799/commits
Checks 33 https://github.com/simstudioai/sim/pull/6799/checks
Files changed https://github.com/simstudioai/sim/pull/6799/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6799/files
fix(email): greet SMTP relays with a qualified hostname instead of [127.0.0.1] https://github.com/simstudioai/sim/pull/6799/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/6799/files
78a54fc fix(email): greet SMTP relays with a qualified hostname instead of [1… waleedlatif1 Aug 18, 2026 https://github.com/simstudioai/sim/pull/6799/commits/78a54fc46087ce3d970357299d7497e38dfab9c0
43b2c70 fix(email): parse EHLO address literals and drop a port from the app … waleedlatif1 Aug 18, 2026 https://github.com/simstudioai/sim/pull/6799/commits/43b2c7019615541ecb4b8f5d0d4335c26500ec15
3334de8 fix(email): accept any casing of the IPv6 literal tag, and stop ownin… waleedlatif1 Aug 18, 2026 https://github.com/simstudioai/sim/pull/6799/commits/3334de8f9ad11712845ae5960a44ff527953a885
Clear filters https://github.com/simstudioai/sim/pull/6799/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6799/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6799/files
email.mdx https://github.com/simstudioai/sim/pull/6799/files#diff-e204fbe50b7cb8c61fda5b1dd8ffeb8dd4e32e099935b67fe85427214d654285
environment-variables.mdx https://github.com/simstudioai/sim/pull/6799/files#diff-45c8a6c323a9a86d2d705efd872e35aaa5487fde36f469c5c447a80ab9449fd0
.env.example https://github.com/simstudioai/sim/pull/6799/files#diff-4a29ce2c9471f5720a7b21936c0716a37c648ef653d7563bfa140153bb045284
route.ts https://github.com/simstudioai/sim/pull/6799/files#diff-b8648472fde8f62b8b1e45f1288d9ffaee7dd8a3531c8b570ebedf574ae9b54d
env.ts https://github.com/simstudioai/sim/pull/6799/files#diff-7db3fc610ff89cf819c4eb69b43ec37ae18530e1861f6c322faeb62f8f48f298
ehlo.test.ts https://github.com/simstudioai/sim/pull/6799/files#diff-01ddc12ff3e0577e55c9ca568b1385569c0195c7338ec140b63b71c2b9e983ca
ehlo.ts https://github.com/simstudioai/sim/pull/6799/files#diff-be96b8aafc1e6f13d7679da959c460f1dd5df6b51207420f9f58ed5fbbf49263
smtp.ts https://github.com/simstudioai/sim/pull/6799/files#diff-014aa4413ed6ee653da2834cbf3d98bc6a102c76bd2472b3a98074a12e6e1b88
Chart.yaml https://github.com/simstudioai/sim/pull/6799/files#diff-d445852065771a32d12552f3dda5753bbf1f5cadfc7f4c3368a27d9c92932918
values.schema.json https://github.com/simstudioai/sim/pull/6799/files#diff-3203678a723acd84dd61f119ae4b9e439b04d35a123c7918821e20c31a72c791
values.yaml https://github.com/simstudioai/sim/pull/6799/files#diff-5586790157aac5be1a3be674910d22e602e8c840abbf289d0ad31ffb5dac5cb1
apps/docs/content/docs/en/platform/self-hosting/email.mdxhttps://github.com/simstudioai/sim/pull/6799/files#diff-e204fbe50b7cb8c61fda5b1dd8ffeb8dd4e32e099935b67fe85427214d654285
View file https://github.com/simstudioai/sim/blob/3334de8f9ad11712845ae5960a44ff527953a885/apps/docs/content/docs/en/platform/self-hosting/email.mdx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6799/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6799/files#diff-e204fbe50b7cb8c61fda5b1dd8ffeb8dd4e32e099935b67fe85427214d654285
https://github.com/simstudioai/sim/pull/6799/files#diff-e204fbe50b7cb8c61fda5b1dd8ffeb8dd4e32e099935b67fe85427214d654285
https://github.com/simstudioai/sim/pull/6799/files#diff-e204fbe50b7cb8c61fda5b1dd8ffeb8dd4e32e099935b67fe85427214d654285
apps/docs/content/docs/en/platform/self-hosting/environment-variables.mdxhttps://github.com/simstudioai/sim/pull/6799/files#diff-45c8a6c323a9a86d2d705efd872e35aaa5487fde36f469c5c447a80ab9449fd0
View file https://github.com/simstudioai/sim/blob/3334de8f9ad11712845ae5960a44ff527953a885/apps/docs/content/docs/en/platform/self-hosting/environment-variables.mdx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6799/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6799/files#diff-45c8a6c323a9a86d2d705efd872e35aaa5487fde36f469c5c447a80ab9449fd0
https://github.com/simstudioai/sim/pull/6799/files#diff-45c8a6c323a9a86d2d705efd872e35aaa5487fde36f469c5c447a80ab9449fd0
apps/sim/.env.examplehttps://github.com/simstudioai/sim/pull/6799/files#diff-4a29ce2c9471f5720a7b21936c0716a37c648ef653d7563bfa140153bb045284
View file https://github.com/simstudioai/sim/blob/3334de8f9ad11712845ae5960a44ff527953a885/apps/sim/.env.example
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6799/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6799/files#diff-4a29ce2c9471f5720a7b21936c0716a37c648ef653d7563bfa140153bb045284
https://github.com/simstudioai/sim/pull/6799/files#diff-4a29ce2c9471f5720a7b21936c0716a37c648ef653d7563bfa140153bb045284
apps/sim/app/api/tools/smtp/send/route.tshttps://github.com/simstudioai/sim/pull/6799/files#diff-b8648472fde8f62b8b1e45f1288d9ffaee7dd8a3531c8b570ebedf574ae9b54d
View file https://github.com/simstudioai/sim/blob/3334de8f9ad11712845ae5960a44ff527953a885/apps/sim/app/api/tools/smtp/send/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6799/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6799/files#diff-b8648472fde8f62b8b1e45f1288d9ffaee7dd8a3531c8b570ebedf574ae9b54d
https://github.com/simstudioai/sim/pull/6799/files#diff-b8648472fde8f62b8b1e45f1288d9ffaee7dd8a3531c8b570ebedf574ae9b54d
https://github.com/simstudioai/sim/pull/6799/files#diff-b8648472fde8f62b8b1e45f1288d9ffaee7dd8a3531c8b570ebedf574ae9b54d
https://github.com/simstudioai/sim/pull/6799/files#diff-b8648472fde8f62b8b1e45f1288d9ffaee7dd8a3531c8b570ebedf574ae9b54d
apps/sim/lib/core/config/env.tshttps://github.com/simstudioai/sim/pull/6799/files#diff-7db3fc610ff89cf819c4eb69b43ec37ae18530e1861f6c322faeb62f8f48f298
View file https://github.com/simstudioai/sim/blob/3334de8f9ad11712845ae5960a44ff527953a885/apps/sim/lib/core/config/env.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6799/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6799/files#diff-7db3fc610ff89cf819c4eb69b43ec37ae18530e1861f6c322faeb62f8f48f298
https://github.com/simstudioai/sim/pull/6799/files#diff-7db3fc610ff89cf819c4eb69b43ec37ae18530e1861f6c322faeb62f8f48f298
apps/sim/lib/messaging/email/ehlo.test.tshttps://github.com/simstudioai/sim/pull/6799/files#diff-01ddc12ff3e0577e55c9ca568b1385569c0195c7338ec140b63b71c2b9e983ca
View file https://github.com/simstudioai/sim/blob/3334de8f9ad11712845ae5960a44ff527953a885/apps/sim/lib/messaging/email/ehlo.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6799/{{ revealButtonHref }}
apps/sim/lib/messaging/email/ehlo.tshttps://github.com/simstudioai/sim/pull/6799/files#diff-be96b8aafc1e6f13d7679da959c460f1dd5df6b51207420f9f58ed5fbbf49263
View file https://github.com/simstudioai/sim/blob/3334de8f9ad11712845ae5960a44ff527953a885/apps/sim/lib/messaging/email/ehlo.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6799/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/6799/files
apps/sim/lib/messaging/email/providers/smtp.tshttps://github.com/simstudioai/sim/pull/6799/files#diff-014aa4413ed6ee653da2834cbf3d98bc6a102c76bd2472b3a98074a12e6e1b88
View file https://github.com/simstudioai/sim/blob/3334de8f9ad11712845ae5960a44ff527953a885/apps/sim/lib/messaging/email/providers/smtp.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6799/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6799/files#diff-014aa4413ed6ee653da2834cbf3d98bc6a102c76bd2472b3a98074a12e6e1b88
https://github.com/simstudioai/sim/pull/6799/files#diff-014aa4413ed6ee653da2834cbf3d98bc6a102c76bd2472b3a98074a12e6e1b88
https://github.com/simstudioai/sim/pull/6799/files#diff-014aa4413ed6ee653da2834cbf3d98bc6a102c76bd2472b3a98074a12e6e1b88
helm/sim/Chart.yamlhttps://github.com/simstudioai/sim/pull/6799/files#diff-d445852065771a32d12552f3dda5753bbf1f5cadfc7f4c3368a27d9c92932918
View file https://github.com/simstudioai/sim/blob/3334de8f9ad11712845ae5960a44ff527953a885/helm/sim/Chart.yaml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6799/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6799/files#diff-d445852065771a32d12552f3dda5753bbf1f5cadfc7f4c3368a27d9c92932918
https://github.com/simstudioai/sim/pull/6799/files#diff-d445852065771a32d12552f3dda5753bbf1f5cadfc7f4c3368a27d9c92932918
helm/sim/values.schema.jsonhttps://github.com/simstudioai/sim/pull/6799/files#diff-3203678a723acd84dd61f119ae4b9e439b04d35a123c7918821e20c31a72c791
View file https://github.com/simstudioai/sim/blob/3334de8f9ad11712845ae5960a44ff527953a885/helm/sim/values.schema.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6799/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6799/files#diff-3203678a723acd84dd61f119ae4b9e439b04d35a123c7918821e20c31a72c791
https://github.com/simstudioai/sim/pull/6799/files#diff-3203678a723acd84dd61f119ae4b9e439b04d35a123c7918821e20c31a72c791
helm/sim/values.yamlhttps://github.com/simstudioai/sim/pull/6799/files#diff-5586790157aac5be1a3be674910d22e602e8c840abbf289d0ad31ffb5dac5cb1
View file https://github.com/simstudioai/sim/blob/3334de8f9ad11712845ae5960a44ff527953a885/helm/sim/values.yaml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6799/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6799/files#diff-5586790157aac5be1a3be674910d22e602e8c840abbf289d0ad31ffb5dac5cb1
https://github.com/simstudioai/sim/pull/6799/files#diff-5586790157aac5be1a3be674910d22e602e8c840abbf289d0ad31ffb5dac5cb1
Please reload this pagehttps://github.com/simstudioai/sim/pull/6799/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.