René's URL Explorer Experiment


Title: fix(sap_concur): HMAC the token cache key and wire the sendback comment by waleedlatif1 · Pull Request #6794 · simstudioai/sim · GitHub

Open Graph Title: fix(sap_concur): HMAC the token cache key and wire the sendback comment by waleedlatif1 · Pull Request #6794 · simstudioai/sim

X Title: fix(sap_concur): HMAC the token cache key and wire the sendback comment by waleedlatif1 · Pull Request #6794 · simstudioai/sim

Description: Summary Follow-up to #6790 — these two commits were pushed to that branch after it had already been merged, so they never landed. Cherry-picked onto current staging, unchanged. HMAC the token cache key. tokenCacheKey hashed a user-chosen password with a bare SHA-256, which CodeQL flagged (alert 479). The key never leaves the process, but a password is low-entropy enough to brute-force out of a plain digest if a key ever reached a heap dump or a debug log. It is now createHmac('sha256', env.INTERNAL_API_SECRET) over the same tuple, so the digest is useless without the server secret. Deliberately not a password-hashing KDF: this runs on every token fetch and partitions a cache rather than verifying a stored credential, so bcrypt/argon2 would add latency for no gain. That reasoning is in TSDoc on the function. Carve exchange rates out of the wand prompt. The shared body wand prompt claimed every payload family is camelCase. sap_concur_upload_exchange_rates is in BODY_OPS and genuinely takes snake_case (currency_sets of { from_crn_code, to_crn_code, start_date, rate }), so the blanket claim produced bodies Concur rejects. Wire the travel-request sendback comment. move_travel_request accepts a documented query comment that Concur applies to the sendback action, but the params branch never forwarded it and the block's only comment field is gated to create_report_comment, so it was unreachable from the UI. Uses a dedicated sendbackComment subblock — sharing the existing id would clash on required-ness and let values bleed between the two operations. Type of Change Bug fix Testing Tested manually. bun run check:audits (29/29), check-block-registry, lint, type-check, and the 127 SAP Concur tests all pass against current staging. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-up to #6790 — these two commits were pushed to that branch after it had already been merged, so they never landed. Cherry-picked onto current staging, unchanged. HMAC the token cach...

X Description: Summary Follow-up to #6790 — these two commits were pushed to that branch after it had already been merged, so they never landed. Cherry-picked onto current staging, unchanged. HMAC the token cach...

Opengraph URL: https://github.com/simstudioai/sim/pull/6794

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9366b6c2-6342-ecb0-0790-75c03dc6bf6d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB140:18732E:B34356:F62127:6AFB52D2
html-safe-nonce7d5fb290b3e45490811e19b309955a358100fd9eb24d1e90c7f8fdfee9d64591
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTQwOjE4NzMyRTpCMzQzNTY6RjYyMTI3OjZBRkI1MkQyIiwidmlzaXRvcl9pZCI6IjYwMDI3MTcwMTk5MTA5MTg4NjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacbb612bf17a979d50e97b40afbdaf08f48f76faa6f832febbaa36c2007137a3e7
hovercard-subject-tagpull_request:4300139807
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6794/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up to #6790 — these two commits were pushed to that branch after it had already been merged, so they never landed. Cherry-picked onto current staging, unchanged. HMAC the token cach...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6794/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6794%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6794%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6794/files
Reloadhttps://github.com/simstudioai/sim/pull/6794/files
Reloadhttps://github.com/simstudioai/sim/pull/6794/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/concur-hmac-and-sendbackhttps://github.com/simstudioai/sim/tree/fix/concur-hmac-and-sendback
Conversation 12 https://github.com/simstudioai/sim/pull/6794
Commits 3 https://github.com/simstudioai/sim/pull/6794/commits
Checks 30 https://github.com/simstudioai/sim/pull/6794/checks
Files changed https://github.com/simstudioai/sim/pull/6794/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6794/files
fix(sap_concur): HMAC the token cache key and wire the sendback comment https://github.com/simstudioai/sim/pull/6794/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/6794/files
cd70568 fix(sap_concur): key the token cache with an HMAC and document rate c… waleedlatif1 Aug 17, 2026 https://github.com/simstudioai/sim/pull/6794/commits/cd70568f80e0307f085f25e559d2754f13e15434
c1c3e69 fix(sap_concur): wire the travel request sendback comment through the… waleedlatif1 Aug 17, 2026 https://github.com/simstudioai/sim/pull/6794/commits/c1c3e697127a142e198d94edda6bbb6dba640a37
a21f854 fix(sap_concur): gate the sendback comment and merge duplicate TSDoc waleedlatif1 Aug 18, 2026 https://github.com/simstudioai/sim/pull/6794/commits/a21f854daa12c29c411a2d07b84c4f4e5ee67844
Clear filters https://github.com/simstudioai/sim/pull/6794/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6794/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6794/files
shared.ts https://github.com/simstudioai/sim/pull/6794/files#diff-771c4667a5c04a7f9ed96a2ac24b5916a45dc904b00bf55a22f75d658acc150e
sap_concur.ts https://github.com/simstudioai/sim/pull/6794/files#diff-929d60d4e335f3558e6fe8ef21ddcb19ccc98a196998fbd26eb8a01789f1a962
apps/sim/app/api/tools/sap_concur/shared.tshttps://github.com/simstudioai/sim/pull/6794/files#diff-771c4667a5c04a7f9ed96a2ac24b5916a45dc904b00bf55a22f75d658acc150e
View file https://github.com/simstudioai/sim/blob/a21f854daa12c29c411a2d07b84c4f4e5ee67844/apps/sim/app/api/tools/sap_concur/shared.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6794/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6794/files#diff-771c4667a5c04a7f9ed96a2ac24b5916a45dc904b00bf55a22f75d658acc150e
https://github.com/simstudioai/sim/pull/6794/files#diff-771c4667a5c04a7f9ed96a2ac24b5916a45dc904b00bf55a22f75d658acc150e
https://github.com/simstudioai/sim/pull/6794/files#diff-771c4667a5c04a7f9ed96a2ac24b5916a45dc904b00bf55a22f75d658acc150e
apps/sim/blocks/blocks/sap_concur.tshttps://github.com/simstudioai/sim/pull/6794/files#diff-929d60d4e335f3558e6fe8ef21ddcb19ccc98a196998fbd26eb8a01789f1a962
View file https://github.com/simstudioai/sim/blob/a21f854daa12c29c411a2d07b84c4f4e5ee67844/apps/sim/blocks/blocks/sap_concur.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6794/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6794/files#diff-929d60d4e335f3558e6fe8ef21ddcb19ccc98a196998fbd26eb8a01789f1a962
Please reload this pagehttps://github.com/simstudioai/sim/pull/6794/files
https://github.com/simstudioai/sim/pull/6794/files#diff-929d60d4e335f3558e6fe8ef21ddcb19ccc98a196998fbd26eb8a01789f1a962
https://github.com/simstudioai/sim/pull/6794/files#diff-929d60d4e335f3558e6fe8ef21ddcb19ccc98a196998fbd26eb8a01789f1a962
https://github.com/simstudioai/sim/pull/6794/files#diff-929d60d4e335f3558e6fe8ef21ddcb19ccc98a196998fbd26eb8a01789f1a962
https://github.com/simstudioai/sim/pull/6794/files#diff-929d60d4e335f3558e6fe8ef21ddcb19ccc98a196998fbd26eb8a01789f1a962
https://github.com/simstudioai/sim/pull/6794/files#diff-929d60d4e335f3558e6fe8ef21ddcb19ccc98a196998fbd26eb8a01789f1a962
https://github.com/simstudioai/sim/pull/6794/files#diff-929d60d4e335f3558e6fe8ef21ddcb19ccc98a196998fbd26eb8a01789f1a962
https://github.com/simstudioai/sim/pull/6794/files#diff-929d60d4e335f3558e6fe8ef21ddcb19ccc98a196998fbd26eb8a01789f1a962
https://github.com/simstudioai/sim/pull/6794/files#diff-929d60d4e335f3558e6fe8ef21ddcb19ccc98a196998fbd26eb8a01789f1a962
Please reload this pagehttps://github.com/simstudioai/sim/pull/6794/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.