René's URL Explorer Experiment


Title: fix(execution): stop a cancelled run reporting success when its wait swallows the cancellation by waleedlatif1 · Pull Request #6775 · simstudioai/sim · GitHub

Open Graph Title: fix(execution): stop a cancelled run reporting success when its wait swallows the cancellation by waleedlatif1 · Pull Request #6775 · simstudioai/sim

X Title: fix(execution): stop a cancelled run reporting success when its wait swallows the cancellation by waleedlatif1 · Pull Request #6775 · simstudioai/sim

Description: Summary Cancellation reaches a running execution over Redis pub/sub, which is at-most-once. The engine turns that into status: 'cancelled'. But the wait handler also polled the durable Redis cancellation key itself, and on a hit returned an ordinary successful block output — leaving the engine's cancelledFlag false, so a cancelled run finished as success: true. Whichever detector fired first won. The engine's pub/sub path normally wins by about one round trip; when the wait's own 500 ms poll landed inside that window, the cancellation was lost. Intermittent, roughly daily. With a block after the wait it's worse than a mislabelled result: the engine's next loop iteration reads cancelledFlag === false and keeps executing, so a cancel silently doesn't cancel. Consolidated detection into ExecutionEngine, the only component that can project run status: the once-at-start durable backstop is now a poll that runs for the life of the run and routes through signalCancelled. The wait handler and loop orchestrator observe only ctx.abortSignal, which the engine aborts — no leaf can observe a cancellation the engine hasn't seen. Fixes a second latent bug: the loop orchestrator ignored abortSignal.aborted whenever Redis was enabled, so a mid-loop timeout or client disconnect was invisible to it. It also awaited a Redis round trip on every loop iteration, now a local boolean read. Why this shape Redis pub/sub has no persistence, acks, or replay for a disconnected subscriber, so a correctness-critical signal carried over it needs a durable fallback read. The codebase already encodes that: markExecutionCancelled writes the durable key before publishing, and the engine already had a backstop — it just only ran once, at engine start. This completes that design rather than adding a new mechanism. status: 'cancelled' is not a new state. Every consumer across the sync route, async job, webhook, schedule, resume, column-execution, and child-workflow paths already branches on it — it's what the pub/sub path produces in the common case. This makes the lost-delivery case converge on the already-handled state. Handlers that abort their own I/O off ctx.abortSignal (Mothership, Pi babysit) are unaffected: that surfaces as a throw, which the cancelled branch of run already classifies. They were never part of this defect class. Type of Change Bug fix Testing Tested manually against the failing scenario, plus: New regression test: a durable cancellation with no pub/sub delivery now ends the run success: false, status: 'cancelled'. Verified it goes red with the poll removed. New timer-leak test asserting no interval survives the run. Verified it goes red with the cleanup removed. executor/ suite: 1984 passed. Cancellation-adjacent suites (child-execution, executor lib, run-control, schedule/resume/column execution, cancel-workflow-execution, cancellation, cancel route): 314 passed. Execute route: 119 passed. bun run type-check clean, bun run lint clean, bun run check:audits 29/29, docs:check in sync. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Cancellation reaches a running execution over Redis pub/sub, which is at-most-once. The engine turns that into status: 'cancelled'. But the wait handler also polled the durable Red...

X Description: Summary Cancellation reaches a running execution over Redis pub/sub, which is at-most-once. The engine turns that into status: 'cancelled'. But the wait handler also polled the dur...

Opengraph URL: https://github.com/simstudioai/sim/pull/6775

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8d717ba9-d02d-8b60-c5b8-2e161252a35c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC1DE:CB99F:63516A:8CF3C5:6AFB45D8
html-safe-nonce3970d0eda2b4fd825dad365c9d1fadb1c9a24d3c021cd53d70377d8b7b80c5f5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMURFOkNCOTlGOjYzNTE2QTo4Q0YzQzU6NkFGQjQ1RDgiLCJ2aXNpdG9yX2lkIjoiODkxNTkzNzQ4MDczODAzMTA2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac87becfd5f82c4ec63955f87e0fc16d57a0b1ddf389a5d396b4ec64d173cbd8b0
hovercard-subject-tagpull_request:4294476838
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6775/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Cancellation reaches a running execution over Redis pub/sub, which is at-most-once. The engine turns that into status: 'cancelled'. But the wait handler also polled the durable Red...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6775/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6775%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6775%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6775/files
Reloadhttps://github.com/simstudioai/sim/pull/6775/files
Reloadhttps://github.com/simstudioai/sim/pull/6775/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
investigate/staging-cancel-canaryhttps://github.com/simstudioai/sim/tree/investigate/staging-cancel-canary
Conversation 3 https://github.com/simstudioai/sim/pull/6775
Commits 2 https://github.com/simstudioai/sim/pull/6775/commits
Checks 30 https://github.com/simstudioai/sim/pull/6775/checks
Files changed https://github.com/simstudioai/sim/pull/6775/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6775/files
fix(execution): stop a cancelled run reporting success when its wait swallows the cancellation https://github.com/simstudioai/sim/pull/6775/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/6775/files
2656803 fix(execution): stop a cancelled run reporting success when its wait … waleedlatif1 Aug 17, 2026 https://github.com/simstudioai/sim/pull/6775/commits/2656803b30508b7452bba0e4c69b5f9bf5b6c92a
c3819ce docs(wait): correct the in-line wait ceiling to 5 minutes waleedlatif1 Aug 17, 2026 https://github.com/simstudioai/sim/pull/6775/commits/c3819ce8569e4367c2aa16f8c06732fcfc06d63c
Clear filters https://github.com/simstudioai/sim/pull/6775/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6775/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6775/files
wait.mdx https://github.com/simstudioai/sim/pull/6775/files#diff-9159703902fc17432713b414cb88cb54fed53fcf36140cae962be8e2f0fb2142
engine.test.ts https://github.com/simstudioai/sim/pull/6775/files#diff-8a7dc7d2027ef09942b6480f995b1175f4f22ecbd015133850cb9f2dbc3df51e
engine.ts https://github.com/simstudioai/sim/pull/6775/files#diff-8fc33da0f336e4f8e9c4cef6bdcb2297ffb3bc693d739245b28cde225130de22
wait-handler.ts https://github.com/simstudioai/sim/pull/6775/files#diff-d34976a190f697997cb5d4b92f414792baf7662c86d56c8c5fa1e0dff337157d
loop.ts https://github.com/simstudioai/sim/pull/6775/files#diff-112bfce09777d1c73cccd2a5bf9870750f5d7e380332c8af3cdc0fbccc21e98f
child-execution.ts https://github.com/simstudioai/sim/pull/6775/files#diff-1b44de8251f333f4ed92e5b75dfacb71313b97a0a81dcea9507c150e847a7645
apps/docs/content/docs/en/workflows/blocks/wait.mdxhttps://github.com/simstudioai/sim/pull/6775/files#diff-9159703902fc17432713b414cb88cb54fed53fcf36140cae962be8e2f0fb2142
View file https://github.com/simstudioai/sim/blob/c3819ce8569e4367c2aa16f8c06732fcfc06d63c/apps/docs/content/docs/en/workflows/blocks/wait.mdx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6775/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6775/files#diff-9159703902fc17432713b414cb88cb54fed53fcf36140cae962be8e2f0fb2142
https://github.com/simstudioai/sim/pull/6775/files#diff-9159703902fc17432713b414cb88cb54fed53fcf36140cae962be8e2f0fb2142
https://github.com/simstudioai/sim/pull/6775/files#diff-9159703902fc17432713b414cb88cb54fed53fcf36140cae962be8e2f0fb2142
apps/sim/executor/execution/engine.test.tshttps://github.com/simstudioai/sim/pull/6775/files#diff-8a7dc7d2027ef09942b6480f995b1175f4f22ecbd015133850cb9f2dbc3df51e
View file https://github.com/simstudioai/sim/blob/c3819ce8569e4367c2aa16f8c06732fcfc06d63c/apps/sim/executor/execution/engine.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6775/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6775/files#diff-8a7dc7d2027ef09942b6480f995b1175f4f22ecbd015133850cb9f2dbc3df51e
https://github.com/simstudioai/sim/pull/6775/files#diff-8a7dc7d2027ef09942b6480f995b1175f4f22ecbd015133850cb9f2dbc3df51e
https://github.com/simstudioai/sim/pull/6775/files#diff-8a7dc7d2027ef09942b6480f995b1175f4f22ecbd015133850cb9f2dbc3df51e
apps/sim/executor/execution/engine.tshttps://github.com/simstudioai/sim/pull/6775/files#diff-8fc33da0f336e4f8e9c4cef6bdcb2297ffb3bc693d739245b28cde225130de22
View file https://github.com/simstudioai/sim/blob/c3819ce8569e4367c2aa16f8c06732fcfc06d63c/apps/sim/executor/execution/engine.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6775/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6775/files#diff-8fc33da0f336e4f8e9c4cef6bdcb2297ffb3bc693d739245b28cde225130de22
https://github.com/simstudioai/sim/pull/6775/files#diff-8fc33da0f336e4f8e9c4cef6bdcb2297ffb3bc693d739245b28cde225130de22
https://github.com/simstudioai/sim/pull/6775/files#diff-8fc33da0f336e4f8e9c4cef6bdcb2297ffb3bc693d739245b28cde225130de22
https://github.com/simstudioai/sim/pull/6775/files#diff-8fc33da0f336e4f8e9c4cef6bdcb2297ffb3bc693d739245b28cde225130de22
https://github.com/simstudioai/sim/pull/6775/files#diff-8fc33da0f336e4f8e9c4cef6bdcb2297ffb3bc693d739245b28cde225130de22
https://github.com/simstudioai/sim/pull/6775/files#diff-8fc33da0f336e4f8e9c4cef6bdcb2297ffb3bc693d739245b28cde225130de22
https://github.com/simstudioai/sim/pull/6775/files#diff-8fc33da0f336e4f8e9c4cef6bdcb2297ffb3bc693d739245b28cde225130de22
https://github.com/simstudioai/sim/pull/6775/files#diff-8fc33da0f336e4f8e9c4cef6bdcb2297ffb3bc693d739245b28cde225130de22
apps/sim/executor/handlers/wait/wait-handler.tshttps://github.com/simstudioai/sim/pull/6775/files#diff-d34976a190f697997cb5d4b92f414792baf7662c86d56c8c5fa1e0dff337157d
View file https://github.com/simstudioai/sim/blob/c3819ce8569e4367c2aa16f8c06732fcfc06d63c/apps/sim/executor/handlers/wait/wait-handler.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6775/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6775/files#diff-d34976a190f697997cb5d4b92f414792baf7662c86d56c8c5fa1e0dff337157d
https://github.com/simstudioai/sim/pull/6775/files#diff-d34976a190f697997cb5d4b92f414792baf7662c86d56c8c5fa1e0dff337157d
https://github.com/simstudioai/sim/pull/6775/files#diff-d34976a190f697997cb5d4b92f414792baf7662c86d56c8c5fa1e0dff337157d
https://github.com/simstudioai/sim/pull/6775/files#diff-d34976a190f697997cb5d4b92f414792baf7662c86d56c8c5fa1e0dff337157d
apps/sim/executor/orchestrators/loop.tshttps://github.com/simstudioai/sim/pull/6775/files#diff-112bfce09777d1c73cccd2a5bf9870750f5d7e380332c8af3cdc0fbccc21e98f
View file https://github.com/simstudioai/sim/blob/c3819ce8569e4367c2aa16f8c06732fcfc06d63c/apps/sim/executor/orchestrators/loop.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6775/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6775/files#diff-112bfce09777d1c73cccd2a5bf9870750f5d7e380332c8af3cdc0fbccc21e98f
https://github.com/simstudioai/sim/pull/6775/files#diff-112bfce09777d1c73cccd2a5bf9870750f5d7e380332c8af3cdc0fbccc21e98f
https://github.com/simstudioai/sim/pull/6775/files#diff-112bfce09777d1c73cccd2a5bf9870750f5d7e380332c8af3cdc0fbccc21e98f
apps/sim/lib/workflows/custom-blocks/child-execution.tshttps://github.com/simstudioai/sim/pull/6775/files#diff-1b44de8251f333f4ed92e5b75dfacb71313b97a0a81dcea9507c150e847a7645
View file https://github.com/simstudioai/sim/blob/c3819ce8569e4367c2aa16f8c06732fcfc06d63c/apps/sim/lib/workflows/custom-blocks/child-execution.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6775/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6775/files#diff-1b44de8251f333f4ed92e5b75dfacb71313b97a0a81dcea9507c150e847a7645
https://github.com/simstudioai/sim/pull/6775/files#diff-1b44de8251f333f4ed92e5b75dfacb71313b97a0a81dcea9507c150e847a7645
Please reload this pagehttps://github.com/simstudioai/sim/pull/6775/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.