René's URL Explorer Experiment


Title: fix(knowledge): stop capping the unpaged knowledge-base list by waleedlatif1 · Pull Request #6771 · simstudioai/sim · GitHub

Open Graph Title: fix(knowledge): stop capping the unpaged knowledge-base list by waleedlatif1 · Pull Request #6771 · simstudioai/sim

X Title: fix(knowledge): stop capping the unpaged knowledge-base list by waleedlatif1 · Pull Request #6771 · simstudioai/sim

Description: Summary Staging's integration test failed on the first run after #6770 deployed: GET /api/knowledge returned 500 with Knowledge base list exceeds the 10000 row limit. The same test had passed 28 consecutive runs over the prior two days against the same data — the delta was the code, not the volume. #6770 routed the internal list through the workspace read, which carried a 10,000-row cap. Soft-delete cleanup reclaims archived knowledge bases only past a retention window, and not at all where none is configured, so a workspace that archives faster than that window crosses any fixed count on its own. The cap could never have worked as a guard. Its throw was gated on limit === undefined, so it fired only for callers that had not asked for a page — precisely the callers with no cursor to retry with and no way to ask for less. A paged caller never reached it. It also read one row past the cap before throwing, so it refused to serve rows it had already materialized; most of the memory cost was already paid. Removed. An unpaged read is unbounded, matching the sibling internal lists (listTables, workspace files, neither capped). Paged callers keep their page and their nextCursorKeys. This also clears the same latent 500 in three other unpaged callers — the archived list use case, the catalog read, and the VFS name lookup — rather than only the surface that happened to fail. Two more of the same shape, found while auditing for others: attachConnectorTypes threw a bare Error above its own row cap, on those same unpaged callers. Archiving a knowledge base archives its connectors, so the growth curve that broke staging could not reach it — but it is the identical construct, and the sibling latestJobsForTables has no equivalent. The VFS path lookup read every knowledge base whose name merely contained the term and exact-matched in JS, so a single-row lookup scaled with the workspace. It now queries the exact name and reads two rows, mirroring findActiveTablesByExactName. Regression test reproduces the incident: it fails with the cap restored, passes without. Type of Change Bug fix Testing Tested manually. Full apps/sim suite, type-check, lint, and all 29 audits pass. Two things worth separate follow-up, neither in this PR: The integration test's teardown leaves archived knowledge bases behind, which is how that workspace reached five figures. sync-engine.ts accumulates every synced document's extracted text into one array with a page-count bound but no byte cap. That is where a bound would actually earn its keep. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Staging's integration test failed on the first run after #6770 deployed: GET /api/knowledge returned 500 with Knowledge base list exceeds the 10000 row limit. The same test had passed ...

X Description: Summary Staging's integration test failed on the first run after #6770 deployed: GET /api/knowledge returned 500 with Knowledge base list exceeds the 10000 row limit. The same test had pas...

Opengraph URL: https://github.com/simstudioai/sim/pull/6771

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ebcd2177-e1c6-606d-b6be-1559c5d343fe
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA394:3E3DC:D852:1335F:6AFB42FF
html-safe-noncec8347a85f5a05036dbdce5e7a332fa3b81116a4a6d01b42917674b2bc23a5684
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMzk0OjNFM0RDOkQ4NTI6MTMzNUY6NkFGQjQyRkYiLCJ2aXNpdG9yX2lkIjoiODIzMzE5NzczNjkyNTI4MzA3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2b9d9763096542536c1c8c68e840b87fbe89429fbfce7df490076d9b4e9c2b54
hovercard-subject-tagpull_request:4293611709
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6771/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Staging's integration test failed on the first run after #6770 deployed: GET /api/knowledge returned 500 with Knowledge base list exceeds the 10000 row limit. The same test had passed ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6771/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6771%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6771%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6771/files
Reloadhttps://github.com/simstudioai/sim/pull/6771/files
Reloadhttps://github.com/simstudioai/sim/pull/6771/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests200 (200)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/kb-archived-list-caphttps://github.com/simstudioai/sim/tree/fix/kb-archived-list-cap
Conversation 9 https://github.com/simstudioai/sim/pull/6771
Commits 1 https://github.com/simstudioai/sim/pull/6771/commits
Checks 31 https://github.com/simstudioai/sim/pull/6771/checks
Files changed https://github.com/simstudioai/sim/pull/6771/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6771/files
fix(knowledge): stop capping the unpaged knowledge-base list https://github.com/simstudioai/sim/pull/6771/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6771/files
bc7d114 fix(knowledge): stop capping the unpaged knowledge-base list waleedlatif1 Aug 17, 2026 https://github.com/simstudioai/sim/pull/6771/commits/bc7d11416dfa5a3bbc88d2e0cdebbae00ed60e1f
Clear filters https://github.com/simstudioai/sim/pull/6771/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6771/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6771/files
knowledge-vfs.ts https://github.com/simstudioai/sim/pull/6771/files#diff-9969439716eb3ad1c0c1030294200628f5b040f814937c023d6d4b45fb4e4a4c
constants.ts https://github.com/simstudioai/sim/pull/6771/files#diff-d0f66ec31a3b2ab7b1a24fb76cf2b0865b07be5abb97836403a2aab47784024a
service.test.ts https://github.com/simstudioai/sim/pull/6771/files#diff-5856177786ea5bfaddee3756ec5ac692c1e3e97c332ec370f6c31f401649abb8
service.ts https://github.com/simstudioai/sim/pull/6771/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
apps/sim/lib/knowledge/application/knowledge-vfs.tshttps://github.com/simstudioai/sim/pull/6771/files#diff-9969439716eb3ad1c0c1030294200628f5b040f814937c023d6d4b45fb4e4a4c
View file https://github.com/simstudioai/sim/blob/bc7d11416dfa5a3bbc88d2e0cdebbae00ed60e1f/apps/sim/lib/knowledge/application/knowledge-vfs.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6771/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6771/files#diff-9969439716eb3ad1c0c1030294200628f5b040f814937c023d6d4b45fb4e4a4c
https://github.com/simstudioai/sim/pull/6771/files#diff-9969439716eb3ad1c0c1030294200628f5b040f814937c023d6d4b45fb4e4a4c
https://github.com/simstudioai/sim/pull/6771/files#diff-9969439716eb3ad1c0c1030294200628f5b040f814937c023d6d4b45fb4e4a4c
apps/sim/lib/knowledge/constants.tshttps://github.com/simstudioai/sim/pull/6771/files#diff-d0f66ec31a3b2ab7b1a24fb76cf2b0865b07be5abb97836403a2aab47784024a
View file https://github.com/simstudioai/sim/blob/bc7d11416dfa5a3bbc88d2e0cdebbae00ed60e1f/apps/sim/lib/knowledge/constants.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6771/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6771/files#diff-d0f66ec31a3b2ab7b1a24fb76cf2b0865b07be5abb97836403a2aab47784024a
https://github.com/simstudioai/sim/pull/6771/files#diff-d0f66ec31a3b2ab7b1a24fb76cf2b0865b07be5abb97836403a2aab47784024a
https://github.com/simstudioai/sim/pull/6771/files#diff-d0f66ec31a3b2ab7b1a24fb76cf2b0865b07be5abb97836403a2aab47784024a
apps/sim/lib/knowledge/service.test.tshttps://github.com/simstudioai/sim/pull/6771/files#diff-5856177786ea5bfaddee3756ec5ac692c1e3e97c332ec370f6c31f401649abb8
View file https://github.com/simstudioai/sim/blob/bc7d11416dfa5a3bbc88d2e0cdebbae00ed60e1f/apps/sim/lib/knowledge/service.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6771/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6771/files#diff-5856177786ea5bfaddee3756ec5ac692c1e3e97c332ec370f6c31f401649abb8
https://github.com/simstudioai/sim/pull/6771/files#diff-5856177786ea5bfaddee3756ec5ac692c1e3e97c332ec370f6c31f401649abb8
https://github.com/simstudioai/sim/pull/6771/files#diff-5856177786ea5bfaddee3756ec5ac692c1e3e97c332ec370f6c31f401649abb8
https://github.com/simstudioai/sim/pull/6771/files#diff-5856177786ea5bfaddee3756ec5ac692c1e3e97c332ec370f6c31f401649abb8
https://github.com/simstudioai/sim/pull/6771/files#diff-5856177786ea5bfaddee3756ec5ac692c1e3e97c332ec370f6c31f401649abb8
https://github.com/simstudioai/sim/pull/6771/files#diff-5856177786ea5bfaddee3756ec5ac692c1e3e97c332ec370f6c31f401649abb8
apps/sim/lib/knowledge/service.tshttps://github.com/simstudioai/sim/pull/6771/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
View file https://github.com/simstudioai/sim/blob/bc7d11416dfa5a3bbc88d2e0cdebbae00ed60e1f/apps/sim/lib/knowledge/service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6771/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6771/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/6771/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/6771/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/6771/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/6771/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/6771/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/6771/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/6771/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/6771/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/6771/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/6771/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/6771/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/6771/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/6771/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/6771/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/6771/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
Please reload this pagehttps://github.com/simstudioai/sim/pull/6771/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.