René's URL Explorer Experiment


Title: fix(forks): stop sync demanding config the source never had by mzxchandra · Pull Request #6766 · simstudioai/sim · GitHub

Open Graph Title: fix(forks): stop sync demanding config the source never had by mzxchandra · Pull Request #6766 · simstudioai/sim

X Title: fix(forks): stop sync demanding config the source never had by mzxchandra · Pull Request #6766 · simstudioai/sim

Description: What Workspace fork sync manufactured required re-pick rows the source never asked for, disabling Sync and suppressing the "Fully mapped" badge. Two independently-reported symptoms turned out to be two distinct root causes landing on the same line in collectForkDependentReconfigs. Symptom A — an Agent block whose tools include Jira Get Issue, with Select Issue deliberately blank so the agent resolves it at runtime. The modal demanded a value. Symptom B — a Jira block on write whose Select Project was blank in the source. A required row appeared under the credential card. Toggling the field to manual-input mode and redeploying made the demand vanish. Why Cause A — a block-level required applied to a nested tool param emitAnchoredDependents() runs over two structurally different things: a block's own subblocks, and the params of each tool inside a tool-input. The nested pass read the raw block config and stamped required: isSubBlockRequired(...). Jira's issueKey subblock declares required: { field: 'operation', value: ['read', …] }, so a Get Issue tool evaluated operation === 'read' → required: true. But Sim already models this as ParameterVisibility: the tool param is issueKey: { required: true, visibility: 'user-or-llm' }. Every other consumer honors that — the tool-row editor strips required for anything not user-only, and createLLMToolSchema keeps an empty param in the model's schema so the model can fill it. The fork collector was the only surface that didn't. The editor's own verdict on the same field: Domain * and Jira Account * carry asterisks; Select Project and Select Issue do not. Cause B — demanding configuration the source never had projectId hangs off the credential anchor, so a blank one was emitted as a required row. The asymmetry that proves it's a collector bug rather than a data bug: only members carrying a selectorKey are emitted, so the basic selector gated while its advanced twin manualProjectId — identical required and dependsOn, no selectorKey — did not. The same empty configuration blocked or didn't purely on a display preference. That's also why the manual-mode workaround worked: the toggle writes canonicalModes.projectId = 'advanced', and the dormant-member guard skips the row. Not the remapper. A Jira project isn't a remappable kind — project-selector maps to selector-resource, absent from REGISTRY_KIND_TO_FORK_KIND, so it never reaches unmappedRequired. Neither fix subsumes the other The emptiness fix alone leaves a populated user-or-llm param gating after a parent swap, because effectiveDependentValue blanks the stored value whenever the parent changed in-session. The visibility rule alone never touches top-level subblocks. How One predicate at the single out.push site, expressing two independent invariants: A sync carries the source's configuration across; it never invents configuration the source never had. Applies to every dependent. Inside a tool-input, only a user-only param is the user's to supply. Applies to the nested pass, where visibility is known. The tool-row rule is extracted to apps/sim/lib/workflows/tool-input/param-visibility.ts and used by both the editor and the sync gate, so they can't drift. Visibility comes from getToolInputParamConfigs — the same resolver the rest of fork remapping already uses. Unknown schemas (custom-tool / MCP / unresolvable tool id) fail closed to the pre-existing gate. Rows are still emitted either way — only the gating flag changes — so no stored dependent value is orphaned and no row disappears. The predicate is written as the positive === 'user-only', never a user-or-llm || llm-only denylist: the two non-user visibilities reach the same verdict for different reasons, and a denylist would silently mis-classify any visibility added later. Blast radius ~110 required selector dependents across ~45 blocks stop gating when blank in source. Populated ones still gate everywhere — verified on the knowledge-base anchor, which is a different code path from the credential anchor. Untouched: mapping entries themselves (mapping-service.ts hardcodes required: true, and a blank credential never becomes an entry), nested user-only params with a value, requiredComplete, syncDisabled, and the cleared-ref blocker list. Verification Fork diff before → after, against a workflow built and deployed through the real editor: Block Field Before After Jira Write projectId true false Cause B Jira Read Pinned issueKey true true control — still gates Agent Blank tools[0].issueKey true false Cause A+B Agent Pinned tools[0].issueKey true false Cause A only (sourceValue: ACME-999) KB Blank Doc documentSelector — false KB anchor KB Pinned Doc documentSelector — true KB anchor control Row count unchanged (7 → 7). Push and pull directions produce identical flags. End-to-end through the UI, on a forked workspace: Credential mapped → badge reads "Fully mapped", Sync enabled. A populated required row emptied → Sync disabled, reason "Reconfigure all required fields first". Re-picked a document → persisted as documentSelector = doc_child → after sync the target block holds doc=doc_child. Two real syncs ran: credential remapped cred_jira_a → cred_jira_child, KB kb_parent → kb_child, blanks preserved. Repeat sync idempotent (no duplicate workflows); rollback {"restored":1} with the undo consumed; unlink left parent: null. Tests apps/sim/lib/workflows/tool-input/param-visibility.test.ts (new), dependent-field-noun.test.ts (new), plus 12 cases added to dependent-reconfigs.test.ts. Every behavioral case was verified to fail without the fix, not just pass with it. Full apps/sim suite: 1,968 files / 26,289 tests passing. turbo run type-check clean across all 24 workspaces. check:api-validation passes. Review findings fixed in-branch The pre-landing review caught a real defect in the first commit, fixed in 3ca8d29: Silent un-gating on non-string values. The predicate asked isNonEmptyValue about rawSourceValue, which flattens every non-string to '' for the wire contract. A multi-select dependent stores an array, so a populated one reported blank and stopped gating. Reachable today via zoho-desk departmentIds. Now asks the raw value. Canonical id is an alias — no longer clobbers a param owning that key as its own paramId. A test asserting .every() over an empty array (vacuously true) now pins both shapes. The indexer mock is reset per test, so the new cases aren't order-dependent. Placeholder copy: Select ${title.toLowerCase()} rendered "Select select issue" for titles that already read as instructions. Extracted and tested; a bare "Select" title now falls back instead of rendering "Select " / "No found". Security specialist: no findings. Deliberately out of scope human_in_the_loop. Its notification subblock is also a tool-input, but its tools execute directly with no model, so a user-or-llm blank there genuinely is missing. This change stops fork sync gating on it. The gap already exists in the editor — the HITL tool row shows no asterisk and saves blank — so fork sync was only masking it, and only for forked workspaces. The fix is editor-side (give those params explicit visibility: 'user-only', which re-gates them through this same rule). Separate PR. Jira condition gating (sibling in-flight PR). It shrinks the blast radius but does not fix Cause B — write / read-bulk / get_project legitimately show the selector. Independent; can land in either order. Note for affected users The toggle-to-manual workaround persists advanced into those workflows, which changes which member serializes. Harmless while both fields are empty, but if anyone later picks a project in the basic selector it will be silently dropped. Not auto-migrated — those blocks want toggling back by hand.

Open Graph Description: What Workspace fork sync manufactured required re-pick rows the source never asked for, disabling Sync and suppressing the "Fully mapped" badge. Two independently-reported symptoms turned...

X Description: What Workspace fork sync manufactured required re-pick rows the source never asked for, disabling Sync and suppressing the "Fully mapped" badge. Two independently-reported symptom...

Opengraph URL: https://github.com/simstudioai/sim/pull/6766

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a57340a7-8670-f747-9b6f-77a97baad55d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC6E6:A5723:5E013A:85B3DD:6AFB43E7
html-safe-nonced5c404c6a8b2a62d1de09ea3e54d664e0efd6365f462bea811a9fdc4cf284f33
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNkU2OkE1NzIzOjVFMDEzQTo4NUIzREQ6NkFGQjQzRTciLCJ2aXNpdG9yX2lkIjoiNzQ0NzM4MzMyMjA4MzkzNTIwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd64682d75364033953a99bd553e547941b87d2145ffe795a7d797fee0ea7f544
hovercard-subject-tagpull_request:4289220687
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6766/files
twitter:imagehttps://avatars.githubusercontent.com/u/129460234?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/129460234?s=400&v=4
og:image:altWhat Workspace fork sync manufactured required re-pick rows the source never asked for, disabling Sync and suppressing the "Fully mapped" badge. Two independently-reported symptoms turned...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6766/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6766%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6766%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6766/files
Reloadhttps://github.com/simstudioai/sim/pull/6766/files
Reloadhttps://github.com/simstudioai/sim/pull/6766/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests200 (200)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
icecrasher321https://github.com/icecrasher321
staginghttps://github.com/simstudioai/sim/tree/staging
fix/fork-sync-false-required-blockershttps://github.com/simstudioai/sim/tree/fix/fork-sync-false-required-blockers
Conversation 9 https://github.com/simstudioai/sim/pull/6766
Commits 5 https://github.com/simstudioai/sim/pull/6766/commits
Checks 30 https://github.com/simstudioai/sim/pull/6766/checks
Files changed https://github.com/simstudioai/sim/pull/6766/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6766/files
fix(forks): stop sync demanding config the source never had https://github.com/simstudioai/sim/pull/6766/files#top
Show all changes 5 commits https://github.com/simstudioai/sim/pull/6766/files
b922508 fix(forks): stop sync demanding config the source never had mzxchandra Aug 16, 2026 https://github.com/simstudioai/sim/pull/6766/commits/b922508a03c2cd4c1e25654b4ed7169f54389dea
44e417a Merge remote-tracking branch 'origin/staging' into fix/fork-sync-fals… mzxchandra Aug 16, 2026 https://github.com/simstudioai/sim/pull/6766/commits/44e417af38edd23b46f81c4be184e40dd25c09e7
3ca8d29 fix(forks): ask emptiness of the raw dependent value, not the coerced… mzxchandra Aug 16, 2026 https://github.com/simstudioai/sim/pull/6766/commits/3ca8d290335990bad586da8951ebcd375a7e0ae7
68c1b10 fix(forks): make the post-sync collector honor tool param visibility too mzxchandra Aug 16, 2026 https://github.com/simstudioai/sim/pull/6766/commits/68c1b10527292a045ef26298f6dfcd2b49146d19
dbeba09 style(forks): use TSDoc for the new test declaration comments mzxchandra Aug 16, 2026 https://github.com/simstudioai/sim/pull/6766/commits/dbeba09ebb77b571d08212385353baeada2cd2e0
Clear filters https://github.com/simstudioai/sim/pull/6766/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6766/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6766/files
sub-block-renderer.tsx https://github.com/simstudioai/sim/pull/6766/files#diff-a4f8f3cb6640aeff9da1e9b7b718cefce60abf57cc9435bc9983708dc0a68647
dependent-field-noun.test.ts https://github.com/simstudioai/sim/pull/6766/files#diff-9ef873212f320256e4cf822a5371c7d793a367e0dbcec2f6dea1616d6b562bcf
dependent-field-noun.ts https://github.com/simstudioai/sim/pull/6766/files#diff-358135d37d918e3d22f89f55dcd5dfdd1ea17f7393004dd1488eb296701097a5
dependent-field-selector.tsx https://github.com/simstudioai/sim/pull/6766/files#diff-0d2bec14a6bc7be2401870e4de90273969f12d7b13b3519527f8ebff7a2b2c11
dependent-reconfigs.test.ts https://github.com/simstudioai/sim/pull/6766/files#diff-16deeeee5d79ca25da5875ee3cfeef0b8a0e5ca0d9606468a6905b09c8d0a8b1
dependent-reconfigs.ts https://github.com/simstudioai/sim/pull/6766/files#diff-58e71da4792e4fc54c94b1298ae4be703b2309143285c2967c1a284aea1665cc
remap-references.test.ts https://github.com/simstudioai/sim/pull/6766/files#diff-c9998b9f58735cd8642ccab24bc2b58cb1babdd8498fe96a510958b969b359cf
remap-references.ts https://github.com/simstudioai/sim/pull/6766/files#diff-9069cb4b6ae70f51608f138f41c58fba13f17769a78770981df7f76da5dd26f8
param-visibility.test.ts https://github.com/simstudioai/sim/pull/6766/files#diff-5bf59daa08924476504707e52bd62d76b7fac522d13a4740d97d9843b40529dc
param-visibility.ts https://github.com/simstudioai/sim/pull/6766/files#diff-d4039932bb4f45c65b9b6769e54000628e49406e64e8996c4391210e465d908d
...editor/components/sub-block/components/tool-input/components/tools/sub-block-renderer.tsxhttps://github.com/simstudioai/sim/pull/6766/files#diff-a4f8f3cb6640aeff9da1e9b7b718cefce60abf57cc9435bc9983708dc0a68647
View file https://github.com/simstudioai/sim/blob/dbeba09ebb77b571d08212385353baeada2cd2e0/apps/sim/app/workspace/%5BworkspaceId%5D/w/%5BworkflowId%5D/components/panel/components/editor/components/sub-block/components/tool-input/components/tools/sub-block-renderer.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6766/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6766/files#diff-a4f8f3cb6640aeff9da1e9b7b718cefce60abf57cc9435bc9983708dc0a68647
https://github.com/simstudioai/sim/pull/6766/files#diff-a4f8f3cb6640aeff9da1e9b7b718cefce60abf57cc9435bc9983708dc0a68647
https://github.com/simstudioai/sim/pull/6766/files#diff-a4f8f3cb6640aeff9da1e9b7b718cefce60abf57cc9435bc9983708dc0a68647
apps/sim/ee/workspace-forking/components/fork-sync/dependent-field-noun.test.tshttps://github.com/simstudioai/sim/pull/6766/files#diff-9ef873212f320256e4cf822a5371c7d793a367e0dbcec2f6dea1616d6b562bcf
View file https://github.com/simstudioai/sim/blob/dbeba09ebb77b571d08212385353baeada2cd2e0/apps/sim/ee/workspace-forking/components/fork-sync/dependent-field-noun.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6766/{{ revealButtonHref }}
apps/sim/ee/workspace-forking/components/fork-sync/dependent-field-noun.tshttps://github.com/simstudioai/sim/pull/6766/files#diff-358135d37d918e3d22f89f55dcd5dfdd1ea17f7393004dd1488eb296701097a5
View file https://github.com/simstudioai/sim/blob/dbeba09ebb77b571d08212385353baeada2cd2e0/apps/sim/ee/workspace-forking/components/fork-sync/dependent-field-noun.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6766/{{ revealButtonHref }}
apps/sim/ee/workspace-forking/components/fork-sync/dependent-field-selector.tsxhttps://github.com/simstudioai/sim/pull/6766/files#diff-0d2bec14a6bc7be2401870e4de90273969f12d7b13b3519527f8ebff7a2b2c11
View file https://github.com/simstudioai/sim/blob/dbeba09ebb77b571d08212385353baeada2cd2e0/apps/sim/ee/workspace-forking/components/fork-sync/dependent-field-selector.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6766/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6766/files#diff-0d2bec14a6bc7be2401870e4de90273969f12d7b13b3519527f8ebff7a2b2c11
https://github.com/simstudioai/sim/pull/6766/files#diff-0d2bec14a6bc7be2401870e4de90273969f12d7b13b3519527f8ebff7a2b2c11
https://github.com/simstudioai/sim/pull/6766/files#diff-0d2bec14a6bc7be2401870e4de90273969f12d7b13b3519527f8ebff7a2b2c11
https://github.com/simstudioai/sim/pull/6766/files#diff-0d2bec14a6bc7be2401870e4de90273969f12d7b13b3519527f8ebff7a2b2c11
Please reload this pagehttps://github.com/simstudioai/sim/pull/6766/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6766/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.