Title: fix(workflow): derive the webhook URL only where a sub-block shows one by waleedlatif1 · Pull Request #6758 · simstudioai/sim · GitHub
Open Graph Title: fix(workflow): derive the webhook URL only where a sub-block shows one by waleedlatif1 · Pull Request #6758 · simstudioai/sim
X Title: fix(workflow): derive the webhook URL only where a sub-block shows one by waleedlatif1 · Pull Request #6758 · simstudioai/sim
Description: Summary sub-block.tsx:485 mounts useWebhookManagement for every sub-block in the editor panel, and the hook derived a webhook URL for all of them. getBaseUrl() throws when NEXT_PUBLIC_APP_URL reads empty, so a missing deployment value took down the entire workflow route instead of the single webhook field that needed the URL. The hook already gates its query and its sub-block store writes on useWebhookUrl (queryEnabled, line 131). The derived URL was the one value ignoring that flag; it now agrees with the rest of the hook. No caller can observe the change: short-input.tsx:219,341 already read it as useWebhookUrl && webhookManagement.webhookUrl, the copy button renders only when config.showCopyButton && config.useWebhookUrl (sub-block.tsx:1209), and slack-setup-wizard.tsx:92 passes useWebhookUrl: true. The value is never read inside the hook itself. Type of Change Bug fix Testing Typecheck clean; hooks/, stores/, and app/workspace suites pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary sub-block.tsx:485 mounts useWebhookManagement for every sub-block in the editor panel, and the hook derived a webhook URL for all of them. getBaseUrl() throws when NEXT_PUBLIC_APP_URL read...
X Description: Summary sub-block.tsx:485 mounts useWebhookManagement for every sub-block in the editor panel, and the hook derived a webhook URL for all of them. getBaseUrl() throws when NEXT_PUBLIC_APP_URL read...
Opengraph URL: https://github.com/simstudioai/sim/pull/6758
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:17d33598-90a3-c197-81d4-a08d7dea302d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A0EE:243FA5:73AFAA:9FC8F1:6AFB43F1 |
| html-safe-nonce | 0a0fad6d3bca812c4117077d47cc96c2889565ee824e499104e8753bdfa6d196 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMEVFOjI0M0ZBNTo3M0FGQUE6OUZDOEYxOjZBRkI0M0YxIiwidmlzaXRvcl9pZCI6Ijc4Nzg3MDkxNzA4ODExMTkyMTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5b18859da40f81c15d749d5c974f0f0fe685d18038774a5f55cf7d978be7d17d |
| hovercard-subject-tag | pull_request:4288326205 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6758/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary sub-block.tsx:485 mounts useWebhookManagement for every sub-block in the editor panel, and the hook derived a webhook URL for all of them. getBaseUrl() throws when NEXT_PUBLIC_APP_URL read... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | d849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a6c2f87cbcb6414452377b4967858ed6a66f1109 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width