René's URL Explorer Experiment


Title: fix(deploy): resolve the error-output flag from edges on both sides of change detection by waleedlatif1 · Pull Request #6754 · simstudioai/sim · GitHub

Open Graph Title: fix(deploy): resolve the error-output flag from edges on both sides of change detection by waleedlatif1 · Pull Request #6754 · simstudioai/sim

X Title: fix(deploy): resolve the error-output flag from edges on both sides of change detection by waleedlatif1 · Pull Request #6754 · simstudioai/sim

Description: Summary A block can hold errorEnabled: false while an error edge still leaves it — setBlockErrorEnabled doesn't remove existing error edges, both block renderers draw the port on errorEnabled || hasErrorConnection, and the executor never reads the flag at all (the edge alone decides routing). The two spellings are one state. Only the deployed side reconciled them: materializeDeploymentState backfills errorEnabled: true for any block with an error edge, while the live normalized tables are read verbatim. Change detection compared the raw flag and saw true against false for a block that hadn't changed. No redeploy could clear it — deploying snapshots the live false, which the next read backfills straight back to true. The deploy button sat on "Update" permanently, and checkNeedsRedeployment (raw jsonb, skips the backfill) disagreed with the button. Lifted the rule into @sim/workflow-types as collectErrorSourceBlockIds / resolveEffectiveErrorEnabled so the backfill and the comparison share one definition, and applied it to both sides of the diff. Compared outside the structural gate, since the flag can match while the edges disagree. Type of Change Bug fix Testing 3 regression tests in compare.test.ts; verified they go red when the fix is neutered Full apps/sim suite: 25742 passed, 0 failed bunx turbo run type-check (24 packages) and bun run check:audits (27 audits) clean Confirmed against a real affected workflow: deployed snapshot and live normalized tables matched byte-for-byte across blocks, edges, loops, parallels and variables, so the only difference was the one-sided backfill Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary A block can hold errorEnabled: false while an error edge still leaves it — setBlockErrorEnabled doesn't remove existing error edges, both block renderers draw the port on errorEnabled ...

X Description: Summary A block can hold errorEnabled: false while an error edge still leaves it — setBlockErrorEnabled doesn't remove existing error edges, both block renderers draw the port on errorEnab...

Opengraph URL: https://github.com/simstudioai/sim/pull/6754

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e0fbc7e0-01ac-0eab-88df-fc25c3c99f6d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBB54:277BD5:7ABD0B:A989EF:6AFB4548
html-safe-noncecb21b349b45a8293d2a5e42a2ff01e9f6a5532e130f063487d10cc56a10b71c4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjU0OjI3N0JENTo3QUJEMEI6QTk4OUVGOjZBRkI0NTQ4IiwidmlzaXRvcl9pZCI6IjU3MjM4ODQ5MTY5NjYxMTQ2MzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac04610b47075c118e534ee02ce7d0fcf3334eaa31bc1183732dfc7c2e5199a402
hovercard-subject-tagpull_request:4288225013
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6754/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary A block can hold errorEnabled: false while an error edge still leaves it — setBlockErrorEnabled doesn't remove existing error edges, both block renderers draw the port on errorEnabled ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6754/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6754%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6754%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6754/files
Reloadhttps://github.com/simstudioai/sim/pull/6754/files
Reloadhttps://github.com/simstudioai/sim/pull/6754/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/deploy-change-detection-rvthttps://github.com/simstudioai/sim/tree/fix/deploy-change-detection-rvt
Conversation 7 https://github.com/simstudioai/sim/pull/6754
Commits 2 https://github.com/simstudioai/sim/pull/6754/commits
Checks 30 https://github.com/simstudioai/sim/pull/6754/checks
Files changed https://github.com/simstudioai/sim/pull/6754/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6754/files
fix(deploy): resolve the error-output flag from edges on both sides of change detection https://github.com/simstudioai/sim/pull/6754/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/6754/files
8e0c46c fix(deploy): resolve the error-output flag from edges on both sides o… waleedlatif1 Aug 16, 2026 https://github.com/simstudioai/sim/pull/6754/commits/8e0c46c08cc38ef046843bbaeb88099bfc05538b
af0fb83 chore(deploy): use TSDoc for the error-output comparison comments waleedlatif1 Aug 16, 2026 https://github.com/simstudioai/sim/pull/6754/commits/af0fb83f7ad5a028a462d9f68f3698df8a779364
Clear filters https://github.com/simstudioai/sim/pull/6754/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6754/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6754/files
compare.test.ts https://github.com/simstudioai/sim/pull/6754/files#diff-5947dee9e55a7c1b758f6ee7bf0113ccb352ffb4fe27e29479772068178962e9
compare.ts https://github.com/simstudioai/sim/pull/6754/files#diff-2d2608412803fa0f5bb1e39795d91391e61dff5fe1b6ad4eb2f1a03a71600410
utils.ts https://github.com/simstudioai/sim/pull/6754/files#diff-b723bb650a6d3c96289fdf891fc363d5311c841ed15ffa4aa4ef963d1fa52227
workflow.ts https://github.com/simstudioai/sim/pull/6754/files#diff-d22956d2a7d110ae0ae7f6ee45dd7504260eecd01b38feb8bd0b6e05779eb2a5
apps/sim/lib/workflows/comparison/compare.test.tshttps://github.com/simstudioai/sim/pull/6754/files#diff-5947dee9e55a7c1b758f6ee7bf0113ccb352ffb4fe27e29479772068178962e9
View file https://github.com/simstudioai/sim/blob/af0fb83f7ad5a028a462d9f68f3698df8a779364/apps/sim/lib/workflows/comparison/compare.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6754/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6754/files#diff-5947dee9e55a7c1b758f6ee7bf0113ccb352ffb4fe27e29479772068178962e9
https://github.com/simstudioai/sim/pull/6754/files#diff-5947dee9e55a7c1b758f6ee7bf0113ccb352ffb4fe27e29479772068178962e9
apps/sim/lib/workflows/comparison/compare.tshttps://github.com/simstudioai/sim/pull/6754/files#diff-2d2608412803fa0f5bb1e39795d91391e61dff5fe1b6ad4eb2f1a03a71600410
View file https://github.com/simstudioai/sim/blob/af0fb83f7ad5a028a462d9f68f3698df8a779364/apps/sim/lib/workflows/comparison/compare.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6754/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6754/files#diff-2d2608412803fa0f5bb1e39795d91391e61dff5fe1b6ad4eb2f1a03a71600410
https://github.com/simstudioai/sim/pull/6754/files#diff-2d2608412803fa0f5bb1e39795d91391e61dff5fe1b6ad4eb2f1a03a71600410
https://github.com/simstudioai/sim/pull/6754/files#diff-2d2608412803fa0f5bb1e39795d91391e61dff5fe1b6ad4eb2f1a03a71600410
https://github.com/simstudioai/sim/pull/6754/files#diff-2d2608412803fa0f5bb1e39795d91391e61dff5fe1b6ad4eb2f1a03a71600410
https://github.com/simstudioai/sim/pull/6754/files#diff-2d2608412803fa0f5bb1e39795d91391e61dff5fe1b6ad4eb2f1a03a71600410
https://github.com/simstudioai/sim/pull/6754/files#diff-2d2608412803fa0f5bb1e39795d91391e61dff5fe1b6ad4eb2f1a03a71600410
apps/sim/lib/workflows/persistence/utils.tshttps://github.com/simstudioai/sim/pull/6754/files#diff-b723bb650a6d3c96289fdf891fc363d5311c841ed15ffa4aa4ef963d1fa52227
View file https://github.com/simstudioai/sim/blob/af0fb83f7ad5a028a462d9f68f3698df8a779364/apps/sim/lib/workflows/persistence/utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6754/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6754/files#diff-b723bb650a6d3c96289fdf891fc363d5311c841ed15ffa4aa4ef963d1fa52227
https://github.com/simstudioai/sim/pull/6754/files#diff-b723bb650a6d3c96289fdf891fc363d5311c841ed15ffa4aa4ef963d1fa52227
https://github.com/simstudioai/sim/pull/6754/files#diff-b723bb650a6d3c96289fdf891fc363d5311c841ed15ffa4aa4ef963d1fa52227
https://github.com/simstudioai/sim/pull/6754/files#diff-b723bb650a6d3c96289fdf891fc363d5311c841ed15ffa4aa4ef963d1fa52227
packages/workflow-types/src/workflow.tshttps://github.com/simstudioai/sim/pull/6754/files#diff-d22956d2a7d110ae0ae7f6ee45dd7504260eecd01b38feb8bd0b6e05779eb2a5
View file https://github.com/simstudioai/sim/blob/af0fb83f7ad5a028a462d9f68f3698df8a779364/packages/workflow-types/src/workflow.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6754/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6754/files#diff-d22956d2a7d110ae0ae7f6ee45dd7504260eecd01b38feb8bd0b6e05779eb2a5
https://github.com/simstudioai/sim/pull/6754/files#diff-d22956d2a7d110ae0ae7f6ee45dd7504260eecd01b38feb8bd0b6e05779eb2a5
https://github.com/simstudioai/sim/pull/6754/files#diff-d22956d2a7d110ae0ae7f6ee45dd7504260eecd01b38feb8bd0b6e05779eb2a5
https://github.com/simstudioai/sim/pull/6754/files#diff-d22956d2a7d110ae0ae7f6ee45dd7504260eecd01b38feb8bd0b6e05779eb2a5
Please reload this pagehttps://github.com/simstudioai/sim/pull/6754/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.