Title: fix(tables): re-check the find match at the reveal, not just before paging by waleedlatif1 · Pull Request #6750 · simstudioai/sim · GitHub
Open Graph Title: fix(tables): re-check the find match at the reveal, not just before paging by waleedlatif1 · Pull Request #6750 · simstudioai/sim
X Title: fix(tables): re-check the find match at the reveal, not just before paging by waleedlatif1 · Pull Request #6750 · simstudioai/sim
Description: Summary Follow-up to #6733, which merged while the last review round was still in flight — this is the one fix from that round that didn't make it in. #6733 added a guard in goToMatch so a match removed while its row was paging isn't revealed. Greptile's next round pointed out one more window: between goToMatch queueing the reveal and the reveal effect running is another commit, and a refetch there can remove the match after the guard has already passed. Extracts the membership check into isStillAMatch(match) and applies it at the reveal too — the one place the selection actually moves. When the match is gone, the pending jump is dropped and the cursor is released (activeMatchRef nulled, cursorIsOnMatchRef false), so the next step lands on the clamped replacement instead of skipping it. Without this, a row write or SSE update landing in that window selects a cell that no longer matches and marks the cursor as sitting on a result. Type of Change Bug fix Testing Typecheck, bun run lint:check, bun run check:audits (27 audits), 1313 table tests — all pass on top of current staging. The async race itself isn't unit-covered: the existing tests exercise the find bar, and driving this needs the 4,600-line grid mounted with a mid-flight refetch. The invariant is now enforced at both seams that can observe it (post-await in goToMatch, and the reveal effect). Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Follow-up to #6733, which merged while the last review round was still in flight — this is the one fix from that round that didn't make it in. #6733 added a guard in goToMatch so a matc...
X Description: Summary Follow-up to #6733, which merged while the last review round was still in flight — this is the one fix from that round that didn't make it in. #6733 added a guard in goToMatch so a ...
Opengraph URL: https://github.com/simstudioai/sim/pull/6750
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:e591e437-72b9-9288-cad1-4e4141aa479d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E4A0:11DC7C:AEB70A:EEF5D4:6AFB501A |
| html-safe-nonce | e40a20310f9039a8eab44c95b79370ce5d90f26f18f578464433997be0da2cc0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNEEwOjExREM3QzpBRUI3MEE6RUVGNUQ0OjZBRkI1MDFBIiwidmlzaXRvcl9pZCI6Ijg0MTM5OTg4MzQ4MzY1MjUwODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 2f17512eca4e17485622657d95b6cbdcaa404068a91a7223442eedadb4aebb86 |
| hovercard-subject-tag | pull_request:4288182508 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6750/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Follow-up to #6733, which merged while the last review round was still in flight — this is the one fix from that round that didn't make it in. #6733 added a guard in goToMatch so a matc... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width