René's URL Explorer Experiment


Title: fix(tables): re-check the find match at the reveal, not just before paging by waleedlatif1 · Pull Request #6750 · simstudioai/sim · GitHub

Open Graph Title: fix(tables): re-check the find match at the reveal, not just before paging by waleedlatif1 · Pull Request #6750 · simstudioai/sim

X Title: fix(tables): re-check the find match at the reveal, not just before paging by waleedlatif1 · Pull Request #6750 · simstudioai/sim

Description: Summary Follow-up to #6733, which merged while the last review round was still in flight — this is the one fix from that round that didn't make it in. #6733 added a guard in goToMatch so a match removed while its row was paging isn't revealed. Greptile's next round pointed out one more window: between goToMatch queueing the reveal and the reveal effect running is another commit, and a refetch there can remove the match after the guard has already passed. Extracts the membership check into isStillAMatch(match) and applies it at the reveal too — the one place the selection actually moves. When the match is gone, the pending jump is dropped and the cursor is released (activeMatchRef nulled, cursorIsOnMatchRef false), so the next step lands on the clamped replacement instead of skipping it. Without this, a row write or SSE update landing in that window selects a cell that no longer matches and marks the cursor as sitting on a result. Type of Change Bug fix Testing Typecheck, bun run lint:check, bun run check:audits (27 audits), 1313 table tests — all pass on top of current staging. The async race itself isn't unit-covered: the existing tests exercise the find bar, and driving this needs the 4,600-line grid mounted with a mid-flight refetch. The invariant is now enforced at both seams that can observe it (post-await in goToMatch, and the reveal effect). Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-up to #6733, which merged while the last review round was still in flight — this is the one fix from that round that didn't make it in. #6733 added a guard in goToMatch so a matc...

X Description: Summary Follow-up to #6733, which merged while the last review round was still in flight — this is the one fix from that round that didn't make it in. #6733 added a guard in goToMatch so a ...

Opengraph URL: https://github.com/simstudioai/sim/pull/6750

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e591e437-72b9-9288-cad1-4e4141aa479d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE4A0:11DC7C:AEB70A:EEF5D4:6AFB501A
html-safe-noncee40a20310f9039a8eab44c95b79370ce5d90f26f18f578464433997be0da2cc0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNEEwOjExREM3QzpBRUI3MEE6RUVGNUQ0OjZBRkI1MDFBIiwidmlzaXRvcl9pZCI6Ijg0MTM5OTg4MzQ4MzY1MjUwODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2f17512eca4e17485622657d95b6cbdcaa404068a91a7223442eedadb4aebb86
hovercard-subject-tagpull_request:4288182508
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6750/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up to #6733, which merged while the last review round was still in flight — this is the one fix from that round that didn't make it in. #6733 added a guard in goToMatch so a matc...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6750/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6750%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6750%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6750/files
Reloadhttps://github.com/simstudioai/sim/pull/6750/files
Reloadhttps://github.com/simstudioai/sim/pull/6750/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/table-find-reveal-recheckhttps://github.com/simstudioai/sim/tree/fix/table-find-reveal-recheck
Conversation 8 https://github.com/simstudioai/sim/pull/6750
Commits 2 https://github.com/simstudioai/sim/pull/6750/commits
Checks 30 https://github.com/simstudioai/sim/pull/6750/checks
Files changed https://github.com/simstudioai/sim/pull/6750/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6750/files
fix(tables): re-check the find match at the reveal, not just before paging https://github.com/simstudioai/sim/pull/6750/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/6750/files
f08db60 fix(tables): re-check the match at the reveal, not just before paging waleedlatif1 Aug 15, 2026 https://github.com/simstudioai/sim/pull/6750/commits/f08db602e49b1ad480b9659ade6afe2aeaed1b20
d91a700 fix(tables): only release the find cursor from the reveal that owns it waleedlatif1 Aug 16, 2026 https://github.com/simstudioai/sim/pull/6750/commits/d91a7006a90bd90ac0ae67d21cb132b767de27ca
Clear filters https://github.com/simstudioai/sim/pull/6750/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6750/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6750/files
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsxhttps://github.com/simstudioai/sim/pull/6750/files#diff-264141b75a0ee2c4464df4bb6f5722cd982587470cf162e5aae9de04c84fbc0e
View file https://github.com/simstudioai/sim/blob/d91a7006a90bd90ac0ae67d21cb132b767de27ca/apps/sim/app/workspace/%5BworkspaceId%5D/tables/%5BtableId%5D/components/table-grid/table-grid.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6750/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6750/files#diff-264141b75a0ee2c4464df4bb6f5722cd982587470cf162e5aae9de04c84fbc0e
https://github.com/simstudioai/sim/pull/6750/files#diff-264141b75a0ee2c4464df4bb6f5722cd982587470cf162e5aae9de04c84fbc0e
https://github.com/simstudioai/sim/pull/6750/files#diff-264141b75a0ee2c4464df4bb6f5722cd982587470cf162e5aae9de04c84fbc0e
https://github.com/simstudioai/sim/pull/6750/files#diff-264141b75a0ee2c4464df4bb6f5722cd982587470cf162e5aae9de04c84fbc0e
https://github.com/simstudioai/sim/pull/6750/files#diff-264141b75a0ee2c4464df4bb6f5722cd982587470cf162e5aae9de04c84fbc0e
Please reload this pagehttps://github.com/simstudioai/sim/pull/6750/files
https://github.com/simstudioai/sim/pull/6750/files#diff-264141b75a0ee2c4464df4bb6f5722cd982587470cf162e5aae9de04c84fbc0e
Please reload this pagehttps://github.com/simstudioai/sim/pull/6750/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.