René's URL Explorer Experiment


Title: refactor(resources): converge Files onto the shared drag hook and batch bulk authorization by waleedlatif1 · Pull Request #6748 · simstudioai/sim · GitHub

Open Graph Title: refactor(resources): converge Files onto the shared drag hook and batch bulk authorization by waleedlatif1 · Pull Request #6748 · simstudioai/sim

X Title: refactor(resources): converge Files onto the shared drag hook and batch bulk authorization by waleedlatif1 · Pull Request #6748 · simstudioai/sim

Description: Summary Files kept a 280-line copy of the foldered-list drag logic because it also accepts OS file drops, and the copies had drifted. The external drop is now an externalDrop option on the shared hook and the copy is gone — folder rows highlight and spring open for an OS file drag exactly as for a move, while the body and breadcrumb decline so the page-level upload overlay owns those regions Collapsed the three drop-active booleans into one ActiveDropTarget union, so exactly one affordance is armed by construction instead of by hand-clearing the other two Kept drop-target state writes identity-stable, so dragover no longer re-renders the list on every event Restored per-list drag MIMEs, so the cross-surface isolation drag-payload.ts documents is true again A folder can now spring open more than once per drag: descend, walk back out through the breadcrumb, descend again. The guard against re-entering the folder already on screen moved to useSpringNavigation, the only layer that can express it Bulk move/delete now resolve each item against the workspace context the batch already holds, and memoize the effective-permission lookup for the batch — two invariant queries per item removed Drop target fills at --surface-active; --surface-4 is the button-base token and is lighter than hover in light mode, so the strongest row state painted the faintest fill Type of Change Refactor / improvement Testing bun run type-check, bun run check:audits (27/27), and 4013 tests pass. New coverage for the drag lifecycle: re-entering a folder through the breadcrumb, refusing to re-open the folder already on screen, cancelling a pending open when the drag moves onto the current folder, one-hop return to origin after a multi-level round trip, staying put when the round trip ends in a drop, and the next drag taking a fresh origin. Plus unit tests for the permission memo, including key separation and re-query after a rejection. Not browser-tested — the convergence changes which code path Files runs, so the drag interactions are worth a manual pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Files kept a 280-line copy of the foldered-list drag logic because it also accepts OS file drops, and the copies had drifted. The external drop is now an externalDrop option on the shared ...

X Description: Summary Files kept a 280-line copy of the foldered-list drag logic because it also accepts OS file drops, and the copies had drifted. The external drop is now an externalDrop option on the shared ...

Opengraph URL: https://github.com/simstudioai/sim/pull/6748

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ac48f06b-a9ef-6ce6-151c-2b795adc4fd8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD796:31E6FC:ADFF8:F5051:6AFB45EE
html-safe-nonce910683cf4b1896bc69a6c0eb59f00375569f6871c0501ce1da1c95618babb798
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzk2OjMxRTZGQzpBREZGODpGNTA1MTo2QUZCNDVFRSIsInZpc2l0b3JfaWQiOiIxMjc0NjkwNDk1MDMyNTQyNzAzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace5d8d9c4a117d352ac0d644f8be243a67974a0117efe179775d18338af00d942
hovercard-subject-tagpull_request:4288077720
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6748/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Files kept a 280-line copy of the foldered-list drag logic because it also accepts OS file drops, and the copies had drifted. The external drop is now an externalDrop option on the shared ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6748/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6748%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6748%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6748/files
Reloadhttps://github.com/simstudioai/sim/pull/6748/files
Reloadhttps://github.com/simstudioai/sim/pull/6748/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
refactor/foldered-drag-convergencehttps://github.com/simstudioai/sim/tree/refactor/foldered-drag-convergence
Conversation 10 https://github.com/simstudioai/sim/pull/6748
Commits 2 https://github.com/simstudioai/sim/pull/6748/commits
Checks 30 https://github.com/simstudioai/sim/pull/6748/checks
Files changed https://github.com/simstudioai/sim/pull/6748/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6748/files
refactor(resources): converge Files onto the shared drag hook and batch bulk authorization https://github.com/simstudioai/sim/pull/6748/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/6748/files
b02c146 refactor(resources): converge Files onto the shared drag hook and bat… waleedlatif1 Aug 15, 2026 https://github.com/simstudioai/sim/pull/6748/commits/b02c146f5c9cc1a31c2b59a665fb707b1e4f5781
6ab3c6f fix(resources): dismiss the upload overlay on a folder drop and re-ch… waleedlatif1 Aug 15, 2026 https://github.com/simstudioai/sim/pull/6748/commits/6ab3c6f7c59eebe2c5f73237df6486f3d024e406
Clear filters https://github.com/simstudioai/sim/pull/6748/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6748/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6748/files
use-folder-row-drag-drop.ts https://github.com/simstudioai/sim/pull/6748/files#diff-d1b8d8888d4ad0079637b118c40d2079336e2d645b0533ba0f8419a40184e823
use-spring-loaded-folder.test.tsx https://github.com/simstudioai/sim/pull/6748/files#diff-856fdaff4dbd30a24d186be1e6a0c67ff797c5d4b6c25ebf4156605736b00017
use-spring-loaded-folder.ts https://github.com/simstudioai/sim/pull/6748/files#diff-7ae7b79e2e5b6f9936b68b0890dcad80713b77192e47e5271b16a2c2486e1ce4
use-spring-navigation.test.tsx https://github.com/simstudioai/sim/pull/6748/files#diff-e5aa924c0a7038f94995f0b413bf38e5d8e13cfdd814b145e9902a6ae4cd05bf
use-spring-navigation.ts https://github.com/simstudioai/sim/pull/6748/files#diff-92efdcbc1803523eb3f2d621f2750d7b5bf001ab0d2b2b1bdcfedfcbf5b7449f
resource.tsx https://github.com/simstudioai/sim/pull/6748/files#diff-0a8b4241a80381381e908b7da57edc5b1a8e7c6f6c9f2ae6d199cb1b2f4c8f22
files.tsx https://github.com/simstudioai/sim/pull/6748/files#diff-0284e2e46ba0636bd37fb01a0bee2a53844af9bbaf0a5879e3b182c0f34e67a9
knowledge.tsx https://github.com/simstudioai/sim/pull/6748/files#diff-c94a1040beada0cc0b8033410cc00f26610a4d0a25eeb6123bbf3a2206021142
tables.tsx https://github.com/simstudioai/sim/pull/6748/files#diff-6f863f5398bd7eec36119c2c77deb2483dbe0374d1bb6909d3e6a279d857bbdc
bulk.test.ts https://github.com/simstudioai/sim/pull/6748/files#diff-87cd84e386b0c1278e2803b8d4f2ea9d87ba2b622bbaeb12e3dfeee53aef3d76
bulk.ts https://github.com/simstudioai/sim/pull/6748/files#diff-35f629a989c9f6f36a7032dcab5b621d42ccc9e15c3303281e000129d4255ccb
contexts.ts https://github.com/simstudioai/sim/pull/6748/files#diff-f20167ce64f7c8a362b246ef7ee61f5611d0c4e35751471a5ca578220ce560cc
bulk.test.ts https://github.com/simstudioai/sim/pull/6748/files#diff-d80c770d13684fbe4de45a3e7d4bc6d2467e337bb5197720e8d0c7dca80a1060
bulk.ts https://github.com/simstudioai/sim/pull/6748/files#diff-bdef8a1fa916872df725b599ddac2c2747f01e14e78d7ae3437cebc74b9f7a77
context.ts https://github.com/simstudioai/sim/pull/6748/files#diff-7108d355c46176ebdb7307c9c2b4d6214283e29798e3a9698cf83d94b0dbea11
chip-chrome.ts https://github.com/simstudioai/sim/pull/6748/files#diff-50b08165b463816d0be603b445b08af24f8fcd79d5331fe73831769194869b56
apps/sim/app/workspace/[workspaceId]/components/folders/use-folder-row-drag-drop.tshttps://github.com/simstudioai/sim/pull/6748/files#diff-d1b8d8888d4ad0079637b118c40d2079336e2d645b0533ba0f8419a40184e823
View file https://github.com/simstudioai/sim/blob/6ab3c6f7c59eebe2c5f73237df6486f3d024e406/apps/sim/app/workspace/%5BworkspaceId%5D/components/folders/use-folder-row-drag-drop.ts
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/simstudioai/sim/pull/6748/files
apps/sim/app/workspace/[workspaceId]/components/folders/use-spring-loaded-folder.test.tsxhttps://github.com/simstudioai/sim/pull/6748/files#diff-856fdaff4dbd30a24d186be1e6a0c67ff797c5d4b6c25ebf4156605736b00017
View file https://github.com/simstudioai/sim/blob/6ab3c6f7c59eebe2c5f73237df6486f3d024e406/apps/sim/app/workspace/%5BworkspaceId%5D/components/folders/use-spring-loaded-folder.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6748/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6748/files#diff-856fdaff4dbd30a24d186be1e6a0c67ff797c5d4b6c25ebf4156605736b00017
https://github.com/simstudioai/sim/pull/6748/files#diff-856fdaff4dbd30a24d186be1e6a0c67ff797c5d4b6c25ebf4156605736b00017
https://github.com/simstudioai/sim/pull/6748/files#diff-856fdaff4dbd30a24d186be1e6a0c67ff797c5d4b6c25ebf4156605736b00017
https://github.com/simstudioai/sim/pull/6748/files#diff-856fdaff4dbd30a24d186be1e6a0c67ff797c5d4b6c25ebf4156605736b00017
apps/sim/app/workspace/[workspaceId]/components/folders/use-spring-loaded-folder.tshttps://github.com/simstudioai/sim/pull/6748/files#diff-7ae7b79e2e5b6f9936b68b0890dcad80713b77192e47e5271b16a2c2486e1ce4
View file https://github.com/simstudioai/sim/blob/6ab3c6f7c59eebe2c5f73237df6486f3d024e406/apps/sim/app/workspace/%5BworkspaceId%5D/components/folders/use-spring-loaded-folder.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6748/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6748/files#diff-7ae7b79e2e5b6f9936b68b0890dcad80713b77192e47e5271b16a2c2486e1ce4
https://github.com/simstudioai/sim/pull/6748/files#diff-7ae7b79e2e5b6f9936b68b0890dcad80713b77192e47e5271b16a2c2486e1ce4
https://github.com/simstudioai/sim/pull/6748/files#diff-7ae7b79e2e5b6f9936b68b0890dcad80713b77192e47e5271b16a2c2486e1ce4
https://github.com/simstudioai/sim/pull/6748/files#diff-7ae7b79e2e5b6f9936b68b0890dcad80713b77192e47e5271b16a2c2486e1ce4
https://github.com/simstudioai/sim/pull/6748/files#diff-7ae7b79e2e5b6f9936b68b0890dcad80713b77192e47e5271b16a2c2486e1ce4
apps/sim/app/workspace/[workspaceId]/components/folders/use-spring-navigation.test.tsxhttps://github.com/simstudioai/sim/pull/6748/files#diff-e5aa924c0a7038f94995f0b413bf38e5d8e13cfdd814b145e9902a6ae4cd05bf
View file https://github.com/simstudioai/sim/blob/6ab3c6f7c59eebe2c5f73237df6486f3d024e406/apps/sim/app/workspace/%5BworkspaceId%5D/components/folders/use-spring-navigation.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6748/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6748/files#diff-e5aa924c0a7038f94995f0b413bf38e5d8e13cfdd814b145e9902a6ae4cd05bf
https://github.com/simstudioai/sim/pull/6748/files#diff-e5aa924c0a7038f94995f0b413bf38e5d8e13cfdd814b145e9902a6ae4cd05bf
https://github.com/simstudioai/sim/pull/6748/files#diff-e5aa924c0a7038f94995f0b413bf38e5d8e13cfdd814b145e9902a6ae4cd05bf
https://github.com/simstudioai/sim/pull/6748/files#diff-e5aa924c0a7038f94995f0b413bf38e5d8e13cfdd814b145e9902a6ae4cd05bf
apps/sim/app/workspace/[workspaceId]/components/folders/use-spring-navigation.tshttps://github.com/simstudioai/sim/pull/6748/files#diff-92efdcbc1803523eb3f2d621f2750d7b5bf001ab0d2b2b1bdcfedfcbf5b7449f
View file https://github.com/simstudioai/sim/blob/6ab3c6f7c59eebe2c5f73237df6486f3d024e406/apps/sim/app/workspace/%5BworkspaceId%5D/components/folders/use-spring-navigation.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6748/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6748/files#diff-92efdcbc1803523eb3f2d621f2750d7b5bf001ab0d2b2b1bdcfedfcbf5b7449f
https://github.com/simstudioai/sim/pull/6748/files#diff-92efdcbc1803523eb3f2d621f2750d7b5bf001ab0d2b2b1bdcfedfcbf5b7449f
https://github.com/simstudioai/sim/pull/6748/files#diff-92efdcbc1803523eb3f2d621f2750d7b5bf001ab0d2b2b1bdcfedfcbf5b7449f
https://github.com/simstudioai/sim/pull/6748/files#diff-92efdcbc1803523eb3f2d621f2750d7b5bf001ab0d2b2b1bdcfedfcbf5b7449f
apps/sim/app/workspace/[workspaceId]/components/resource/resource.tsxhttps://github.com/simstudioai/sim/pull/6748/files#diff-0a8b4241a80381381e908b7da57edc5b1a8e7c6f6c9f2ae6d199cb1b2f4c8f22
View file https://github.com/simstudioai/sim/blob/6ab3c6f7c59eebe2c5f73237df6486f3d024e406/apps/sim/app/workspace/%5BworkspaceId%5D/components/resource/resource.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6748/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6748/files#diff-0a8b4241a80381381e908b7da57edc5b1a8e7c6f6c9f2ae6d199cb1b2f4c8f22
https://github.com/simstudioai/sim/pull/6748/files#diff-0a8b4241a80381381e908b7da57edc5b1a8e7c6f6c9f2ae6d199cb1b2f4c8f22
Please reload this pagehttps://github.com/simstudioai/sim/pull/6748/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6748/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.