René's URL Explorer Experiment


Title: fix(media): prevent drawtext filtergraph injection in add_text by waleedlatif1 · Pull Request #6734 · simstudioai/sim · GitHub

Open Graph Title: fix(media): prevent drawtext filtergraph injection in add_text by waleedlatif1 · Pull Request #6734 · simstudioai/sim

X Title: fix(media): prevent drawtext filtergraph injection in add_text by waleedlatif1 · Pull Request #6734 · simstudioai/sim

Description: Summary The add_text FFmpeg operation inlined the caller's caption into a single-quoted drawtext=text='...' filter option. FFmpeg's av_get_token copies bytes verbatim inside a single-quoted run, so a literal quote in the caption closed the quote and the rest of the caption was parsed as filtergraph syntax. This let an authenticated caller inject filters — drawtext=textfile= (arbitrary local-file read) or movie=filename=:f=tty (read-SSRF) — rendering the target file's bytes or an HTTP response body into the returned video. Fix: route the caption out-of-band. Write it to a file the operation owns and reference it via drawtext=textfile='' with expansion=none, so caption bytes never re-enter the filtergraph parser. Only the app-controlled temp path is escaped (for FFmpeg's two-level option parsing); expansion=none also disables %{...} expansion so the caption renders fully literally. Added apps/sim/lib/media/ffmpeg.test.ts covering the two breakout classes (textfile file-read and movie= SSRF) plus a normal caption. Type of Change Bug fix (security) Testing Reproduced the injection against a real FFmpeg 8.0 binary and confirmed the fix neutralizes it end-to-end (payload stored as literal caption, never opened). New unit tests assert the caption is never inlined into the filtergraph; verified they fail against the pre-fix code and pass after. Existing ffmpeg tool tests, lint, and type-check all pass (no new errors). Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The add_text FFmpeg operation inlined the caller's caption into a single-quoted drawtext=text='...' filter option. FFmpeg's av_get_token copies bytes verbatim inside a sing...

X Description: Summary The add_text FFmpeg operation inlined the caller's caption into a single-quoted drawtext=text='...' filter option. FFmpeg's av_get_token copies bytes verbat...

Opengraph URL: https://github.com/simstudioai/sim/pull/6734

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ec95ccb4-5581-c6db-b11e-319cec59b379
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB0EC:A5723:5E256F:85E6B8:6AFB43F0
html-safe-nonceed797398fc63c9a1853a87f9e148baa1496e711efb93ed0e1385d985c530db96
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMEVDOkE1NzIzOjVFMjU2Rjo4NUU2Qjg6NkFGQjQzRjAiLCJ2aXNpdG9yX2lkIjoiMzMwMDY2NzQwMDgwOTgyNTI2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac12a1a9e4c62ff888729be77c7c65281216f06c676b075191551b909dca8dbb4b
hovercard-subject-tagpull_request:4287358040
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6734/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The add_text FFmpeg operation inlined the caller's caption into a single-quoted drawtext=text='...' filter option. FFmpeg's av_get_token copies bytes verbatim inside a sing...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6734/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6734%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6734%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6734/files
Reloadhttps://github.com/simstudioai/sim/pull/6734/files
Reloadhttps://github.com/simstudioai/sim/pull/6734/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests200 (200)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/ffmpeg-drawtext-filtergraph-injectionhttps://github.com/simstudioai/sim/tree/fix/ffmpeg-drawtext-filtergraph-injection
Conversation 10 https://github.com/simstudioai/sim/pull/6734
Commits 1 https://github.com/simstudioai/sim/pull/6734/commits
Checks 30 https://github.com/simstudioai/sim/pull/6734/checks
Files changed https://github.com/simstudioai/sim/pull/6734/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6734/files
fix(media): prevent drawtext filtergraph injection in add_text https://github.com/simstudioai/sim/pull/6734/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6734/files
e77c308 fix(media): prevent drawtext filtergraph injection in add_text waleedlatif1 Aug 15, 2026 https://github.com/simstudioai/sim/pull/6734/commits/e77c3081bec6d4dc74ae00f94f89f2cf0f1418db
Clear filters https://github.com/simstudioai/sim/pull/6734/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6734/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6734/files
ffmpeg.test.ts https://github.com/simstudioai/sim/pull/6734/files#diff-84d6454b1747ffe231fb651f9c2f250ca9c9ffca1b44c177c5c5930d7f68bc1e
ffmpeg.ts https://github.com/simstudioai/sim/pull/6734/files#diff-4cb239d09c65948f5097877c0984c0a2063556969163ff7c4316dd2de35ca7a9
apps/sim/lib/media/ffmpeg.test.tshttps://github.com/simstudioai/sim/pull/6734/files#diff-84d6454b1747ffe231fb651f9c2f250ca9c9ffca1b44c177c5c5930d7f68bc1e
View file https://github.com/simstudioai/sim/blob/e77c3081bec6d4dc74ae00f94f89f2cf0f1418db/apps/sim/lib/media/ffmpeg.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6734/{{ revealButtonHref }}
apps/sim/lib/media/ffmpeg.tshttps://github.com/simstudioai/sim/pull/6734/files#diff-4cb239d09c65948f5097877c0984c0a2063556969163ff7c4316dd2de35ca7a9
View file https://github.com/simstudioai/sim/blob/e77c3081bec6d4dc74ae00f94f89f2cf0f1418db/apps/sim/lib/media/ffmpeg.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6734/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6734/files#diff-4cb239d09c65948f5097877c0984c0a2063556969163ff7c4316dd2de35ca7a9
https://github.com/simstudioai/sim/pull/6734/files#diff-4cb239d09c65948f5097877c0984c0a2063556969163ff7c4316dd2de35ca7a9
https://github.com/simstudioai/sim/pull/6734/files#diff-4cb239d09c65948f5097877c0984c0a2063556969163ff7c4316dd2de35ca7a9
https://github.com/simstudioai/sim/pull/6734/files#diff-4cb239d09c65948f5097877c0984c0a2063556969163ff7c4316dd2de35ca7a9
https://github.com/simstudioai/sim/pull/6734/files#diff-4cb239d09c65948f5097877c0984c0a2063556969163ff7c4316dd2de35ca7a9
Please reload this pagehttps://github.com/simstudioai/sim/pull/6734/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.