René's URL Explorer Experiment


Title: improvement(tables): make Cmd+F search as you type and clear on close by waleedlatif1 · Pull Request #6733 · simstudioai/sim · GitHub

Open Graph Title: improvement(tables): make Cmd+F search as you type and clear on close by waleedlatif1 · Pull Request #6733 · simstudioai/sim

X Title: improvement(tables): make Cmd+F search as you type and clear on close by waleedlatif1 · Pull Request #6733 · simstudioai/sim

Description: Summary Cmd+F in a table had two problems: nothing told you the search only ran on Enter, and closing the bar left the search behind. Reworked it to match what Chrome and Sheets do. Searches as you type (debounced), so there is nothing to discover. Enter and Shift+Enter now step through matches instead of being the way to search at all. Every match is highlighted, not just the one you're on — the active match keeps the selection outline, so you can see the hits and which one you're on at once. Uses the app's existing --highlight-match-bg token, the same one the knowledge-base search highlight paints with. A counter that says which state you're in: hidden before you type, 3 of 12 once there are hits, a spinner while the next result set lands, No results only once the search has settled. It holds the previous count mid-typing rather than blanking, and reserves its width so the bar doesn't resize on the first keystroke. Clears completely on close — term, highlights, and match cursor. It also puts you back on the cell you were on before opening find, unless you'd since selected one yourself. (Sheets parks you on the last match; that's a standing complaint there.) Added a clear (X) button in the field, an accessible name on the input, and no spellcheck squiggle on search terms. Also fixes a pre-existing bug found on the way: closing the bar left the previous term's matches cached as keepPreviousData, so reopening and pressing Enter on an empty box navigated the old search's hits. Type of Change Improvement Testing 11 unit tests on the find bar covering each counter state, Enter / Shift+Enter / Escape, the clear button, and the disabled-nav case. Verified they fail when the behavior is broken. Typecheck, bun run lint:check, bun run check:audits (26 audits), and 1291 table tests pass. Not yet clicked through in a browser. Notes for review Live search makes a few things newly hot; each is handled deliberately: Auto-jump to the first match is skipped when that row isn't loaded yet. ensureRowsLoadedUpTo pages sequentially, so a selective term whose first hit is 50k rows down would otherwise fire ~50 serial round trips per typing pause. Highlights and the count still cover the whole table; only the viewport jump waits for a deliberate Enter/next-click. Auto-reveal is keyed on the term, not the result-set identity — the find query hangs off the rows cache, so a row write or SSE update would otherwise yank you from match 7 back to match 1. Matches are grouped into a per-row Map so rows without a hit keep a stable undefined prop and don't re-render; TableFind is memoized. gcTime added to the find query, since each typing pause now mints its own cache entry. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Cmd+F in a table had two problems: nothing told you the search only ran on Enter, and closing the bar left the search behind. Reworked it to match what Chrome and Sheets do. Searches as yo...

X Description: Summary Cmd+F in a table had two problems: nothing told you the search only ran on Enter, and closing the bar left the search behind. Reworked it to match what Chrome and Sheets do. Searches as yo...

Opengraph URL: https://github.com/simstudioai/sim/pull/6733

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:26a019c8-398c-8eb7-e2a4-65236358798b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE020:4113F:828BE:B7B9E:6AFB454D
html-safe-noncea98e2c56c463b1208f6a997e84b105c20ea17e023c1f0f3775f5cd8b38aa8d14
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDIwOjQxMTNGOjgyOEJFOkI3QjlFOjZBRkI0NTREIiwidmlzaXRvcl9pZCI6IjQ4MDIxODE0MzA1NTEyMDExMDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac032297daff94fc4be4fb15e1c9862bd6cd5d8a8872ead8c36cec93d0b4f79a83
hovercard-subject-tagpull_request:4287251985
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6733/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Cmd+F in a table had two problems: nothing told you the search only ran on Enter, and closing the bar left the search behind. Reworked it to match what Chrome and Sheets do. Searches as yo...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6733/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6733%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6733%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6733/files
Reloadhttps://github.com/simstudioai/sim/pull/6733/files
Reloadhttps://github.com/simstudioai/sim/pull/6733/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
feat/table-find-uxhttps://github.com/simstudioai/sim/tree/feat/table-find-ux
Conversation 74 https://github.com/simstudioai/sim/pull/6733
Commits 12 https://github.com/simstudioai/sim/pull/6733/commits
Checks 30 https://github.com/simstudioai/sim/pull/6733/checks
Files changed https://github.com/simstudioai/sim/pull/6733/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6733/files
improvement(tables): make Cmd+F search as you type and clear on close https://github.com/simstudioai/sim/pull/6733/files#top
Show all changes 12 commits https://github.com/simstudioai/sim/pull/6733/files
c6098c4 improvement(tables): make Cmd+F search as you type and clear on close waleedlatif1 Aug 15, 2026 https://github.com/simstudioai/sim/pull/6733/commits/c6098c48487862c6a3e4766b8552ea25df545994
b5b2a88 fix(tables): reset the find debounce on close and land Enter on a ski… waleedlatif1 Aug 15, 2026 https://github.com/simstudioai/sim/pull/6733/commits/b5b2a887ed0ac77cc43974f4933c13c6b66fc046
a4a71ac fix(tables): keep a clicked cell selected when find closes waleedlatif1 Aug 15, 2026 https://github.com/simstudioai/sim/pull/6733/commits/a4a71ac900fc03f1b7f3dde560f45e51a208e37d
0153cd4 fix(tables): strand an in-flight match jump when the search term changes waleedlatif1 Aug 15, 2026 https://github.com/simstudioai/sim/pull/6733/commits/0153cd479e33787379750bea1075554f99eb879e
95f578d fix(tables): strand match jumps on the live query, not the debounced one waleedlatif1 Aug 15, 2026 https://github.com/simstudioai/sim/pull/6733/commits/95f578d6aa13a3f690a1eca382854cbf74d7e2ef
b9bd619 fix(tables): cancel before reveal, and release find's selection on an… waleedlatif1 Aug 15, 2026 https://github.com/simstudioai/sim/pull/6733/commits/b9bd619ffb5f1761353e040c6d530c1949c52533
d131feb fix(tables): drop find's selection restore, commit the term on Enter waleedlatif1 Aug 15, 2026 https://github.com/simstudioai/sim/pull/6733/commits/d131febe23800a78e818288b8609915f8b9e8e8b
7599a53 fix(tables): block find navigation until the results describe the term waleedlatif1 Aug 15, 2026 https://github.com/simstudioai/sim/pull/6733/commits/7599a53b64668bd268a823fecca821bab0674c72
62a2297 fix(tables): clamp the find step base when a refetch shrinks the matc… waleedlatif1 Aug 15, 2026 https://github.com/simstudioai/sim/pull/6733/commits/62a229729eb3a3aa592b5b1263d94e6bf63961fa
b197d55 fix(tables): track the find cursor by match identity, not position waleedlatif1 Aug 15, 2026 https://github.com/simstudioai/sim/pull/6733/commits/b197d55f495ae5fe5d8e5b0c09540932eee46be6
fd24b2d fix(tables): release the find cursor when its match leaves the result… waleedlatif1 Aug 15, 2026 https://github.com/simstudioai/sim/pull/6733/commits/fd24b2d087a6a85dd4cac1c9b605cac28e846cd0
4b884db fix(tables): skip the reveal when the target match vanishes mid-jump waleedlatif1 Aug 15, 2026 https://github.com/simstudioai/sim/pull/6733/commits/4b884dbba6e1ab992cafb08ce1fddb3e05ccc7ec
Clear filters https://github.com/simstudioai/sim/pull/6733/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6733/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6733/files
constants.ts https://github.com/simstudioai/sim/pull/6733/files#diff-f54a9c8b63fd562e4db99d08ddc0ca3eadde0ff8058ee0ef159479fea0bbeaa7
data-row.tsx https://github.com/simstudioai/sim/pull/6733/files#diff-155cf6284924ef5ffefab01aeeac331ed062f9820ca686c1ac2b95466cbbed92
table-find.test.tsx https://github.com/simstudioai/sim/pull/6733/files#diff-d7ad73c8029eb5516ba42e7b6b5a78dfd53edb1bcfa573bc0b67bd6427009e3d
table-find.tsx https://github.com/simstudioai/sim/pull/6733/files#diff-92ac2e515331e5e4e029de86bae0c4ca5dfe562ffbf4ac829bd3f9d1aca4b5fe
table-grid.tsx https://github.com/simstudioai/sim/pull/6733/files#diff-264141b75a0ee2c4464df4bb6f5722cd982587470cf162e5aae9de04c84fbc0e
search-params.ts https://github.com/simstudioai/sim/pull/6733/files#diff-85b4c1069e7c4c23cb28b19a6e8960dc170f3937f2dcff031f93216d99fe4e4f
tables.ts https://github.com/simstudioai/sim/pull/6733/files#diff-1d761ed5a7a2ed9ba4435d0f39c5f1f7ac13c177b301c401b38f5a6d731ac8cb
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/constants.tshttps://github.com/simstudioai/sim/pull/6733/files#diff-f54a9c8b63fd562e4db99d08ddc0ca3eadde0ff8058ee0ef159479fea0bbeaa7
View file https://github.com/simstudioai/sim/blob/4b884dbba6e1ab992cafb08ce1fddb3e05ccc7ec/apps/sim/app/workspace/%5BworkspaceId%5D/tables/%5BtableId%5D/components/table-grid/constants.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6733/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6733/files#diff-f54a9c8b63fd562e4db99d08ddc0ca3eadde0ff8058ee0ef159479fea0bbeaa7
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/data-row.tsxhttps://github.com/simstudioai/sim/pull/6733/files#diff-155cf6284924ef5ffefab01aeeac331ed062f9820ca686c1ac2b95466cbbed92
View file https://github.com/simstudioai/sim/blob/4b884dbba6e1ab992cafb08ce1fddb3e05ccc7ec/apps/sim/app/workspace/%5BworkspaceId%5D/tables/%5BtableId%5D/components/table-grid/data-row.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6733/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6733/files#diff-155cf6284924ef5ffefab01aeeac331ed062f9820ca686c1ac2b95466cbbed92
https://github.com/simstudioai/sim/pull/6733/files#diff-155cf6284924ef5ffefab01aeeac331ed062f9820ca686c1ac2b95466cbbed92
https://github.com/simstudioai/sim/pull/6733/files#diff-155cf6284924ef5ffefab01aeeac331ed062f9820ca686c1ac2b95466cbbed92
https://github.com/simstudioai/sim/pull/6733/files#diff-155cf6284924ef5ffefab01aeeac331ed062f9820ca686c1ac2b95466cbbed92
https://github.com/simstudioai/sim/pull/6733/files#diff-155cf6284924ef5ffefab01aeeac331ed062f9820ca686c1ac2b95466cbbed92
https://github.com/simstudioai/sim/pull/6733/files#diff-155cf6284924ef5ffefab01aeeac331ed062f9820ca686c1ac2b95466cbbed92
https://github.com/simstudioai/sim/pull/6733/files#diff-155cf6284924ef5ffefab01aeeac331ed062f9820ca686c1ac2b95466cbbed92
https://github.com/simstudioai/sim/pull/6733/files#diff-155cf6284924ef5ffefab01aeeac331ed062f9820ca686c1ac2b95466cbbed92
https://github.com/simstudioai/sim/pull/6733/files#diff-155cf6284924ef5ffefab01aeeac331ed062f9820ca686c1ac2b95466cbbed92
https://github.com/simstudioai/sim/pull/6733/files#diff-155cf6284924ef5ffefab01aeeac331ed062f9820ca686c1ac2b95466cbbed92
https://github.com/simstudioai/sim/pull/6733/files#diff-155cf6284924ef5ffefab01aeeac331ed062f9820ca686c1ac2b95466cbbed92
https://github.com/simstudioai/sim/pull/6733/files#diff-155cf6284924ef5ffefab01aeeac331ed062f9820ca686c1ac2b95466cbbed92
...im/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-find.test.tsxhttps://github.com/simstudioai/sim/pull/6733/files#diff-d7ad73c8029eb5516ba42e7b6b5a78dfd53edb1bcfa573bc0b67bd6427009e3d
View file https://github.com/simstudioai/sim/blob/4b884dbba6e1ab992cafb08ce1fddb3e05ccc7ec/apps/sim/app/workspace/%5BworkspaceId%5D/tables/%5BtableId%5D/components/table-grid/table-find.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6733/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/6733/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6733/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.