Title: fix(canvas): stop phantom ports and a latched-open action bar by waleedlatif1 · Pull Request #6688 · simstudioai/sim · GitHub
Open Graph Title: fix(canvas): stop phantom ports and a latched-open action bar by waleedlatif1 · Pull Request #6688 · simstudioai/sim
X Title: fix(canvas): stop phantom ports and a latched-open action bar by waleedlatif1 · Pull Request #6688 · simstudioai/sim
Description: Two canvas hover bugs from Slack. Ports that appear where no edge can be made Hovering a card raises a swell on its border that reads as a connection port. The swell was raised without regard for whether a handle exists behind it: A Response block mounts no source handle, so hovering its edge raised a knob no edge could ever leave from. A trigger mounts no target handle, yet still swelled under a connection dragged from another card — offering a drop it cannot accept. The two contexts are separate (your own hover is a source affordance; a swell raised while another card is the drag origin is a target affordance), so they are now gated separately on the handle that actually backs each one. A trigger's own swell is additionally limited to its source edge, matching what the subflow start node already does — so it no longer raises a knob on the edge where every other card shows its input. Action bar staying open after leaving via a port Leaving a card arms a 100ms retract and installs a pointermove listener to track the pointer across the gap up to the bar, which floats above the card. Re-entering the bar's hover band called openHover() — which cancelled the retract and removed that listener. Since no further pointerleave can arrive once the pointer is off the node, nothing was left to close the bar and it latched open. The listener now stays installed and the retract is re-armed when the pointer moves back out. Same gesture also left a knob puffed: only the in-band path recomputed the magnetized port, so leaving the tracking band upward onto the action bar pinned the last one at hover amplitude with the pointer nowhere near it. Type of Change Bug fix Testing Added use-action-menu-swell.test.tsx covering both directions of the gap crossing — retracts when the pointer carries on past the bar, stays open when it rests on it. Verified it fails against the old behavior and passes with the fix. Full renderer suite (72) and canvas suite (349) green; type-check and lint clean. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Two canvas hover bugs from Slack. Ports that appear where no edge can be made Hovering a card raises a swell on its border that reads as a connection port. The swell was raised without regard for w...
X Description: Two canvas hover bugs from Slack. Ports that appear where no edge can be made Hovering a card raises a swell on its border that reads as a connection port. The swell was raised without regard for w...
Opengraph URL: https://github.com/simstudioai/sim/pull/6688
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:bc691cb7-c51e-a32d-1548-003a0f347dab |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AADE:223A5F:B179D3:F485E4:6AFB534B |
| html-safe-nonce | 816833ea726578019d0002f6475e7849eac8ac15e338e2e3ac5529e1563e7079 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQURFOjIyM0E1RjpCMTc5RDM6RjQ4NUU0OjZBRkI1MzRCIiwidmlzaXRvcl9pZCI6IjgyOTgxOTEwOTc2MDM3NzMyNTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | af026949de68a05f7b170c454e5af8548fd878d0a16cd7adbb19a12592e87bbd |
| hovercard-subject-tag | pull_request:4275897334 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6688/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Two canvas hover bugs from Slack. Ports that appear where no edge can be made Hovering a card raises a swell on its border that reads as a connection port. The swell was raised without regard for w... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width