Title: fix(v2): hold create to the rules update enforces, and bind the last two cursors by waleedlatif1 · Pull Request #6684 · simstudioai/sim · GitHub
Open Graph Title: fix(v2): hold create to the rules update enforces, and bind the last two cursors by waleedlatif1 · Pull Request #6684 · simstudioai/sim
X Title: fix(v2): hold create to the rules update enforces, and bind the last two cursors by waleedlatif1 · Pull Request #6684 · simstudioai/sim
Description: Three defects, one shape: a rule applied to one path and not its sibling. Two were found by probing the live surface after #6681 deployed; the third by reading for the pattern. Each was reproduced before any code changed, and each fix is verified red-then-green. Create validated almost nothing update validates createTableGroupUseCase — what POST /api/v2/tables/{tableId}/groups calls — never received the registry checks #6681 added to updateTableGroupUseCase. Confirmed live on a self-created table: Request Create Update enrichmentId: "company-info", output outputId: "zz5_nosuch" 201, stored verbatim 400 Enrichment "Company Info" has no output "zz5_nosuch" enrichmentId: "zz5_no_such_enrichment", output with no outputId 201 400 manual group, fabricated blockId/path 201 400 with a valid-options list Each 201 stores a column no run can ever write — the runner fills a cell from result[out.outputId] and skips an output with none. The caller discovers it only when a later edit returns the 400 create should have given. Create now runs the same requireEnrichment / requireKnownEnrichmentOutputIds helpers and the same validateRequestedOutputs check as update. No third validator. The discriminator is workflowId, not type — load-bearing. workflow-sidebar.tsx creates enrichment-template groups labelled type: 'enrichment' while backed by a real workflowId and carrying no enrichmentId. Keying on the label would have sent that straight into requireEnrichment(undefined) and 400'd the first-party create path. Pinned by a regression test. A group's producer type could be relabelled into a state create forbids refineGroupSource enforces "enrichmentId required when type is enrichment" on create; the v2 update body has no such refine, declares type as a "replacement producer type", and declares no enrichmentId — so PATCH {groupId, type:"enrichment"} on a manual group reached the writer, which applies it unconditionally. Unrepairable: the strict body has no field that would make it valid. The harmful direction is the reverse flip. Relabelling an enrichment group as manual keeps enrichmentId while moving it onto the workflow branch with workflowId === '', so every cell run fails. (The forward flip is survivable — workflowId persists and the runner falls through.) An update may now only restate the type the group already has; re-sending the stored value stays a no-op, so a caller echoing the whole group back is unaffected. Option (b) — accepting enrichmentId on update and validating the merged state — was rejected: it needs the writer to persist enrichmentId and clear workflowId, i.e. a producer-swap feature nobody asked for. The last two unbound cursors GET /workflows/{id}/versions and GET /workspaces/{workspaceId}/members were the only paged reads still minting bare tokens — literally {"version":2} and {"email":"..."} base64'd. Confirmed live: a versions cursor from workflow A is accepted by workflow B, and a hand-crafted {"version":99} is accepted verbatim. The keyset still applies within the authorized parent, so it is a silently-wrong start position, not a leak. Both now wrap their domain token with the same {scope,inner} binding used everywhere else. No new mechanism. Guardrail closed too: CURSOR_BINDINGS recorded only query/body params, so [] could not distinguish "no filters" from "parent forgotten" — which is exactly what hid these two. CURSOR_BOUND_PATH_PARAMS now declares the parent path param for all six nested paged lists, with tests that fail actionably if an entry is dropped. The cursor tests were also reworked to mint through the route, so a route that stops binding cannot pass. In-flight tokens for these two lists are invalidated. They are single-walk and unpersisted, and the refusal message is accurate. Not fixed, flagged for follow-up The same relabelling hole via workflowId: PATCH {workflowId} on a registry-enrichment group makes it workflow-backed while enrichmentId stays set, so the runner still takes the enrichment branch and ignores the workflow. No first-party caller does this. v2 create refuses a shape the first-party surface produces (type:'enrichment' + workflowId + no enrichmentId), so a public caller cannot create a group the UI can. Verification Full suite: 1,863 files / 24,939 tests passed, 0 failed type-check 23/23, biome, check:audits 26/26, check:api-validation:strict, check:openapi — all clean One-line OpenAPI description diff regenerated for the type field
Open Graph Description: Three defects, one shape: a rule applied to one path and not its sibling. Two were found by probing the live surface after #6681 deployed; the third by reading for the pattern. Each was reproduced ...
X Description: Three defects, one shape: a rule applied to one path and not its sibling. Two were found by probing the live surface after #6681 deployed; the third by reading for the pattern. Each was reproduced ...
Opengraph URL: https://github.com/simstudioai/sim/pull/6684
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:195a239a-70b3-7c1b-e977-8532ad3c8dda |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C1D6:3B3600:C822BB:112D7B6:6AFB56B4 |
| html-safe-nonce | c859a6fd87b5c3fcd6bc7804afc3b4c71909e3d6a321c6a12d1d25849136d09c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUQ2OjNCMzYwMDpDODIyQkI6MTEyRDdCNjo2QUZCNTZCNCIsInZpc2l0b3JfaWQiOiI1MjkzNzM1MDUxNjg5NDE2MzcyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 926cc6fd27057446231ce3d9e4b74f868c0789cc006325620b6cfee523dd17a2 |
| hovercard-subject-tag | pull_request:4275767609 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6684/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Three defects, one shape: a rule applied to one path and not its sibling. Two were found by probing the live surface after #6681 deployed; the third by reading for the pattern. Each was reproduced ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width