René's URL Explorer Experiment


Title: fix(v2): hold create to the rules update enforces, and bind the last two cursors by waleedlatif1 · Pull Request #6684 · simstudioai/sim · GitHub

Open Graph Title: fix(v2): hold create to the rules update enforces, and bind the last two cursors by waleedlatif1 · Pull Request #6684 · simstudioai/sim

X Title: fix(v2): hold create to the rules update enforces, and bind the last two cursors by waleedlatif1 · Pull Request #6684 · simstudioai/sim

Description: Three defects, one shape: a rule applied to one path and not its sibling. Two were found by probing the live surface after #6681 deployed; the third by reading for the pattern. Each was reproduced before any code changed, and each fix is verified red-then-green. Create validated almost nothing update validates createTableGroupUseCase — what POST /api/v2/tables/{tableId}/groups calls — never received the registry checks #6681 added to updateTableGroupUseCase. Confirmed live on a self-created table: Request Create Update enrichmentId: "company-info", output outputId: "zz5_nosuch" 201, stored verbatim 400 Enrichment "Company Info" has no output "zz5_nosuch" enrichmentId: "zz5_no_such_enrichment", output with no outputId 201 400 manual group, fabricated blockId/path 201 400 with a valid-options list Each 201 stores a column no run can ever write — the runner fills a cell from result[out.outputId] and skips an output with none. The caller discovers it only when a later edit returns the 400 create should have given. Create now runs the same requireEnrichment / requireKnownEnrichmentOutputIds helpers and the same validateRequestedOutputs check as update. No third validator. The discriminator is workflowId, not type — load-bearing. workflow-sidebar.tsx creates enrichment-template groups labelled type: 'enrichment' while backed by a real workflowId and carrying no enrichmentId. Keying on the label would have sent that straight into requireEnrichment(undefined) and 400'd the first-party create path. Pinned by a regression test. A group's producer type could be relabelled into a state create forbids refineGroupSource enforces "enrichmentId required when type is enrichment" on create; the v2 update body has no such refine, declares type as a "replacement producer type", and declares no enrichmentId — so PATCH {groupId, type:"enrichment"} on a manual group reached the writer, which applies it unconditionally. Unrepairable: the strict body has no field that would make it valid. The harmful direction is the reverse flip. Relabelling an enrichment group as manual keeps enrichmentId while moving it onto the workflow branch with workflowId === '', so every cell run fails. (The forward flip is survivable — workflowId persists and the runner falls through.) An update may now only restate the type the group already has; re-sending the stored value stays a no-op, so a caller echoing the whole group back is unaffected. Option (b) — accepting enrichmentId on update and validating the merged state — was rejected: it needs the writer to persist enrichmentId and clear workflowId, i.e. a producer-swap feature nobody asked for. The last two unbound cursors GET /workflows/{id}/versions and GET /workspaces/{workspaceId}/members were the only paged reads still minting bare tokens — literally {"version":2} and {"email":"..."} base64'd. Confirmed live: a versions cursor from workflow A is accepted by workflow B, and a hand-crafted {"version":99} is accepted verbatim. The keyset still applies within the authorized parent, so it is a silently-wrong start position, not a leak. Both now wrap their domain token with the same {scope,inner} binding used everywhere else. No new mechanism. Guardrail closed too: CURSOR_BINDINGS recorded only query/body params, so [] could not distinguish "no filters" from "parent forgotten" — which is exactly what hid these two. CURSOR_BOUND_PATH_PARAMS now declares the parent path param for all six nested paged lists, with tests that fail actionably if an entry is dropped. The cursor tests were also reworked to mint through the route, so a route that stops binding cannot pass. In-flight tokens for these two lists are invalidated. They are single-walk and unpersisted, and the refusal message is accurate. Not fixed, flagged for follow-up The same relabelling hole via workflowId: PATCH {workflowId} on a registry-enrichment group makes it workflow-backed while enrichmentId stays set, so the runner still takes the enrichment branch and ignores the workflow. No first-party caller does this. v2 create refuses a shape the first-party surface produces (type:'enrichment' + workflowId + no enrichmentId), so a public caller cannot create a group the UI can. Verification Full suite: 1,863 files / 24,939 tests passed, 0 failed type-check 23/23, biome, check:audits 26/26, check:api-validation:strict, check:openapi — all clean One-line OpenAPI description diff regenerated for the type field

Open Graph Description: Three defects, one shape: a rule applied to one path and not its sibling. Two were found by probing the live surface after #6681 deployed; the third by reading for the pattern. Each was reproduced ...

X Description: Three defects, one shape: a rule applied to one path and not its sibling. Two were found by probing the live surface after #6681 deployed; the third by reading for the pattern. Each was reproduced ...

Opengraph URL: https://github.com/simstudioai/sim/pull/6684

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:195a239a-70b3-7c1b-e977-8532ad3c8dda
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC1D6:3B3600:C822BB:112D7B6:6AFB56B4
html-safe-noncec859a6fd87b5c3fcd6bc7804afc3b4c71909e3d6a321c6a12d1d25849136d09c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUQ2OjNCMzYwMDpDODIyQkI6MTEyRDdCNjo2QUZCNTZCNCIsInZpc2l0b3JfaWQiOiI1MjkzNzM1MDUxNjg5NDE2MzcyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac926cc6fd27057446231ce3d9e4b74f868c0789cc006325620b6cfee523dd17a2
hovercard-subject-tagpull_request:4275767609
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6684/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altThree defects, one shape: a rule applied to one path and not its sibling. Two were found by probing the live surface after #6681 deployed; the third by reading for the pattern. Each was reproduced ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6684/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6684%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6684%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6684/files
Reloadhttps://github.com/simstudioai/sim/pull/6684/files
Reloadhttps://github.com/simstudioai/sim/pull/6684/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/v2-group-create-parityhttps://github.com/simstudioai/sim/tree/fix/v2-group-create-parity
Conversation 3 https://github.com/simstudioai/sim/pull/6684
Commits 1 https://github.com/simstudioai/sim/pull/6684/commits
Checks 30 https://github.com/simstudioai/sim/pull/6684/checks
Files changed https://github.com/simstudioai/sim/pull/6684/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6684/files
fix(v2): hold create to the rules update enforces, and bind the last two cursors https://github.com/simstudioai/sim/pull/6684/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6684/files
717b4bf fix(v2): hold create to the rules update enforces, and bind the last … waleedlatif1 Aug 13, 2026 https://github.com/simstudioai/sim/pull/6684/commits/717b4bf3db7e9d7b7104217a4a7f5c923eab6491
Clear filters https://github.com/simstudioai/sim/pull/6684/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6684/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6684/files
openapi-v2-tables.json https://github.com/simstudioai/sim/pull/6684/files#diff-ce7e6e983230c870183cf99d3e224cd90a9b070ad038113d581d755a0386043b
route.test.ts https://github.com/simstudioai/sim/pull/6684/files#diff-b941d23c80d27271acbcc68c3ec6c9eae78fa47af3ea68d3b3c9f5ae6a88c1b9
route.ts https://github.com/simstudioai/sim/pull/6684/files#diff-217e057ccdd26e30780f1e00db487ba3dffb689aad5d4b122fcff868f9781c55
route.ts https://github.com/simstudioai/sim/pull/6684/files#diff-2a042bc28891a7a0f8724c21444590fece6f54c6bc1e97364fc05ef7183659fe
route.test.ts https://github.com/simstudioai/sim/pull/6684/files#diff-579850048caceaeba4d80256777744288ff12c192a20ed96dc907710c899fb70
tables.ts https://github.com/simstudioai/sim/pull/6684/files#diff-927ba827479bb6f5c0c9cee9dfe1067112e939610060f6a1e939f232b976257d
list-pagination.test.ts https://github.com/simstudioai/sim/pull/6684/files#diff-5327c2d14afe92642c98462f0ef8e4b14f7ee5d1ec4085548c8e240da9379d08
groups.test.ts https://github.com/simstudioai/sim/pull/6684/files#diff-04564ac7ee5455b37db0291e61630dae5e8eb8207200404749eb8a6ceae0ed98
groups.ts https://github.com/simstudioai/sim/pull/6684/files#diff-95fc66a6107b068d6e0680bb700373a6c970e18f464d37fdb55d1e5068f44418
apps/docs/openapi-v2-tables.jsonhttps://github.com/simstudioai/sim/pull/6684/files#diff-ce7e6e983230c870183cf99d3e224cd90a9b070ad038113d581d755a0386043b
View file https://github.com/simstudioai/sim/blob/717b4bf3db7e9d7b7104217a4a7f5c923eab6491/apps/docs/openapi-v2-tables.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6684/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6684/files#diff-ce7e6e983230c870183cf99d3e224cd90a9b070ad038113d581d755a0386043b
https://github.com/simstudioai/sim/pull/6684/files#diff-ce7e6e983230c870183cf99d3e224cd90a9b070ad038113d581d755a0386043b
apps/sim/app/api/v2/workflows/[id]/versions/route.test.tshttps://github.com/simstudioai/sim/pull/6684/files#diff-b941d23c80d27271acbcc68c3ec6c9eae78fa47af3ea68d3b3c9f5ae6a88c1b9
View file https://github.com/simstudioai/sim/blob/717b4bf3db7e9d7b7104217a4a7f5c923eab6491/apps/sim/app/api/v2/workflows/%5Bid%5D/versions/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6684/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6684/files#diff-b941d23c80d27271acbcc68c3ec6c9eae78fa47af3ea68d3b3c9f5ae6a88c1b9
https://github.com/simstudioai/sim/pull/6684/files#diff-b941d23c80d27271acbcc68c3ec6c9eae78fa47af3ea68d3b3c9f5ae6a88c1b9
https://github.com/simstudioai/sim/pull/6684/files#diff-b941d23c80d27271acbcc68c3ec6c9eae78fa47af3ea68d3b3c9f5ae6a88c1b9
https://github.com/simstudioai/sim/pull/6684/files#diff-b941d23c80d27271acbcc68c3ec6c9eae78fa47af3ea68d3b3c9f5ae6a88c1b9
https://github.com/simstudioai/sim/pull/6684/files#diff-b941d23c80d27271acbcc68c3ec6c9eae78fa47af3ea68d3b3c9f5ae6a88c1b9
https://github.com/simstudioai/sim/pull/6684/files#diff-b941d23c80d27271acbcc68c3ec6c9eae78fa47af3ea68d3b3c9f5ae6a88c1b9
apps/sim/app/api/v2/workflows/[id]/versions/route.tshttps://github.com/simstudioai/sim/pull/6684/files#diff-217e057ccdd26e30780f1e00db487ba3dffb689aad5d4b122fcff868f9781c55
View file https://github.com/simstudioai/sim/blob/717b4bf3db7e9d7b7104217a4a7f5c923eab6491/apps/sim/app/api/v2/workflows/%5Bid%5D/versions/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6684/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6684/files#diff-217e057ccdd26e30780f1e00db487ba3dffb689aad5d4b122fcff868f9781c55
https://github.com/simstudioai/sim/pull/6684/files#diff-217e057ccdd26e30780f1e00db487ba3dffb689aad5d4b122fcff868f9781c55
https://github.com/simstudioai/sim/pull/6684/files#diff-217e057ccdd26e30780f1e00db487ba3dffb689aad5d4b122fcff868f9781c55
https://github.com/simstudioai/sim/pull/6684/files#diff-217e057ccdd26e30780f1e00db487ba3dffb689aad5d4b122fcff868f9781c55
apps/sim/app/api/v2/workspaces/[workspaceId]/members/route.tshttps://github.com/simstudioai/sim/pull/6684/files#diff-2a042bc28891a7a0f8724c21444590fece6f54c6bc1e97364fc05ef7183659fe
View file https://github.com/simstudioai/sim/blob/717b4bf3db7e9d7b7104217a4a7f5c923eab6491/apps/sim/app/api/v2/workspaces/%5BworkspaceId%5D/members/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6684/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6684/files#diff-2a042bc28891a7a0f8724c21444590fece6f54c6bc1e97364fc05ef7183659fe
https://github.com/simstudioai/sim/pull/6684/files#diff-2a042bc28891a7a0f8724c21444590fece6f54c6bc1e97364fc05ef7183659fe
https://github.com/simstudioai/sim/pull/6684/files#diff-2a042bc28891a7a0f8724c21444590fece6f54c6bc1e97364fc05ef7183659fe
https://github.com/simstudioai/sim/pull/6684/files#diff-2a042bc28891a7a0f8724c21444590fece6f54c6bc1e97364fc05ef7183659fe
https://github.com/simstudioai/sim/pull/6684/files#diff-2a042bc28891a7a0f8724c21444590fece6f54c6bc1e97364fc05ef7183659fe
Please reload this pagehttps://github.com/simstudioai/sim/pull/6684/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6684/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.