René's URL Explorer Experiment


Title: fix(queries): close correctness and stale-data defects found auditing the query layer by waleedlatif1 · Pull Request #6659 · simstudioai/sim · GitHub

Open Graph Title: fix(queries): close correctness and stale-data defects found auditing the query layer by waleedlatif1 · Pull Request #6659 · simstudioai/sim

X Title: fix(queries): close correctness and stale-data defects found auditing the query layer by waleedlatif1 · Pull Request #6659 · simstudioai/sim

Description: Summary A four-agent audit of the query and server-render layers, following #6657. Every finding was verified against the code before being fixed — several were reported but turned out not to be real, and those are listed at the bottom rather than "fixed". Functional bugs Table cell edits threw after using search. patchCachedRows walked tableKeys.rowsRoot non-exact, but that is a prefix — the find and write subtrees hang off it with non-paged shapes, so old.pages.map threw. It runs inside onMutate, so the edit rejected before reaching the server. A sibling helper already excluded those subtrees and its docstring claimed they "never match"; that was only true of the sibling. Both now share one helper. A transient failure permanently disabled cloud uploads. useCloudStorageConfigured combined staleTime: Infinity, retry: false, and the global retryOnMount: false on a workspace-independent key, and the upload path fails closed. One blip left it errored for the tab's life with no way back. useVoiceSettings carries the same three options and already escapes it. CloudWatch server-side filtering was dead. The log-group and log-stream selectors forwarded search as prefix but omitted it from the query key, so typing never changed the key and no refetch fired. A log group outside the first page was unreachable. An audit of all 69 selector definitions found these two and no others. Optimistic rows could collide. generateTempId used Date.now(), so two rows created in the same millisecond shared an id and one server response overwrote both. Stale data Workspace usage/credits were invalidated nowhere — the credits chip and run gate held page-load values until a reload, while six sites already refreshed subscriptionKeys after credits moved. Also fixed: KB list doc counts after upload/delete, billing state after a non-redirect plan switch, workflow lists after a copilot tool call (raw key missed the archived scope and the selector prefix), and an aliased schedule key namespace. Server reads The workspace row was read ~3× per workspace route and ~5× on settings. Memoization is deliberately partial: getWorkspaceWithOwner accepts a transaction and forUpdate and live callers use both, so only the plain no-options read is memoized — a row read inside a transaction or under a lock can never be served to a later caller. Guards prefetchWorkspaceSidebar / seedWorkspaceList had no test despite being the whole of #6656, and one existing assertion could not fail (it asserted on a key the function never writes). The file-folder seed now parses through its contract — it was the same shape bug #6657 fixed, waiting to recur. Reported but NOT real — deliberately unchanged CSV preview staleness. The key already folds in the file version and storage key, so a content update addresses a different entry. link-preview / unsubscribe retry traps. Same three options, no blast radius: finite staleTime, per-URL keys, consumers that degrade correctly. oauth-connections swallowing errors. No consumer reads isConnected; letting it reject would blank the suggested-action rows. Documented instead. A "permanent spinner" from the selector gate. The precedence bug was real, but the symptom was not — the throw happens before any request and the sole consumer never reads isLoading. Substituting ownerBilling for the Inbox/Sandbox or Enterprise checks would have changed who gets those features. Type of Change Bug fix Testing prefetch.test.ts 26/26, plus new tests for the usage, knowledge, CloudWatch key, and temp-id fixes — each proven to fail without its fix. type-check, biome, lint:check, check:audits, check:react-query, and the module-count ratchet all pass. Not verified locally: several affected files cannot load in a git worktree (pre-existing postcss/tailwind resolution failure) — workspace-files.test.tsx, the selector registry, and the upgrade/tool-event/schedules hosts. CI is the first place those run against these changes; please confirm Lint and Test is green before merging. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary A four-agent audit of the query and server-render layers, following #6657. Every finding was verified against the code before being fixed — several were reported but turned out not to be re...

X Description: Summary A four-agent audit of the query and server-render layers, following #6657. Every finding was verified against the code before being fixed — several were reported but turned out not to be re...

Opengraph URL: https://github.com/simstudioai/sim/pull/6659

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:56a8a557-1790-0e8c-72a2-88e7bfce9659
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id814A:8CC91:223050:2EA3E0:6AFB4FF8
html-safe-noncee7bc542a4bcf073ba198e7b5fc560cf27c58da16138aa9c9290adaca95a2cfe0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTRBOjhDQzkxOjIyMzA1MDoyRUEzRTA6NkFGQjRGRjgiLCJ2aXNpdG9yX2lkIjoiODU3OTI3Mjg0NDI4ODY3NTgzMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca918423e9ed9af0e3ac33fbf4b629ddecc5624a2a47186cccb2b774bda211c2f
hovercard-subject-tagpull_request:4269051813
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6659/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary A four-agent audit of the query and server-render layers, following #6657. Every finding was verified against the code before being fixed — several were reported but turned out not to be re...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6659/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6659%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6659%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6659/files
Reloadhttps://github.com/simstudioai/sim/pull/6659/files
Reloadhttps://github.com/simstudioai/sim/pull/6659/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
audit/prefetch-perf-verificationhttps://github.com/simstudioai/sim/tree/audit/prefetch-perf-verification
Conversation 5 https://github.com/simstudioai/sim/pull/6659
Commits 1 https://github.com/simstudioai/sim/pull/6659/commits
Checks 31 https://github.com/simstudioai/sim/pull/6659/checks
Files changed https://github.com/simstudioai/sim/pull/6659/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6659/files
fix(queries): close correctness and stale-data defects found auditing the query layer https://github.com/simstudioai/sim/pull/6659/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6659/files
946ff74 test(prefetch): cover the workspace-list seed, and fix two tests that… waleedlatif1 Aug 13, 2026 https://github.com/simstudioai/sim/pull/6659/commits/946ff7464f035bd01255cae66c0a7f1844f35e9d
Clear filters https://github.com/simstudioai/sim/pull/6659/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6659/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6659/files
prefetch.ts https://github.com/simstudioai/sim/pull/6659/files#diff-cbabd41588f9501e29016577c4bd074a22f2b379aa7860fa0f01780c3fc5b9e7
prefetch.test.ts https://github.com/simstudioai/sim/pull/6659/files#diff-0f96fdbc0043b9049bd7b95533743eec99f8fae0184fd3464b17ed4f5c19e1d5
prefetch.ts https://github.com/simstudioai/sim/pull/6659/files#diff-17f9da631614610a1ed03ff8fad6b917e56b57da971435a4cf7561dfaf7383f3
apps/sim/app/workspace/[workspaceId]/knowledge/prefetch.tshttps://github.com/simstudioai/sim/pull/6659/files#diff-cbabd41588f9501e29016577c4bd074a22f2b379aa7860fa0f01780c3fc5b9e7
View file https://github.com/simstudioai/sim/blob/946ff7464f035bd01255cae66c0a7f1844f35e9d/apps/sim/app/workspace/%5BworkspaceId%5D/knowledge/prefetch.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6659/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6659/files#diff-cbabd41588f9501e29016577c4bd074a22f2b379aa7860fa0f01780c3fc5b9e7
https://github.com/simstudioai/sim/pull/6659/files#diff-cbabd41588f9501e29016577c4bd074a22f2b379aa7860fa0f01780c3fc5b9e7
apps/sim/app/workspace/[workspaceId]/lib/prefetch.test.tshttps://github.com/simstudioai/sim/pull/6659/files#diff-0f96fdbc0043b9049bd7b95533743eec99f8fae0184fd3464b17ed4f5c19e1d5
View file https://github.com/simstudioai/sim/blob/946ff7464f035bd01255cae66c0a7f1844f35e9d/apps/sim/app/workspace/%5BworkspaceId%5D/lib/prefetch.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6659/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6659/files#diff-0f96fdbc0043b9049bd7b95533743eec99f8fae0184fd3464b17ed4f5c19e1d5
https://github.com/simstudioai/sim/pull/6659/files#diff-0f96fdbc0043b9049bd7b95533743eec99f8fae0184fd3464b17ed4f5c19e1d5
https://github.com/simstudioai/sim/pull/6659/files#diff-0f96fdbc0043b9049bd7b95533743eec99f8fae0184fd3464b17ed4f5c19e1d5
https://github.com/simstudioai/sim/pull/6659/files#diff-0f96fdbc0043b9049bd7b95533743eec99f8fae0184fd3464b17ed4f5c19e1d5
https://github.com/simstudioai/sim/pull/6659/files#diff-0f96fdbc0043b9049bd7b95533743eec99f8fae0184fd3464b17ed4f5c19e1d5
https://github.com/simstudioai/sim/pull/6659/files#diff-0f96fdbc0043b9049bd7b95533743eec99f8fae0184fd3464b17ed4f5c19e1d5
https://github.com/simstudioai/sim/pull/6659/files#diff-0f96fdbc0043b9049bd7b95533743eec99f8fae0184fd3464b17ed4f5c19e1d5
https://github.com/simstudioai/sim/pull/6659/files#diff-0f96fdbc0043b9049bd7b95533743eec99f8fae0184fd3464b17ed4f5c19e1d5
https://github.com/simstudioai/sim/pull/6659/files#diff-0f96fdbc0043b9049bd7b95533743eec99f8fae0184fd3464b17ed4f5c19e1d5
https://github.com/simstudioai/sim/pull/6659/files#diff-0f96fdbc0043b9049bd7b95533743eec99f8fae0184fd3464b17ed4f5c19e1d5
https://github.com/simstudioai/sim/pull/6659/files#diff-0f96fdbc0043b9049bd7b95533743eec99f8fae0184fd3464b17ed4f5c19e1d5
apps/sim/app/workspace/[workspaceId]/prefetch.tshttps://github.com/simstudioai/sim/pull/6659/files#diff-17f9da631614610a1ed03ff8fad6b917e56b57da971435a4cf7561dfaf7383f3
View file https://github.com/simstudioai/sim/blob/946ff7464f035bd01255cae66c0a7f1844f35e9d/apps/sim/app/workspace/%5BworkspaceId%5D/prefetch.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6659/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6659/files#diff-17f9da631614610a1ed03ff8fad6b917e56b57da971435a4cf7561dfaf7383f3
https://github.com/simstudioai/sim/pull/6659/files#diff-17f9da631614610a1ed03ff8fad6b917e56b57da971435a4cf7561dfaf7383f3
https://github.com/simstudioai/sim/pull/6659/files#diff-17f9da631614610a1ed03ff8fad6b917e56b57da971435a4cf7561dfaf7383f3
https://github.com/simstudioai/sim/pull/6659/files#diff-17f9da631614610a1ed03ff8fad6b917e56b57da971435a4cf7561dfaf7383f3
https://github.com/simstudioai/sim/pull/6659/files#diff-17f9da631614610a1ed03ff8fad6b917e56b57da971435a4cf7561dfaf7383f3
https://github.com/simstudioai/sim/pull/6659/files#diff-17f9da631614610a1ed03ff8fad6b917e56b57da971435a4cf7561dfaf7383f3
https://github.com/simstudioai/sim/pull/6659/files#diff-17f9da631614610a1ed03ff8fad6b917e56b57da971435a4cf7561dfaf7383f3
https://github.com/simstudioai/sim/pull/6659/files#diff-17f9da631614610a1ed03ff8fad6b917e56b57da971435a4cf7561dfaf7383f3
https://github.com/simstudioai/sim/pull/6659/files#diff-17f9da631614610a1ed03ff8fad6b917e56b57da971435a4cf7561dfaf7383f3
Please reload this pagehttps://github.com/simstudioai/sim/pull/6659/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.