Title: improvement(nav): cut prefetch and session-recorder waste by waleedlatif1 · Pull Request #6656 · simstudioai/sim · GitHub
Open Graph Title: improvement(nav): cut prefetch and session-recorder waste by waleedlatif1 · Pull Request #6656 · simstudioai/sim
X Title: improvement(nav): cut prefetch and session-recorder waste by waleedlatif1 · Pull Request #6656 · simstudioai/sim
Description: Summary Seed the workspace list rather than prefetching it. The empty-list case was signalled by throwing inside queryFn; the retry: 1 default then re-ran the whole read, a retry delay later, purely to re-derive an outcome already known. Also logs the failure path, which was silent — contract drift between the read and the response schema would have degraded into every viewer waterfalling with nothing in the logs. Add slimDOMOptions to session recording so non-painted nodes (comments, script bodies, head meta) stay out of every rrweb snapshot. Enumerated rather than true/'all' so headTitleMutations stays off and replays keep document.title. Prefetch concurrency and await semantics are unchanged, so sidebar paint timing matches staging. Context Came out of investigating a report that opening a workflow from the sidebar took a long time. These are the two contained wins that fell out of it; neither is the fix for that report. What this does not fix The dominant cost on the workflow canvas is workflow-block-border.tsx rewriting a spring-animated SVG path per block per frame, which trips PostHog's mutation throttler. No posthog-js option can throttle that — sampling has no mutation key and isn't on posthog-js's rrweb allowlist anyway, and the throttler that does exist runs after serialization, so it only trades payload for fidelity. Fixing it at the source means driving the silhouette imperatively from the rAF loop instead of React state — a deliberate rewrite, out of scope here. Sidebar navigation also still gives no feedback on click, which is what leads users to click again and escalate a soft navigation into a full document load. A pending affordance was prototyped and pulled — it didn't fit the sidebar's visual language. Worth solving with an affordance the design system already uses. We collect no navigation timing and no INP, so none of this is measurable today. That instrumentation is the real follow-up. Type of Change Bug fix Testing type-check, biome, and repo lint:check (23/23) pass, along with the workspace layout test. No UI changes in this PR. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Seed the workspace list rather than prefetching it. The empty-list case was signalled by throwing inside queryFn; the retry: 1 default then re-ran the whole read, a retry delay later, pure...
X Description: Summary Seed the workspace list rather than prefetching it. The empty-list case was signalled by throwing inside queryFn; the retry: 1 default then re-ran the whole read, a retry delay later, pure...
Opengraph URL: https://github.com/simstudioai/sim/pull/6656
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:fef4cdaf-8745-fee9-c663-443e2851b5e7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AD1E:14C9D4:283FEB:388C57:6AFB5301 |
| html-safe-nonce | 7659a5a89a8eb4023171300a07eb79b8c517e2ee2c2c9d7bca4ff5339d5b55fb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDFFOjE0QzlENDoyODNGRUI6Mzg4QzU3OjZBRkI1MzAxIiwidmlzaXRvcl9pZCI6IjI0NjUwMTE2MjEzNzAyMjEzMTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 7ab52582874c2669915c609cf1bc9382691536c15c46a2e65ae952b6bb4f2981 |
| hovercard-subject-tag | pull_request:4268017299 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6656/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Seed the workspace list rather than prefetching it. The empty-list case was signalled by throwing inside queryFn; the retry: 1 default then re-ran the whole read, a retry delay later, pure... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width