René's URL Explorer Experiment


Title: fix(workflow): stop a nested block jumping when it leaves its container by waleedlatif1 · Pull Request #6644 · simstudioai/sim · GitHub

Open Graph Title: fix(workflow): stop a nested block jumping when it leaves its container by waleedlatif1 · Pull Request #6644 · simstudioai/sim

X Title: fix(workflow): stop a nested block jumping when it leaves its container by waleedlatif1 · Pull Request #6644 · simstudioai/sim

Description: Summary getNodeAbsolutePosition added the container's header and padding to a child's position. Those are already in the position — React Flow places a child at its parent's origin plus its own coordinates, and clampPositionToContainer is what holds it clear of the chrome, flooring it at LEFT_PADDING and HEADER_HEIGHT + TOP_PADDING. Counting them twice reported every nested node 16px right and 66px below where it actually renders. What that looks like: A block drops down-right the moment it is dragged out of a Loop. A block dragged into a Loop from the canvas lands off-target. Container hit-testing during a drag, and the bounds fitView focuses on, are both skewed for nested nodes. Two callers already knew something was wrong: each subtracted the same three constants straight back off to recover a relative position. They now take the difference of two absolutes, which is what a relative position is. A third place had its own copy — React Flow's child extent, with a fourth distinct header height (42, against the 40 the card renders and the 50 this helper used). It now reads the same constants as the clamp, so a drag stops where a drop would put it. And positionAbsolute ?? getNodeAbsolutePosition(...) in the fit-view path stops disagreeing with itself: React Flow's own answer carries no offset, so its two branches returned points 66px apart for the same node. Type of Change Bug fix Testing New unit tests on the hook pinning the convention — a child sits at parent-plus-position, a root node is untouched, and popping a child out round-trips to exactly where it was. Two fail on the old helper, with the double-count visible in the diff: expected { x: 32, y: 132 } to deeply equal { x: 16, y: 66 } That is the pop-out case: the block landed 16px right and 66px down instead of staying put. Blast radius is bounded by the helper's own early return — a node with no parent returns its position unchanged, so nothing about top-level blocks changes. Only nested nodes move, and only onto the position they were already being drawn at. Full [workflowId] and lib/workflows suites green (1756 tests), type-check and lint clean across all 23 packages. Not verified on a running canvas. Worth dragging a block out of a Loop and back in before merging — that is the exact interaction this changes. Notes The extent change tightens the drag floor from 42 to HEADER_HEIGHT + TOP_PADDING. Programmatic placement already used the larger floor, so this makes dragging agree with dropping rather than loosening anything. Remaining follow-ups from the subflow work, deliberately not bundled here: the mcp-dynamic-args row estimate, and writing a container's derived size back so the first painted frame is not the stored default. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary getNodeAbsolutePosition added the container's header and padding to a child's position. Those are already in the position — React Flow places a child at its parent's origin plus...

X Description: Summary getNodeAbsolutePosition added the container's header and padding to a child's position. Those are already in the position — React Flow places a child at its parent's...

Opengraph URL: https://github.com/simstudioai/sim/pull/6644

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:53ba8a33-f8c1-aa42-127c-47b43b6bdcb1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC1DE:243FA5:C48685:10DA8B5:6AFB56B5
html-safe-nonceefc89ced5d023d59a7c1d292210f19b86e175a2f976c9ac87178c6ab97437fd9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMURFOjI0M0ZBNTpDNDg2ODU6MTBEQThCNTo2QUZCNTZCNSIsInZpc2l0b3JfaWQiOiI3NzA1MDYyMDg4MzI1NjgyODY5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac81a2486669f913cc9d84b4787b835395c6ed515608025f588a5e335c8860643f
hovercard-subject-tagpull_request:4266317801
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6644/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary getNodeAbsolutePosition added the container's header and padding to a child's position. Those are already in the position — React Flow places a child at its parent's origin plus...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6644/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6644%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6644%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6644/files
Reloadhttps://github.com/simstudioai/sim/pull/6644/files
Reloadhttps://github.com/simstudioai/sim/pull/6644/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/nested-absolute-positionhttps://github.com/simstudioai/sim/tree/fix/nested-absolute-position
Conversation 8 https://github.com/simstudioai/sim/pull/6644
Commits 2 https://github.com/simstudioai/sim/pull/6644/commits
Checks 30 https://github.com/simstudioai/sim/pull/6644/checks
Files changed https://github.com/simstudioai/sim/pull/6644/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6644/files
fix(workflow): stop a nested block jumping when it leaves its container https://github.com/simstudioai/sim/pull/6644/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/6644/files
5e1aa23 fix(workflow): stop a nested block jumping when it leaves its container waleedlatif1 Aug 12, 2026 https://github.com/simstudioai/sim/pull/6644/commits/5e1aa23726ff3044092a044b9cba9ffcd799ae5a
1c7fc31 refactor(workflow): type the node-utilities block map waleedlatif1 Aug 12, 2026 https://github.com/simstudioai/sim/pull/6644/commits/1c7fc31f29d17e385c3f3341d243edb1909422cf
Clear filters https://github.com/simstudioai/sim/pull/6644/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6644/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6644/files
use-node-utilities.test.tsx https://github.com/simstudioai/sim/pull/6644/files#diff-473b6601117d6b74d21adba7dc068c96bc014055ac87fcbd1cd9112058dbb51b
use-node-utilities.ts https://github.com/simstudioai/sim/pull/6644/files#diff-7c8e4382cb0f1e315c8c8c26befd9fc53d32fcd4ac96aeb21edb7f75fda88974
workflow.tsx https://github.com/simstudioai/sim/pull/6644/files#diff-633646152e985737e5fd12931da50f7d1f2b76bc3fbb589f7ce3fcf26f69da01
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-node-utilities.test.tsxhttps://github.com/simstudioai/sim/pull/6644/files#diff-473b6601117d6b74d21adba7dc068c96bc014055ac87fcbd1cd9112058dbb51b
View file https://github.com/simstudioai/sim/blob/1c7fc31f29d17e385c3f3341d243edb1909422cf/apps/sim/app/workspace/%5BworkspaceId%5D/w/%5BworkflowId%5D/hooks/use-node-utilities.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6644/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/6644/files
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-node-utilities.tshttps://github.com/simstudioai/sim/pull/6644/files#diff-7c8e4382cb0f1e315c8c8c26befd9fc53d32fcd4ac96aeb21edb7f75fda88974
View file https://github.com/simstudioai/sim/blob/1c7fc31f29d17e385c3f3341d243edb1909422cf/apps/sim/app/workspace/%5BworkspaceId%5D/w/%5BworkflowId%5D/hooks/use-node-utilities.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6644/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6644/files#diff-7c8e4382cb0f1e315c8c8c26befd9fc53d32fcd4ac96aeb21edb7f75fda88974
https://github.com/simstudioai/sim/pull/6644/files#diff-7c8e4382cb0f1e315c8c8c26befd9fc53d32fcd4ac96aeb21edb7f75fda88974
https://github.com/simstudioai/sim/pull/6644/files#diff-7c8e4382cb0f1e315c8c8c26befd9fc53d32fcd4ac96aeb21edb7f75fda88974
https://github.com/simstudioai/sim/pull/6644/files#diff-7c8e4382cb0f1e315c8c8c26befd9fc53d32fcd4ac96aeb21edb7f75fda88974
https://github.com/simstudioai/sim/pull/6644/files#diff-7c8e4382cb0f1e315c8c8c26befd9fc53d32fcd4ac96aeb21edb7f75fda88974
https://github.com/simstudioai/sim/pull/6644/files#diff-7c8e4382cb0f1e315c8c8c26befd9fc53d32fcd4ac96aeb21edb7f75fda88974
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsxhttps://github.com/simstudioai/sim/pull/6644/files#diff-633646152e985737e5fd12931da50f7d1f2b76bc3fbb589f7ce3fcf26f69da01
View file https://github.com/simstudioai/sim/blob/1c7fc31f29d17e385c3f3341d243edb1909422cf/apps/sim/app/workspace/%5BworkspaceId%5D/w/%5BworkflowId%5D/workflow.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6644/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6644/files#diff-633646152e985737e5fd12931da50f7d1f2b76bc3fbb589f7ce3fcf26f69da01
https://github.com/simstudioai/sim/pull/6644/files#diff-633646152e985737e5fd12931da50f7d1f2b76bc3fbb589f7ce3fcf26f69da01
https://github.com/simstudioai/sim/pull/6644/files#diff-633646152e985737e5fd12931da50f7d1f2b76bc3fbb589f7ce3fcf26f69da01
https://github.com/simstudioai/sim/pull/6644/files#diff-633646152e985737e5fd12931da50f7d1f2b76bc3fbb589f7ce3fcf26f69da01
https://github.com/simstudioai/sim/pull/6644/files#diff-633646152e985737e5fd12931da50f7d1f2b76bc3fbb589f7ce3fcf26f69da01
https://github.com/simstudioai/sim/pull/6644/files#diff-633646152e985737e5fd12931da50f7d1f2b76bc3fbb589f7ce3fcf26f69da01
Please reload this pagehttps://github.com/simstudioai/sim/pull/6644/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.