René's URL Explorer Experiment


Title: fix(workflow): draw a highlighted edge over the ordinary ones by waleedlatif1 · Pull Request #6642 · simstudioai/sim · GitHub

Open Graph Title: fix(workflow): draw a highlighted edge over the ordinary ones by waleedlatif1 · Pull Request #6642 · simstudioai/sim

X Title: fix(workflow): draw a highlighted edge over the ordinary ones by waleedlatif1 · Pull Request #6642 · simstudioai/sim

Description: Summary A highlighted edge gets cut in half where an unselected edge crosses it, as reported by Theo. An edge's z came from the nesting depth of the container it belongs to, and a highlighted edge kept that depth like any other. A top-level edge sits at EDGE_Z_BASE; an edge one container deeper sits above it — so the deeper, unselected line paints straight through the highlight. A highlighted edge (selected, or connected to the selected card) now takes the top tier of the edge band. Depth only ever ordered edges against each other, and once one is picked out, being drawn whole matters more than which container it came from. The tier deliberately stays inside the band, below the cards. There's a comment at the call site recording that highlighted edges were elevated over cards once before and drew across the chrome of their own endpoints. So ordinary edges give up the top of the band (EDGE_Z_DEPTH_MAX, 18) rather than the band being widened into the cards. EDGE_Z_MAX (20) is untouched, so the in-flight connection line still sits above everything. Resulting order, unchanged either side of the new tier: container bodies 0… → ordinary edges 10…18 → highlighted edges 19 → in-flight line 20 → cards 21+ → container children 1000 → connection picker 2000. Type of Change Bug fix Testing New unit tests on canvas-layers, pinning both directions of the invariant — that a highlighted edge beats every ordinary one at any depth, and that it stays under the cards, getBlockZIndex, and container children. Two of them fail on the old code (expected 10 to be less than 10 — the highlighted edge tied with an ordinary top-level one). Also pinned: ordinary edges still order by depth, every edge still clears the container body it crosses, and the in-flight line still tops the band. One honest note on a pre-existing limit the tests now document. The band is fixed, so past its ceiling every edge saturates at the deepest tier and no longer clears a container nested that far. That was already true — the old cap was EDGE_Z_MAX, so it broke past depth 10 — and this change moves the ceiling from depth 10 to depth 8. Nothing in the editor nests remotely near either. Full workflow-renderer suite green (70), type-check and lint clean across all 23 packages. Not verified on a running canvas — this is layering, so it's worth a look at a selected edge crossing a nested one before merging. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary A highlighted edge gets cut in half where an unselected edge crosses it, as reported by Theo. An edge's z came from the nesting depth of the container it belongs to, and a highlighted ...

X Description: Summary A highlighted edge gets cut in half where an unselected edge crosses it, as reported by Theo. An edge's z came from the nesting depth of the container it belongs to, and a highligh...

Opengraph URL: https://github.com/simstudioai/sim/pull/6642

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:468ebfcc-5bb0-0960-c5d1-5c5146525901
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC3F6:186510:B2EC12:F5C9A8:6AFB5217
html-safe-nonce4998eb7402632cf5f815b0ec3e2cb0551f1561ae16427b82e73f7e683511801e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDM0Y2OjE4NjUxMDpCMkVDMTI6RjVDOUE4OjZBRkI1MjE3IiwidmlzaXRvcl9pZCI6IjM4MDgzMDU2ODMwNjE0OTQyOTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace47015d02ff9477c58386bed6339d91d259fc1dd23cc963cddeaaeaeda5ccfe9
hovercard-subject-tagpull_request:4266211097
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6642/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary A highlighted edge gets cut in half where an unselected edge crosses it, as reported by Theo. An edge's z came from the nesting depth of the container it belongs to, and a highlighted ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6642/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6642%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6642%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6642/files
Reloadhttps://github.com/simstudioai/sim/pull/6642/files
Reloadhttps://github.com/simstudioai/sim/pull/6642/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/selected-edge-z-orderhttps://github.com/simstudioai/sim/tree/fix/selected-edge-z-order
Conversation 10 https://github.com/simstudioai/sim/pull/6642
Commits 3 https://github.com/simstudioai/sim/pull/6642/commits
Checks 30 https://github.com/simstudioai/sim/pull/6642/checks
Files changed https://github.com/simstudioai/sim/pull/6642/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6642/files
fix(workflow): draw a highlighted edge over the ordinary ones https://github.com/simstudioai/sim/pull/6642/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/6642/files
4f55c08 fix(workflow): draw a highlighted edge over the ordinary ones waleedlatif1 Aug 12, 2026 https://github.com/simstudioai/sim/pull/6642/commits/4f55c088f8c0dcc058e9cf536d4d4142678db2d8
d5285f8 fix(workflow): elevate the connection preview edge with the rest waleedlatif1 Aug 12, 2026 https://github.com/simstudioai/sim/pull/6642/commits/d5285f8cb5b02a9d8caf18f10d1624a1c1921608
7496c23 fix(workflow): give the edge highlight one definition waleedlatif1 Aug 12, 2026 https://github.com/simstudioai/sim/pull/6642/commits/7496c23e9e7c01acc51516b6eb7b0b56fa23dfba
Clear filters https://github.com/simstudioai/sim/pull/6642/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6642/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6642/files
workflow-block.tsx https://github.com/simstudioai/sim/pull/6642/files#diff-eb2223ecc5d1f699578f6498c95b4182bbe7df71b182febbfb6886413b61043b
workflow-edge.tsx https://github.com/simstudioai/sim/pull/6642/files#diff-215544d6ccd3fe0053fc6228509b009369301c4be9fb7d5fea63aa24b6758cdc
edge-highlight.ts https://github.com/simstudioai/sim/pull/6642/files#diff-c8f29355be602c7c92323054e08b08962fe89f6749e91316483efb753067f083
workflow.tsx https://github.com/simstudioai/sim/pull/6642/files#diff-633646152e985737e5fd12931da50f7d1f2b76bc3fbb589f7ce3fcf26f69da01
canvas-layers.test.ts https://github.com/simstudioai/sim/pull/6642/files#diff-5dd0daeb927c88551168ad400b1ab139db3cacd03ceb086dff1569acb1eebed0
canvas-layers.ts https://github.com/simstudioai/sim/pull/6642/files#diff-266f1bec15312f7aa6af7583872516fa2a542d08bed0fb21b54cfa0122da4ca8
...m/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-block/workflow-block.tsxhttps://github.com/simstudioai/sim/pull/6642/files#diff-eb2223ecc5d1f699578f6498c95b4182bbe7df71b182febbfb6886413b61043b
View file https://github.com/simstudioai/sim/blob/7496c23e9e7c01acc51516b6eb7b0b56fa23dfba/apps/sim/app/workspace/%5BworkspaceId%5D/w/%5BworkflowId%5D/components/workflow-block/workflow-block.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6642/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6642/files#diff-eb2223ecc5d1f699578f6498c95b4182bbe7df71b182febbfb6886413b61043b
https://github.com/simstudioai/sim/pull/6642/files#diff-eb2223ecc5d1f699578f6498c95b4182bbe7df71b182febbfb6886413b61043b
https://github.com/simstudioai/sim/pull/6642/files#diff-eb2223ecc5d1f699578f6498c95b4182bbe7df71b182febbfb6886413b61043b
https://github.com/simstudioai/sim/pull/6642/files#diff-eb2223ecc5d1f699578f6498c95b4182bbe7df71b182febbfb6886413b61043b
...sim/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-edge/workflow-edge.tsxhttps://github.com/simstudioai/sim/pull/6642/files#diff-215544d6ccd3fe0053fc6228509b009369301c4be9fb7d5fea63aa24b6758cdc
View file https://github.com/simstudioai/sim/blob/7496c23e9e7c01acc51516b6eb7b0b56fa23dfba/apps/sim/app/workspace/%5BworkspaceId%5D/w/%5BworkflowId%5D/components/workflow-edge/workflow-edge.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6642/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6642/files#diff-215544d6ccd3fe0053fc6228509b009369301c4be9fb7d5fea63aa24b6758cdc
https://github.com/simstudioai/sim/pull/6642/files#diff-215544d6ccd3fe0053fc6228509b009369301c4be9fb7d5fea63aa24b6758cdc
https://github.com/simstudioai/sim/pull/6642/files#diff-215544d6ccd3fe0053fc6228509b009369301c4be9fb7d5fea63aa24b6758cdc
https://github.com/simstudioai/sim/pull/6642/files#diff-215544d6ccd3fe0053fc6228509b009369301c4be9fb7d5fea63aa24b6758cdc
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/utils/edge-highlight.tshttps://github.com/simstudioai/sim/pull/6642/files#diff-c8f29355be602c7c92323054e08b08962fe89f6749e91316483efb753067f083
View file https://github.com/simstudioai/sim/blob/7496c23e9e7c01acc51516b6eb7b0b56fa23dfba/apps/sim/app/workspace/%5BworkspaceId%5D/w/%5BworkflowId%5D/utils/edge-highlight.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6642/{{ revealButtonHref }}
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsxhttps://github.com/simstudioai/sim/pull/6642/files#diff-633646152e985737e5fd12931da50f7d1f2b76bc3fbb589f7ce3fcf26f69da01
View file https://github.com/simstudioai/sim/blob/7496c23e9e7c01acc51516b6eb7b0b56fa23dfba/apps/sim/app/workspace/%5BworkspaceId%5D/w/%5BworkflowId%5D/workflow.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6642/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6642/files#diff-633646152e985737e5fd12931da50f7d1f2b76bc3fbb589f7ce3fcf26f69da01
https://github.com/simstudioai/sim/pull/6642/files#diff-633646152e985737e5fd12931da50f7d1f2b76bc3fbb589f7ce3fcf26f69da01
https://github.com/simstudioai/sim/pull/6642/files#diff-633646152e985737e5fd12931da50f7d1f2b76bc3fbb589f7ce3fcf26f69da01
https://github.com/simstudioai/sim/pull/6642/files#diff-633646152e985737e5fd12931da50f7d1f2b76bc3fbb589f7ce3fcf26f69da01
https://github.com/simstudioai/sim/pull/6642/files#diff-633646152e985737e5fd12931da50f7d1f2b76bc3fbb589f7ce3fcf26f69da01
https://github.com/simstudioai/sim/pull/6642/files#diff-633646152e985737e5fd12931da50f7d1f2b76bc3fbb589f7ce3fcf26f69da01
Please reload this pagehttps://github.com/simstudioai/sim/pull/6642/files
https://github.com/simstudioai/sim/pull/6642/files#diff-633646152e985737e5fd12931da50f7d1f2b76bc3fbb589f7ce3fcf26f69da01
https://github.com/simstudioai/sim/pull/6642/files#diff-633646152e985737e5fd12931da50f7d1f2b76bc3fbb589f7ce3fcf26f69da01
https://github.com/simstudioai/sim/pull/6642/files#diff-633646152e985737e5fd12931da50f7d1f2b76bc3fbb589f7ce3fcf26f69da01
packages/workflow-renderer/src/canvas-layers.test.tshttps://github.com/simstudioai/sim/pull/6642/files#diff-5dd0daeb927c88551168ad400b1ab139db3cacd03ceb086dff1569acb1eebed0
View file https://github.com/simstudioai/sim/blob/7496c23e9e7c01acc51516b6eb7b0b56fa23dfba/packages/workflow-renderer/src/canvas-layers.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6642/{{ revealButtonHref }}
packages/workflow-renderer/src/canvas-layers.tshttps://github.com/simstudioai/sim/pull/6642/files#diff-266f1bec15312f7aa6af7583872516fa2a542d08bed0fb21b54cfa0122da4ca8
View file https://github.com/simstudioai/sim/blob/7496c23e9e7c01acc51516b6eb7b0b56fa23dfba/packages/workflow-renderer/src/canvas-layers.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6642/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6642/files#diff-266f1bec15312f7aa6af7583872516fa2a542d08bed0fb21b54cfa0122da4ca8
https://github.com/simstudioai/sim/pull/6642/files#diff-266f1bec15312f7aa6af7583872516fa2a542d08bed0fb21b54cfa0122da4ca8
Please reload this pagehttps://github.com/simstudioai/sim/pull/6642/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.